[U-Boot] [PATCH] driver: net: ldpaa_eth: return number of buffer seeded

[U-Boot] [PATCH] driver: net: ldpaa_eth: return number of buffer seeded

[Prabhakar Kushwaha]

if buffer < 7, return number of buffer seeded to QBMAN.

Signed-off-by: Prabhakar Kushwaha <prabhakar.kushwaha@nxp.com>
Reported-by: Jose Rivera <german.rivera@nxp.com>
---
 drivers/net/ldpaa_eth/ldpaa_eth.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/net/ldpaa_eth/ldpaa_eth.c b/drivers/net/ldpaa_eth/ldpaa_eth.c
index 8a00bc3..274bcea 100644
--- a/drivers/net/ldpaa_eth/ldpaa_eth.c
+++ b/drivers/net/ldpaa_eth/ldpaa_eth.c
@@ -665,7 +665,7 @@ err_alloc:
 	if (i)
 		goto release_bufs;
 
-	return 0;
+	return i;
 }
 
 static int ldpaa_dpbp_seed(uint16_t bpid)
-- 
1.9.1

[U-Boot] [PATCH] driver: net: ldpaa_eth: return number of buffer seeded

[york sun]

On 03/18/2016 03:45 AM, Prabhakar Kushwaha wrote:
> if buffer < 7, return number of buffer seeded to QBMAN.
> 
> Signed-off-by: Prabhakar Kushwaha <prabhakar.kushwaha@nxp.com>
> Reported-by: Jose Rivera <german.rivera@nxp.com>
> ---
>  drivers/net/ldpaa_eth/ldpaa_eth.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/net/ldpaa_eth/ldpaa_eth.c b/drivers/net/ldpaa_eth/ldpaa_eth.c
> index 8a00bc3..274bcea 100644
> --- a/drivers/net/ldpaa_eth/ldpaa_eth.c
> +++ b/drivers/net/ldpaa_eth/ldpaa_eth.c
> @@ -665,7 +665,7 @@ err_alloc:
>  	if (i)
>  		goto release_bufs;
>  
> -	return 0;
> +	return i;
>  }
>  

Prabhakar,

I don't understand what you are trying to do. If i != 0, it goes to
"release_bufs" and return from there. So the "return i" here only returns 0.

York

[U-Boot] [PATCH] driver: net: ldpaa_eth: return number of buffer seeded

[Prabhakar Kushwaha]

> -----Original Message-----
> From: york sun
> Sent: Thursday, March 24, 2016 11:08 PM
> To: Prabhakar Kushwaha <prabhakar.kushwaha@nxp.com>; u-
> boot at lists.denx.de
> Cc: joe.hershberger at gmail.com
> Subject: Re: [PATCH] driver: net: ldpaa_eth: return number of buffer seeded
> 
> On 03/18/2016 03:45 AM, Prabhakar Kushwaha wrote:
> > if buffer < 7, return number of buffer seeded to QBMAN.
> >
> > Signed-off-by: Prabhakar Kushwaha <prabhakar.kushwaha@nxp.com>
> > Reported-by: Jose Rivera <german.rivera@nxp.com>
> > ---
> >  drivers/net/ldpaa_eth/ldpaa_eth.c | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/drivers/net/ldpaa_eth/ldpaa_eth.c
> > b/drivers/net/ldpaa_eth/ldpaa_eth.c
> > index 8a00bc3..274bcea 100644
> > --- a/drivers/net/ldpaa_eth/ldpaa_eth.c
> > +++ b/drivers/net/ldpaa_eth/ldpaa_eth.c
> > @@ -665,7 +665,7 @@ err_alloc:
> >  	if (i)
> >  		goto release_bufs;
> >
> > -	return 0;
> > +	return i;
> >  }
> >
> 
> Prabhakar,
> 
> I don't understand what you are trying to do. If i != 0, it goes to
> "release_bufs" and return from there. So the "return i" here only returns 0.
> 

Thanks York for pointing out.

"return i", is not even required. "return 0" is correct. 
This patch should be rejected. I will update the patchwork

--prabhakar