All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH] ARM: dts: rockchip: Add mdio node to ethernet node
@ 2016-03-18 11:20 ` Tomeu Vizoso
  0 siblings, 0 replies; 12+ messages in thread
From: Tomeu Vizoso @ 2016-03-18 11:20 UTC (permalink / raw)
  To: linux-kernel
  Cc: Tomeu Vizoso, Heiko Stuebner, Rob Herring, Pawel Moll,
	Mark Rutland, Ian Campbell, Kumar Gala, Russell King,
	linux-arm-kernel, linux-rockchip, devicetree

So the dwmac device manages to probe again.

Signed-off-by: Tomeu Vizoso <tomeu.vizoso@collabora.com>
Fixes: 88f8b1bb41c6 ("stmmac: Fix 'eth0: No PHY found' regression")
---
 arch/arm/boot/dts/rk3288-rock2-som.dtsi | 8 ++++++++
 1 file changed, 8 insertions(+)

diff --git a/arch/arm/boot/dts/rk3288-rock2-som.dtsi b/arch/arm/boot/dts/rk3288-rock2-som.dtsi
index 1ece66f3e162..4ba7ddecb478 100644
--- a/arch/arm/boot/dts/rk3288-rock2-som.dtsi
+++ b/arch/arm/boot/dts/rk3288-rock2-som.dtsi
@@ -101,6 +101,14 @@
 	snps,reset-delays-us = <0 10000 30000>;
 	rx_delay = <0x10>;
 	tx_delay = <0x30>;
+	mdio0 {
+		#address-cells = <1>;
+		#size-cells = <0>;
+		compatible = "snps,dwmac-mdio";
+		ethphy1: ethernet-phy@1 {
+			reg = <1>;
+		};
+	};
 };
 
 &i2c0 {
-- 
2.5.0

^ permalink raw reply related	[flat|nested] 12+ messages in thread
* [PATCH] ARM: dts: rockchip: Add mdio node to ethernet node
@ 2016-03-18 11:20 ` Tomeu Vizoso
  0 siblings, 0 replies; 12+ messages in thread
From: Tomeu Vizoso @ 2016-03-18 11:20 UTC (permalink / raw)
  To: linux-kernel-u79uwXL29TY76Z2rM5mHXA
  Cc: Tomeu Vizoso, Heiko Stuebner, Rob Herring, Pawel Moll,
	Mark Rutland, Ian Campbell, Kumar Gala, Russell King,
	linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r,
	linux-rockchip-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r,
	devicetree-u79uwXL29TY76Z2rM5mHXA

So the dwmac device manages to probe again.

Signed-off-by: Tomeu Vizoso <tomeu.vizoso-ZGY8ohtN/8qB+jHODAdFcQ@public.gmane.org>
Fixes: 88f8b1bb41c6 ("stmmac: Fix 'eth0: No PHY found' regression")
---
 arch/arm/boot/dts/rk3288-rock2-som.dtsi | 8 ++++++++
 1 file changed, 8 insertions(+)

diff --git a/arch/arm/boot/dts/rk3288-rock2-som.dtsi b/arch/arm/boot/dts/rk3288-rock2-som.dtsi
index 1ece66f3e162..4ba7ddecb478 100644
--- a/arch/arm/boot/dts/rk3288-rock2-som.dtsi
+++ b/arch/arm/boot/dts/rk3288-rock2-som.dtsi
@@ -101,6 +101,14 @@
 	snps,reset-delays-us = <0 10000 30000>;
 	rx_delay = <0x10>;
 	tx_delay = <0x30>;
+	mdio0 {
+		#address-cells = <1>;
+		#size-cells = <0>;
+		compatible = "snps,dwmac-mdio";
+		ethphy1: ethernet-phy@1 {
+			reg = <1>;
+		};
+	};
 };
 
 &i2c0 {
-- 
2.5.0

--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

^ permalink raw reply related	[flat|nested] 12+ messages in thread
* [PATCH] ARM: dts: rockchip: Add mdio node to ethernet node
@ 2016-03-18 11:20 ` Tomeu Vizoso
  0 siblings, 0 replies; 12+ messages in thread
From: Tomeu Vizoso @ 2016-03-18 11:20 UTC (permalink / raw)
  To: linux-arm-kernel

So the dwmac device manages to probe again.

Signed-off-by: Tomeu Vizoso <tomeu.vizoso@collabora.com>
Fixes: 88f8b1bb41c6 ("stmmac: Fix 'eth0: No PHY found' regression")
---
 arch/arm/boot/dts/rk3288-rock2-som.dtsi | 8 ++++++++
 1 file changed, 8 insertions(+)

diff --git a/arch/arm/boot/dts/rk3288-rock2-som.dtsi b/arch/arm/boot/dts/rk3288-rock2-som.dtsi
index 1ece66f3e162..4ba7ddecb478 100644
--- a/arch/arm/boot/dts/rk3288-rock2-som.dtsi
+++ b/arch/arm/boot/dts/rk3288-rock2-som.dtsi
@@ -101,6 +101,14 @@
 	snps,reset-delays-us = <0 10000 30000>;
 	rx_delay = <0x10>;
 	tx_delay = <0x30>;
+	mdio0 {
+		#address-cells = <1>;
+		#size-cells = <0>;
+		compatible = "snps,dwmac-mdio";
+		ethphy1: ethernet-phy at 1 {
+			reg = <1>;
+		};
+	};
 };
 
 &i2c0 {
-- 
2.5.0

^ permalink raw reply related	[flat|nested] 12+ messages in thread
* Re: [PATCH] ARM: dts: rockchip: Add mdio node to ethernet node
@ 2016-03-18 21:34   ` Andreas Färber
  0 siblings, 0 replies; 12+ messages in thread
From: Andreas Färber @ 2016-03-18 21:34 UTC (permalink / raw)
  To: Tomeu Vizoso, linux-kernel
  Cc: Mark Rutland, devicetree, Russell King, Heiko Stuebner,
	Pawel Moll, Ian Campbell, Rob Herring, Kumar Gala,
	linux-rockchip, linux-arm-kernel, Giuseppe Cavallaro

Am 18.03.2016 um 12:20 schrieb Tomeu Vizoso:
> So the dwmac device manages to probe again.
> 
> Signed-off-by: Tomeu Vizoso <tomeu.vizoso@collabora.com>
> Fixes: 88f8b1bb41c6 ("stmmac: Fix 'eth0: No PHY found' regression")
> ---
>  arch/arm/boot/dts/rk3288-rock2-som.dtsi | 8 ++++++++
>  1 file changed, 8 insertions(+)
> 
> diff --git a/arch/arm/boot/dts/rk3288-rock2-som.dtsi b/arch/arm/boot/dts/rk3288-rock2-som.dtsi
> index 1ece66f3e162..4ba7ddecb478 100644
> --- a/arch/arm/boot/dts/rk3288-rock2-som.dtsi
> +++ b/arch/arm/boot/dts/rk3288-rock2-som.dtsi
> @@ -101,6 +101,14 @@
>  	snps,reset-delays-us = <0 10000 30000>;
>  	rx_delay = <0x10>;
>  	tx_delay = <0x30>;
> +	mdio0 {
> +		#address-cells = <1>;
> +		#size-cells = <0>;
> +		compatible = "snps,dwmac-mdio";
> +		ethphy1: ethernet-phy@1 {
> +			reg = <1>;
> +		};
> +	};

This is a) ugly for lack of white lines in between, b) unnecessary since
this is being fixed in the stmmac driver where it will benefit more than
just this one SoM.

Regards,
Andreas

>  };
>  
>  &i2c0 {

-- 
SUSE Linux GmbH, Maxfeldstr. 5, 90409 Nürnberg, Germany
GF: Felix Imendörffer, Jane Smithard, Graham Norton; HRB 21284 (AG Nürnberg)

^ permalink raw reply	[flat|nested] 12+ messages in thread
* Re: [PATCH] ARM: dts: rockchip: Add mdio node to ethernet node
@ 2016-03-18 21:34   ` Andreas Färber
  0 siblings, 0 replies; 12+ messages in thread
From: Andreas Färber @ 2016-03-18 21:34 UTC (permalink / raw)
  To: Tomeu Vizoso, linux-kernel-u79uwXL29TY76Z2rM5mHXA
  Cc: Mark Rutland, devicetree-u79uwXL29TY76Z2rM5mHXA, Russell King,
	Heiko Stuebner, Pawel Moll, Ian Campbell, Rob Herring,
	Kumar Gala, linux-rockchip-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r,
	linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r,
	Giuseppe Cavallaro

Am 18.03.2016 um 12:20 schrieb Tomeu Vizoso:
> So the dwmac device manages to probe again.
> 
> Signed-off-by: Tomeu Vizoso <tomeu.vizoso-ZGY8ohtN/8qB+jHODAdFcQ@public.gmane.org>
> Fixes: 88f8b1bb41c6 ("stmmac: Fix 'eth0: No PHY found' regression")
> ---
>  arch/arm/boot/dts/rk3288-rock2-som.dtsi | 8 ++++++++
>  1 file changed, 8 insertions(+)
> 
> diff --git a/arch/arm/boot/dts/rk3288-rock2-som.dtsi b/arch/arm/boot/dts/rk3288-rock2-som.dtsi
> index 1ece66f3e162..4ba7ddecb478 100644
> --- a/arch/arm/boot/dts/rk3288-rock2-som.dtsi
> +++ b/arch/arm/boot/dts/rk3288-rock2-som.dtsi
> @@ -101,6 +101,14 @@
>  	snps,reset-delays-us = <0 10000 30000>;
>  	rx_delay = <0x10>;
>  	tx_delay = <0x30>;
> +	mdio0 {
> +		#address-cells = <1>;
> +		#size-cells = <0>;
> +		compatible = "snps,dwmac-mdio";
> +		ethphy1: ethernet-phy@1 {
> +			reg = <1>;
> +		};
> +	};

This is a) ugly for lack of white lines in between, b) unnecessary since
this is being fixed in the stmmac driver where it will benefit more than
just this one SoM.

Regards,
Andreas

>  };
>  
>  &i2c0 {

-- 
SUSE Linux GmbH, Maxfeldstr. 5, 90409 Nürnberg, Germany
GF: Felix Imendörffer, Jane Smithard, Graham Norton; HRB 21284 (AG Nürnberg)
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

^ permalink raw reply	[flat|nested] 12+ messages in thread
* [PATCH] ARM: dts: rockchip: Add mdio node to ethernet node
@ 2016-03-18 21:34   ` Andreas Färber
  0 siblings, 0 replies; 12+ messages in thread
From: Andreas Färber @ 2016-03-18 21:34 UTC (permalink / raw)
  To: linux-arm-kernel

Am 18.03.2016 um 12:20 schrieb Tomeu Vizoso:
> So the dwmac device manages to probe again.
> 
> Signed-off-by: Tomeu Vizoso <tomeu.vizoso@collabora.com>
> Fixes: 88f8b1bb41c6 ("stmmac: Fix 'eth0: No PHY found' regression")
> ---
>  arch/arm/boot/dts/rk3288-rock2-som.dtsi | 8 ++++++++
>  1 file changed, 8 insertions(+)
> 
> diff --git a/arch/arm/boot/dts/rk3288-rock2-som.dtsi b/arch/arm/boot/dts/rk3288-rock2-som.dtsi
> index 1ece66f3e162..4ba7ddecb478 100644
> --- a/arch/arm/boot/dts/rk3288-rock2-som.dtsi
> +++ b/arch/arm/boot/dts/rk3288-rock2-som.dtsi
> @@ -101,6 +101,14 @@
>  	snps,reset-delays-us = <0 10000 30000>;
>  	rx_delay = <0x10>;
>  	tx_delay = <0x30>;
> +	mdio0 {
> +		#address-cells = <1>;
> +		#size-cells = <0>;
> +		compatible = "snps,dwmac-mdio";
> +		ethphy1: ethernet-phy at 1 {
> +			reg = <1>;
> +		};
> +	};

This is a) ugly for lack of white lines in between, b) unnecessary since
this is being fixed in the stmmac driver where it will benefit more than
just this one SoM.

Regards,
Andreas

>  };
>  
>  &i2c0 {

-- 
SUSE Linux GmbH, Maxfeldstr. 5, 90409 N?rnberg, Germany
GF: Felix Imend?rffer, Jane Smithard, Graham Norton; HRB 21284 (AG N?rnberg)

^ permalink raw reply	[flat|nested] 12+ messages in thread
* Re: [PATCH] ARM: dts: rockchip: Add mdio node to ethernet node
@ 2016-03-21  8:23     ` Tomeu Vizoso
  0 siblings, 0 replies; 12+ messages in thread
From: Tomeu Vizoso @ 2016-03-21  8:23 UTC (permalink / raw)
  To: Andreas Färber
  Cc: linux-kernel, Mark Rutland, devicetree, Russell King,
	Heiko Stuebner, Pawel Moll, Ian Campbell, Rob Herring,
	Kumar Gala, open list:ARM/Rockchip SoC...,
	linux-arm-kernel, Giuseppe Cavallaro

On 18 March 2016 at 22:34, Andreas Färber <afaerber@suse.de> wrote:
> Am 18.03.2016 um 12:20 schrieb Tomeu Vizoso:
>> So the dwmac device manages to probe again.
>>
>> Signed-off-by: Tomeu Vizoso <tomeu.vizoso@collabora.com>
>> Fixes: 88f8b1bb41c6 ("stmmac: Fix 'eth0: No PHY found' regression")
>> ---
>>  arch/arm/boot/dts/rk3288-rock2-som.dtsi | 8 ++++++++
>>  1 file changed, 8 insertions(+)
>>
>> diff --git a/arch/arm/boot/dts/rk3288-rock2-som.dtsi b/arch/arm/boot/dts/rk3288-rock2-som.dtsi
>> index 1ece66f3e162..4ba7ddecb478 100644
>> --- a/arch/arm/boot/dts/rk3288-rock2-som.dtsi
>> +++ b/arch/arm/boot/dts/rk3288-rock2-som.dtsi
>> @@ -101,6 +101,14 @@
>>       snps,reset-delays-us = <0 10000 30000>;
>>       rx_delay = <0x10>;
>>       tx_delay = <0x30>;
>> +     mdio0 {
>> +             #address-cells = <1>;
>> +             #size-cells = <0>;
>> +             compatible = "snps,dwmac-mdio";
>> +             ethphy1: ethernet-phy@1 {
>> +                     reg = <1>;
>> +             };
>> +     };
>
> This is a) ugly for lack of white lines in between, b) unnecessary since
> this is being fixed in the stmmac driver where it will benefit more than
> just this one SoM.

So is this redundant information, or just not necessary with the
present kernel driver because of some assumption in its current
implementation?

Thanks,

Tomeu

> Regards,
> Andreas
>
>>  };
>>
>>  &i2c0 {
>
> --
> SUSE Linux GmbH, Maxfeldstr. 5, 90409 Nürnberg, Germany
> GF: Felix Imendörffer, Jane Smithard, Graham Norton; HRB 21284 (AG Nürnberg)

^ permalink raw reply	[flat|nested] 12+ messages in thread
* Re: [PATCH] ARM: dts: rockchip: Add mdio node to ethernet node
@ 2016-03-21  8:23     ` Tomeu Vizoso
  0 siblings, 0 replies; 12+ messages in thread
From: Tomeu Vizoso @ 2016-03-21  8:23 UTC (permalink / raw)
  To: Andreas Färber
  Cc: linux-kernel-u79uwXL29TY76Z2rM5mHXA, Mark Rutland,
	devicetree-u79uwXL29TY76Z2rM5mHXA, Russell King, Heiko Stuebner,
	Pawel Moll, Ian Campbell, Rob Herring, Kumar Gala,
	open list:ARM/Rockchip SoC...,
	linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r,
	Giuseppe Cavallaro

On 18 March 2016 at 22:34, Andreas Färber <afaerber-l3A5Bk7waGM@public.gmane.org> wrote:
> Am 18.03.2016 um 12:20 schrieb Tomeu Vizoso:
>> So the dwmac device manages to probe again.
>>
>> Signed-off-by: Tomeu Vizoso <tomeu.vizoso-ZGY8ohtN/8qB+jHODAdFcQ@public.gmane.org>
>> Fixes: 88f8b1bb41c6 ("stmmac: Fix 'eth0: No PHY found' regression")
>> ---
>>  arch/arm/boot/dts/rk3288-rock2-som.dtsi | 8 ++++++++
>>  1 file changed, 8 insertions(+)
>>
>> diff --git a/arch/arm/boot/dts/rk3288-rock2-som.dtsi b/arch/arm/boot/dts/rk3288-rock2-som.dtsi
>> index 1ece66f3e162..4ba7ddecb478 100644
>> --- a/arch/arm/boot/dts/rk3288-rock2-som.dtsi
>> +++ b/arch/arm/boot/dts/rk3288-rock2-som.dtsi
>> @@ -101,6 +101,14 @@
>>       snps,reset-delays-us = <0 10000 30000>;
>>       rx_delay = <0x10>;
>>       tx_delay = <0x30>;
>> +     mdio0 {
>> +             #address-cells = <1>;
>> +             #size-cells = <0>;
>> +             compatible = "snps,dwmac-mdio";
>> +             ethphy1: ethernet-phy@1 {
>> +                     reg = <1>;
>> +             };
>> +     };
>
> This is a) ugly for lack of white lines in between, b) unnecessary since
> this is being fixed in the stmmac driver where it will benefit more than
> just this one SoM.

So is this redundant information, or just not necessary with the
present kernel driver because of some assumption in its current
implementation?

Thanks,

Tomeu

> Regards,
> Andreas
>
>>  };
>>
>>  &i2c0 {
>
> --
> SUSE Linux GmbH, Maxfeldstr. 5, 90409 Nürnberg, Germany
> GF: Felix Imendörffer, Jane Smithard, Graham Norton; HRB 21284 (AG Nürnberg)
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

^ permalink raw reply	[flat|nested] 12+ messages in thread
* [PATCH] ARM: dts: rockchip: Add mdio node to ethernet node
@ 2016-03-21  8:23     ` Tomeu Vizoso
  0 siblings, 0 replies; 12+ messages in thread
From: Tomeu Vizoso @ 2016-03-21  8:23 UTC (permalink / raw)
  To: linux-arm-kernel

On 18 March 2016 at 22:34, Andreas F?rber <afaerber@suse.de> wrote:
> Am 18.03.2016 um 12:20 schrieb Tomeu Vizoso:
>> So the dwmac device manages to probe again.
>>
>> Signed-off-by: Tomeu Vizoso <tomeu.vizoso@collabora.com>
>> Fixes: 88f8b1bb41c6 ("stmmac: Fix 'eth0: No PHY found' regression")
>> ---
>>  arch/arm/boot/dts/rk3288-rock2-som.dtsi | 8 ++++++++
>>  1 file changed, 8 insertions(+)
>>
>> diff --git a/arch/arm/boot/dts/rk3288-rock2-som.dtsi b/arch/arm/boot/dts/rk3288-rock2-som.dtsi
>> index 1ece66f3e162..4ba7ddecb478 100644
>> --- a/arch/arm/boot/dts/rk3288-rock2-som.dtsi
>> +++ b/arch/arm/boot/dts/rk3288-rock2-som.dtsi
>> @@ -101,6 +101,14 @@
>>       snps,reset-delays-us = <0 10000 30000>;
>>       rx_delay = <0x10>;
>>       tx_delay = <0x30>;
>> +     mdio0 {
>> +             #address-cells = <1>;
>> +             #size-cells = <0>;
>> +             compatible = "snps,dwmac-mdio";
>> +             ethphy1: ethernet-phy at 1 {
>> +                     reg = <1>;
>> +             };
>> +     };
>
> This is a) ugly for lack of white lines in between, b) unnecessary since
> this is being fixed in the stmmac driver where it will benefit more than
> just this one SoM.

So is this redundant information, or just not necessary with the
present kernel driver because of some assumption in its current
implementation?

Thanks,

Tomeu

> Regards,
> Andreas
>
>>  };
>>
>>  &i2c0 {
>
> --
> SUSE Linux GmbH, Maxfeldstr. 5, 90409 N?rnberg, Germany
> GF: Felix Imend?rffer, Jane Smithard, Graham Norton; HRB 21284 (AG N?rnberg)

^ permalink raw reply	[flat|nested] 12+ messages in thread
* Re: [PATCH] ARM: dts: rockchip: Add mdio node to ethernet node
@ 2016-03-21  8:32       ` Michael Trimarchi
  0 siblings, 0 replies; 12+ messages in thread
From: Michael Trimarchi @ 2016-03-21  8:32 UTC (permalink / raw)
  To: Tomeu Vizoso
  Cc: Andreas Färber, Mark Rutland, devicetree, Russell King,
	Heiko Stuebner, Pawel Moll, Ian Campbell, linux-kernel,
	open list:ARM/Rockchip SoC...,
	Rob Herring, Kumar Gala, Giuseppe Cavallaro, linux-arm-kernel

Hi

On Mon, Mar 21, 2016 at 9:23 AM, Tomeu Vizoso
<tomeu.vizoso@collabora.com> wrote:
> On 18 March 2016 at 22:34, Andreas Färber <afaerber@suse.de> wrote:
>> Am 18.03.2016 um 12:20 schrieb Tomeu Vizoso:
>>> So the dwmac device manages to probe again.
>>>
>>> Signed-off-by: Tomeu Vizoso <tomeu.vizoso@collabora.com>
>>> Fixes: 88f8b1bb41c6 ("stmmac: Fix 'eth0: No PHY found' regression")
>>> ---
>>>  arch/arm/boot/dts/rk3288-rock2-som.dtsi | 8 ++++++++
>>>  1 file changed, 8 insertions(+)
>>>
>>> diff --git a/arch/arm/boot/dts/rk3288-rock2-som.dtsi b/arch/arm/boot/dts/rk3288-rock2-som.dtsi
>>> index 1ece66f3e162..4ba7ddecb478 100644
>>> --- a/arch/arm/boot/dts/rk3288-rock2-som.dtsi
>>> +++ b/arch/arm/boot/dts/rk3288-rock2-som.dtsi
>>> @@ -101,6 +101,14 @@
>>>       snps,reset-delays-us = <0 10000 30000>;
>>>       rx_delay = <0x10>;
>>>       tx_delay = <0x30>;
>>> +     mdio0 {
>>> +             #address-cells = <1>;
>>> +             #size-cells = <0>;
>>> +             compatible = "snps,dwmac-mdio";
>>> +             ethphy1: ethernet-phy@1 {
>>> +                     reg = <1>;
>>> +             };
>>> +     };
>>
>> This is a) ugly for lack of white lines in between, b) unnecessary since
>> this is being fixed in the stmmac driver where it will benefit more than
>> just this one SoM.
>
> So is this redundant information, or just not necessary with the
> present kernel driver because of some assumption in its current
> implementation?
>

I have the same fix on my firefly tree. Look likes correct and describe the
connection

Michael

> Thanks,
>
> Tomeu
>
>> Regards,
>> Andreas
>>
>>>  };
>>>
>>>  &i2c0 {
>>
>> --
>> SUSE Linux GmbH, Maxfeldstr. 5, 90409 Nürnberg, Germany
>> GF: Felix Imendörffer, Jane Smithard, Graham Norton; HRB 21284 (AG Nürnberg)
>
> _______________________________________________
> Linux-rockchip mailing list
> Linux-rockchip@lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/linux-rockchip



-- 
| Michael Nazzareno Trimarchi                     Amarula Solutions BV |
| COO  -  Founder                                      Cruquiuskade 47 |
| +31(0)851119172                                 Amsterdam 1018 AM NL |
|                  [`as] http://www.amarulasolutions.com               |

^ permalink raw reply	[flat|nested] 12+ messages in thread
* Re: [PATCH] ARM: dts: rockchip: Add mdio node to ethernet node
@ 2016-03-21  8:32       ` Michael Trimarchi
  0 siblings, 0 replies; 12+ messages in thread
From: Michael Trimarchi @ 2016-03-21  8:32 UTC (permalink / raw)
  To: Tomeu Vizoso
  Cc: Andreas Färber, Mark Rutland,
	devicetree-u79uwXL29TY76Z2rM5mHXA, Russell King, Heiko Stuebner,
	Pawel Moll, Ian Campbell, linux-kernel-u79uwXL29TY76Z2rM5mHXA,
	open list:ARM/Rockchip SoC...,
	Rob Herring, Kumar Gala, Giuseppe Cavallaro,
	linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r

Hi

On Mon, Mar 21, 2016 at 9:23 AM, Tomeu Vizoso
<tomeu.vizoso-ZGY8ohtN/8qB+jHODAdFcQ@public.gmane.org> wrote:
> On 18 March 2016 at 22:34, Andreas Färber <afaerber-l3A5Bk7waGM@public.gmane.org> wrote:
>> Am 18.03.2016 um 12:20 schrieb Tomeu Vizoso:
>>> So the dwmac device manages to probe again.
>>>
>>> Signed-off-by: Tomeu Vizoso <tomeu.vizoso-ZGY8ohtN/8qB+jHODAdFcQ@public.gmane.org>
>>> Fixes: 88f8b1bb41c6 ("stmmac: Fix 'eth0: No PHY found' regression")
>>> ---
>>>  arch/arm/boot/dts/rk3288-rock2-som.dtsi | 8 ++++++++
>>>  1 file changed, 8 insertions(+)
>>>
>>> diff --git a/arch/arm/boot/dts/rk3288-rock2-som.dtsi b/arch/arm/boot/dts/rk3288-rock2-som.dtsi
>>> index 1ece66f3e162..4ba7ddecb478 100644
>>> --- a/arch/arm/boot/dts/rk3288-rock2-som.dtsi
>>> +++ b/arch/arm/boot/dts/rk3288-rock2-som.dtsi
>>> @@ -101,6 +101,14 @@
>>>       snps,reset-delays-us = <0 10000 30000>;
>>>       rx_delay = <0x10>;
>>>       tx_delay = <0x30>;
>>> +     mdio0 {
>>> +             #address-cells = <1>;
>>> +             #size-cells = <0>;
>>> +             compatible = "snps,dwmac-mdio";
>>> +             ethphy1: ethernet-phy@1 {
>>> +                     reg = <1>;
>>> +             };
>>> +     };
>>
>> This is a) ugly for lack of white lines in between, b) unnecessary since
>> this is being fixed in the stmmac driver where it will benefit more than
>> just this one SoM.
>
> So is this redundant information, or just not necessary with the
> present kernel driver because of some assumption in its current
> implementation?
>

I have the same fix on my firefly tree. Look likes correct and describe the
connection

Michael

> Thanks,
>
> Tomeu
>
>> Regards,
>> Andreas
>>
>>>  };
>>>
>>>  &i2c0 {
>>
>> --
>> SUSE Linux GmbH, Maxfeldstr. 5, 90409 Nürnberg, Germany
>> GF: Felix Imendörffer, Jane Smithard, Graham Norton; HRB 21284 (AG Nürnberg)
>
> _______________________________________________
> Linux-rockchip mailing list
> Linux-rockchip-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org
> http://lists.infradead.org/mailman/listinfo/linux-rockchip



-- 
| Michael Nazzareno Trimarchi                     Amarula Solutions BV |
| COO  -  Founder                                      Cruquiuskade 47 |
| +31(0)851119172                                 Amsterdam 1018 AM NL |
|                  [`as] http://www.amarulasolutions.com               |
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

^ permalink raw reply	[flat|nested] 12+ messages in thread
* [PATCH] ARM: dts: rockchip: Add mdio node to ethernet node
@ 2016-03-21  8:32       ` Michael Trimarchi
  0 siblings, 0 replies; 12+ messages in thread
From: Michael Trimarchi @ 2016-03-21  8:32 UTC (permalink / raw)
  To: linux-arm-kernel

Hi

On Mon, Mar 21, 2016 at 9:23 AM, Tomeu Vizoso
<tomeu.vizoso@collabora.com> wrote:
> On 18 March 2016 at 22:34, Andreas F?rber <afaerber@suse.de> wrote:
>> Am 18.03.2016 um 12:20 schrieb Tomeu Vizoso:
>>> So the dwmac device manages to probe again.
>>>
>>> Signed-off-by: Tomeu Vizoso <tomeu.vizoso@collabora.com>
>>> Fixes: 88f8b1bb41c6 ("stmmac: Fix 'eth0: No PHY found' regression")
>>> ---
>>>  arch/arm/boot/dts/rk3288-rock2-som.dtsi | 8 ++++++++
>>>  1 file changed, 8 insertions(+)
>>>
>>> diff --git a/arch/arm/boot/dts/rk3288-rock2-som.dtsi b/arch/arm/boot/dts/rk3288-rock2-som.dtsi
>>> index 1ece66f3e162..4ba7ddecb478 100644
>>> --- a/arch/arm/boot/dts/rk3288-rock2-som.dtsi
>>> +++ b/arch/arm/boot/dts/rk3288-rock2-som.dtsi
>>> @@ -101,6 +101,14 @@
>>>       snps,reset-delays-us = <0 10000 30000>;
>>>       rx_delay = <0x10>;
>>>       tx_delay = <0x30>;
>>> +     mdio0 {
>>> +             #address-cells = <1>;
>>> +             #size-cells = <0>;
>>> +             compatible = "snps,dwmac-mdio";
>>> +             ethphy1: ethernet-phy at 1 {
>>> +                     reg = <1>;
>>> +             };
>>> +     };
>>
>> This is a) ugly for lack of white lines in between, b) unnecessary since
>> this is being fixed in the stmmac driver where it will benefit more than
>> just this one SoM.
>
> So is this redundant information, or just not necessary with the
> present kernel driver because of some assumption in its current
> implementation?
>

I have the same fix on my firefly tree. Look likes correct and describe the
connection

Michael

> Thanks,
>
> Tomeu
>
>> Regards,
>> Andreas
>>
>>>  };
>>>
>>>  &i2c0 {
>>
>> --
>> SUSE Linux GmbH, Maxfeldstr. 5, 90409 N?rnberg, Germany
>> GF: Felix Imend?rffer, Jane Smithard, Graham Norton; HRB 21284 (AG N?rnberg)
>
> _______________________________________________
> Linux-rockchip mailing list
> Linux-rockchip at lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/linux-rockchip



-- 
| Michael Nazzareno Trimarchi                     Amarula Solutions BV |
| COO  -  Founder                                      Cruquiuskade 47 |
| +31(0)851119172                                 Amsterdam 1018 AM NL |
|                  [`as] http://www.amarulasolutions.com               |

^ permalink raw reply	[flat|nested] 12+ messages in thread
end of thread, other threads:[~2016-03-21  8:33 UTC | newest]

Thread overview: 12+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2016-03-18 11:20 [PATCH] ARM: dts: rockchip: Add mdio node to ethernet node Tomeu Vizoso
2016-03-18 11:20 ` Tomeu Vizoso
2016-03-18 11:20 ` Tomeu Vizoso
2016-03-18 21:34 ` Andreas Färber
2016-03-18 21:34   ` Andreas Färber
2016-03-18 21:34   ` Andreas Färber
2016-03-21  8:23   ` Tomeu Vizoso
2016-03-21  8:23     ` Tomeu Vizoso
2016-03-21  8:23     ` Tomeu Vizoso
2016-03-21  8:32     ` Michael Trimarchi
2016-03-21  8:32       ` Michael Trimarchi
2016-03-21  8:32       ` Michael Trimarchi

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.