* [PATCH] ASoC: Intel: Skylake: Fix kbuild dependency
@ 2016-03-18 14:40 Vinod Koul
2016-03-18 17:34 ` Takashi Iwai
0 siblings, 1 reply; 2+ messages in thread
From: Vinod Koul @ 2016-03-18 14:40 UTC (permalink / raw)
To: alsa-devel; +Cc: liam.r.girdwood, tiwai, broonie, Vinod Koul, patches.audio
The Skylake driver selects SND_HDA_I915 which causes kbuild to spew warning:
warning: (SND_SOC_INTEL_SKYLAKE) selects SND_HDA_I915 which has unmet direct dependencies
(SOUND && !M68K && !UML && SND && DRM_I915 && SND_HDA_CORE)
The SND_HDA_I915 should not be selected so drop that.
Reported-by: Takashi Iwai <tiwai@suse.de>
Signed-off-by: Vinod Koul <vinod.koul@intel.com>
---
sound/soc/intel/Kconfig | 1 -
1 file changed, 1 deletion(-)
diff --git a/sound/soc/intel/Kconfig b/sound/soc/intel/Kconfig
index b3e6c2300457..1120f4f4d011 100644
--- a/sound/soc/intel/Kconfig
+++ b/sound/soc/intel/Kconfig
@@ -163,7 +163,6 @@ config SND_SOC_INTEL_SKYLAKE
tristate
select SND_HDA_EXT_CORE
select SND_SOC_TOPOLOGY
- select SND_HDA_I915
select SND_SOC_INTEL_SST
config SND_SOC_INTEL_SKL_RT286_MACH
--
1.9.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] ASoC: Intel: Skylake: Fix kbuild dependency
2016-03-18 14:40 [PATCH] ASoC: Intel: Skylake: Fix kbuild dependency Vinod Koul
@ 2016-03-18 17:34 ` Takashi Iwai
0 siblings, 0 replies; 2+ messages in thread
From: Takashi Iwai @ 2016-03-18 17:34 UTC (permalink / raw)
To: Vinod Koul; +Cc: liam.r.girdwood, patches.audio, alsa-devel, broonie
On Fri, 18 Mar 2016 15:40:23 +0100,
Vinod Koul wrote:
>
> The Skylake driver selects SND_HDA_I915 which causes kbuild to spew warning:
>
> warning: (SND_SOC_INTEL_SKYLAKE) selects SND_HDA_I915 which has unmet direct dependencies
> (SOUND && !M68K && !UML && SND && DRM_I915 && SND_HDA_CORE)
>
> The SND_HDA_I915 should not be selected so drop that.
>
> Reported-by: Takashi Iwai <tiwai@suse.de>
> Signed-off-by: Vinod Koul <vinod.koul@intel.com>
Reviewed-by: Takashi Iwai <tiwai@suse.de>
thanks,
Takashi
> ---
> sound/soc/intel/Kconfig | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/sound/soc/intel/Kconfig b/sound/soc/intel/Kconfig
> index b3e6c2300457..1120f4f4d011 100644
> --- a/sound/soc/intel/Kconfig
> +++ b/sound/soc/intel/Kconfig
> @@ -163,7 +163,6 @@ config SND_SOC_INTEL_SKYLAKE
> tristate
> select SND_HDA_EXT_CORE
> select SND_SOC_TOPOLOGY
> - select SND_HDA_I915
> select SND_SOC_INTEL_SST
>
> config SND_SOC_INTEL_SKL_RT286_MACH
> --
> 1.9.1
>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2016-03-18 17:34 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2016-03-18 14:40 [PATCH] ASoC: Intel: Skylake: Fix kbuild dependency Vinod Koul
2016-03-18 17:34 ` Takashi Iwai
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.