* [PATCH v5] rt2x00usb: Use usb anchor to manage URB
@ 2016-03-18 16:29 Vishal Thanki
2016-03-19 8:06 ` Stanislaw Gruszka
0 siblings, 1 reply; 4+ messages in thread
From: Vishal Thanki @ 2016-03-18 16:29 UTC (permalink / raw)
To: sgruszka, helmut.schaa, linux-wireless; +Cc: Vishal Thanki
With current driver, it is observed that a URB is not
completed while the USB disconnect is initiated. Due to
that, the URB completion hanlder is trying to access
the resource which was freed as a part of USB disconnect.
Managing the URBs with anchor will make sure that all
the URBs are handled gracefully before device gets
disconnected.
Signed-off-by: Vishal Thanki <vishalthanki@gmail.com>
---
drivers/net/wireless/ralink/rt2x00/rt2x00.h | 4 ++++
drivers/net/wireless/ralink/rt2x00/rt2x00dev.c | 1 +
drivers/net/wireless/ralink/rt2x00/rt2x00usb.c | 27 ++++++++++++++++++++++++--
3 files changed, 30 insertions(+), 2 deletions(-)
diff --git a/drivers/net/wireless/ralink/rt2x00/rt2x00.h b/drivers/net/wireless/ralink/rt2x00/rt2x00.h
index 3282ddb..0ae11e9 100644
--- a/drivers/net/wireless/ralink/rt2x00/rt2x00.h
+++ b/drivers/net/wireless/ralink/rt2x00/rt2x00.h
@@ -38,6 +38,7 @@
#include <linux/kfifo.h>
#include <linux/hrtimer.h>
#include <linux/average.h>
+#include <linux/usb.h>
#include <net/mac80211.h>
@@ -1001,6 +1002,9 @@ struct rt2x00_dev {
/* Extra TX headroom required for alignment purposes. */
unsigned int extra_tx_headroom;
+
+ struct usb_anchor *anchor;
+ void (*kill_anchored_urbs)(struct rt2x00_dev *);
};
struct rt2x00_bar_list_entry {
diff --git a/drivers/net/wireless/ralink/rt2x00/rt2x00dev.c b/drivers/net/wireless/ralink/rt2x00/rt2x00dev.c
index 5639ed8..47b2d99 100644
--- a/drivers/net/wireless/ralink/rt2x00/rt2x00dev.c
+++ b/drivers/net/wireless/ralink/rt2x00/rt2x00dev.c
@@ -1423,6 +1423,7 @@ void rt2x00lib_remove_dev(struct rt2x00_dev *rt2x00dev)
cancel_delayed_work_sync(&rt2x00dev->autowakeup_work);
cancel_work_sync(&rt2x00dev->sleep_work);
if (rt2x00_is_usb(rt2x00dev)) {
+ rt2x00dev->kill_anchored_urbs(rt2x00dev);
hrtimer_cancel(&rt2x00dev->txstatus_timer);
cancel_work_sync(&rt2x00dev->rxdone_work);
cancel_work_sync(&rt2x00dev->txdone_work);
diff --git a/drivers/net/wireless/ralink/rt2x00/rt2x00usb.c b/drivers/net/wireless/ralink/rt2x00/rt2x00usb.c
index 7627af6..7b47a66 100644
--- a/drivers/net/wireless/ralink/rt2x00/rt2x00usb.c
+++ b/drivers/net/wireless/ralink/rt2x00/rt2x00usb.c
@@ -171,8 +171,11 @@ static void rt2x00usb_register_read_async_cb(struct urb *urb)
{
struct rt2x00_async_read_data *rd = urb->context;
if (rd->callback(rd->rt2x00dev, urb->status, le32_to_cpu(rd->reg))) {
- if (usb_submit_urb(urb, GFP_ATOMIC) < 0)
+ usb_anchor_urb(urb, rd->rt2x00dev->anchor);
+ if (usb_submit_urb(urb, GFP_ATOMIC) < 0) {
+ usb_unanchor_urb(urb);
kfree(rd);
+ }
} else
kfree(rd);
}
@@ -206,8 +209,11 @@ void rt2x00usb_register_read_async(struct rt2x00_dev *rt2x00dev,
usb_fill_control_urb(urb, usb_dev, usb_rcvctrlpipe(usb_dev, 0),
(unsigned char *)(&rd->cr), &rd->reg, sizeof(rd->reg),
rt2x00usb_register_read_async_cb, rd);
- if (usb_submit_urb(urb, GFP_ATOMIC) < 0)
+ usb_anchor_urb(urb, rt2x00dev->anchor);
+ if (usb_submit_urb(urb, GFP_ATOMIC) < 0) {
+ usb_unanchor_urb(urb);
kfree(rd);
+ }
usb_free_urb(urb);
}
EXPORT_SYMBOL_GPL(rt2x00usb_register_read_async);
@@ -313,8 +319,10 @@ static bool rt2x00usb_kick_tx_entry(struct queue_entry *entry, void *data)
entry->skb->data, length,
rt2x00usb_interrupt_txdone, entry);
+ usb_anchor_urb(entry_priv->urb, rt2x00dev->anchor);
status = usb_submit_urb(entry_priv->urb, GFP_ATOMIC);
if (status) {
+ usb_unanchor_urb(entry_priv->urb);
if (status == -ENODEV)
clear_bit(DEVICE_STATE_PRESENT, &rt2x00dev->flags);
set_bit(ENTRY_DATA_IO_FAILED, &entry->flags);
@@ -402,8 +410,10 @@ static bool rt2x00usb_kick_rx_entry(struct queue_entry *entry, void *data)
entry->skb->data, entry->skb->len,
rt2x00usb_interrupt_rxdone, entry);
+ usb_anchor_urb(entry_priv->urb, rt2x00dev->anchor);
status = usb_submit_urb(entry_priv->urb, GFP_ATOMIC);
if (status) {
+ usb_unanchor_urb(entry_priv->urb);
if (status == -ENODEV)
clear_bit(DEVICE_STATE_PRESENT, &rt2x00dev->flags);
set_bit(ENTRY_DATA_IO_FAILED, &entry->flags);
@@ -778,6 +788,11 @@ exit:
return -ENOMEM;
}
+static void rt2x00usb_kill_anchored_usb(struct rt2x00_dev *rt2x00dev)
+{
+ usb_kill_anchored_urbs(rt2x00dev->anchor);
+}
+
int rt2x00usb_probe(struct usb_interface *usb_intf,
const struct rt2x00_ops *ops)
{
@@ -818,6 +833,14 @@ int rt2x00usb_probe(struct usb_interface *usb_intf,
if (retval)
goto exit_free_reg;
+ rt2x00dev->anchor = devm_kmalloc(&usb_dev->dev,
+ sizeof(struct usb_anchor),
+ GFP_KERNEL);
+ if (!rt2x00dev->anchor)
+ goto exit_free_reg;
+
+ init_usb_anchor(rt2x00dev->anchor);
+ rt2x00dev->kill_anchored_urbs = rt2x00usb_kill_anchored_usb;
return 0;
exit_free_reg:
--
2.4.3
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH v5] rt2x00usb: Use usb anchor to manage URB
2016-03-18 16:29 [PATCH v5] rt2x00usb: Use usb anchor to manage URB Vishal Thanki
@ 2016-03-19 8:06 ` Stanislaw Gruszka
2016-03-19 8:21 ` Vishal Thanki
0 siblings, 1 reply; 4+ messages in thread
From: Stanislaw Gruszka @ 2016-03-19 8:06 UTC (permalink / raw)
To: Vishal Thanki; +Cc: helmut.schaa, linux-wireless
On Fri, Mar 18, 2016 at 05:29:51PM +0100, Vishal Thanki wrote:
>
> @@ -1001,6 +1002,9 @@ struct rt2x00_dev {
>
> /* Extra TX headroom required for alignment purposes. */
> unsigned int extra_tx_headroom;
> +
> + struct usb_anchor *anchor;
> + void (*kill_anchored_urbs)(struct rt2x00_dev *);
...
> @@ -1423,6 +1423,7 @@ void rt2x00lib_remove_dev(struct rt2x00_dev *rt2x00dev)
> cancel_delayed_work_sync(&rt2x00dev->autowakeup_work);
> cancel_work_sync(&rt2x00dev->sleep_work);
> if (rt2x00_is_usb(rt2x00dev)) {
> + rt2x00dev->kill_anchored_urbs(rt2x00dev);
...
>
> +static void rt2x00usb_kill_anchored_usb(struct rt2x00_dev *rt2x00dev)
> +{
> + usb_kill_anchored_urbs(rt2x00dev->anchor);
> +}
...
> + rt2x00dev->kill_anchored_urbs = rt2x00usb_kill_anchored_usb;
Why do you complicate things, instead of call usb_kill_anchored_urbs()
directly?
Stanislaw
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH v5] rt2x00usb: Use usb anchor to manage URB
2016-03-19 8:06 ` Stanislaw Gruszka
@ 2016-03-19 8:21 ` Vishal Thanki
2016-03-19 8:58 ` Stanislaw Gruszka
0 siblings, 1 reply; 4+ messages in thread
From: Vishal Thanki @ 2016-03-19 8:21 UTC (permalink / raw)
To: Stanislaw Gruszka; +Cc: Helmut Schaa, linux-wireless
On Sat, Mar 19, 2016 at 9:06 AM, Stanislaw Gruszka <sgruszka@redhat.com> wrote:
> On Fri, Mar 18, 2016 at 05:29:51PM +0100, Vishal Thanki wrote:
>>
>> @@ -1001,6 +1002,9 @@ struct rt2x00_dev {
>>
>> /* Extra TX headroom required for alignment purposes. */
>> unsigned int extra_tx_headroom;
>> +
>> + struct usb_anchor *anchor;
>> + void (*kill_anchored_urbs)(struct rt2x00_dev *);
> ...
>> @@ -1423,6 +1423,7 @@ void rt2x00lib_remove_dev(struct rt2x00_dev *rt2x00dev)
>> cancel_delayed_work_sync(&rt2x00dev->autowakeup_work);
>> cancel_work_sync(&rt2x00dev->sleep_work);
>> if (rt2x00_is_usb(rt2x00dev)) {
>> + rt2x00dev->kill_anchored_urbs(rt2x00dev);
> ...
>>
>> +static void rt2x00usb_kill_anchored_usb(struct rt2x00_dev *rt2x00dev)
>> +{
>> + usb_kill_anchored_urbs(rt2x00dev->anchor);
>> +}
> ...
>> + rt2x00dev->kill_anchored_urbs = rt2x00usb_kill_anchored_usb;
>
> Why do you complicate things, instead of call usb_kill_anchored_urbs()
> directly?
>
I tried to compile by disabling the CONFIG_USB from kernel, and was getting
error for missing symbol usb_kill_anchored_urbs.
> Stanislaw
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH v5] rt2x00usb: Use usb anchor to manage URB
2016-03-19 8:21 ` Vishal Thanki
@ 2016-03-19 8:58 ` Stanislaw Gruszka
0 siblings, 0 replies; 4+ messages in thread
From: Stanislaw Gruszka @ 2016-03-19 8:58 UTC (permalink / raw)
To: Vishal Thanki; +Cc: Helmut Schaa, linux-wireless
On Sat, Mar 19, 2016 at 09:21:52AM +0100, Vishal Thanki wrote:
> On Sat, Mar 19, 2016 at 9:06 AM, Stanislaw Gruszka <sgruszka@redhat.com> wrote:
> > On Fri, Mar 18, 2016 at 05:29:51PM +0100, Vishal Thanki wrote:
> >>
> >> @@ -1001,6 +1002,9 @@ struct rt2x00_dev {
> >>
> >> /* Extra TX headroom required for alignment purposes. */
> >> unsigned int extra_tx_headroom;
> >> +
> >> + struct usb_anchor *anchor;
> >> + void (*kill_anchored_urbs)(struct rt2x00_dev *);
> > ...
> >> @@ -1423,6 +1423,7 @@ void rt2x00lib_remove_dev(struct rt2x00_dev *rt2x00dev)
> >> cancel_delayed_work_sync(&rt2x00dev->autowakeup_work);
> >> cancel_work_sync(&rt2x00dev->sleep_work);
> >> if (rt2x00_is_usb(rt2x00dev)) {
> >> + rt2x00dev->kill_anchored_urbs(rt2x00dev);
> > ...
> >>
> >> +static void rt2x00usb_kill_anchored_usb(struct rt2x00_dev *rt2x00dev)
> >> +{
> >> + usb_kill_anchored_urbs(rt2x00dev->anchor);
> >> +}
> > ...
> >> + rt2x00dev->kill_anchored_urbs = rt2x00usb_kill_anchored_usb;
> >
> > Why do you complicate things, instead of call usb_kill_anchored_urbs()
> > directly?
> >
>
> I tried to compile by disabling the CONFIG_USB from kernel, and was getting
> error for missing symbol usb_kill_anchored_urbs.
Ok, just around if(rt2x00_is_usb) section by #ifdef RT2X00_LIB_USB. Or
you can try to modify rt2x00_is_usb to always return false if RT2X00_LIB_USB
is not configured - perhaps that will also prevent compilation failure
without USB support.
Stanislaw
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2016-03-19 9:00 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2016-03-18 16:29 [PATCH v5] rt2x00usb: Use usb anchor to manage URB Vishal Thanki
2016-03-19 8:06 ` Stanislaw Gruszka
2016-03-19 8:21 ` Vishal Thanki
2016-03-19 8:58 ` Stanislaw Gruszka
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.