* [U-Boot] [PATCH][v2] driver: net: fsl-mc: Return from DPAA_exit if boot_status !=0
@ 2016-03-21 8:49 Prabhakar Kushwaha
2016-03-21 16:24 ` Joe Hershberger
2016-03-22 15:47 ` york sun
0 siblings, 2 replies; 3+ messages in thread
From: Prabhakar Kushwaha @ 2016-03-21 8:49 UTC (permalink / raw)
To: u-boot
Return value of get_mc_boot_status() in case of failure is not necessary
to be -1.
So update the error condition check.
Signed-off-by: Prabhakar Kushwaha <prabhakar.kushwaha@nxp.com>
Reported-by: Yao Yuan <yao.yuan@nxp.com>
---
Changes for v2: Incorporated York's comments
- Added comments
drivers/net/fsl-mc/mc.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/drivers/net/fsl-mc/mc.c b/drivers/net/fsl-mc/mc.c
index 53c4966..f83bd0c 100644
--- a/drivers/net/fsl-mc/mc.c
+++ b/drivers/net/fsl-mc/mc.c
@@ -1147,7 +1147,8 @@ int fsl_mc_ldpaa_exit(bd_t *bd)
{
int err = 0;
- if (bd && get_mc_boot_status() == -1)
+ /* MC is not loaded intentionally, So return success. */
+ if (bd && get_mc_boot_status() != 0)
return 0;
if (bd && !get_mc_boot_status() && get_dpl_apply_status() == -1) {
--
1.9.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
* [U-Boot] [PATCH][v2] driver: net: fsl-mc: Return from DPAA_exit if boot_status !=0
2016-03-21 8:49 [U-Boot] [PATCH][v2] driver: net: fsl-mc: Return from DPAA_exit if boot_status !=0 Prabhakar Kushwaha
@ 2016-03-21 16:24 ` Joe Hershberger
2016-03-22 15:47 ` york sun
1 sibling, 0 replies; 3+ messages in thread
From: Joe Hershberger @ 2016-03-21 16:24 UTC (permalink / raw)
To: u-boot
On Mon, Mar 21, 2016 at 3:49 AM, Prabhakar Kushwaha
<prabhakar.kushwaha@nxp.com> wrote:
> Return value of get_mc_boot_status() in case of failure is not necessary
> to be -1.
>
> So update the error condition check.
>
> Signed-off-by: Prabhakar Kushwaha <prabhakar.kushwaha@nxp.com>
> Reported-by: Yao Yuan <yao.yuan@nxp.com>
Acked-by: Joe Hershberger <joe.hershberger@ni.com>
^ permalink raw reply [flat|nested] 3+ messages in thread
* [U-Boot] [PATCH][v2] driver: net: fsl-mc: Return from DPAA_exit if boot_status !=0
2016-03-21 8:49 [U-Boot] [PATCH][v2] driver: net: fsl-mc: Return from DPAA_exit if boot_status !=0 Prabhakar Kushwaha
2016-03-21 16:24 ` Joe Hershberger
@ 2016-03-22 15:47 ` york sun
1 sibling, 0 replies; 3+ messages in thread
From: york sun @ 2016-03-22 15:47 UTC (permalink / raw)
To: u-boot
On 03/21/2016 01:50 AM, Prabhakar Kushwaha wrote:
> Return value of get_mc_boot_status() in case of failure is not necessary
> to be -1.
>
> So update the error condition check.
>
> Signed-off-by: Prabhakar Kushwaha <prabhakar.kushwaha@nxp.com>
> Reported-by: Yao Yuan <yao.yuan@nxp.com>
> ---
> Changes for v2: Incorporated York's comments
> - Added comments
>
> drivers/net/fsl-mc/mc.c | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
Applied to u-boot-fsl-qoriq, awaiting upstream.
Thanks.
York
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2016-03-22 15:47 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2016-03-21 8:49 [U-Boot] [PATCH][v2] driver: net: fsl-mc: Return from DPAA_exit if boot_status !=0 Prabhakar Kushwaha
2016-03-21 16:24 ` Joe Hershberger
2016-03-22 15:47 ` york sun
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.