All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH 2/5] USB: serial: cp210x: Made sure SERIAL_XOFF_CONTINUE flag is clear.
@ 2016-03-21 23:37 Konstantin Shkolnyy
  0 siblings, 0 replies; only message in thread
From: Konstantin Shkolnyy @ 2016-03-21 23:37 UTC (permalink / raw)
  To: johan; +Cc: linux-usb, linux-kernel, Konstantin Shkolnyy

The CRTCTS flag code intended to clear the SERIAL_XOFF_CONTINUE flag, but
did it inconsistently. This change is non-functional for existing chips
because the driver never set the flag and it's clear by default.

Signed-off-by: Konstantin Shkolnyy <konstantin.shkolnyy@gmail.com>
---
 drivers/usb/serial/cp210x.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/usb/serial/cp210x.c b/drivers/usb/serial/cp210x.c
index de1606f..ede5c52 100644
--- a/drivers/usb/serial/cp210x.c
+++ b/drivers/usb/serial/cp210x.c
@@ -955,7 +955,6 @@ static void cp210x_set_termios(struct tty_struct *tty,
 			modem_ctl[0] &= ~0x7B;
 			modem_ctl[0] |= 0x09;
 			modem_ctl[4] = 0x80;
-			modem_ctl[7] = 0;
 			dev_dbg(dev, "%s - flow control = CRTSCTS\n", __func__);
 		} else {
 			modem_ctl[0] &= ~0x7B;
@@ -963,6 +962,7 @@ static void cp210x_set_termios(struct tty_struct *tty,
 			modem_ctl[4] = 0x40;
 			dev_dbg(dev, "%s - flow control = NONE\n", __func__);
 		}
+		modem_ctl[7] = 0;
 
 		dev_dbg(dev, "%s - write modem controls = %02x .. .. .. %02x .. .. %02x\n",
 			__func__, modem_ctl[0], modem_ctl[4], modem_ctl[7]);
-- 
1.8.4.5

^ permalink raw reply related	[flat|nested] only message in thread

only message in thread, other threads:[~2016-03-21 23:35 UTC | newest]

Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2016-03-21 23:37 [PATCH 2/5] USB: serial: cp210x: Made sure SERIAL_XOFF_CONTINUE flag is clear Konstantin Shkolnyy

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.