All of lore.kernel.org
 help / color / mirror / Atom feed
From: Joerg Roedel <joro@8bytes.org>
To: Rob Herring <robh+dt@kernel.org>, grant.likely@linaro.org
Cc: Will Deacon <will.deacon@arm.com>,
	linux-arm-kernel@lists.infradead.org, devicetree@vger.kernel.org,
	iommu@lists.linux-foundation.org, linux-kernel@vger.kernel.org,
	jroedel@suse.de
Subject: [PATCH 4/6] of: Introduce of_for_each_phandle() helper macro
Date: Tue, 22 Mar 2016 18:58:27 +0100	[thread overview]
Message-ID: <1458669509-7178-5-git-send-email-joro@8bytes.org> (raw)
In-Reply-To: <1458669509-7178-1-git-send-email-joro@8bytes.org>

From: Joerg Roedel <jroedel@suse.de>

With this macro any user can easily iterate over a list of
phandles. The patch also converts __of_parse_phandle_with_args()
to make use of the macro.

The of_count_phandle_with_args() function is not converted,
because the macro hides the return value of of_phandle_iterator_init(),
which is needed in there.

Signed-off-by: Joerg Roedel <jroedel@suse.de>
---
 drivers/of/base.c  | 7 +------
 include/linux/of.h | 6 ++++++
 2 files changed, 7 insertions(+), 6 deletions(-)

diff --git a/drivers/of/base.c b/drivers/of/base.c
index 15593cd..471d3d9 100644
--- a/drivers/of/base.c
+++ b/drivers/of/base.c
@@ -1542,13 +1542,8 @@ static int __of_parse_phandle_with_args(const struct device_node *np,
 	struct of_phandle_iterator it;
 	int rc, cur_index = 0;
 
-	rc = of_phandle_iterator_init(&it, np, list_name,
-				      cells_name, cell_count);
-	if (rc)
-		return rc;
-
 	/* Loop over the phandles until all the requested entry is found */
-	while ((rc = of_phandle_iterator_next(&it)) == 0) {
+	of_for_each_phandle(&it, rc, np, list_name, cells_name, cell_count) {
 		/*
 		 * All of the error cases bail out of the loop, so at
 		 * this point, the parsing is successful. If the requested
diff --git a/include/linux/of.h b/include/linux/of.h
index d94388b0..05e38ed 100644
--- a/include/linux/of.h
+++ b/include/linux/of.h
@@ -908,6 +908,12 @@ static inline int of_property_read_s32(const struct device_node *np,
 	return of_property_read_u32(np, propname, (u32*) out_value);
 }
 
+#define of_for_each_phandle(it, err, np, ln, cn, cc)			\
+	for (of_phandle_iterator_init((it), (np), (ln), (cn), (cc)),	\
+	     err = of_phandle_iterator_next(it);			\
+	     err == 0;							\
+	     err = of_phandle_iterator_next(it))
+
 #define of_property_for_each_u32(np, propname, prop, p, u)	\
 	for (prop = of_find_property(np, propname, NULL),	\
 		p = of_prop_next_u32(prop, NULL, &u);		\
-- 
1.9.1

WARNING: multiple messages have this Message-ID (diff)
From: Joerg Roedel <joro-zLv9SwRftAIdnm+yROfE0A@public.gmane.org>
To: Rob Herring <robh+dt-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>,
	grant.likely-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org
Cc: devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
	jroedel-l3A5Bk7waGM@public.gmane.org,
	Will Deacon <will.deacon-5wv7dgnIgG8@public.gmane.org>,
	linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
	iommu-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org,
	linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org
Subject: [PATCH 4/6] of: Introduce of_for_each_phandle() helper macro
Date: Tue, 22 Mar 2016 18:58:27 +0100	[thread overview]
Message-ID: <1458669509-7178-5-git-send-email-joro@8bytes.org> (raw)
In-Reply-To: <1458669509-7178-1-git-send-email-joro-zLv9SwRftAIdnm+yROfE0A@public.gmane.org>

From: Joerg Roedel <jroedel-l3A5Bk7waGM@public.gmane.org>

With this macro any user can easily iterate over a list of
phandles. The patch also converts __of_parse_phandle_with_args()
to make use of the macro.

The of_count_phandle_with_args() function is not converted,
because the macro hides the return value of of_phandle_iterator_init(),
which is needed in there.

Signed-off-by: Joerg Roedel <jroedel-l3A5Bk7waGM@public.gmane.org>
---
 drivers/of/base.c  | 7 +------
 include/linux/of.h | 6 ++++++
 2 files changed, 7 insertions(+), 6 deletions(-)

diff --git a/drivers/of/base.c b/drivers/of/base.c
index 15593cd..471d3d9 100644
--- a/drivers/of/base.c
+++ b/drivers/of/base.c
@@ -1542,13 +1542,8 @@ static int __of_parse_phandle_with_args(const struct device_node *np,
 	struct of_phandle_iterator it;
 	int rc, cur_index = 0;
 
-	rc = of_phandle_iterator_init(&it, np, list_name,
-				      cells_name, cell_count);
-	if (rc)
-		return rc;
-
 	/* Loop over the phandles until all the requested entry is found */
-	while ((rc = of_phandle_iterator_next(&it)) == 0) {
+	of_for_each_phandle(&it, rc, np, list_name, cells_name, cell_count) {
 		/*
 		 * All of the error cases bail out of the loop, so at
 		 * this point, the parsing is successful. If the requested
diff --git a/include/linux/of.h b/include/linux/of.h
index d94388b0..05e38ed 100644
--- a/include/linux/of.h
+++ b/include/linux/of.h
@@ -908,6 +908,12 @@ static inline int of_property_read_s32(const struct device_node *np,
 	return of_property_read_u32(np, propname, (u32*) out_value);
 }
 
+#define of_for_each_phandle(it, err, np, ln, cn, cc)			\
+	for (of_phandle_iterator_init((it), (np), (ln), (cn), (cc)),	\
+	     err = of_phandle_iterator_next(it);			\
+	     err == 0;							\
+	     err = of_phandle_iterator_next(it))
+
 #define of_property_for_each_u32(np, propname, prop, p, u)	\
 	for (prop = of_find_property(np, propname, NULL),	\
 		p = of_prop_next_u32(prop, NULL, &u);		\
-- 
1.9.1

WARNING: multiple messages have this Message-ID (diff)
From: joro@8bytes.org (Joerg Roedel)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 4/6] of: Introduce of_for_each_phandle() helper macro
Date: Tue, 22 Mar 2016 18:58:27 +0100	[thread overview]
Message-ID: <1458669509-7178-5-git-send-email-joro@8bytes.org> (raw)
In-Reply-To: <1458669509-7178-1-git-send-email-joro@8bytes.org>

From: Joerg Roedel <jroedel@suse.de>

With this macro any user can easily iterate over a list of
phandles. The patch also converts __of_parse_phandle_with_args()
to make use of the macro.

The of_count_phandle_with_args() function is not converted,
because the macro hides the return value of of_phandle_iterator_init(),
which is needed in there.

Signed-off-by: Joerg Roedel <jroedel@suse.de>
---
 drivers/of/base.c  | 7 +------
 include/linux/of.h | 6 ++++++
 2 files changed, 7 insertions(+), 6 deletions(-)

diff --git a/drivers/of/base.c b/drivers/of/base.c
index 15593cd..471d3d9 100644
--- a/drivers/of/base.c
+++ b/drivers/of/base.c
@@ -1542,13 +1542,8 @@ static int __of_parse_phandle_with_args(const struct device_node *np,
 	struct of_phandle_iterator it;
 	int rc, cur_index = 0;
 
-	rc = of_phandle_iterator_init(&it, np, list_name,
-				      cells_name, cell_count);
-	if (rc)
-		return rc;
-
 	/* Loop over the phandles until all the requested entry is found */
-	while ((rc = of_phandle_iterator_next(&it)) == 0) {
+	of_for_each_phandle(&it, rc, np, list_name, cells_name, cell_count) {
 		/*
 		 * All of the error cases bail out of the loop, so at
 		 * this point, the parsing is successful. If the requested
diff --git a/include/linux/of.h b/include/linux/of.h
index d94388b0..05e38ed 100644
--- a/include/linux/of.h
+++ b/include/linux/of.h
@@ -908,6 +908,12 @@ static inline int of_property_read_s32(const struct device_node *np,
 	return of_property_read_u32(np, propname, (u32*) out_value);
 }
 
+#define of_for_each_phandle(it, err, np, ln, cn, cc)			\
+	for (of_phandle_iterator_init((it), (np), (ln), (cn), (cc)),	\
+	     err = of_phandle_iterator_next(it);			\
+	     err == 0;							\
+	     err = of_phandle_iterator_next(it))
+
 #define of_property_for_each_u32(np, propname, prop, p, u)	\
 	for (prop = of_find_property(np, propname, NULL),	\
 		p = of_prop_next_u32(prop, NULL, &u);		\
-- 
1.9.1

  parent reply	other threads:[~2016-03-22 17:58 UTC|newest]

Thread overview: 62+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-03-22 17:58 [PATCH 0/6] of: Implement iterator for phandles Joerg Roedel
2016-03-22 17:58 ` Joerg Roedel
2016-03-22 17:58 ` Joerg Roedel
2016-03-22 17:58 ` [PATCH 1/6] of: Introduce struct of_phandle_iterator Joerg Roedel
2016-03-22 17:58   ` Joerg Roedel
2016-03-22 17:58   ` Joerg Roedel
2016-03-22 17:58 ` [PATCH 2/6] of: Move phandle walking to of_phandle_iterator_next() Joerg Roedel
2016-03-22 17:58   ` Joerg Roedel
2016-03-22 17:58   ` Joerg Roedel
2016-03-22 17:58 ` [PATCH 3/6] of: Remove counting special case from __of_parse_phandle_with_args() Joerg Roedel
2016-03-22 17:58   ` Joerg Roedel
2016-03-22 17:58   ` Joerg Roedel
2016-03-22 17:58 ` Joerg Roedel [this message]
2016-03-22 17:58   ` [PATCH 4/6] of: Introduce of_for_each_phandle() helper macro Joerg Roedel
2016-03-22 17:58   ` Joerg Roedel
2016-03-22 17:58 ` [PATCH 5/6] of: Introduce of_phandle_iterator_args() Joerg Roedel
2016-03-22 17:58   ` Joerg Roedel
2016-03-22 17:58   ` Joerg Roedel
2016-03-22 17:58 ` [PATCH 6/6] iommu/arm-smmu: Make use of phandle iterators in device-tree parsing Joerg Roedel
2016-03-22 17:58   ` Joerg Roedel
2016-03-22 17:58   ` Joerg Roedel
2016-03-22 18:38   ` Rob Herring
2016-03-22 18:38     ` Rob Herring
2016-03-22 18:38     ` Rob Herring
2016-03-23 11:47     ` [PATCH v2] iommu/arm-smmu: Make use of phandle iterators in device-tree " Joerg Roedel
2016-03-23 11:47       ` Joerg Roedel
2016-03-23 11:47       ` Joerg Roedel
2016-03-23 15:18       ` kbuild test robot
2016-03-23 15:18         ` kbuild test robot
2016-03-23 15:18         ` kbuild test robot
2016-04-04 14:25         ` Joerg Roedel
2016-04-04 14:25           ` Joerg Roedel
2016-04-04 14:25           ` Joerg Roedel
2016-03-22 18:53   ` [PATCH 6/6] iommu/arm-smmu: Make use of phandle iterators in " Robin Murphy
2016-03-22 18:53     ` Robin Murphy
2016-03-22 18:53     ` Robin Murphy
2016-03-23 11:51     ` Joerg Roedel
2016-03-23 11:51       ` Joerg Roedel
2016-03-23 11:51       ` Joerg Roedel
2016-03-29 17:20       ` Will Deacon
2016-03-29 17:20         ` Will Deacon
2016-03-29 17:20         ` Will Deacon
2016-03-29 17:22   ` Will Deacon
2016-03-29 17:22     ` Will Deacon
2016-03-29 17:22     ` Will Deacon
2016-04-04 14:24     ` Joerg Roedel
2016-04-04 14:24       ` Joerg Roedel
2016-03-22 18:45 ` [PATCH 0/6] of: Implement iterator for phandles Rob Herring
2016-03-22 18:45   ` Rob Herring
2016-03-22 18:45   ` Rob Herring
2016-03-23 11:54   ` Joerg Roedel
2016-03-23 11:54     ` Joerg Roedel
2016-03-23 11:54     ` Joerg Roedel
2016-03-23 20:37     ` Rob Herring
2016-03-23 20:37       ` Rob Herring
2016-03-23 20:37       ` Rob Herring
2016-04-04 15:47       ` Joerg Roedel
2016-04-04 15:47         ` Joerg Roedel
2016-04-04 15:47         ` Joerg Roedel
2016-04-04 15:49 [PATCH 0/6 v2] " Joerg Roedel
2016-04-04 15:49 ` [PATCH 4/6] of: Introduce of_for_each_phandle() helper macro Joerg Roedel
2016-04-04 15:49   ` Joerg Roedel
2016-04-04 15:49   ` Joerg Roedel

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1458669509-7178-5-git-send-email-joro@8bytes.org \
    --to=joro@8bytes.org \
    --cc=devicetree@vger.kernel.org \
    --cc=grant.likely@linaro.org \
    --cc=iommu@lists.linux-foundation.org \
    --cc=jroedel@suse.de \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=robh+dt@kernel.org \
    --cc=will.deacon@arm.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.