* [PATCH 1/8] phy: Fix phy-hi6220-usb dependencies
@ 2016-03-25 22:40 Richard Weinberger
2016-03-25 22:40 ` [PATCH 2/8] mailbox: Fix rockchip dependencies Richard Weinberger
` (8 more replies)
0 siblings, 9 replies; 14+ messages in thread
From: Richard Weinberger @ 2016-03-25 22:40 UTC (permalink / raw)
To: linux-kernel
Cc: linux-iio, Richard Weinberger, Kishon Vijay Abraham I,
Geert Uytterhoeven
This driver needs io memory.
Fixes the following Kconfig warning:
warning: (ST_IRQCHIP && STMMAC_PLATFORM && DWMAC_IPQ806X && DWMAC_LPC18XX && DWMAC_ROCKCHIP && DWMAC_SOCFPGA && DWMAC_STI && TI_CPSW && PINCTRL_ROCKCHIP && PINCTRL_DOVE && POWER_RESET_KEYSTONE && S3C2410_WATCHDOG && VIDEO_OMAP3 && VIDEO_S5P_FIMC && USB_XHCI_MTK && RTC_DRV_AT91SAM9 && LPC18XX_DMAMUX && VIDEO_OMAP4 && HWSPINLOCK_QCOM && ATMEL_ST && QCOM_GSBI && PHY_HI6220_USB) selects MFD_SYSCON which has unmet direct dependencies (HAS_IOMEM)
And this build error:
drivers/mfd/syscon.c: In function ‘of_syscon_register’:
drivers/mfd/syscon.c:67:2: error: implicit declaration of function ‘ioremap’ [-Werror=implicit-function-declaration]
base = ioremap(res.start, resource_size(&res));
^
drivers/mfd/syscon.c:67:7: warning: assignment makes pointer from integer without a cast [enabled by default]
base = ioremap(res.start, resource_size(&res));
^
drivers/mfd/syscon.c:109:2: error: implicit declaration of function ‘iounmap’ [-Werror=implicit-function-declaration]
iounmap(base);
Cc: Kishon Vijay Abraham I <kishon@ti.com>
Cc: Geert Uytterhoeven <geert@linux-m68k.org>
Fixes: d896910f3 ("phy: Restrict phy-hi6220-usb to HiSilicon arm64")
Signed-off-by: Richard Weinberger <richard@nod.at>
---
drivers/phy/Kconfig | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/phy/Kconfig b/drivers/phy/Kconfig
index 26566db..78d2981 100644
--- a/drivers/phy/Kconfig
+++ b/drivers/phy/Kconfig
@@ -224,6 +224,7 @@ config PHY_MT65XX_USB3
config PHY_HI6220_USB
tristate "hi6220 USB PHY support"
+ depends on HAS_IOMEM
depends on (ARCH_HISI && ARM64) || COMPILE_TEST
select GENERIC_PHY
select MFD_SYSCON
--
1.8.4.5
^ permalink raw reply related [flat|nested] 14+ messages in thread
* [PATCH 2/8] mailbox: Fix rockchip dependencies
2016-03-25 22:40 [PATCH 1/8] phy: Fix phy-hi6220-usb dependencies Richard Weinberger
@ 2016-03-25 22:40 ` Richard Weinberger
2016-03-25 22:40 ` [PATCH 3/8] phy: Fix phy-omap-control dependencies Richard Weinberger
` (7 subsequent siblings)
8 siblings, 0 replies; 14+ messages in thread
From: Richard Weinberger @ 2016-03-25 22:40 UTC (permalink / raw)
To: linux-kernel; +Cc: linux-iio, Richard Weinberger, Jassi Brar
This driver needs io memory but not all archs offer it.
Fixes the following build error:
drivers/built-in.o: In function `rockchip_mbox_probe':
rockchip-mailbox.c:(.text+0x4b19c): undefined reference to `devm_ioremap_resource'
Cc: Jassi Brar <jassisinghbrar@gmail.com>
Signed-off-by: Richard Weinberger <richard@nod.at>
---
drivers/mailbox/Kconfig | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/mailbox/Kconfig b/drivers/mailbox/Kconfig
index 5305923..5ee207c 100644
--- a/drivers/mailbox/Kconfig
+++ b/drivers/mailbox/Kconfig
@@ -45,6 +45,7 @@ config OMAP_MBOX_KFIFO_SIZE
config ROCKCHIP_MBOX
bool "Rockchip Soc Intergrated Mailbox Support"
+ depends on HAS_IOMEM
depends on ARCH_ROCKCHIP || COMPILE_TEST
help
This driver provides support for inter-processor communication
--
1.8.4.5
^ permalink raw reply related [flat|nested] 14+ messages in thread
* [PATCH 3/8] phy: Fix phy-omap-control dependencies
2016-03-25 22:40 [PATCH 1/8] phy: Fix phy-hi6220-usb dependencies Richard Weinberger
2016-03-25 22:40 ` [PATCH 2/8] mailbox: Fix rockchip dependencies Richard Weinberger
@ 2016-03-25 22:40 ` Richard Weinberger
2016-03-25 22:40 ` [PATCH 4/8] phy: Fix phy-bcm-cygnus-pcie dependencies Richard Weinberger
` (6 subsequent siblings)
8 siblings, 0 replies; 14+ messages in thread
From: Richard Weinberger @ 2016-03-25 22:40 UTC (permalink / raw)
To: linux-kernel; +Cc: linux-iio, Richard Weinberger, Kishon Vijay Abraham I
Not all archs have io memory.
Fixes the following build error:
ERROR: "devm_ioremap_resource" [drivers/phy/phy-omap-control.ko] undefined!
Cc: Kishon Vijay Abraham I <kishon@ti.com>
Signed-off-by: Richard Weinberger <richard@nod.at>
---
drivers/phy/Kconfig | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/phy/Kconfig b/drivers/phy/Kconfig
index 78d2981..7856e7d 100644
--- a/drivers/phy/Kconfig
+++ b/drivers/phy/Kconfig
@@ -127,6 +127,7 @@ config PHY_RCAR_GEN3_USB2
config OMAP_CONTROL_PHY
tristate "OMAP CONTROL PHY Driver"
+ depends on HAS_IOMEM
depends on ARCH_OMAP2PLUS || COMPILE_TEST
help
Enable this to add support for the PHY part present in the control
--
1.8.4.5
^ permalink raw reply related [flat|nested] 14+ messages in thread
* [PATCH 4/8] phy: Fix phy-bcm-cygnus-pcie dependencies
2016-03-25 22:40 [PATCH 1/8] phy: Fix phy-hi6220-usb dependencies Richard Weinberger
2016-03-25 22:40 ` [PATCH 2/8] mailbox: Fix rockchip dependencies Richard Weinberger
2016-03-25 22:40 ` [PATCH 3/8] phy: Fix phy-omap-control dependencies Richard Weinberger
@ 2016-03-25 22:40 ` Richard Weinberger
2016-03-25 22:40 ` [PATCH 5/8] nvmem: Fix io memory dependencies Richard Weinberger
` (5 subsequent siblings)
8 siblings, 0 replies; 14+ messages in thread
From: Richard Weinberger @ 2016-03-25 22:40 UTC (permalink / raw)
To: linux-kernel; +Cc: linux-iio, Richard Weinberger, Kishon Vijay Abraham I
Not all archs have io memory.
Fixes the following build error:
ERROR: "devm_ioremap_resource" [drivers/phy/phy-bcm-cygnus-pcie.ko] undefined!
Cc: Kishon Vijay Abraham I <kishon@ti.com>
Signed-off-by: Richard Weinberger <richard@nod.at>
---
drivers/phy/Kconfig | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/phy/Kconfig b/drivers/phy/Kconfig
index 7856e7d..d209eb1 100644
--- a/drivers/phy/Kconfig
+++ b/drivers/phy/Kconfig
@@ -416,6 +416,7 @@ config PHY_BRCMSTB_SATA
config PHY_CYGNUS_PCIE
tristate "Broadcom Cygnus PCIe PHY driver"
+ depends on HAS_IOMEM
depends on OF && (ARCH_BCM_CYGNUS || COMPILE_TEST)
select GENERIC_PHY
default ARCH_BCM_CYGNUS
--
1.8.4.5
^ permalink raw reply related [flat|nested] 14+ messages in thread
* [PATCH 5/8] nvmem: Fix io memory dependencies
2016-03-25 22:40 [PATCH 1/8] phy: Fix phy-hi6220-usb dependencies Richard Weinberger
` (2 preceding siblings ...)
2016-03-25 22:40 ` [PATCH 4/8] phy: Fix phy-bcm-cygnus-pcie dependencies Richard Weinberger
@ 2016-03-25 22:40 ` Richard Weinberger
2016-03-30 8:50 ` Srinivas Kandagatla
2016-03-25 22:40 ` [PATCH 6/8] iio: adc: Fix at91-sama5d2_adc dependencies Richard Weinberger
` (4 subsequent siblings)
8 siblings, 1 reply; 14+ messages in thread
From: Richard Weinberger @ 2016-03-25 22:40 UTC (permalink / raw)
To: linux-kernel
Cc: linux-iio, Richard Weinberger, Srinivas Kandagatla, Maxime Ripard
Not all archs have io memory.
Fixes the following build error:
ERROR: "devm_ioremap_resource" [drivers/nvmem/nvmem_mtk-efuse.ko] undefined!
ERROR: "devm_ioremap_resource" [drivers/nvmem/nvmem_lpc18xx_eeprom.ko] undefined!
Cc: Srinivas Kandagatla <srinivas.kandagatla@linaro.org>
Cc: Maxime Ripard <maxime.ripard@free-electrons.com>
Signed-off-by: Richard Weinberger <richard@nod.at>
---
drivers/nvmem/Kconfig | 2 ++
1 file changed, 2 insertions(+)
diff --git a/drivers/nvmem/Kconfig b/drivers/nvmem/Kconfig
index ca52952..3766da3 100644
--- a/drivers/nvmem/Kconfig
+++ b/drivers/nvmem/Kconfig
@@ -27,6 +27,7 @@ config NVMEM_IMX_OCOTP
config NVMEM_LPC18XX_EEPROM
tristate "NXP LPC18XX EEPROM Memory Support"
+ depends on HAS_IOMEM
depends on ARCH_LPC18XX || COMPILE_TEST
help
Say Y here to include support for NXP LPC18xx EEPROM memory found in
@@ -48,6 +49,7 @@ config NVMEM_MXS_OCOTP
config MTK_EFUSE
tristate "Mediatek SoCs EFUSE support"
+ depends on HAS_IOMEM
depends on ARCH_MEDIATEK || COMPILE_TEST
select REGMAP_MMIO
help
--
1.8.4.5
^ permalink raw reply related [flat|nested] 14+ messages in thread
* [PATCH 6/8] iio: adc: Fix at91-sama5d2_adc dependencies
2016-03-25 22:40 [PATCH 1/8] phy: Fix phy-hi6220-usb dependencies Richard Weinberger
` (3 preceding siblings ...)
2016-03-25 22:40 ` [PATCH 5/8] nvmem: Fix io memory dependencies Richard Weinberger
@ 2016-03-25 22:40 ` Richard Weinberger
2016-03-28 8:44 ` Jonathan Cameron
2016-03-25 22:40 ` [PATCH 7/8] fpga: Fix zynq-fpga dependencies Richard Weinberger
` (3 subsequent siblings)
8 siblings, 1 reply; 14+ messages in thread
From: Richard Weinberger @ 2016-03-25 22:40 UTC (permalink / raw)
To: linux-kernel
Cc: linux-iio, Richard Weinberger, Jonathan Cameron, Hartmut Knaack,
Lars-Peter Clausen, Peter Meerwald, Ludovic Desroches
Not all archs have io memory.
Fixes the following build error:
ERROR: "devm_ioremap_resource" [drivers/iio/adc/at91-sama5d2_adc.ko] undefined!
Cc: Jonathan Cameron <jic23@kernel.org>
Cc: Hartmut Knaack <knaack.h@gmx.de>
Cc: Lars-Peter Clausen <lars@metafoo.de>
Cc: Peter Meerwald <pmeerw@pmeerw.net>
Cc: Ludovic Desroches <ludovic.desroches@atmel.com>
Fixes: b9cd7a25 ("MAINTAINERS: add entry for Atmel SAMA5D2 ADC driver")
Signed-off-by: Richard Weinberger <richard@nod.at>
---
drivers/iio/adc/Kconfig | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/iio/adc/Kconfig b/drivers/iio/adc/Kconfig
index af4aea7..31fa2e7 100644
--- a/drivers/iio/adc/Kconfig
+++ b/drivers/iio/adc/Kconfig
@@ -133,6 +133,7 @@ config AT91_ADC
config AT91_SAMA5D2_ADC
tristate "Atmel AT91 SAMA5D2 ADC"
+ depends on HAS_IOMEM
depends on ARCH_AT91 || COMPILE_TEST
help
Say yes here to build support for Atmel SAMA5D2 ADC which is
--
1.8.4.5
^ permalink raw reply related [flat|nested] 14+ messages in thread
* [PATCH 7/8] fpga: Fix zynq-fpga dependencies
2016-03-25 22:40 [PATCH 1/8] phy: Fix phy-hi6220-usb dependencies Richard Weinberger
` (4 preceding siblings ...)
2016-03-25 22:40 ` [PATCH 6/8] iio: adc: Fix at91-sama5d2_adc dependencies Richard Weinberger
@ 2016-03-25 22:40 ` Richard Weinberger
2016-03-25 22:40 ` [PATCH 8/8] iio: imu: Fix inv_mpu6050 dependencies Richard Weinberger
` (2 subsequent siblings)
8 siblings, 0 replies; 14+ messages in thread
From: Richard Weinberger @ 2016-03-25 22:40 UTC (permalink / raw)
To: linux-kernel; +Cc: linux-iio, Richard Weinberger, Alan Tull, Moritz Fischer
Not all archs have DMA.
Fixes the following build error:
ERROR: "devm_ioremap_resource" [drivers/fpga/zynq-fpga.ko] undefined!
Cc: Alan Tull <atull@opensource.altera.com>
Cc: Moritz Fischer <moritz.fischer@ettus.com>
Signed-off-by: Richard Weinberger <richard@nod.at>
---
drivers/fpga/Kconfig | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/fpga/Kconfig b/drivers/fpga/Kconfig
index c9b9fdf..490ecf0 100644
--- a/drivers/fpga/Kconfig
+++ b/drivers/fpga/Kconfig
@@ -20,6 +20,7 @@ config FPGA_MGR_SOCFPGA
FPGA manager driver support for Altera SOCFPGA.
config FPGA_MGR_ZYNQ_FPGA
+ depends on HAS_DMA
tristate "Xilinx Zynq FPGA"
help
FPGA manager driver support for Xilinx Zynq FPGAs.
--
1.8.4.5
^ permalink raw reply related [flat|nested] 14+ messages in thread
* [PATCH 8/8] iio: imu: Fix inv_mpu6050 dependencies
2016-03-25 22:40 [PATCH 1/8] phy: Fix phy-hi6220-usb dependencies Richard Weinberger
` (5 preceding siblings ...)
2016-03-25 22:40 ` [PATCH 7/8] fpga: Fix zynq-fpga dependencies Richard Weinberger
@ 2016-03-25 22:40 ` Richard Weinberger
2016-03-28 9:03 ` Jonathan Cameron
2016-03-26 9:05 ` [PATCH 1/8] phy: Fix phy-hi6220-usb dependencies Geert Uytterhoeven
2016-03-30 4:15 ` Krzysztof Kozlowski
8 siblings, 1 reply; 14+ messages in thread
From: Richard Weinberger @ 2016-03-25 22:40 UTC (permalink / raw)
To: linux-kernel
Cc: linux-iio, Richard Weinberger, Jonathan Cameron, Hartmut Knaack,
Lars-Peter Clausen, Peter Meerwald
Not all archs have io memory.
Instead of selecting I2C_MUX (and bypassing the HAS_IOMEM dependency)
depend directly on it.
Fixes the following kconfig warning:
warning: (MEDIA_SUBDRV_AUTOSELECT && VIDEO_CX231XX && INV_MPU6050_I2C) selects I2C_MUX which has unmet direct dependencies (I2C && HAS_IOMEM)
And this build error:
ERROR: "devm_ioremap_resource" [drivers/i2c/muxes/i2c-mux-reg.ko] undefined!
ERROR: "of_address_to_resource" [drivers/i2c/muxes/i2c-mux-reg.ko] undefined!
Cc: Jonathan Cameron <jic23@kernel.org>
Cc: Hartmut Knaack <knaack.h@gmx.de>
Cc: Lars-Peter Clausen <lars@metafoo.de>
Cc: Peter Meerwald <pmeerw@pmeerw.net>
Signed-off-by: Richard Weinberger <richard@nod.at>
---
drivers/iio/imu/inv_mpu6050/Kconfig | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/drivers/iio/imu/inv_mpu6050/Kconfig b/drivers/iio/imu/inv_mpu6050/Kconfig
index a7f557a..847455a 100644
--- a/drivers/iio/imu/inv_mpu6050/Kconfig
+++ b/drivers/iio/imu/inv_mpu6050/Kconfig
@@ -9,9 +9,8 @@ config INV_MPU6050_IIO
config INV_MPU6050_I2C
tristate "Invensense MPU6050 devices (I2C)"
- depends on I2C
+ depends on I2C_MUX
select INV_MPU6050_IIO
- select I2C_MUX
select REGMAP_I2C
help
This driver supports the Invensense MPU6050 devices.
--
1.8.4.5
^ permalink raw reply related [flat|nested] 14+ messages in thread
* Re: [PATCH 1/8] phy: Fix phy-hi6220-usb dependencies
2016-03-25 22:40 [PATCH 1/8] phy: Fix phy-hi6220-usb dependencies Richard Weinberger
` (6 preceding siblings ...)
2016-03-25 22:40 ` [PATCH 8/8] iio: imu: Fix inv_mpu6050 dependencies Richard Weinberger
@ 2016-03-26 9:05 ` Geert Uytterhoeven
2016-03-26 9:27 ` Richard Weinberger
2016-03-30 4:15 ` Krzysztof Kozlowski
8 siblings, 1 reply; 14+ messages in thread
From: Geert Uytterhoeven @ 2016-03-26 9:05 UTC (permalink / raw)
To: Richard Weinberger; +Cc: linux-kernel, linux-iio, Kishon Vijay Abraham I
Hi Richard,
On Fri, Mar 25, 2016 at 11:40 PM, Richard Weinberger <richard@nod.at> wrote:
> This driver needs io memory.
>
> Fixes the following Kconfig warning:
> warning: (ST_IRQCHIP && STMMAC_PLATFORM && DWMAC_IPQ806X && DWMAC_LPC18XX && DWMAC_ROCKCHIP && DWMAC_SOCFPGA && DWMAC_STI && TI_CPSW && PINCTRL_ROCKCHIP && PINCTRL_DOVE && POWER_RESET_KEYSTONE && S3C2410_WATCHDOG && VIDEO_OMAP3 && VIDEO_S5P_FIMC && USB_XHCI_MTK && RTC_DRV_AT91SAM9 && LPC18XX_DMAMUX && VIDEO_OMAP4 && HWSPINLOCK_QCOM && ATMEL_ST && QCOM_GSBI && PHY_HI6220_USB) selects MFD_SYSCON which has unmet direct dependencies (HAS_IOMEM)
>
> And this build error:
> drivers/mfd/syscon.c: In function ‘of_syscon_register’:
> drivers/mfd/syscon.c:67:2: error: implicit declaration of function ‘ioremap’ [-Werror=implicit-function-declaration]
> base = ioremap(res.start, resource_size(&res));
> ^
> drivers/mfd/syscon.c:67:7: warning: assignment makes pointer from integer without a cast [enabled by default]
> base = ioremap(res.start, resource_size(&res));
> ^
> drivers/mfd/syscon.c:109:2: error: implicit declaration of function ‘iounmap’ [-Werror=implicit-function-declaration]
> iounmap(base);
>
> Cc: Kishon Vijay Abraham I <kishon@ti.com>
> Cc: Geert Uytterhoeven <geert@linux-m68k.org>
> Fixes: d896910f3 ("phy: Restrict phy-hi6220-usb to HiSilicon arm64")
I don't think that commit is the root cause ;-)
Before there were no dependencies at all...
Fixes: 30e9a0b2147c8405 ("phy: add phy-hi6220-usb")
> Signed-off-by: Richard Weinberger <richard@nod.at>
With the above fixed:
Acked-by: Geert Uytterhoeven <geert@linux-m68k.org>
Gr{oetje,eeting}s,
Geert
--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org
In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds
^ permalink raw reply [flat|nested] 14+ messages in thread
* Re: [PATCH 1/8] phy: Fix phy-hi6220-usb dependencies
2016-03-26 9:05 ` [PATCH 1/8] phy: Fix phy-hi6220-usb dependencies Geert Uytterhoeven
@ 2016-03-26 9:27 ` Richard Weinberger
0 siblings, 0 replies; 14+ messages in thread
From: Richard Weinberger @ 2016-03-26 9:27 UTC (permalink / raw)
To: Geert Uytterhoeven; +Cc: linux-kernel, linux-iio, Kishon Vijay Abraham I
Am 26.03.2016 um 10:05 schrieb Geert Uytterhoeven:
> Hi Richard,
>
> On Fri, Mar 25, 2016 at 11:40 PM, Richard Weinberger <richard@nod.at> wrote:
>> This driver needs io memory.
>>
>> Fixes the following Kconfig warning:
>> warning: (ST_IRQCHIP && STMMAC_PLATFORM && DWMAC_IPQ806X && DWMAC_LPC18XX && DWMAC_ROCKCHIP && DWMAC_SOCFPGA && DWMAC_STI && TI_CPSW && PINCTRL_ROCKCHIP && PINCTRL_DOVE && POWER_RESET_KEYSTONE && S3C2410_WATCHDOG && VIDEO_OMAP3 && VIDEO_S5P_FIMC && USB_XHCI_MTK && RTC_DRV_AT91SAM9 && LPC18XX_DMAMUX && VIDEO_OMAP4 && HWSPINLOCK_QCOM && ATMEL_ST && QCOM_GSBI && PHY_HI6220_USB) selects MFD_SYSCON which has unmet direct dependencies (HAS_IOMEM)
>>
>> And this build error:
>> drivers/mfd/syscon.c: In function ‘of_syscon_register’:
>> drivers/mfd/syscon.c:67:2: error: implicit declaration of function ‘ioremap’ [-Werror=implicit-function-declaration]
>> base = ioremap(res.start, resource_size(&res));
>> ^
>> drivers/mfd/syscon.c:67:7: warning: assignment makes pointer from integer without a cast [enabled by default]
>> base = ioremap(res.start, resource_size(&res));
>> ^
>> drivers/mfd/syscon.c:109:2: error: implicit declaration of function ‘iounmap’ [-Werror=implicit-function-declaration]
>> iounmap(base);
>>
>> Cc: Kishon Vijay Abraham I <kishon@ti.com>
>> Cc: Geert Uytterhoeven <geert@linux-m68k.org>
>> Fixes: d896910f3 ("phy: Restrict phy-hi6220-usb to HiSilicon arm64")
>
> I don't think that commit is the root cause ;-)
> Before there were no dependencies at all...
Fair point. :-)
> Fixes: 30e9a0b2147c8405 ("phy: add phy-hi6220-usb")
>
>> Signed-off-by: Richard Weinberger <richard@nod.at>
>
> With the above fixed:
> Acked-by: Geert Uytterhoeven <geert@linux-m68k.org>
Thanks,
//richard
^ permalink raw reply [flat|nested] 14+ messages in thread
* Re: [PATCH 6/8] iio: adc: Fix at91-sama5d2_adc dependencies
2016-03-25 22:40 ` [PATCH 6/8] iio: adc: Fix at91-sama5d2_adc dependencies Richard Weinberger
@ 2016-03-28 8:44 ` Jonathan Cameron
0 siblings, 0 replies; 14+ messages in thread
From: Jonathan Cameron @ 2016-03-28 8:44 UTC (permalink / raw)
To: Richard Weinberger, linux-kernel
Cc: linux-iio, Hartmut Knaack, Lars-Peter Clausen, Peter Meerwald,
Ludovic Desroches
On 25/03/16 22:40, Richard Weinberger wrote:
> Not all archs have io memory.
>
> Fixes the following build error:
> ERROR: "devm_ioremap_resource" [drivers/iio/adc/at91-sama5d2_adc.ko] undefined!
>
> Cc: Jonathan Cameron <jic23@kernel.org>
> Cc: Hartmut Knaack <knaack.h@gmx.de>
> Cc: Lars-Peter Clausen <lars@metafoo.de>
> Cc: Peter Meerwald <pmeerw@pmeerw.net>
> Cc: Ludovic Desroches <ludovic.desroches@atmel.com>
> Fixes: b9cd7a25 ("MAINTAINERS: add entry for Atmel SAMA5D2 ADC driver")
> Signed-off-by: Richard Weinberger <richard@nod.at>
Hi Richard,
I already have a patch queued up covering this, it just hit at exactly the wrong
moment compared to the merge window so hasn't made it upstream yet.
Thanks,
Jonathan
> ---
> drivers/iio/adc/Kconfig | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/iio/adc/Kconfig b/drivers/iio/adc/Kconfig
> index af4aea7..31fa2e7 100644
> --- a/drivers/iio/adc/Kconfig
> +++ b/drivers/iio/adc/Kconfig
> @@ -133,6 +133,7 @@ config AT91_ADC
>
> config AT91_SAMA5D2_ADC
> tristate "Atmel AT91 SAMA5D2 ADC"
> + depends on HAS_IOMEM
> depends on ARCH_AT91 || COMPILE_TEST
> help
> Say yes here to build support for Atmel SAMA5D2 ADC which is
>
^ permalink raw reply [flat|nested] 14+ messages in thread
* Re: [PATCH 8/8] iio: imu: Fix inv_mpu6050 dependencies
2016-03-25 22:40 ` [PATCH 8/8] iio: imu: Fix inv_mpu6050 dependencies Richard Weinberger
@ 2016-03-28 9:03 ` Jonathan Cameron
0 siblings, 0 replies; 14+ messages in thread
From: Jonathan Cameron @ 2016-03-28 9:03 UTC (permalink / raw)
To: Richard Weinberger, linux-kernel
Cc: linux-iio, Hartmut Knaack, Lars-Peter Clausen, Peter Meerwald
On 25/03/16 22:40, Richard Weinberger wrote:
> Not all archs have io memory.
> Instead of selecting I2C_MUX (and bypassing the HAS_IOMEM dependency)
> depend directly on it.
>
> Fixes the following kconfig warning:
> warning: (MEDIA_SUBDRV_AUTOSELECT && VIDEO_CX231XX && INV_MPU6050_I2C) selects I2C_MUX which has unmet direct dependencies (I2C && HAS_IOMEM)
> And this build error:
> ERROR: "devm_ioremap_resource" [drivers/i2c/muxes/i2c-mux-reg.ko] undefined!
> ERROR: "of_address_to_resource" [drivers/i2c/muxes/i2c-mux-reg.ko] undefined!
>
> Cc: Jonathan Cameron <jic23@kernel.org>
> Cc: Hartmut Knaack <knaack.h@gmx.de>
> Cc: Lars-Peter Clausen <lars@metafoo.de>
> Cc: Peter Meerwald <pmeerw@pmeerw.net>
> Signed-off-by: Richard Weinberger <richard@nod.at>
Applied to the fixes-togreg-post-rc1 branch of iio.git.
Thanks,
Jonathan
> ---
> drivers/iio/imu/inv_mpu6050/Kconfig | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/drivers/iio/imu/inv_mpu6050/Kconfig b/drivers/iio/imu/inv_mpu6050/Kconfig
> index a7f557a..847455a 100644
> --- a/drivers/iio/imu/inv_mpu6050/Kconfig
> +++ b/drivers/iio/imu/inv_mpu6050/Kconfig
> @@ -9,9 +9,8 @@ config INV_MPU6050_IIO
>
> config INV_MPU6050_I2C
> tristate "Invensense MPU6050 devices (I2C)"
> - depends on I2C
> + depends on I2C_MUX
> select INV_MPU6050_IIO
> - select I2C_MUX
> select REGMAP_I2C
> help
> This driver supports the Invensense MPU6050 devices.
>
^ permalink raw reply [flat|nested] 14+ messages in thread
* Re: [PATCH 1/8] phy: Fix phy-hi6220-usb dependencies
2016-03-25 22:40 [PATCH 1/8] phy: Fix phy-hi6220-usb dependencies Richard Weinberger
` (7 preceding siblings ...)
2016-03-26 9:05 ` [PATCH 1/8] phy: Fix phy-hi6220-usb dependencies Geert Uytterhoeven
@ 2016-03-30 4:15 ` Krzysztof Kozlowski
8 siblings, 0 replies; 14+ messages in thread
From: Krzysztof Kozlowski @ 2016-03-30 4:15 UTC (permalink / raw)
To: Richard Weinberger
Cc: linux-kernel, linux-iio, Kishon Vijay Abraham I, Geert Uytterhoeven
On Sat, Mar 26, 2016 at 7:40 AM, Richard Weinberger <richard@nod.at> wrote:
> This driver needs io memory.
>
> Fixes the following Kconfig warning:
> warning: (ST_IRQCHIP && STMMAC_PLATFORM && DWMAC_IPQ806X && DWMAC_LPC18XX && DWMAC_ROCKCHIP && DWMAC_SOCFPGA && DWMAC_STI && TI_CPSW && PINCTRL_ROCKCHIP && PINCTRL_DOVE && POWER_RESET_KEYSTONE && S3C2410_WATCHDOG && VIDEO_OMAP3 && VIDEO_S5P_FIMC && USB_XHCI_MTK && RTC_DRV_AT91SAM9 && LPC18XX_DMAMUX && VIDEO_OMAP4 && HWSPINLOCK_QCOM && ATMEL_ST && QCOM_GSBI && PHY_HI6220_USB) selects MFD_SYSCON which has unmet direct dependencies (HAS_IOMEM)
>
> And this build error:
> drivers/mfd/syscon.c: In function ‘of_syscon_register’:
> drivers/mfd/syscon.c:67:2: error: implicit declaration of function ‘ioremap’ [-Werror=implicit-function-declaration]
> base = ioremap(res.start, resource_size(&res));
> ^
> drivers/mfd/syscon.c:67:7: warning: assignment makes pointer from integer without a cast [enabled by default]
> base = ioremap(res.start, resource_size(&res));
> ^
> drivers/mfd/syscon.c:109:2: error: implicit declaration of function ‘iounmap’ [-Werror=implicit-function-declaration]
> iounmap(base);
>
> Cc: Kishon Vijay Abraham I <kishon@ti.com>
> Cc: Geert Uytterhoeven <geert@linux-m68k.org>
> Fixes: d896910f3 ("phy: Restrict phy-hi6220-usb to HiSilicon arm64")
> Signed-off-by: Richard Weinberger <richard@nod.at>
Waiting with this from 3rd March...
https://www.spinics.net/lists/linux-usb/msg137114.html
(and resent on 15th https://lkml.org/lkml/2016/3/16/408)
...but indeed recent Rob's work is a better solution.
BR,
Krzysztof
^ permalink raw reply [flat|nested] 14+ messages in thread
* Re: [PATCH 5/8] nvmem: Fix io memory dependencies
2016-03-25 22:40 ` [PATCH 5/8] nvmem: Fix io memory dependencies Richard Weinberger
@ 2016-03-30 8:50 ` Srinivas Kandagatla
0 siblings, 0 replies; 14+ messages in thread
From: Srinivas Kandagatla @ 2016-03-30 8:50 UTC (permalink / raw)
To: Richard Weinberger, linux-kernel; +Cc: linux-iio, Maxime Ripard
Thanks for the patch,
But there is already a same patch [1] submitted few days back.
I will pick that one.
Thanks,
srini
[1] http://lkml.iu.edu/hypermail/linux/kernel/1603.0/03538.html
On 25/03/16 22:40, Richard Weinberger wrote:
> Not all archs have io memory.
>
> Fixes the following build error:
> ERROR: "devm_ioremap_resource" [drivers/nvmem/nvmem_mtk-efuse.ko] undefined!
> ERROR: "devm_ioremap_resource" [drivers/nvmem/nvmem_lpc18xx_eeprom.ko] undefined!
>
> Cc: Srinivas Kandagatla <srinivas.kandagatla@linaro.org>
> Cc: Maxime Ripard <maxime.ripard@free-electrons.com>
> Signed-off-by: Richard Weinberger <richard@nod.at>
> ---
> drivers/nvmem/Kconfig | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/drivers/nvmem/Kconfig b/drivers/nvmem/Kconfig
> index ca52952..3766da3 100644
> --- a/drivers/nvmem/Kconfig
> +++ b/drivers/nvmem/Kconfig
> @@ -27,6 +27,7 @@ config NVMEM_IMX_OCOTP
>
> config NVMEM_LPC18XX_EEPROM
> tristate "NXP LPC18XX EEPROM Memory Support"
> + depends on HAS_IOMEM
> depends on ARCH_LPC18XX || COMPILE_TEST
> help
> Say Y here to include support for NXP LPC18xx EEPROM memory found in
> @@ -48,6 +49,7 @@ config NVMEM_MXS_OCOTP
>
> config MTK_EFUSE
> tristate "Mediatek SoCs EFUSE support"
> + depends on HAS_IOMEM
> depends on ARCH_MEDIATEK || COMPILE_TEST
> select REGMAP_MMIO
> help
>
^ permalink raw reply [flat|nested] 14+ messages in thread
end of thread, other threads:[~2016-03-30 8:50 UTC | newest]
Thread overview: 14+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2016-03-25 22:40 [PATCH 1/8] phy: Fix phy-hi6220-usb dependencies Richard Weinberger
2016-03-25 22:40 ` [PATCH 2/8] mailbox: Fix rockchip dependencies Richard Weinberger
2016-03-25 22:40 ` [PATCH 3/8] phy: Fix phy-omap-control dependencies Richard Weinberger
2016-03-25 22:40 ` [PATCH 4/8] phy: Fix phy-bcm-cygnus-pcie dependencies Richard Weinberger
2016-03-25 22:40 ` [PATCH 5/8] nvmem: Fix io memory dependencies Richard Weinberger
2016-03-30 8:50 ` Srinivas Kandagatla
2016-03-25 22:40 ` [PATCH 6/8] iio: adc: Fix at91-sama5d2_adc dependencies Richard Weinberger
2016-03-28 8:44 ` Jonathan Cameron
2016-03-25 22:40 ` [PATCH 7/8] fpga: Fix zynq-fpga dependencies Richard Weinberger
2016-03-25 22:40 ` [PATCH 8/8] iio: imu: Fix inv_mpu6050 dependencies Richard Weinberger
2016-03-28 9:03 ` Jonathan Cameron
2016-03-26 9:05 ` [PATCH 1/8] phy: Fix phy-hi6220-usb dependencies Geert Uytterhoeven
2016-03-26 9:27 ` Richard Weinberger
2016-03-30 4:15 ` Krzysztof Kozlowski
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.