* [U-Boot] [PATCH] common: env_sf: Add exclamation mark
@ 2016-03-28 9:26 Peng Fan
2016-03-28 14:00 ` Tom Rini
2016-04-02 1:59 ` [U-Boot] " Tom Rini
0 siblings, 2 replies; 3+ messages in thread
From: Peng Fan @ 2016-03-28 9:26 UTC (permalink / raw)
To: u-boot
Add exclamation mark to the errmsg, when error and set_default_env.
Signed-off-by: Peng Fan <van.freenix@gmail.com>
Cc: Mario Schuknecht <mario.schuknecht@dresearch-fe.de>
Cc: Vignesh R <vigneshr@ti.com>
Cc: Jagan Teki <jteki@openedev.com>
Cc: Ravi Babu <ravibabu@ti.com>
Cc: York Sun <york.sun@nxp.com>
Cc: Tom Rini <trini@konsulko.com>
---
common/env_sf.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/common/env_sf.c b/common/env_sf.c
index 892e6cb..273098c 100644
--- a/common/env_sf.c
+++ b/common/env_sf.c
@@ -225,7 +225,7 @@ void env_relocate_spec(void)
ret = env_import((char *)ep, 0);
if (!ret) {
error("Cannot import environment: errno = %d\n", errno);
- set_default_env("env_import failed");
+ set_default_env("!env_import failed");
}
err_read:
--
2.6.2
^ permalink raw reply related [flat|nested] 3+ messages in thread
* [U-Boot] [PATCH] common: env_sf: Add exclamation mark
2016-03-28 9:26 [U-Boot] [PATCH] common: env_sf: Add exclamation mark Peng Fan
@ 2016-03-28 14:00 ` Tom Rini
2016-04-02 1:59 ` [U-Boot] " Tom Rini
1 sibling, 0 replies; 3+ messages in thread
From: Tom Rini @ 2016-03-28 14:00 UTC (permalink / raw)
To: u-boot
On Mon, Mar 28, 2016 at 05:26:27PM +0800, Peng Fan wrote:
> Add exclamation mark to the errmsg, when error and set_default_env.
This is awkwardly worded. We aren't adding a literal ! to the errmsg
itself, we're adding that as a flag. I'll try and re-word this when
applying to be clearer.
>
> Signed-off-by: Peng Fan <van.freenix@gmail.com>
> Cc: Mario Schuknecht <mario.schuknecht@dresearch-fe.de>
> Cc: Vignesh R <vigneshr@ti.com>
> Cc: Jagan Teki <jteki@openedev.com>
> Cc: Ravi Babu <ravibabu@ti.com>
> Cc: York Sun <york.sun@nxp.com>
> Cc: Tom Rini <trini@konsulko.com>
Reviewed-by: Tom Rini <trini@konsulko.com>
--
Tom
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 836 bytes
Desc: Digital signature
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20160328/f12c0349/attachment.sig>
^ permalink raw reply [flat|nested] 3+ messages in thread
* [U-Boot] common: env_sf: Add exclamation mark
2016-03-28 9:26 [U-Boot] [PATCH] common: env_sf: Add exclamation mark Peng Fan
2016-03-28 14:00 ` Tom Rini
@ 2016-04-02 1:59 ` Tom Rini
1 sibling, 0 replies; 3+ messages in thread
From: Tom Rini @ 2016-04-02 1:59 UTC (permalink / raw)
To: u-boot
On Mon, Mar 28, 2016 at 05:26:27PM +0800, Peng Fan wrote:
> Add exclamation mark to the errmsg, when error and set_default_env.
>
> Signed-off-by: Peng Fan <van.freenix@gmail.com>
> Cc: Mario Schuknecht <mario.schuknecht@dresearch-fe.de>
> Cc: Vignesh R <vigneshr@ti.com>
> Cc: Jagan Teki <jteki@openedev.com>
> Cc: Ravi Babu <ravibabu@ti.com>
> Cc: York Sun <york.sun@nxp.com>
> Cc: Tom Rini <trini@konsulko.com>
> Reviewed-by: Tom Rini <trini@konsulko.com>
Applied to u-boot/master, thanks!
--
Tom
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 836 bytes
Desc: Digital signature
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20160401/b76d39c6/attachment.sig>
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2016-04-02 1:59 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2016-03-28 9:26 [U-Boot] [PATCH] common: env_sf: Add exclamation mark Peng Fan
2016-03-28 14:00 ` Tom Rini
2016-04-02 1:59 ` [U-Boot] " Tom Rini
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.