From: Richard Purdie <richard.purdie@linuxfoundation.org>
To: Robert Yang <liezhi.yang@windriver.com>,
openembedded-core@lists.openembedded.org
Subject: Re: [PATCH 3/3] image-live.bbclass/image-vm.bbclass: remove duplicated code
Date: Tue, 29 Mar 2016 12:59:15 +0100 [thread overview]
Message-ID: <1459252755.21672.21.camel@linuxfoundation.org> (raw)
In-Reply-To: <3148e125ec883b341b1bbbc8bb3f8845bde01eb2.1459238263.git.liezhi.yang@windriver.com>
On Tue, 2016-03-29 at 00:59 -0700, Robert Yang wrote:
> Move the common code to image.bbclass and remove duplicated ones.
Whilst I do like the idea of this patch set, I don't like generic
functions called "populate", or adding EFI variables to image.bbclass
itself.
I believe that some refactoring does make a lot of sense here but this
doesn't look right. The diffstats don't seem to suggest a large volume
of common code either (as yet).
Cheers,
Richard
next prev parent reply other threads:[~2016-03-29 11:59 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-03-29 7:59 [PATCH 0/3] Remove bootimg.bbclass and boot-directdisk.bbclass Robert Yang
2016-03-29 7:59 ` [PATCH 1/3] boot-directdisk.bbclass: merge it into image-vm.bbclass Robert Yang
2016-03-29 7:59 ` [PATCH 2/3] bootimg.bbclass: merge it into image-live.bbclass Robert Yang
2016-03-29 7:59 ` [PATCH 3/3] image-live.bbclass/image-vm.bbclass: remove duplicated code Robert Yang
2016-03-29 11:59 ` Richard Purdie [this message]
2016-03-30 0:42 ` Robert Yang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1459252755.21672.21.camel@linuxfoundation.org \
--to=richard.purdie@linuxfoundation.org \
--cc=liezhi.yang@windriver.com \
--cc=openembedded-core@lists.openembedded.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.