* [PATCH] ASoC: wm8960: Add I2C dependency
@ 2016-03-30 19:23 Fabio Estevam
2016-03-30 21:06 ` Mark Brown
0 siblings, 1 reply; 2+ messages in thread
From: Fabio Estevam @ 2016-03-30 19:23 UTC (permalink / raw)
To: broonie; +Cc: Fabio Estevam, ckeepax, festevam, alsa-devel
Building wm8960 codec without I2C support causes build issues:
sound/soc/codecs/wm8960.c:1388:1: warning: data definition has no type or storage class
module_i2c_driver(wm8960_i2c_driver);
^
sound/soc/codecs/wm8960.c:1388:1: error: type defaults to 'int' in declaration of 'module_i2c_driver' [-Werror=implicit-int]
sound/soc/codecs/wm8960.c:1388:1: warning: parameter names (without types) in function declaration
sound/soc/codecs/wm8960.c:1378:26: warning: 'wm8960_i2c_driver' defined but not used [-Wunused-variable]
static struct i2c_driver wm8960_i2c_driver = {
, so add the I2C dependency to fix this problem.
Reported-by: kbuild test robot <fengguang.wu@intel.com>
Signed-off-by: Fabio Estevam <fabio.estevam@nxp.com>
---
sound/soc/codecs/Kconfig | 1 +
1 file changed, 1 insertion(+)
diff --git a/sound/soc/codecs/Kconfig b/sound/soc/codecs/Kconfig
index ba835b6..09e8c39 100644
--- a/sound/soc/codecs/Kconfig
+++ b/sound/soc/codecs/Kconfig
@@ -911,6 +911,7 @@ config SND_SOC_WM8955
config SND_SOC_WM8960
tristate "Wolfson Microelectronics WM8960 CODEC"
+ depends on I2C
config SND_SOC_WM8961
tristate
--
1.9.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] ASoC: wm8960: Add I2C dependency
2016-03-30 19:23 [PATCH] ASoC: wm8960: Add I2C dependency Fabio Estevam
@ 2016-03-30 21:06 ` Mark Brown
0 siblings, 0 replies; 2+ messages in thread
From: Mark Brown @ 2016-03-30 21:06 UTC (permalink / raw)
To: Fabio Estevam; +Cc: ckeepax, festevam, alsa-devel
[-- Attachment #1.1: Type: text/plain, Size: 151 bytes --]
On Wed, Mar 30, 2016 at 04:23:08PM -0300, Fabio Estevam wrote:
> Building wm8960 codec without I2C support causes build issues:
I already fixed this.
[-- Attachment #1.2: signature.asc --]
[-- Type: application/pgp-signature, Size: 473 bytes --]
[-- Attachment #2: Type: text/plain, Size: 0 bytes --]
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2016-03-30 21:06 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2016-03-30 19:23 [PATCH] ASoC: wm8960: Add I2C dependency Fabio Estevam
2016-03-30 21:06 ` Mark Brown
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.