All of lore.kernel.org
 help / color / mirror / Atom feed
From: Shannon Zhao <shannon.zhao@linaro.org>
To: linux-arm-kernel@lists.infradead.org, stefano.stabellini@citrix.com
Cc: david.vrabel@citrix.com, devicetree@vger.kernel.org,
	linux-efi@vger.kernel.org, linux-kernel@vger.kernel.org,
	catalin.marinas@arm.com, will.deacon@arm.com,
	julien.grall@arm.com, peter.huangpeng@huawei.com,
	xen-devel@lists.xen.org, zhaoshenglong@huawei.com,
	shannon.zhao@linaro.org, Russell King <linux@arm.linux.org.uk>
Subject: [PATCH v10 11/17] ARM: XEN: Move xen_early_init() before efi_init()
Date: Fri,  1 Apr 2016 23:49:09 +0800	[thread overview]
Message-ID: <1459525755-36968-12-git-send-email-shannon.zhao@linaro.org> (raw)
In-Reply-To: <1459525755-36968-1-git-send-email-shannon.zhao@linaro.org>

Move xen_early_init() before efi_init(), then when calling efi_init()
could initialize Xen specific UEFI.

Check if it runs on Xen hypervisor through the flat dts.

Cc: Russell King <linux@arm.linux.org.uk>
Signed-off-by: Shannon Zhao <shannon.zhao@linaro.org>
Reviewed-by: Stefano Stabellini <stefano.stabellini@eu.citrix.com>
---
 arch/arm/kernel/setup.c   |  2 +-
 arch/arm/xen/enlighten.c  | 56 ++++++++++++++++++++++++++++++++++-------------
 arch/arm64/kernel/setup.c |  2 +-
 3 files changed, 43 insertions(+), 17 deletions(-)

diff --git a/arch/arm/kernel/setup.c b/arch/arm/kernel/setup.c
index 139791e..5bc7516 100644
--- a/arch/arm/kernel/setup.c
+++ b/arch/arm/kernel/setup.c
@@ -1035,6 +1035,7 @@ void __init setup_arch(char **cmdline_p)
 	early_paging_init(mdesc);
 #endif
 	setup_dma_zone(mdesc);
+	xen_early_init();
 	efi_init();
 	sanity_check_meminfo();
 	arm_memblock_init(mdesc);
@@ -1051,7 +1052,6 @@ void __init setup_arch(char **cmdline_p)
 
 	arm_dt_init_cpu_maps();
 	psci_dt_init();
-	xen_early_init();
 #ifdef CONFIG_SMP
 	if (is_smp()) {
 		if (!mdesc->smp_init || !mdesc->smp_init()) {
diff --git a/arch/arm/xen/enlighten.c b/arch/arm/xen/enlighten.c
index 06bd61a..13e3e9f 100644
--- a/arch/arm/xen/enlighten.c
+++ b/arch/arm/xen/enlighten.c
@@ -20,6 +20,7 @@
 #include <linux/irqreturn.h>
 #include <linux/module.h>
 #include <linux/of.h>
+#include <linux/of_fdt.h>
 #include <linux/of_irq.h>
 #include <linux/of_address.h>
 #include <linux/cpuidle.h>
@@ -53,8 +54,6 @@ struct xen_memory_region xen_extra_mem[XEN_EXTRA_MEM_MAX_REGIONS] __initdata;
 
 static __read_mostly unsigned int xen_events_irq;
 
-static __initdata struct device_node *xen_node;
-
 int xen_remap_domain_gfn_array(struct vm_area_struct *vma,
 			       unsigned long addr,
 			       xen_pfn_t *gfn, int nr,
@@ -238,6 +237,33 @@ static irqreturn_t xen_arm_callback(int irq, void *arg)
 	return IRQ_HANDLED;
 }
 
+static __initdata struct {
+	const char *compat;
+	const char *prefix;
+	const char *version;
+	bool found;
+} hyper_node = {"xen,xen", "xen,xen-", NULL, false};
+
+static int __init fdt_find_hyper_node(unsigned long node, const char *uname,
+				      int depth, void *data)
+{
+	const void *s = NULL;
+	int len;
+
+	if (depth != 1 || strcmp(uname, "hypervisor") != 0)
+		return 0;
+
+	if (of_flat_dt_is_compatible(node, hyper_node.compat))
+		hyper_node.found = true;
+
+	s = of_get_flat_dt_prop(node, "compatible", &len);
+	if (strlen(hyper_node.prefix) + 3  < len &&
+	    !strncmp(hyper_node.prefix, s, strlen(hyper_node.prefix)))
+		hyper_node.version = s + strlen(hyper_node.prefix);
+
+	return 0;
+}
+
 /*
  * see Documentation/devicetree/bindings/arm/xen.txt for the
  * documentation of the Xen Device Tree format.
@@ -245,26 +271,18 @@ static irqreturn_t xen_arm_callback(int irq, void *arg)
 #define GRANT_TABLE_PHYSADDR 0
 void __init xen_early_init(void)
 {
-	int len;
-	const char *s = NULL;
-	const char *version = NULL;
-	const char *xen_prefix = "xen,xen-";
-
-	xen_node = of_find_compatible_node(NULL, NULL, "xen,xen");
-	if (!xen_node) {
+	of_scan_flat_dt(fdt_find_hyper_node, NULL);
+	if (!hyper_node.found) {
 		pr_debug("No Xen support\n");
 		return;
 	}
-	s = of_get_property(xen_node, "compatible", &len);
-	if (strlen(xen_prefix) + 3  < len &&
-			!strncmp(xen_prefix, s, strlen(xen_prefix)))
-		version = s + strlen(xen_prefix);
-	if (version == NULL) {
+
+	if (hyper_node.version == NULL) {
 		pr_debug("Xen version not found\n");
 		return;
 	}
 
-	pr_info("Xen %s support found\n", version);
+	pr_info("Xen %s support found\n", hyper_node.version);
 
 	xen_domain_type = XEN_HVM_DOMAIN;
 
@@ -305,6 +323,14 @@ static void __init xen_acpi_guest_init(void)
 
 static void __init xen_dt_guest_init(void)
 {
+	struct device_node *xen_node;
+
+	xen_node = of_find_compatible_node(NULL, NULL, "xen,xen");
+	if (!xen_node) {
+		pr_err("Xen support was detected before, but it has disappeared\n");
+		return;
+	}
+
 	xen_events_irq = irq_of_parse_and_map(xen_node, 0);
 }
 
diff --git a/arch/arm64/kernel/setup.c b/arch/arm64/kernel/setup.c
index 9dc6776..7cf992f 100644
--- a/arch/arm64/kernel/setup.c
+++ b/arch/arm64/kernel/setup.c
@@ -320,6 +320,7 @@ void __init setup_arch(char **cmdline_p)
 	 */
 	cpu_uninstall_idmap();
 
+	xen_early_init();
 	efi_init();
 	arm64_memblock_init();
 
@@ -341,7 +342,6 @@ void __init setup_arch(char **cmdline_p)
 	} else {
 		psci_acpi_init();
 	}
-	xen_early_init();
 
 	cpu_read_bootcpu_ops();
 	smp_init_cpus();
-- 
2.1.4

WARNING: multiple messages have this Message-ID (diff)
From: shannon.zhao@linaro.org (Shannon Zhao)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v10 11/17] ARM: XEN: Move xen_early_init() before efi_init()
Date: Fri,  1 Apr 2016 23:49:09 +0800	[thread overview]
Message-ID: <1459525755-36968-12-git-send-email-shannon.zhao@linaro.org> (raw)
In-Reply-To: <1459525755-36968-1-git-send-email-shannon.zhao@linaro.org>

Move xen_early_init() before efi_init(), then when calling efi_init()
could initialize Xen specific UEFI.

Check if it runs on Xen hypervisor through the flat dts.

Cc: Russell King <linux@arm.linux.org.uk>
Signed-off-by: Shannon Zhao <shannon.zhao@linaro.org>
Reviewed-by: Stefano Stabellini <stefano.stabellini@eu.citrix.com>
---
 arch/arm/kernel/setup.c   |  2 +-
 arch/arm/xen/enlighten.c  | 56 ++++++++++++++++++++++++++++++++++-------------
 arch/arm64/kernel/setup.c |  2 +-
 3 files changed, 43 insertions(+), 17 deletions(-)

diff --git a/arch/arm/kernel/setup.c b/arch/arm/kernel/setup.c
index 139791e..5bc7516 100644
--- a/arch/arm/kernel/setup.c
+++ b/arch/arm/kernel/setup.c
@@ -1035,6 +1035,7 @@ void __init setup_arch(char **cmdline_p)
 	early_paging_init(mdesc);
 #endif
 	setup_dma_zone(mdesc);
+	xen_early_init();
 	efi_init();
 	sanity_check_meminfo();
 	arm_memblock_init(mdesc);
@@ -1051,7 +1052,6 @@ void __init setup_arch(char **cmdline_p)
 
 	arm_dt_init_cpu_maps();
 	psci_dt_init();
-	xen_early_init();
 #ifdef CONFIG_SMP
 	if (is_smp()) {
 		if (!mdesc->smp_init || !mdesc->smp_init()) {
diff --git a/arch/arm/xen/enlighten.c b/arch/arm/xen/enlighten.c
index 06bd61a..13e3e9f 100644
--- a/arch/arm/xen/enlighten.c
+++ b/arch/arm/xen/enlighten.c
@@ -20,6 +20,7 @@
 #include <linux/irqreturn.h>
 #include <linux/module.h>
 #include <linux/of.h>
+#include <linux/of_fdt.h>
 #include <linux/of_irq.h>
 #include <linux/of_address.h>
 #include <linux/cpuidle.h>
@@ -53,8 +54,6 @@ struct xen_memory_region xen_extra_mem[XEN_EXTRA_MEM_MAX_REGIONS] __initdata;
 
 static __read_mostly unsigned int xen_events_irq;
 
-static __initdata struct device_node *xen_node;
-
 int xen_remap_domain_gfn_array(struct vm_area_struct *vma,
 			       unsigned long addr,
 			       xen_pfn_t *gfn, int nr,
@@ -238,6 +237,33 @@ static irqreturn_t xen_arm_callback(int irq, void *arg)
 	return IRQ_HANDLED;
 }
 
+static __initdata struct {
+	const char *compat;
+	const char *prefix;
+	const char *version;
+	bool found;
+} hyper_node = {"xen,xen", "xen,xen-", NULL, false};
+
+static int __init fdt_find_hyper_node(unsigned long node, const char *uname,
+				      int depth, void *data)
+{
+	const void *s = NULL;
+	int len;
+
+	if (depth != 1 || strcmp(uname, "hypervisor") != 0)
+		return 0;
+
+	if (of_flat_dt_is_compatible(node, hyper_node.compat))
+		hyper_node.found = true;
+
+	s = of_get_flat_dt_prop(node, "compatible", &len);
+	if (strlen(hyper_node.prefix) + 3  < len &&
+	    !strncmp(hyper_node.prefix, s, strlen(hyper_node.prefix)))
+		hyper_node.version = s + strlen(hyper_node.prefix);
+
+	return 0;
+}
+
 /*
  * see Documentation/devicetree/bindings/arm/xen.txt for the
  * documentation of the Xen Device Tree format.
@@ -245,26 +271,18 @@ static irqreturn_t xen_arm_callback(int irq, void *arg)
 #define GRANT_TABLE_PHYSADDR 0
 void __init xen_early_init(void)
 {
-	int len;
-	const char *s = NULL;
-	const char *version = NULL;
-	const char *xen_prefix = "xen,xen-";
-
-	xen_node = of_find_compatible_node(NULL, NULL, "xen,xen");
-	if (!xen_node) {
+	of_scan_flat_dt(fdt_find_hyper_node, NULL);
+	if (!hyper_node.found) {
 		pr_debug("No Xen support\n");
 		return;
 	}
-	s = of_get_property(xen_node, "compatible", &len);
-	if (strlen(xen_prefix) + 3  < len &&
-			!strncmp(xen_prefix, s, strlen(xen_prefix)))
-		version = s + strlen(xen_prefix);
-	if (version == NULL) {
+
+	if (hyper_node.version == NULL) {
 		pr_debug("Xen version not found\n");
 		return;
 	}
 
-	pr_info("Xen %s support found\n", version);
+	pr_info("Xen %s support found\n", hyper_node.version);
 
 	xen_domain_type = XEN_HVM_DOMAIN;
 
@@ -305,6 +323,14 @@ static void __init xen_acpi_guest_init(void)
 
 static void __init xen_dt_guest_init(void)
 {
+	struct device_node *xen_node;
+
+	xen_node = of_find_compatible_node(NULL, NULL, "xen,xen");
+	if (!xen_node) {
+		pr_err("Xen support was detected before, but it has disappeared\n");
+		return;
+	}
+
 	xen_events_irq = irq_of_parse_and_map(xen_node, 0);
 }
 
diff --git a/arch/arm64/kernel/setup.c b/arch/arm64/kernel/setup.c
index 9dc6776..7cf992f 100644
--- a/arch/arm64/kernel/setup.c
+++ b/arch/arm64/kernel/setup.c
@@ -320,6 +320,7 @@ void __init setup_arch(char **cmdline_p)
 	 */
 	cpu_uninstall_idmap();
 
+	xen_early_init();
 	efi_init();
 	arm64_memblock_init();
 
@@ -341,7 +342,6 @@ void __init setup_arch(char **cmdline_p)
 	} else {
 		psci_acpi_init();
 	}
-	xen_early_init();
 
 	cpu_read_bootcpu_ops();
 	smp_init_cpus();
-- 
2.1.4

  parent reply	other threads:[~2016-04-01 15:51 UTC|newest]

Thread overview: 121+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-04-01 15:48 [PATCH v10 00/17] Add ACPI support for Xen Dom0 on ARM64 Shannon Zhao
2016-04-01 15:48 ` Shannon Zhao
2016-04-01 15:48 ` Shannon Zhao
2016-04-01 15:48 ` [PATCH v10 01/17] Xen: ACPI: Hide UART used by Xen Shannon Zhao
2016-04-01 15:48 ` Shannon Zhao
2016-04-01 15:48   ` Shannon Zhao
2016-04-01 15:48   ` Shannon Zhao
2016-04-01 19:21   ` Rafael J. Wysocki
2016-04-01 19:21     ` Rafael J. Wysocki
2016-04-01 19:21     ` Rafael J. Wysocki
2016-04-01 19:21   ` Rafael J. Wysocki
2016-04-01 15:49 ` [PATCH v10 02/17] xen/grant-table: Move xlated_setup_gnttab_pages to common place Shannon Zhao
2016-04-01 15:49   ` Shannon Zhao
2016-04-01 15:49   ` Shannon Zhao
2016-04-06 11:40   ` Julien Grall
2016-04-06 11:40   ` Julien Grall
2016-04-06 11:40     ` Julien Grall
2016-04-06 11:40     ` Julien Grall
2016-04-01 15:49 ` Shannon Zhao
2016-04-01 15:49 ` [PATCH v10 03/17] Xen: xlate: Use page_to_xen_pfn instead of page_to_pfn Shannon Zhao
2016-04-01 15:49 ` Shannon Zhao
2016-04-01 15:49   ` Shannon Zhao
2016-04-06 11:42   ` Julien Grall
2016-04-06 11:42     ` Julien Grall
2016-04-06 11:42     ` Julien Grall
2016-04-06 11:42   ` Julien Grall
2016-04-01 15:49 ` [PATCH v10 04/17] arm/xen: Use xen_xlate_map_ballooned_pages to setup grant table Shannon Zhao
2016-04-01 15:49   ` Shannon Zhao
2016-04-06 11:43   ` Julien Grall
2016-04-06 11:43   ` Julien Grall
2016-04-06 11:43     ` Julien Grall
2016-04-06 11:43     ` Julien Grall
2016-04-01 15:49 ` Shannon Zhao
2016-04-01 15:49 ` [PATCH v10 05/17] xen: memory : Add new XENMAPSPACE type XENMAPSPACE_dev_mmio Shannon Zhao
2016-04-01 15:49   ` Shannon Zhao
2016-04-01 15:49   ` Shannon Zhao
2016-04-06 11:44   ` Julien Grall
2016-04-06 11:44   ` Julien Grall
2016-04-06 11:44     ` Julien Grall
2016-04-06 11:44     ` Julien Grall
2016-04-01 15:49 ` Shannon Zhao
2016-04-01 15:49 ` [PATCH v10 06/17] Xen: ARM: Add support for mapping platform device mmio Shannon Zhao
2016-04-01 15:49 ` Shannon Zhao
2016-04-01 15:49   ` Shannon Zhao
2016-04-06 12:16   ` Julien Grall
2016-04-06 12:16     ` Julien Grall
2016-04-06 12:16     ` Julien Grall
2016-04-07  1:37     ` Shannon Zhao
2016-04-07  1:37       ` Shannon Zhao
2016-04-07  1:37       ` Shannon Zhao
2016-04-07 10:32       ` Julien Grall
2016-04-07 10:32       ` Julien Grall
2016-04-07 10:32         ` Julien Grall
2016-04-07 10:32         ` Julien Grall
2016-04-07 11:25         ` Shannon Zhao
2016-04-07 11:25         ` Shannon Zhao
2016-04-07 11:25           ` Shannon Zhao
2016-04-07 11:25           ` Shannon Zhao
2016-04-07  1:37     ` Shannon Zhao
2016-04-06 12:16   ` Julien Grall
2016-04-01 15:49 ` [PATCH v10 07/17] Xen: ARM: Add support for mapping AMBA " Shannon Zhao
2016-04-01 15:49 ` Shannon Zhao
2016-04-01 15:49   ` Shannon Zhao
2016-04-01 15:49   ` Shannon Zhao
2016-04-06 12:26   ` Julien Grall
2016-04-06 12:26   ` Julien Grall
2016-04-06 12:26     ` Julien Grall
2016-04-06 12:26     ` Julien Grall
2016-04-01 15:49 ` [PATCH v10 08/17] Xen: public/hvm: sync changes of HVM_PARAM_CALLBACK_VIA ABI from Xen Shannon Zhao
2016-04-01 15:49   ` Shannon Zhao
2016-04-01 15:49 ` Shannon Zhao
2016-04-01 15:49 ` [PATCH v10 09/17] xen/hvm/params: Add a new delivery type for event-channel in HVM_PARAM_CALLBACK_IRQ Shannon Zhao
2016-04-01 15:49   ` Shannon Zhao
2016-04-06 12:29   ` Julien Grall
2016-04-06 12:29     ` Julien Grall
2016-04-06 12:29     ` Julien Grall
2016-04-06 12:29   ` Julien Grall
2016-04-01 15:49 ` Shannon Zhao
2016-04-01 15:49 ` [PATCH v10 10/17] arm/xen: Get event-channel irq through HVM_PARAM when booting with ACPI Shannon Zhao
2016-04-01 15:49   ` Shannon Zhao
2016-04-06 12:31   ` Julien Grall
2016-04-06 12:31     ` Julien Grall
2016-04-06 12:31     ` Julien Grall
2016-04-06 12:31   ` Julien Grall
2016-04-01 15:49 ` Shannon Zhao
2016-04-01 15:49 ` Shannon Zhao [this message]
2016-04-01 15:49   ` [PATCH v10 11/17] ARM: XEN: Move xen_early_init() before efi_init() Shannon Zhao
2016-04-06 12:35   ` Julien Grall
2016-04-06 12:35   ` Julien Grall
2016-04-06 12:35     ` Julien Grall
2016-04-01 15:49 ` Shannon Zhao
2016-04-01 15:49 ` [PATCH v10 12/17] ARM64: ACPI: Check if it runs on Xen to enable or disable ACPI Shannon Zhao
2016-04-01 15:49 ` Shannon Zhao
2016-04-01 15:49   ` Shannon Zhao
2016-04-01 15:49 ` [PATCH v10 13/17] ARM: Xen: Document UEFI support on Xen ARM virtual platforms Shannon Zhao
2016-04-01 15:49   ` Shannon Zhao
2016-04-01 15:49   ` Shannon Zhao
2016-04-01 15:49 ` Shannon Zhao
2016-04-01 15:49 ` [PATCH v10 14/17] XEN: EFI: Move x86 specific codes to architecture directory Shannon Zhao
2016-04-01 15:49 ` Shannon Zhao
2016-04-01 15:49   ` Shannon Zhao
2016-04-01 15:49 ` [PATCH v10 15/17] ARM64: XEN: Add a function to initialize Xen specific UEFI runtime services Shannon Zhao
2016-04-01 15:49 ` Shannon Zhao
2016-04-01 15:49   ` Shannon Zhao
2016-04-01 15:49 ` [PATCH v10 16/17] FDT: Add a helper to get the subnode by given name Shannon Zhao
2016-04-01 15:49   ` Shannon Zhao
2016-04-01 15:49 ` Shannon Zhao
2016-04-01 15:49 ` [PATCH v10 17/17] Xen: EFI: Parse DT parameters for Xen specific UEFI Shannon Zhao
2016-04-01 15:49   ` Shannon Zhao
2016-04-01 15:49 ` Shannon Zhao
2016-04-06 11:32 ` [PATCH v10 00/17] Add ACPI support for Xen Dom0 on ARM64 Julien Grall
2016-04-06 11:32 ` Julien Grall
2016-04-06 11:32   ` Julien Grall
2016-04-06 11:32   ` Julien Grall
2016-04-07  1:39   ` Shannon Zhao
2016-04-07  1:39     ` Shannon Zhao
2016-04-07  1:39     ` Shannon Zhao
2016-04-07 10:34     ` Julien Grall
2016-04-07 10:34     ` Julien Grall
2016-04-07 10:34       ` Julien Grall
2016-04-07  1:39   ` Shannon Zhao

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1459525755-36968-12-git-send-email-shannon.zhao@linaro.org \
    --to=shannon.zhao@linaro.org \
    --cc=catalin.marinas@arm.com \
    --cc=david.vrabel@citrix.com \
    --cc=devicetree@vger.kernel.org \
    --cc=julien.grall@arm.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-efi@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux@arm.linux.org.uk \
    --cc=peter.huangpeng@huawei.com \
    --cc=stefano.stabellini@citrix.com \
    --cc=will.deacon@arm.com \
    --cc=xen-devel@lists.xen.org \
    --cc=zhaoshenglong@huawei.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.