All of lore.kernel.org
 help / color / mirror / Atom feed
From: Paul Gortmaker <paul.gortmaker@windriver.com>
To: linux-kernel@vger.kernel.org
Cc: Paul Gortmaker <paul.gortmaker@windriver.com>,
	Linus Walleij <linus.walleij@linaro.org>,
	Alexandre Courbot <gnurou@gmail.com>,
	Rabin Vincent <rabin.vincent@stericsson.com>,
	Hanumath Prasad <hanumath.prasad@stericsson.com>,
	linux-gpio@vger.kernel.org
Subject: [PATCH 2/6] drivers/gpio: make gpio-tc3589x.c explicitly non-modular
Date: Fri, 1 Apr 2016 14:49:34 -0400	[thread overview]
Message-ID: <1459536578-3017-3-git-send-email-paul.gortmaker@windriver.com> (raw)
In-Reply-To: <1459536578-3017-1-git-send-email-paul.gortmaker@windriver.com>

The Kconfig currently controlling compilation of this code is:

drivers/gpio/Kconfig:config GPIO_TC3589X
drivers/gpio/Kconfig:   bool "TC3589X GPIOs"

...meaning that it currently is not being built as a module by anyone.

Lets remove the modular code that is essentially orphaned, so that
when reading the driver there is no doubt it is builtin-only.

Since module_init was not in use by this code, the init ordering
remains unchanged with this commit.

We also delete the MODULE_LICENSE tag etc. since all that information
is already contained at the top of the file in the comments.

Cc: Linus Walleij <linus.walleij@linaro.org>
Cc: Alexandre Courbot <gnurou@gmail.com>
Cc: Rabin Vincent <rabin.vincent@stericsson.com>
Cc: Hanumath Prasad <hanumath.prasad@stericsson.com>
Cc: linux-gpio@vger.kernel.org
Signed-off-by: Paul Gortmaker <paul.gortmaker@windriver.com>
---
 drivers/gpio/gpio-tc3589x.c | 11 -----------
 1 file changed, 11 deletions(-)

diff --git a/drivers/gpio/gpio-tc3589x.c b/drivers/gpio/gpio-tc3589x.c
index 4f566e6b81f1..a29dec137373 100644
--- a/drivers/gpio/gpio-tc3589x.c
+++ b/drivers/gpio/gpio-tc3589x.c
@@ -6,7 +6,6 @@
  * Author: Rabin Vincent <rabin.vincent@stericsson.com> for ST-Ericsson
  */
 
-#include <linux/module.h>
 #include <linux/init.h>
 #include <linux/platform_device.h>
 #include <linux/slab.h>
@@ -311,13 +310,3 @@ static int __init tc3589x_gpio_init(void)
 	return platform_driver_register(&tc3589x_gpio_driver);
 }
 subsys_initcall(tc3589x_gpio_init);
-
-static void __exit tc3589x_gpio_exit(void)
-{
-	platform_driver_unregister(&tc3589x_gpio_driver);
-}
-module_exit(tc3589x_gpio_exit);
-
-MODULE_LICENSE("GPL v2");
-MODULE_DESCRIPTION("TC3589x GPIO driver");
-MODULE_AUTHOR("Hanumath Prasad, Rabin Vincent");
-- 
2.6.1

WARNING: multiple messages have this Message-ID (diff)
From: Paul Gortmaker <paul.gortmaker@windriver.com>
To: <linux-kernel@vger.kernel.org>
Cc: Paul Gortmaker <paul.gortmaker@windriver.com>,
	Linus Walleij <linus.walleij@linaro.org>,
	Alexandre Courbot <gnurou@gmail.com>,
	Rabin Vincent <rabin.vincent@stericsson.com>,
	Hanumath Prasad <hanumath.prasad@stericsson.com>,
	<linux-gpio@vger.kernel.org>
Subject: [PATCH 2/6] drivers/gpio: make gpio-tc3589x.c explicitly non-modular
Date: Fri, 1 Apr 2016 14:49:34 -0400	[thread overview]
Message-ID: <1459536578-3017-3-git-send-email-paul.gortmaker@windriver.com> (raw)
In-Reply-To: <1459536578-3017-1-git-send-email-paul.gortmaker@windriver.com>

The Kconfig currently controlling compilation of this code is:

drivers/gpio/Kconfig:config GPIO_TC3589X
drivers/gpio/Kconfig:   bool "TC3589X GPIOs"

...meaning that it currently is not being built as a module by anyone.

Lets remove the modular code that is essentially orphaned, so that
when reading the driver there is no doubt it is builtin-only.

Since module_init was not in use by this code, the init ordering
remains unchanged with this commit.

We also delete the MODULE_LICENSE tag etc. since all that information
is already contained at the top of the file in the comments.

Cc: Linus Walleij <linus.walleij@linaro.org>
Cc: Alexandre Courbot <gnurou@gmail.com>
Cc: Rabin Vincent <rabin.vincent@stericsson.com>
Cc: Hanumath Prasad <hanumath.prasad@stericsson.com>
Cc: linux-gpio@vger.kernel.org
Signed-off-by: Paul Gortmaker <paul.gortmaker@windriver.com>
---
 drivers/gpio/gpio-tc3589x.c | 11 -----------
 1 file changed, 11 deletions(-)

diff --git a/drivers/gpio/gpio-tc3589x.c b/drivers/gpio/gpio-tc3589x.c
index 4f566e6b81f1..a29dec137373 100644
--- a/drivers/gpio/gpio-tc3589x.c
+++ b/drivers/gpio/gpio-tc3589x.c
@@ -6,7 +6,6 @@
  * Author: Rabin Vincent <rabin.vincent@stericsson.com> for ST-Ericsson
  */
 
-#include <linux/module.h>
 #include <linux/init.h>
 #include <linux/platform_device.h>
 #include <linux/slab.h>
@@ -311,13 +310,3 @@ static int __init tc3589x_gpio_init(void)
 	return platform_driver_register(&tc3589x_gpio_driver);
 }
 subsys_initcall(tc3589x_gpio_init);
-
-static void __exit tc3589x_gpio_exit(void)
-{
-	platform_driver_unregister(&tc3589x_gpio_driver);
-}
-module_exit(tc3589x_gpio_exit);
-
-MODULE_LICENSE("GPL v2");
-MODULE_DESCRIPTION("TC3589x GPIO driver");
-MODULE_AUTHOR("Hanumath Prasad, Rabin Vincent");
-- 
2.6.1

  parent reply	other threads:[~2016-04-01 18:49 UTC|newest]

Thread overview: 20+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-04-01 18:49 [PATCH 0/6] gpio: batch #2: remove modular code from non-modular drivers Paul Gortmaker
2016-04-01 18:49 ` Paul Gortmaker
2016-04-01 18:49 ` [PATCH 1/6] drivers/gpio: make gpio-rc5t583.c explicitly non-modular Paul Gortmaker
2016-04-01 18:49   ` Paul Gortmaker
2016-04-05 13:22   ` Linus Walleij
2016-04-01 18:49 ` Paul Gortmaker [this message]
2016-04-01 18:49   ` [PATCH 2/6] drivers/gpio: make gpio-tc3589x.c " Paul Gortmaker
2016-04-05 13:23   ` Linus Walleij
2016-04-01 18:49 ` [PATCH 3/6] drivers/gpio: make gpio-sx150x.c " Paul Gortmaker
2016-04-01 18:49   ` Paul Gortmaker
2016-04-05 13:24   ` Linus Walleij
2016-04-01 18:49 ` [PATCH 4/6] drivers/gpio: make gpio-palmas.c " Paul Gortmaker
2016-04-01 18:49   ` Paul Gortmaker
2016-04-05 13:25   ` Linus Walleij
2016-04-01 18:49 ` [PATCH 5/6] drivers/gpio: make gpio-tps65910.c " Paul Gortmaker
2016-04-01 18:49   ` Paul Gortmaker
2016-04-05 13:27   ` Linus Walleij
2016-04-01 18:49 ` [PATCH 6/6] drivers/gpio: make gpio-tps6586x.c " Paul Gortmaker
2016-04-01 18:49   ` Paul Gortmaker
2016-04-05 13:28   ` Linus Walleij

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1459536578-3017-3-git-send-email-paul.gortmaker@windriver.com \
    --to=paul.gortmaker@windriver.com \
    --cc=gnurou@gmail.com \
    --cc=hanumath.prasad@stericsson.com \
    --cc=linus.walleij@linaro.org \
    --cc=linux-gpio@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=rabin.vincent@stericsson.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.