All of lore.kernel.org
 help / color / mirror / Atom feed
From: Benjamin Sanda <ben.sanda@dornerworks.com>
To: xen-devel@lists.xenproject.org
Cc: Wei Liu <wei.liu2@citrix.com>,
	George Dunlap <george.dunlap@eu.citrix.com>,
	Andrew Cooper <andrew.cooper3@citrix.com>,
	Ian Jackson <ian.jackson@eu.citrix.com>, Tim Deegan <tim@xen.org>,
	Julien Grall <julien.grall@arm.com>,
	Stefano Stabellini <stefano.stabellini@citrix.com>,
	Keir Fraser <keir@xen.org>
Subject: [PATCH V2 8/9] xentrace: Support for ARM platform
Date: Fri, 1 Apr 2016 16:33:53 -0400	[thread overview]
Message-ID: <1459542834-17522-10-git-send-email-ben.sanda@dornerworks.com> (raw)
In-Reply-To: <1459542834-17522-1-git-send-email-ben.sanda@dornerworks.com>

Modified p2m_lookup() to provide support for xentrace on the ARM
platform. Added check for DOMID_XEN which skips PFN to MFN
translation. DOMID_XEN is considered a PV guest on x86 (i.e MFN ==
GFN), but on ARM there is no such concept. Thus requests to DOMID_XEN
on ARM use a MFN address directly and do not need translation from
PFN.

Check added to determine read/write or read only page type when
requesting DOMID_XEN. This is  done by checking the u.inuse.type_info
parameter of the requested page. The page rw/ro  paddr_t type is then
set accordingly.

Signed-off-by: Benjamin Sanda <ben.sanda@dornerworks.com>

---
Changed since v1:
  * Added check to determine page rw/ro type to correctly set the
    paddr_t to p2m_ram_rw or p2m_ram_ro instead of assuming p2m_ram_rw
  * Corrected block comment format to conform to Xen coding standard
---
 xen/arch/arm/p2m.c | 35 +++++++++++++++++++++++++++++++----
 1 file changed, 31 insertions(+), 4 deletions(-)

diff --git a/xen/arch/arm/p2m.c b/xen/arch/arm/p2m.c
index a2a9c4b..a99b670 100644
--- a/xen/arch/arm/p2m.c
+++ b/xen/arch/arm/p2m.c
@@ -227,11 +227,38 @@ paddr_t p2m_lookup(struct domain *d, paddr_t paddr, p2m_type_t *t)
 {
     paddr_t ret;
     struct p2m_domain *p2m = &d->arch.p2m;
+    struct page_info *page;
+    unsigned long mfn;
 
-    spin_lock(&p2m->lock);
-    ret = __p2m_lookup(d, paddr, t);
-    spin_unlock(&p2m->lock);
-
+    /*
+    * DOMID_XEN is considered a PV guest on x86 (i.e MFN == GFN), but
+    * on ARM there is no such concept. Thus requests to DOMID_XEN
+    * on ARM use a MFN address directly and do not need translation 
+    * from PFN.
+    */
+    if(DOMID_XEN != d->domain_id)
+    {
+        spin_lock(&p2m->lock);
+        ret = __p2m_lookup(d, paddr, t);
+        spin_unlock(&p2m->lock);
+    }
+    else
+    {
+        /* retrieve the page to determine read/write or read only mapping */
+        mfn = paddr >> PAGE_SHIFT;
+        if (mfn_valid(mfn))
+        {
+            page = mfn_to_page(mfn);
+            *t = (page->u.inuse.type_info == PGT_writable_page ? 
+                                p2m_ram_rw : p2m_ram_ro);
+        }
+        else
+        {
+            *t = p2m_invalid;
+        }
+        ret = paddr;
+    }
+    
     return ret;
 }
 
-- 
2.5.0


_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
http://lists.xen.org/xen-devel

  parent reply	other threads:[~2016-04-01 20:34 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-04-01 20:33 [PATCH V2 0/9] xentrace/xenalyze support on ARM Benjamin Sanda
2016-04-01 20:33 ` Benjamin Sanda
2016-04-01 20:33 ` [PATCH V2 1/9] xenalyze: Support for ARM platform Benjamin Sanda
2016-04-04 14:10   ` Wei Liu
2016-04-04 14:12     ` Wei Liu
2016-04-01 20:33 ` [PATCH V2 2/9] xentrace: " Benjamin Sanda
2016-04-01 20:33 ` [PATCH V2 3/9] " Benjamin Sanda
2016-04-01 20:33 ` [PATCH V2 4/9] " Benjamin Sanda
2016-04-01 20:33 ` [PATCH V2 5/9] " Benjamin Sanda
2016-04-01 20:33 ` [PATCH V2 6/9] " Benjamin Sanda
2016-04-01 20:33 ` [PATCH V2 7/9] " Benjamin Sanda
2016-04-01 20:33 ` Benjamin Sanda [this message]
2016-04-01 20:33 ` [PATCH V2 9/9] " Benjamin Sanda
2016-04-04 14:11 ` [PATCH V2 0/9] xentrace/xenalyze support on ARM Wei Liu
2016-04-04 15:02   ` Julien Grall
2016-04-04 15:50     ` Ben Sanda
2016-04-04 15:59       ` Wei Liu
2016-04-04 16:04       ` Andrew Cooper

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1459542834-17522-10-git-send-email-ben.sanda@dornerworks.com \
    --to=ben.sanda@dornerworks.com \
    --cc=andrew.cooper3@citrix.com \
    --cc=george.dunlap@eu.citrix.com \
    --cc=ian.jackson@eu.citrix.com \
    --cc=julien.grall@arm.com \
    --cc=keir@xen.org \
    --cc=stefano.stabellini@citrix.com \
    --cc=tim@xen.org \
    --cc=wei.liu2@citrix.com \
    --cc=xen-devel@lists.xenproject.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.