All of lore.kernel.org
 help / color / mirror / Atom feed
From: Wei Liu <wei.liu2@citrix.com>
To: Ben Sanda <Ben.Sanda@dornerworks.com>
Cc: "xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>,
	Julien Grall <julien.grall@arm.com>,
	Wei Liu <wei.liu2@citrix.com>
Subject: Re: [PATCH V2 0/9] xentrace/xenalyze support on ARM
Date: Mon, 4 Apr 2016 16:59:46 +0100	[thread overview]
Message-ID: <20160404155946.GO25710@citrix.com> (raw)
In-Reply-To: <A2A949C387F3A54C9B4DAC2DCD2E9A85E333C429@Quimby.dw.local>

On Mon, Apr 04, 2016 at 03:50:35PM +0000, Ben Sanda wrote:
> Julien and Wei,
> 
> >> You patches all have the same subject line.  Please make them more 
> >> specific. See my reply to #1 for example.
> >
> > +1
> > 
> > Also, you should at least check that Xen still builds after applying
> > each patch. Ideally, you also need to be careful to not break any
> > feature currently supported. It's useful when someone needs to 
> > bisect the tree.
> >
> > For instance, you use the function get_pg_owner for ARM in patch #2 
> > but introduce the function in patch #4. This will break ARM build. 
> > So the patch #2 should be moved after #4.
> >
> > Furthermore, you remove the functions get_pg_owner and put_pg_owner 
> > for x86 in patch #3 and then re-introduced them in patch #4. 
> > Therefore, the x86 will be broken after #3. In this case, it's better
> > to have a patch that move the 2 functions from x86 to common.
> 
> Thank you for the comments. I apologize for the errors in the patch
> format. This is my first time submitting a patch to Xen and I was
> unaware that the patch set order mattered or that I had to account for
> a piecewise application of the patch set. I will attempt to resubmit
> with this corrected and the patch names updated. 
> 
> So then it is permissible to have multiple file changes in one
> patch/commit? E.g. a patch that removes from one file and  adds to

That's definitely allowed. Just think of each commit as a logically
complete unit. It should compile. It should not break existing
functionality.

Wei.

> another in the same commit. I initially thought each patch/ commit was
> only supposed to modify one file and that's why I did it that way
> 
> Thank you,
> Ben Sanda

_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
http://lists.xen.org/xen-devel

  reply	other threads:[~2016-04-04 15:58 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-04-01 20:33 [PATCH V2 0/9] xentrace/xenalyze support on ARM Benjamin Sanda
2016-04-01 20:33 ` Benjamin Sanda
2016-04-01 20:33 ` [PATCH V2 1/9] xenalyze: Support for ARM platform Benjamin Sanda
2016-04-04 14:10   ` Wei Liu
2016-04-04 14:12     ` Wei Liu
2016-04-01 20:33 ` [PATCH V2 2/9] xentrace: " Benjamin Sanda
2016-04-01 20:33 ` [PATCH V2 3/9] " Benjamin Sanda
2016-04-01 20:33 ` [PATCH V2 4/9] " Benjamin Sanda
2016-04-01 20:33 ` [PATCH V2 5/9] " Benjamin Sanda
2016-04-01 20:33 ` [PATCH V2 6/9] " Benjamin Sanda
2016-04-01 20:33 ` [PATCH V2 7/9] " Benjamin Sanda
2016-04-01 20:33 ` [PATCH V2 8/9] " Benjamin Sanda
2016-04-01 20:33 ` [PATCH V2 9/9] " Benjamin Sanda
2016-04-04 14:11 ` [PATCH V2 0/9] xentrace/xenalyze support on ARM Wei Liu
2016-04-04 15:02   ` Julien Grall
2016-04-04 15:50     ` Ben Sanda
2016-04-04 15:59       ` Wei Liu [this message]
2016-04-04 16:04       ` Andrew Cooper

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20160404155946.GO25710@citrix.com \
    --to=wei.liu2@citrix.com \
    --cc=Ben.Sanda@dornerworks.com \
    --cc=julien.grall@arm.com \
    --cc=xen-devel@lists.xenproject.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.