All of lore.kernel.org
 help / color / mirror / Atom feed
From: Anna-Maria Gleixner <anna-maria@linutronix.de>
To: linux-kernel@vger.kernel.org
Cc: rt@linutronix.de, Anna-Maria Gleixner <anna-maria@linutronix.de>,
	David Vrabel <david.vrabel@citrix.com>,
	Stefano Stabellini <stefano.stabellini@eu.citrix.com>,
	xen-devel@lists.xenproject.org
Subject: [PATCH] xen: Add comment for missing FROZEN notifier transitions
Date: Mon,  4 Apr 2016 14:32:20 +0200	[thread overview]
Message-ID: <1459773140-43707-1-git-send-email-anna-maria@linutronix.de> (raw)

Xen guests do not offline/online CPUs during suspend/resume and
therefore FROZEN notifier transitions are not required. Add this
explanation as a comment in the code to get not confused why
CPU_TASKS_FROZEN masked transitions are not considered.

Cc: David Vrabel <david.vrabel@citrix.com>
Cc: Stefano Stabellini <stefano.stabellini@eu.citrix.com>
Cc: xen-devel@lists.xenproject.org 
Signed-off-by: Anna-Maria Gleixner <anna-maria@linutronix.de>
---
 arch/arm/xen/enlighten.c         |    6 ++++++
 arch/x86/xen/enlighten.c         |    7 +++++++
 drivers/xen/events/events_fifo.c |    6 ++++++
 3 files changed, 19 insertions(+)

--- a/arch/arm/xen/enlighten.c
+++ b/arch/arm/xen/enlighten.c
@@ -213,6 +213,12 @@ static int xen_cpu_notification(struct n
 				unsigned long action,
 				void *hcpu)
 {
+	/*
+	 * Xen guests do not offline/online CPUs during
+	 * suspend/resume, thus CPU_TASKS_FROZEN masked transitions
+	 * are not considered.
+	 */
+
 	switch (action) {
 	case CPU_STARTING:
 		xen_percpu_init();
--- a/arch/x86/xen/enlighten.c
+++ b/arch/x86/xen/enlighten.c
@@ -1788,6 +1788,13 @@ static int xen_hvm_cpu_notify(struct not
 			      void *hcpu)
 {
 	int cpu = (long)hcpu;
+
+	/*
+	 * Xen guests do not offline/online CPUs during
+	 * suspend/resume, thus CPU_TASKS_FROZEN masked transitions
+	 * are not considered.
+	 */
+
 	switch (action) {
 	case CPU_UP_PREPARE:
 		xen_vcpu_setup(cpu);
--- a/drivers/xen/events/events_fifo.c
+++ b/drivers/xen/events/events_fifo.c
@@ -425,6 +425,12 @@ static int evtchn_fifo_cpu_notification(
 	int cpu = (long)hcpu;
 	int ret = 0;
 
+	/*
+	 * Xen guests do not offline/online CPUs during
+	 * suspend/resume, thus CPU_TASKS_FROZEN masked transitions
+	 * are not considered.
+	*/
+
 	switch (action) {
 	case CPU_UP_PREPARE:
 		if (!per_cpu(cpu_control_block, cpu))

             reply	other threads:[~2016-04-04 12:32 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-04-04 12:32 Anna-Maria Gleixner [this message]
2016-04-04 16:21 ` [PATCH] xen: Add comment for missing FROZEN notifier transitions Julien Grall
2016-04-04 16:21 ` [Xen-devel] " Julien Grall
2016-04-04 16:30   ` David Vrabel
2016-04-04 16:30   ` [Xen-devel] " David Vrabel
2016-04-04 16:48     ` Boris Ostrovsky
2016-04-04 16:48     ` [Xen-devel] " Boris Ostrovsky
2016-04-05  4:22       ` Juergen Gross
2016-04-06 23:52         ` Stefano Stabellini
2016-04-06 23:52         ` Stefano Stabellini
2016-04-05  4:22       ` Juergen Gross
2016-04-06 13:09 ` [Xen-devel] " David Vrabel
2016-04-06 14:08   ` [PREEMPT-RT] " Anna-Maria Gleixner
2016-04-06 14:08   ` [PREEMPT-RT] " Anna-Maria Gleixner
2016-04-06 23:53   ` Stefano Stabellini
2016-04-06 23:53   ` [Xen-devel] " Stefano Stabellini
2016-04-06 13:09 ` David Vrabel
  -- strict thread matches above, loose matches on Subject: below --
2016-04-04 12:32 Anna-Maria Gleixner

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1459773140-43707-1-git-send-email-anna-maria@linutronix.de \
    --to=anna-maria@linutronix.de \
    --cc=david.vrabel@citrix.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=rt@linutronix.de \
    --cc=stefano.stabellini@eu.citrix.com \
    --cc=xen-devel@lists.xenproject.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.