From: Stefano Stabellini <sstabellini@kernel.org>
To: Juergen Gross <jgross@suse.com>
Cc: sstabellini@kernel.org, linux-kernel@vger.kernel.org,
Julien Grall <julien.grall@arm.com>,
David Vrabel <david.vrabel@citrix.com>,
xen-devel@lists.xenproject.org,
Boris Ostrovsky <boris.ostrovsky@oracle.com>,
Anna-Maria Gleixner <anna-maria@linutronix.de>,
rt@linutronix.de
Subject: Re: [PATCH] xen: Add comment for missing FROZEN notifier transitions
Date: Wed, 6 Apr 2016 16:52:34 -0700 (PDT) [thread overview]
Message-ID: <alpine.DEB.2.10.1604061652230.31453__41565.9768194475$1459986917$gmane$org@sstabellini-ThinkPad-X230> (raw)
In-Reply-To: <57033D78.8010306@suse.com>
On Tue, 5 Apr 2016, Juergen Gross wrote:
> On 04/04/16 18:48, Boris Ostrovsky wrote:
> > On 04/04/2016 12:30 PM, David Vrabel wrote:
> >> On 04/04/16 17:21, Julien Grall wrote:
> >>> (CC Stefano new e-mail address)
> >>>
> >>> Hello Anna-Maria,
> >>>
> >>> On 04/04/2016 13:32, Anna-Maria Gleixner wrote:
> >>>> Xen guests do not offline/online CPUs during suspend/resume and
> >>>> therefore FROZEN notifier transitions are not required. Add this
> >>>> explanation as a comment in the code to get not confused why
> >>>> CPU_TASKS_FROZEN masked transitions are not considered.
> >> Alternatively, these could be added even if they are not encountered.
> >> This might be more future-proof but the documentation might be clearer.
> >>
> >> Boris, Juergen, any opinion?
>
> I'd rather do more than a comment:
>
> Either mask CPU_TASKS_FROZEN from action if it really doesn't matter
> whether the flag is set or not (which IMHO is the case here), or
> BUG_ON(action & CPU_TASKS_FROZEN) if this really should never happen.
I agree
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
http://lists.xen.org/xen-devel
next prev parent reply other threads:[~2016-04-06 23:52 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-04-04 12:32 [PATCH] xen: Add comment for missing FROZEN notifier transitions Anna-Maria Gleixner
2016-04-04 16:21 ` Julien Grall
2016-04-04 16:21 ` [Xen-devel] " Julien Grall
2016-04-04 16:30 ` David Vrabel
2016-04-04 16:30 ` [Xen-devel] " David Vrabel
2016-04-04 16:48 ` Boris Ostrovsky
2016-04-04 16:48 ` [Xen-devel] " Boris Ostrovsky
2016-04-05 4:22 ` Juergen Gross
2016-04-06 23:52 ` Stefano Stabellini
2016-04-06 23:52 ` Stefano Stabellini [this message]
2016-04-05 4:22 ` Juergen Gross
2016-04-06 13:09 ` [Xen-devel] " David Vrabel
2016-04-06 14:08 ` [PREEMPT-RT] " Anna-Maria Gleixner
2016-04-06 14:08 ` [PREEMPT-RT] " Anna-Maria Gleixner
2016-04-06 23:53 ` Stefano Stabellini
2016-04-06 23:53 ` [Xen-devel] " Stefano Stabellini
2016-04-06 13:09 ` David Vrabel
-- strict thread matches above, loose matches on Subject: below --
2016-04-04 12:32 Anna-Maria Gleixner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='alpine.DEB.2.10.1604061652230.31453__41565.9768194475$1459986917$gmane$org@sstabellini-ThinkPad-X230' \
--to=sstabellini@kernel.org \
--cc=anna-maria@linutronix.de \
--cc=boris.ostrovsky@oracle.com \
--cc=david.vrabel@citrix.com \
--cc=jgross@suse.com \
--cc=julien.grall@arm.com \
--cc=linux-kernel@vger.kernel.org \
--cc=rt@linutronix.de \
--cc=xen-devel@lists.xenproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.