[PATCH] gprs: Deactivate old contexts on attach

[PATCH] gprs: Deactivate old contexts on attach

[Alfonso Sanchez-Beato]

[-- Attachment #1: Type: text/plain, Size: 855 bytes --]

In some cases it is possible that a context is opened after a detach
event has been received, and right before an attach, depending on the
modem. We make sure that those contexts are removed to keep
consistency.
---
 src/gprs.c | 6 ++++++
 1 file changed, 6 insertions(+)

diff --git a/src/gprs.c b/src/gprs.c
index 3acb412..3a4a819 100644
--- a/src/gprs.c
+++ b/src/gprs.c
@@ -1624,6 +1624,12 @@ static void gprs_attached_update(struct ofono_gprs *gprs)
 		release_active_contexts(gprs);
 		gprs->bearer = -1;
 	} else if (have_active_contexts(gprs) == TRUE) {
+		/*
+		 * Some times the context activates after a detach event and
+		 * right before an attach. We close it to avoid unexpected open
+		 * contexts.
+		 */
+		release_active_contexts(gprs);
 		gprs->flags |= GPRS_FLAG_ATTACHED_UPDATE;
 		return;
 	}
-- 
2.5.0

Re: [PATCH] gprs: Deactivate old contexts on attach

[Denis Kenzior]

[-- Attachment #1: Type: text/plain, Size: 409 bytes --]

Hi Alfonso,

On 04/04/2016 11:11 AM, Alfonso Sanchez-Beato wrote:
> In some cases it is possible that a context is opened after a detach
> event has been received, and right before an attach, depending on the
> modem. We make sure that those contexts are removed to keep
> consistency.
> ---
>   src/gprs.c | 6 ++++++
>   1 file changed, 6 insertions(+)
>

Applied, thanks.

Regards,
-Denis