* [PATCH] ath9k: remove duplicate assignment of variable ah
@ 2016-04-10 11:25 ` Colin King
0 siblings, 0 replies; 10+ messages in thread
From: Colin King @ 2016-04-10 11:25 UTC (permalink / raw)
To: QCA ath9k Development, Kalle Valo, linux-wireless, ath9k-devel, netdev
Cc: linux-kernel
From: Colin Ian King <colin.king@canonical.com>
ah is written twice with the same value, remove one of the
redundant assignments to ah.
Signed-off-by: Colin Ian King <colin.king@canonical.com>
---
drivers/net/wireless/ath/ath9k/init.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/net/wireless/ath/ath9k/init.c b/drivers/net/wireless/ath/ath9k/init.c
index 77ace8d..fb702c4 100644
--- a/drivers/net/wireless/ath/ath9k/init.c
+++ b/drivers/net/wireless/ath/ath9k/init.c
@@ -477,7 +477,7 @@ static void ath9k_eeprom_request_cb(const struct firmware *eeprom_blob,
static int ath9k_eeprom_request(struct ath_softc *sc, const char *name)
{
struct ath9k_eeprom_ctx ec;
- struct ath_hw *ah = ah = sc->sc_ah;
+ struct ath_hw *ah = sc->sc_ah;
int err;
/* try to load the EEPROM content asynchronously */
--
2.7.4
^ permalink raw reply related [flat|nested] 10+ messages in thread
* [PATCH] ath9k: remove duplicate assignment of variable ah
@ 2016-04-10 11:25 ` Colin King
0 siblings, 0 replies; 10+ messages in thread
From: Colin King @ 2016-04-10 11:25 UTC (permalink / raw)
To: QCA ath9k Development, Kalle Valo, linux-wireless, ath9k-devel, netdev
Cc: linux-kernel
From: Colin Ian King <colin.king@canonical.com>
ah is written twice with the same value, remove one of the
redundant assignments to ah.
Signed-off-by: Colin Ian King <colin.king@canonical.com>
---
drivers/net/wireless/ath/ath9k/init.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/net/wireless/ath/ath9k/init.c b/drivers/net/wireless/ath/ath9k/init.c
index 77ace8d..fb702c4 100644
--- a/drivers/net/wireless/ath/ath9k/init.c
+++ b/drivers/net/wireless/ath/ath9k/init.c
@@ -477,7 +477,7 @@ static void ath9k_eeprom_request_cb(const struct firmware *eeprom_blob,
static int ath9k_eeprom_request(struct ath_softc *sc, const char *name)
{
struct ath9k_eeprom_ctx ec;
- struct ath_hw *ah = ah = sc->sc_ah;
+ struct ath_hw *ah = sc->sc_ah;
int err;
/* try to load the EEPROM content asynchronously */
--
2.7.4
^ permalink raw reply related [flat|nested] 10+ messages in thread
* [ath9k-devel] [PATCH] ath9k: remove duplicate assignment of variable ah
@ 2016-04-10 11:25 ` Colin King
0 siblings, 0 replies; 10+ messages in thread
From: Colin King @ 2016-04-10 11:25 UTC (permalink / raw)
To: ath9k-devel
From: Colin Ian King <colin.king@canonical.com>
ah is written twice with the same value, remove one of the
redundant assignments to ah.
Signed-off-by: Colin Ian King <colin.king@canonical.com>
---
drivers/net/wireless/ath/ath9k/init.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/net/wireless/ath/ath9k/init.c b/drivers/net/wireless/ath/ath9k/init.c
index 77ace8d..fb702c4 100644
--- a/drivers/net/wireless/ath/ath9k/init.c
+++ b/drivers/net/wireless/ath/ath9k/init.c
@@ -477,7 +477,7 @@ static void ath9k_eeprom_request_cb(const struct firmware *eeprom_blob,
static int ath9k_eeprom_request(struct ath_softc *sc, const char *name)
{
struct ath9k_eeprom_ctx ec;
- struct ath_hw *ah = ah = sc->sc_ah;
+ struct ath_hw *ah = sc->sc_ah;
int err;
/* try to load the EEPROM content asynchronously */
--
2.7.4
^ permalink raw reply related [flat|nested] 10+ messages in thread
* Re: [PATCH] ath9k: remove duplicate assignment of variable ah
2016-04-10 11:25 ` Colin King
(?)
@ 2016-04-11 1:39 ` Julian Calaby
-1 siblings, 0 replies; 10+ messages in thread
From: Julian Calaby @ 2016-04-11 1:39 UTC (permalink / raw)
To: Colin King
Cc: QCA ath9k Development, Kalle Valo, linux-wireless, ath9k-devel,
netdev, linux-kernel
Hi All,
On Sun, Apr 10, 2016 at 9:25 PM, Colin King <colin.king@canonical.com> wrote:
> From: Colin Ian King <colin.king@canonical.com>
>
> ah is written twice with the same value, remove one of the
> redundant assignments to ah.
>
> Signed-off-by: Colin Ian King <colin.king@canonical.com>
Looks right to me.
Signed-off-by: Julian Calaby <julian.calaby@gmail.com>
Thanks,
> ---
> drivers/net/wireless/ath/ath9k/init.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/net/wireless/ath/ath9k/init.c b/drivers/net/wireless/ath/ath9k/init.c
> index 77ace8d..fb702c4 100644
> --- a/drivers/net/wireless/ath/ath9k/init.c
> +++ b/drivers/net/wireless/ath/ath9k/init.c
> @@ -477,7 +477,7 @@ static void ath9k_eeprom_request_cb(const struct firmware *eeprom_blob,
> static int ath9k_eeprom_request(struct ath_softc *sc, const char *name)
> {
> struct ath9k_eeprom_ctx ec;
> - struct ath_hw *ah = ah = sc->sc_ah;
> + struct ath_hw *ah = sc->sc_ah;
> int err;
>
> /* try to load the EEPROM content asynchronously */
> --
> 2.7.4
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-wireless" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
--
Julian Calaby
Email: julian.calaby@gmail.com
Profile: http://www.google.com/profiles/julian.calaby/
^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [PATCH] ath9k: remove duplicate assignment of variable ah
@ 2016-04-11 1:39 ` Julian Calaby
0 siblings, 0 replies; 10+ messages in thread
From: Julian Calaby @ 2016-04-11 1:39 UTC (permalink / raw)
To: Colin King
Cc: QCA ath9k Development, Kalle Valo, linux-wireless, ath9k-devel,
netdev, linux-kernel
Hi All,
On Sun, Apr 10, 2016 at 9:25 PM, Colin King <colin.king@canonical.com> wrote:
> From: Colin Ian King <colin.king@canonical.com>
>
> ah is written twice with the same value, remove one of the
> redundant assignments to ah.
>
> Signed-off-by: Colin Ian King <colin.king@canonical.com>
Looks right to me.
Signed-off-by: Julian Calaby <julian.calaby@gmail.com>
Thanks,
> ---
> drivers/net/wireless/ath/ath9k/init.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/net/wireless/ath/ath9k/init.c b/drivers/net/wireless/ath/ath9k/init.c
> index 77ace8d..fb702c4 100644
> --- a/drivers/net/wireless/ath/ath9k/init.c
> +++ b/drivers/net/wireless/ath/ath9k/init.c
> @@ -477,7 +477,7 @@ static void ath9k_eeprom_request_cb(const struct firmware *eeprom_blob,
> static int ath9k_eeprom_request(struct ath_softc *sc, const char *name)
> {
> struct ath9k_eeprom_ctx ec;
> - struct ath_hw *ah = ah = sc->sc_ah;
> + struct ath_hw *ah = sc->sc_ah;
> int err;
>
> /* try to load the EEPROM content asynchronously */
> --
> 2.7.4
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-wireless" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
--
Julian Calaby
Email: julian.calaby@gmail.com
Profile: http://www.google.com/profiles/julian.calaby/
^ permalink raw reply [flat|nested] 10+ messages in thread
* [ath9k-devel] [PATCH] ath9k: remove duplicate assignment of variable ah
@ 2016-04-11 1:39 ` Julian Calaby
0 siblings, 0 replies; 10+ messages in thread
From: Julian Calaby @ 2016-04-11 1:39 UTC (permalink / raw)
To: ath9k-devel
Hi All,
On Sun, Apr 10, 2016 at 9:25 PM, Colin King <colin.king@canonical.com> wrote:
> From: Colin Ian King <colin.king@canonical.com>
>
> ah is written twice with the same value, remove one of the
> redundant assignments to ah.
>
> Signed-off-by: Colin Ian King <colin.king@canonical.com>
Looks right to me.
Signed-off-by: Julian Calaby <julian.calaby@gmail.com>
Thanks,
> ---
> drivers/net/wireless/ath/ath9k/init.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/net/wireless/ath/ath9k/init.c b/drivers/net/wireless/ath/ath9k/init.c
> index 77ace8d..fb702c4 100644
> --- a/drivers/net/wireless/ath/ath9k/init.c
> +++ b/drivers/net/wireless/ath/ath9k/init.c
> @@ -477,7 +477,7 @@ static void ath9k_eeprom_request_cb(const struct firmware *eeprom_blob,
> static int ath9k_eeprom_request(struct ath_softc *sc, const char *name)
> {
> struct ath9k_eeprom_ctx ec;
> - struct ath_hw *ah = ah = sc->sc_ah;
> + struct ath_hw *ah = sc->sc_ah;
> int err;
>
> /* try to load the EEPROM content asynchronously */
> --
> 2.7.4
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-wireless" in
> the body of a message to majordomo at vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
--
Julian Calaby
Email: julian.calaby at gmail.com
Profile: http://www.google.com/profiles/julian.calaby/
^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [PATCH] ath9k: remove duplicate assignment of variable ah
2016-04-10 11:25 ` Colin King
(?)
(?)
@ 2016-04-19 16:14 ` Kalle Valo
-1 siblings, 0 replies; 10+ messages in thread
From: Kalle Valo @ 2016-04-19 16:14 UTC (permalink / raw)
To: Colin King
Cc: QCA ath9k Development, linux-wireless, ath9k-devel, netdev, linux-kernel
Colin King <colin.king@canonical.com> writes:
> From: Colin Ian King <colin.king@canonical.com>
>
> ah is written twice with the same value, remove one of the
> redundant assignments to ah.
>
> Signed-off-by: Colin Ian King <colin.king@canonical.com>
Applied, thanks.
--
Kalle Valo
^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [PATCH] ath9k: remove duplicate assignment of variable ah
@ 2016-04-19 16:14 ` Kalle Valo
0 siblings, 0 replies; 10+ messages in thread
From: Kalle Valo @ 2016-04-19 16:14 UTC (permalink / raw)
To: Colin King
Cc: QCA ath9k Development, linux-wireless, ath9k-devel, netdev, linux-kernel
Colin King <colin.king@canonical.com> writes:
> From: Colin Ian King <colin.king@canonical.com>
>
> ah is written twice with the same value, remove one of the
> redundant assignments to ah.
>
> Signed-off-by: Colin Ian King <colin.king@canonical.com>
Applied, thanks.
--
Kalle Valo
^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [PATCH] ath9k: remove duplicate assignment of variable ah
@ 2016-04-19 16:14 ` Kalle Valo
0 siblings, 0 replies; 10+ messages in thread
From: Kalle Valo @ 2016-04-19 16:14 UTC (permalink / raw)
To: Colin King
Cc: netdev, ath9k-devel, linux-wireless, QCA ath9k Development, linux-kernel
Colin King <colin.king@canonical.com> writes:
> From: Colin Ian King <colin.king@canonical.com>
>
> ah is written twice with the same value, remove one of the
> redundant assignments to ah.
>
> Signed-off-by: Colin Ian King <colin.king@canonical.com>
Applied, thanks.
--
Kalle Valo
^ permalink raw reply [flat|nested] 10+ messages in thread
* [ath9k-devel] [PATCH] ath9k: remove duplicate assignment of variable ah
@ 2016-04-19 16:14 ` Kalle Valo
0 siblings, 0 replies; 10+ messages in thread
From: Kalle Valo @ 2016-04-19 16:14 UTC (permalink / raw)
To: ath9k-devel
Colin King <colin.king@canonical.com> writes:
> From: Colin Ian King <colin.king@canonical.com>
>
> ah is written twice with the same value, remove one of the
> redundant assignments to ah.
>
> Signed-off-by: Colin Ian King <colin.king@canonical.com>
Applied, thanks.
--
Kalle Valo
^ permalink raw reply [flat|nested] 10+ messages in thread
end of thread, other threads:[~2016-04-19 16:14 UTC | newest]
Thread overview: 10+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2016-04-10 11:25 [PATCH] ath9k: remove duplicate assignment of variable ah Colin King
2016-04-10 11:25 ` [ath9k-devel] " Colin King
2016-04-10 11:25 ` Colin King
2016-04-11 1:39 ` Julian Calaby
2016-04-11 1:39 ` [ath9k-devel] " Julian Calaby
2016-04-11 1:39 ` Julian Calaby
2016-04-19 16:14 ` Kalle Valo
2016-04-19 16:14 ` [ath9k-devel] " Kalle Valo
2016-04-19 16:14 ` Kalle Valo
2016-04-19 16:14 ` Kalle Valo
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.