[kvm-unit-tests PATCH] fix machine type handling for ppc64le

[kvm-unit-tests PATCH] fix machine type handling for ppc64le

[Lukáš Doktor]

Hello guys,

this mini-series fixes the "MACHINE" type handling in "mkstandalone"
and improves the UI message when kvm not available on ppc64.

[PATCH 1/2] scripts: Handle ppc64le machine name in mkstandalone

[Lukáš Doktor]

The query for machine type in `mkstandalone` is missing the `ppc64le`
fixture. This patch uses the version from `configure` which should
contain all fixtures.

Signed-off-by: Lukáš Doktor <ldoktor@redhat.com>
---
 scripts/mkstandalone.sh | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/scripts/mkstandalone.sh b/scripts/mkstandalone.sh
index ef15bc8..26094df 100755
--- a/scripts/mkstandalone.sh
+++ b/scripts/mkstandalone.sh
@@ -40,7 +40,7 @@ generate_test ()
 
 	echo "#!/bin/bash"
 	echo "export STANDALONE=yes"
-	echo "export HOST=\$(uname -m | sed -e s/i.86/i386/ | sed -e 's/arm.*/arm/')"
+	echo "export HOST=\$(uname -m | sed -e 's/i.86/i386/;s/arm.*/arm/;s/ppc64.*/ppc64/')"
 	echo "export PRETTY_PRINT_STACKS=no"
 
 	config_export ARCH
-- 
2.5.5

[PATCH 2/2] powerpc: Improve "kvm unavailable" message

[Lukáš Doktor]

The message when ACCEL=kvm and kvm not available is rather confusing.
Let's produce (hopefully) easier to understand message.

Signed-off-by: Lukáš Doktor <ldoktor@redhat.com>
---
 powerpc/run | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/powerpc/run b/powerpc/run
index 56698e6..adffb93 100755
--- a/powerpc/run
+++ b/powerpc/run
@@ -16,7 +16,7 @@ if [ -c /dev/kvm ]; then
 fi
 
 if [ "$ACCEL" = "kvm" ] && [ "$kvm_available" != "yes" ]; then
-	echo "skip $TESTNAME (kvm only)"
+	echo "skip $TESTNAME (kvm not available on your system)"
 	exit 2
 fi
 
-- 
2.5.5

Re: [PATCH 1/2] scripts: Handle ppc64le machine name in mkstandalone

[Andrew Jones]

On Mon, Apr 11, 2016 at 01:37:52PM +0200, Lukáš Doktor wrote:
> The query for machine type in `mkstandalone` is missing the `ppc64le`
> fixture. This patch uses the version from `configure` which should
> contain all fixtures.
> 
> Signed-off-by: Lukáš Doktor <ldoktor@redhat.com>
> ---
>  scripts/mkstandalone.sh | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)


Reviewed-by: Andrew Jones <drjones@redhat.com>

> 
> diff --git a/scripts/mkstandalone.sh b/scripts/mkstandalone.sh
> index ef15bc8..26094df 100755
> --- a/scripts/mkstandalone.sh
> +++ b/scripts/mkstandalone.sh
> @@ -40,7 +40,7 @@ generate_test ()
>  
>  	echo "#!/bin/bash"
>  	echo "export STANDALONE=yes"
> -	echo "export HOST=\$(uname -m | sed -e s/i.86/i386/ | sed -e 's/arm.*/arm/')"
> +	echo "export HOST=\$(uname -m | sed -e 's/i.86/i386/;s/arm.*/arm/;s/ppc64.*/ppc64/')"
>  	echo "export PRETTY_PRINT_STACKS=no"
>  
>  	config_export ARCH
> -- 
> 2.5.5
> 

Re: [PATCH 2/2] powerpc: Improve "kvm unavailable" message

[Andrew Jones]

On Mon, Apr 11, 2016 at 01:37:53PM +0200, Lukáš Doktor wrote:
> The message when ACCEL=kvm and kvm not available is rather confusing.
> Let's produce (hopefully) easier to understand message.
> 
> Signed-off-by: Lukáš Doktor <ldoktor@redhat.com>
> ---
>  powerpc/run | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/powerpc/run b/powerpc/run
> index 56698e6..adffb93 100755
> --- a/powerpc/run
> +++ b/powerpc/run
> @@ -16,7 +16,7 @@ if [ -c /dev/kvm ]; then
>  fi
>  
>  if [ "$ACCEL" = "kvm" ] && [ "$kvm_available" != "yes" ]; then
> -	echo "skip $TESTNAME (kvm only)"
> +	echo "skip $TESTNAME (kvm not available on your system)"

This will now be inconsistent with scripts/runtime.bash. Also,
the 'kvm only' message conveys that this test can only run with
kvm, as opposed to also with tcg. While I agree it's terse, we've
now lost that information with the new message. Additionally, I
would say 'this system' instead of 'your system' in the message.

I think Radim has some plans for giving run script error messages
an overhaul. Maybe he can address this one with that series too?
Anyway, for now, I would suggest we drop this patch.

Thanks,
drew

>  	exit 2
>  fi
>  
> -- 
> 2.5.5
> 

Re: [PATCH 2/2] powerpc: Improve "kvm unavailable" message

[Lukáš Doktor]

Dne 11.4.2016 v 14:02 Andrew Jones napsal(a):
> On Mon, Apr 11, 2016 at 01:37:53PM +0200, Lukáš Doktor wrote:
>> The message when ACCEL=kvm and kvm not available is rather confusing.
>> Let's produce (hopefully) easier to understand message.
>>
>> Signed-off-by: Lukáš Doktor <ldoktor@redhat.com>
>> ---
>>   powerpc/run | 2 +-
>>   1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/powerpc/run b/powerpc/run
>> index 56698e6..adffb93 100755
>> --- a/powerpc/run
>> +++ b/powerpc/run
>> @@ -16,7 +16,7 @@ if [ -c /dev/kvm ]; then
>>   fi
>>
>>   if [ "$ACCEL" = "kvm" ] && [ "$kvm_available" != "yes" ]; then
>> -	echo "skip $TESTNAME (kvm only)"
>> +	echo "skip $TESTNAME (kvm not available on your system)"
>
> This will now be inconsistent with scripts/runtime.bash. Also,
> the 'kvm only' message conveys that this test can only run with
> kvm, as opposed to also with tcg. While I agree it's terse, we've
> now lost that information with the new message. Additionally, I
> would say 'this system' instead of 'your system' in the message.
>
> I think Radim has some plans for giving run script error messages
> an overhaul. Maybe he can address this one with that series too?
> Anyway, for now, I would suggest we drop this patch.
>
I thought the message probably has some inner-context, but for me it was 
super confusing. Even more because I'm using

     ACCEL=kvm,kvm-type=PR ...

in some of my power testing, which works well, but when I tried

     ACCEL=kvm ...

it reported test skips. I'm looking forward to some proper errors 
handling (and ways to pass SKIPs as well).

Thank you and feel free to drop this patch,
Lukáš

> Thanks,
> drew
>
>>   	exit 2
>>   fi
>>
>> --
>> 2.5.5
>>

Re: [PATCH 1/2] scripts: Handle ppc64le machine name in mkstandalone

[Paolo Bonzini]

On 11/04/2016 13:37, Lukáš Doktor wrote:
> The query for machine type in `mkstandalone` is missing the `ppc64le`
> fixture. This patch uses the version from `configure` which should
> contain all fixtures.
> 
> Signed-off-by: Lukáš Doktor <ldoktor@redhat.com>
> ---
>  scripts/mkstandalone.sh | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/scripts/mkstandalone.sh b/scripts/mkstandalone.sh
> index ef15bc8..26094df 100755
> --- a/scripts/mkstandalone.sh
> +++ b/scripts/mkstandalone.sh
> @@ -40,7 +40,7 @@ generate_test ()
>  
>  	echo "#!/bin/bash"
>  	echo "export STANDALONE=yes"
> -	echo "export HOST=\$(uname -m | sed -e s/i.86/i386/ | sed -e 's/arm.*/arm/')"
> +	echo "export HOST=\$(uname -m | sed -e 's/i.86/i386/;s/arm.*/arm/;s/ppc64.*/ppc64/')"
>  	echo "export PRETTY_PRINT_STACKS=no"
>  
>  	config_export ARCH
> 

Queued this one, thanks.

Paolo