* [U-Boot] [PATCH 1/2] net: fix vlan validation
@ 2016-04-12 23:09 Stefan Agner
2016-04-12 23:09 ` [U-Boot] [PATCH 2/2] net: increase maximum frame size to accomediate VLAN packets Stefan Agner
0 siblings, 1 reply; 6+ messages in thread
From: Stefan Agner @ 2016-04-12 23:09 UTC (permalink / raw)
To: u-boot
VLAN identifiers are 12-bit decimal numbers, not IP addresses.
Signed-off-by: Stefan Agner <stefan@agner.ch>
---
include/env_flags.h | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/include/env_flags.h b/include/env_flags.h
index 9e87e1b..0dcec06 100644
--- a/include/env_flags.h
+++ b/include/env_flags.h
@@ -57,8 +57,8 @@ enum env_flags_varaccess {
"gatewayip:i," \
"netmask:i," \
"serverip:i," \
- "nvlan:i," \
- "vlan:i," \
+ "nvlan:d," \
+ "vlan:d," \
"dnsip:i,"
#else
#define ETHADDR_FLAGS
--
2.8.0
^ permalink raw reply related [flat|nested] 6+ messages in thread
* [U-Boot] [PATCH 2/2] net: increase maximum frame size to accomediate VLAN packets
2016-04-12 23:09 [U-Boot] [PATCH 1/2] net: fix vlan validation Stefan Agner
@ 2016-04-12 23:09 ` Stefan Agner
2016-04-13 20:33 ` Tom Rini
0 siblings, 1 reply; 6+ messages in thread
From: Stefan Agner @ 2016-04-12 23:09 UTC (permalink / raw)
To: u-boot
Ethernet packages with IEEE 802.1Q VLAN support may be up to 1522
bytes long. Increase the default size used to allocate packet
storage by 4 bytes.
Signed-off-by: Stefan Agner <stefan@agner.ch>
---
include/net.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/include/net.h b/include/net.h
index 1fb4194..a97e530 100644
--- a/include/net.h
+++ b/include/net.h
@@ -476,7 +476,7 @@ struct icmp_hdr {
* maximum packet size = 1518
* maximum packet size and multiple of 32 bytes = 1536
*/
-#define PKTSIZE 1518
+#define PKTSIZE 1522
#define PKTSIZE_ALIGN 1536
/*#define PKTSIZE 608*/
--
2.8.0
^ permalink raw reply related [flat|nested] 6+ messages in thread
* [U-Boot] [PATCH 2/2] net: increase maximum frame size to accomediate VLAN packets
2016-04-12 23:09 ` [U-Boot] [PATCH 2/2] net: increase maximum frame size to accomediate VLAN packets Stefan Agner
@ 2016-04-13 20:33 ` Tom Rini
0 siblings, 0 replies; 6+ messages in thread
From: Tom Rini @ 2016-04-13 20:33 UTC (permalink / raw)
To: u-boot
On Tue, Apr 12, 2016 at 04:09:50PM -0700, Stefan Agner wrote:
> Ethernet packages with IEEE 802.1Q VLAN support may be up to 1522
> bytes long. Increase the default size used to allocate packet
> storage by 4 bytes.
>
> Signed-off-by: Stefan Agner <stefan@agner.ch>
> ---
>
> include/net.h | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/include/net.h b/include/net.h
> index 1fb4194..a97e530 100644
> --- a/include/net.h
> +++ b/include/net.h
> @@ -476,7 +476,7 @@ struct icmp_hdr {
> * maximum packet size = 1518
This comment is now wrong too, please update or maybe add:
* maximum packet size and VLAN header = 1522
> * maximum packet size and multiple of 32 bytes = 1536
> */
> -#define PKTSIZE 1518
> +#define PKTSIZE 1522
> #define PKTSIZE_ALIGN 1536
> /*#define PKTSIZE 608*/
>
> --
> 2.8.0
>
> _______________________________________________
> U-Boot mailing list
> U-Boot at lists.denx.de
> http://lists.denx.de/mailman/listinfo/u-boot
--
Tom
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: Digital signature
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20160413/2398ddda/attachment.sig>
^ permalink raw reply [flat|nested] 6+ messages in thread
* [U-Boot] [PATCH 1/2] net: fix vlan validation
2016-04-13 23:38 [U-Boot] [PATCH 1/2] net: fix vlan validation Stefan Agner
2016-04-16 1:13 ` Tom Rini
@ 2016-04-25 21:44 ` Joe Hershberger
1 sibling, 0 replies; 6+ messages in thread
From: Joe Hershberger @ 2016-04-25 21:44 UTC (permalink / raw)
To: u-boot
On Wed, Apr 13, 2016 at 6:38 PM, Stefan Agner <stefan@agner.ch> wrote:
> VLAN identifiers are 12-bit decimal numbers, not IP addresses.
>
> Signed-off-by: Stefan Agner <stefan@agner.ch>
Acked-by: Joe Hershberger <joe.hershberger@ni.com>
^ permalink raw reply [flat|nested] 6+ messages in thread
* [U-Boot] [PATCH 1/2] net: fix vlan validation
2016-04-13 23:38 [U-Boot] [PATCH 1/2] net: fix vlan validation Stefan Agner
@ 2016-04-16 1:13 ` Tom Rini
2016-04-25 21:44 ` Joe Hershberger
1 sibling, 0 replies; 6+ messages in thread
From: Tom Rini @ 2016-04-16 1:13 UTC (permalink / raw)
To: u-boot
On Wed, Apr 13, 2016 at 04:38:01PM -0700, Stefan Agner wrote:
> VLAN identifiers are 12-bit decimal numbers, not IP addresses.
>
> Signed-off-by: Stefan Agner <stefan@agner.ch>
Reviewed-by: Tom Rini <trini@konsulko.com>
--
Tom
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: Digital signature
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20160415/1340745d/attachment.sig>
^ permalink raw reply [flat|nested] 6+ messages in thread
* [U-Boot] [PATCH 1/2] net: fix vlan validation
@ 2016-04-13 23:38 Stefan Agner
2016-04-16 1:13 ` Tom Rini
2016-04-25 21:44 ` Joe Hershberger
0 siblings, 2 replies; 6+ messages in thread
From: Stefan Agner @ 2016-04-13 23:38 UTC (permalink / raw)
To: u-boot
VLAN identifiers are 12-bit decimal numbers, not IP addresses.
Signed-off-by: Stefan Agner <stefan@agner.ch>
---
include/env_flags.h | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/include/env_flags.h b/include/env_flags.h
index 9e87e1b..0dcec06 100644
--- a/include/env_flags.h
+++ b/include/env_flags.h
@@ -57,8 +57,8 @@ enum env_flags_varaccess {
"gatewayip:i," \
"netmask:i," \
"serverip:i," \
- "nvlan:i," \
- "vlan:i," \
+ "nvlan:d," \
+ "vlan:d," \
"dnsip:i,"
#else
#define ETHADDR_FLAGS
--
2.8.0
^ permalink raw reply related [flat|nested] 6+ messages in thread
end of thread, other threads:[~2016-04-25 21:44 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2016-04-12 23:09 [U-Boot] [PATCH 1/2] net: fix vlan validation Stefan Agner
2016-04-12 23:09 ` [U-Boot] [PATCH 2/2] net: increase maximum frame size to accomediate VLAN packets Stefan Agner
2016-04-13 20:33 ` Tom Rini
2016-04-13 23:38 [U-Boot] [PATCH 1/2] net: fix vlan validation Stefan Agner
2016-04-16 1:13 ` Tom Rini
2016-04-25 21:44 ` Joe Hershberger
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.