* [PATCH 00/10] iio: fix errors reported by checkpatch.pl
@ 2016-04-14 19:36 ` Slawomir Stepien
0 siblings, 0 replies; 48+ messages in thread
From: Slawomir Stepien @ 2016-04-14 19:36 UTC (permalink / raw)
To: jic23, knaack.h, pmeerw; +Cc: linux-iio, kernel-janitors, Slawomir Stepien
Simple fixes of errors reported by checkpatch.pl.
Slawomir Stepien (10):
iio: light apds9960: fix wrong use of brace
iio: inkern: add a missing space before if
iio: adc: vf610_adc: fix case label indent
iio: adc: mcp3422: remove spaces before comma
iio: adc: at91_adc: fix errors reported by checkpatch.pl
iio: adc: ad799x: remove space before comma
iio: common: ms_sensors: use tab for indention
iio: common: hid-sensors: use tab for indention
iio: magnetometer: ak8975: put else and brace at the same line
iio: pressure: ms5611: use tab for indention
drivers/iio/adc/ad799x.c | 2 +-
drivers/iio/adc/at91_adc.c | 8 ++++----
drivers/iio/adc/mcp3422.c | 6 +++---
drivers/iio/adc/vf610_adc.c | 24 +++++++++++-----------
.../iio/common/hid-sensors/hid-sensor-trigger.c | 2 +-
drivers/iio/common/ms_sensors/ms_sensors_i2c.c | 2 +-
drivers/iio/inkern.c | 2 +-
drivers/iio/light/apds9960.c | 8 ++++++--
drivers/iio/magnetometer/ak8975.c | 3 +--
drivers/iio/pressure/ms5611_core.c | 2 +-
drivers/iio/pressure/ms5611_spi.c | 2 +-
11 files changed, 32 insertions(+), 29 deletions(-)
--
2.8.0
^ permalink raw reply [flat|nested] 48+ messages in thread
* [PATCH 00/10] iio: fix errors reported by checkpatch.pl
@ 2016-04-14 19:36 ` Slawomir Stepien
0 siblings, 0 replies; 48+ messages in thread
From: Slawomir Stepien @ 2016-04-14 19:36 UTC (permalink / raw)
To: jic23, knaack.h, pmeerw; +Cc: linux-iio, kernel-janitors, Slawomir Stepien
Simple fixes of errors reported by checkpatch.pl.
Slawomir Stepien (10):
iio: light apds9960: fix wrong use of brace
iio: inkern: add a missing space before if
iio: adc: vf610_adc: fix case label indent
iio: adc: mcp3422: remove spaces before comma
iio: adc: at91_adc: fix errors reported by checkpatch.pl
iio: adc: ad799x: remove space before comma
iio: common: ms_sensors: use tab for indention
iio: common: hid-sensors: use tab for indention
iio: magnetometer: ak8975: put else and brace at the same line
iio: pressure: ms5611: use tab for indention
drivers/iio/adc/ad799x.c | 2 +-
drivers/iio/adc/at91_adc.c | 8 ++++----
drivers/iio/adc/mcp3422.c | 6 +++---
drivers/iio/adc/vf610_adc.c | 24 +++++++++++-----------
.../iio/common/hid-sensors/hid-sensor-trigger.c | 2 +-
drivers/iio/common/ms_sensors/ms_sensors_i2c.c | 2 +-
drivers/iio/inkern.c | 2 +-
drivers/iio/light/apds9960.c | 8 ++++++--
drivers/iio/magnetometer/ak8975.c | 3 +--
drivers/iio/pressure/ms5611_core.c | 2 +-
drivers/iio/pressure/ms5611_spi.c | 2 +-
11 files changed, 32 insertions(+), 29 deletions(-)
--
2.8.0
^ permalink raw reply [flat|nested] 48+ messages in thread
* [PATCH 01/10] iio: light apds9960: fix wrong use of brace
2016-04-14 19:36 ` Slawomir Stepien
@ 2016-04-14 19:36 ` Slawomir Stepien
-1 siblings, 0 replies; 48+ messages in thread
From: Slawomir Stepien @ 2016-04-14 19:36 UTC (permalink / raw)
To: jic23, knaack.h, pmeerw; +Cc: linux-iio, kernel-janitors, Slawomir Stepien
This fixes the error reported by checkpatch.pl:
ERROR: that open brace { should be on the previous line
Signed-off-by: Slawomir Stepien <sst@poczta.fm>
---
drivers/iio/light/apds9960.c | 8 ++++++--
1 file changed, 6 insertions(+), 2 deletions(-)
diff --git a/drivers/iio/light/apds9960.c b/drivers/iio/light/apds9960.c
index a6af56a..ade18aa 100644
--- a/drivers/iio/light/apds9960.c
+++ b/drivers/iio/light/apds9960.c
@@ -321,8 +321,12 @@ static const struct iio_chan_spec apds9960_channels[] = {
};
/* integration time in us */
-static const int apds9960_int_time[][2] - { {28000, 246}, {100000, 219}, {200000, 182}, {700000, 0} };
+static const int apds9960_int_time[][2] = {
+ { 28000, 246},
+ {100000, 219},
+ {200000, 182},
+ {700000, 0}
+};
/* gain mapping */
static const int apds9960_pxs_gain_map[] = {1, 2, 4, 8};
--
2.8.0
^ permalink raw reply related [flat|nested] 48+ messages in thread
* [PATCH 01/10] iio: light apds9960: fix wrong use of brace
@ 2016-04-14 19:36 ` Slawomir Stepien
0 siblings, 0 replies; 48+ messages in thread
From: Slawomir Stepien @ 2016-04-14 19:36 UTC (permalink / raw)
To: jic23, knaack.h, pmeerw; +Cc: linux-iio, kernel-janitors, Slawomir Stepien
This fixes the error reported by checkpatch.pl:
ERROR: that open brace { should be on the previous line
Signed-off-by: Slawomir Stepien <sst@poczta.fm>
---
drivers/iio/light/apds9960.c | 8 ++++++--
1 file changed, 6 insertions(+), 2 deletions(-)
diff --git a/drivers/iio/light/apds9960.c b/drivers/iio/light/apds9960.c
index a6af56a..ade18aa 100644
--- a/drivers/iio/light/apds9960.c
+++ b/drivers/iio/light/apds9960.c
@@ -321,8 +321,12 @@ static const struct iio_chan_spec apds9960_channels[] = {
};
/* integration time in us */
-static const int apds9960_int_time[][2] =
- { {28000, 246}, {100000, 219}, {200000, 182}, {700000, 0} };
+static const int apds9960_int_time[][2] = {
+ { 28000, 246},
+ {100000, 219},
+ {200000, 182},
+ {700000, 0}
+};
/* gain mapping */
static const int apds9960_pxs_gain_map[] = {1, 2, 4, 8};
--
2.8.0
^ permalink raw reply related [flat|nested] 48+ messages in thread
* [PATCH 02/10] iio: inkern: add a missing space before if
2016-04-14 19:36 ` Slawomir Stepien
@ 2016-04-14 19:36 ` Slawomir Stepien
-1 siblings, 0 replies; 48+ messages in thread
From: Slawomir Stepien @ 2016-04-14 19:36 UTC (permalink / raw)
To: jic23, knaack.h, pmeerw; +Cc: linux-iio, kernel-janitors, Slawomir Stepien
This fixes the error reported by checkpatch.pl:
ERROR: space required before the open parenthesis '('
Signed-off-by: Slawomir Stepien <sst@poczta.fm>
---
drivers/iio/inkern.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/iio/inkern.c b/drivers/iio/inkern.c
index 734a004..2fc7928 100644
--- a/drivers/iio/inkern.c
+++ b/drivers/iio/inkern.c
@@ -452,7 +452,7 @@ static int iio_channel_read(struct iio_channel *chan, int *val, int *val2,
if (val2 = NULL)
val2 = &unused;
- if(!iio_channel_has_info(chan->channel, info))
+ if (!iio_channel_has_info(chan->channel, info))
return -EINVAL;
if (chan->indio_dev->info->read_raw_multi) {
--
2.8.0
^ permalink raw reply related [flat|nested] 48+ messages in thread
* [PATCH 02/10] iio: inkern: add a missing space before if
@ 2016-04-14 19:36 ` Slawomir Stepien
0 siblings, 0 replies; 48+ messages in thread
From: Slawomir Stepien @ 2016-04-14 19:36 UTC (permalink / raw)
To: jic23, knaack.h, pmeerw; +Cc: linux-iio, kernel-janitors, Slawomir Stepien
This fixes the error reported by checkpatch.pl:
ERROR: space required before the open parenthesis '('
Signed-off-by: Slawomir Stepien <sst@poczta.fm>
---
drivers/iio/inkern.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/iio/inkern.c b/drivers/iio/inkern.c
index 734a004..2fc7928 100644
--- a/drivers/iio/inkern.c
+++ b/drivers/iio/inkern.c
@@ -452,7 +452,7 @@ static int iio_channel_read(struct iio_channel *chan, int *val, int *val2,
if (val2 == NULL)
val2 = &unused;
- if(!iio_channel_has_info(chan->channel, info))
+ if (!iio_channel_has_info(chan->channel, info))
return -EINVAL;
if (chan->indio_dev->info->read_raw_multi) {
--
2.8.0
^ permalink raw reply related [flat|nested] 48+ messages in thread
* [PATCH 03/10] iio: adc: vf610_adc: fix case label indent
2016-04-14 19:36 ` Slawomir Stepien
@ 2016-04-14 19:36 ` Slawomir Stepien
-1 siblings, 0 replies; 48+ messages in thread
From: Slawomir Stepien @ 2016-04-14 19:36 UTC (permalink / raw)
To: jic23, knaack.h, pmeerw; +Cc: linux-iio, kernel-janitors, Slawomir Stepien
This fixes the error reported by checkpatch.pl:
ERROR: switch and case should be at the same indent
Signed-off-by: Slawomir Stepien <sst@poczta.fm>
---
drivers/iio/adc/vf610_adc.c | 24 ++++++++++++------------
1 file changed, 12 insertions(+), 12 deletions(-)
diff --git a/drivers/iio/adc/vf610_adc.c b/drivers/iio/adc/vf610_adc.c
index b10f629..653bf13 100644
--- a/drivers/iio/adc/vf610_adc.c
+++ b/drivers/iio/adc/vf610_adc.c
@@ -714,19 +714,19 @@ static int vf610_write_raw(struct iio_dev *indio_dev,
int i;
switch (mask) {
- case IIO_CHAN_INFO_SAMP_FREQ:
- for (i = 0;
- i < ARRAY_SIZE(info->sample_freq_avail);
- i++)
- if (val = info->sample_freq_avail[i]) {
- info->adc_feature.sample_rate = i;
- vf610_adc_sample_set(info);
- return 0;
- }
- break;
+ case IIO_CHAN_INFO_SAMP_FREQ:
+ for (i = 0;
+ i < ARRAY_SIZE(info->sample_freq_avail);
+ i++)
+ if (val = info->sample_freq_avail[i]) {
+ info->adc_feature.sample_rate = i;
+ vf610_adc_sample_set(info);
+ return 0;
+ }
+ break;
- default:
- break;
+ default:
+ break;
}
return -EINVAL;
--
2.8.0
^ permalink raw reply related [flat|nested] 48+ messages in thread
* [PATCH 03/10] iio: adc: vf610_adc: fix case label indent
@ 2016-04-14 19:36 ` Slawomir Stepien
0 siblings, 0 replies; 48+ messages in thread
From: Slawomir Stepien @ 2016-04-14 19:36 UTC (permalink / raw)
To: jic23, knaack.h, pmeerw; +Cc: linux-iio, kernel-janitors, Slawomir Stepien
This fixes the error reported by checkpatch.pl:
ERROR: switch and case should be at the same indent
Signed-off-by: Slawomir Stepien <sst@poczta.fm>
---
drivers/iio/adc/vf610_adc.c | 24 ++++++++++++------------
1 file changed, 12 insertions(+), 12 deletions(-)
diff --git a/drivers/iio/adc/vf610_adc.c b/drivers/iio/adc/vf610_adc.c
index b10f629..653bf13 100644
--- a/drivers/iio/adc/vf610_adc.c
+++ b/drivers/iio/adc/vf610_adc.c
@@ -714,19 +714,19 @@ static int vf610_write_raw(struct iio_dev *indio_dev,
int i;
switch (mask) {
- case IIO_CHAN_INFO_SAMP_FREQ:
- for (i = 0;
- i < ARRAY_SIZE(info->sample_freq_avail);
- i++)
- if (val == info->sample_freq_avail[i]) {
- info->adc_feature.sample_rate = i;
- vf610_adc_sample_set(info);
- return 0;
- }
- break;
+ case IIO_CHAN_INFO_SAMP_FREQ:
+ for (i = 0;
+ i < ARRAY_SIZE(info->sample_freq_avail);
+ i++)
+ if (val == info->sample_freq_avail[i]) {
+ info->adc_feature.sample_rate = i;
+ vf610_adc_sample_set(info);
+ return 0;
+ }
+ break;
- default:
- break;
+ default:
+ break;
}
return -EINVAL;
--
2.8.0
^ permalink raw reply related [flat|nested] 48+ messages in thread
* [PATCH 04/10] iio: adc: mcp3422: remove spaces before comma
2016-04-14 19:36 ` Slawomir Stepien
@ 2016-04-14 19:36 ` Slawomir Stepien
-1 siblings, 0 replies; 48+ messages in thread
From: Slawomir Stepien @ 2016-04-14 19:36 UTC (permalink / raw)
To: jic23, knaack.h, pmeerw; +Cc: linux-iio, kernel-janitors, Slawomir Stepien
This fixes the error reported by checkpatch.pl:
ERROR: space prohibited before that ',' (ctx:WxW)
Signed-off-by: Slawomir Stepien <sst@poczta.fm>
---
drivers/iio/adc/mcp3422.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/drivers/iio/adc/mcp3422.c b/drivers/iio/adc/mcp3422.c
index d7b36ef..d1172dc 100644
--- a/drivers/iio/adc/mcp3422.c
+++ b/drivers/iio/adc/mcp3422.c
@@ -61,9 +61,9 @@
static const int mcp3422_scales[4][4] = {
{ 1000000, 500000, 250000, 125000 },
- { 250000 , 125000, 62500 , 31250 },
- { 62500 , 31250 , 15625 , 7812 },
- { 15625 , 7812 , 3906 , 1953 } };
+ { 250000, 125000, 62500, 31250 },
+ { 62500, 31250, 15625, 7812 },
+ { 15625, 7812, 3906, 1953 } };
/* Constant msleep times for data acquisitions */
static const int mcp3422_read_times[4] = {
--
2.8.0
^ permalink raw reply related [flat|nested] 48+ messages in thread
* [PATCH 04/10] iio: adc: mcp3422: remove spaces before comma
@ 2016-04-14 19:36 ` Slawomir Stepien
0 siblings, 0 replies; 48+ messages in thread
From: Slawomir Stepien @ 2016-04-14 19:36 UTC (permalink / raw)
To: jic23, knaack.h, pmeerw; +Cc: linux-iio, kernel-janitors, Slawomir Stepien
This fixes the error reported by checkpatch.pl:
ERROR: space prohibited before that ',' (ctx:WxW)
Signed-off-by: Slawomir Stepien <sst@poczta.fm>
---
drivers/iio/adc/mcp3422.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/drivers/iio/adc/mcp3422.c b/drivers/iio/adc/mcp3422.c
index d7b36ef..d1172dc 100644
--- a/drivers/iio/adc/mcp3422.c
+++ b/drivers/iio/adc/mcp3422.c
@@ -61,9 +61,9 @@
static const int mcp3422_scales[4][4] = {
{ 1000000, 500000, 250000, 125000 },
- { 250000 , 125000, 62500 , 31250 },
- { 62500 , 31250 , 15625 , 7812 },
- { 15625 , 7812 , 3906 , 1953 } };
+ { 250000, 125000, 62500, 31250 },
+ { 62500, 31250, 15625, 7812 },
+ { 15625, 7812, 3906, 1953 } };
/* Constant msleep times for data acquisitions */
static const int mcp3422_read_times[4] = {
--
2.8.0
^ permalink raw reply related [flat|nested] 48+ messages in thread
* [PATCH 05/10] iio: adc: at91_adc: fix errors reported by checkpatch.pl
2016-04-14 19:36 ` Slawomir Stepien
@ 2016-04-14 19:36 ` Slawomir Stepien
-1 siblings, 0 replies; 48+ messages in thread
From: Slawomir Stepien @ 2016-04-14 19:36 UTC (permalink / raw)
To: jic23, knaack.h, pmeerw; +Cc: linux-iio, kernel-janitors, Slawomir Stepien
This fixes the errors reported by checkpatch.pl:
ERROR: space prohibited before that ',' (ctx:WxW)
ERROR: code indent should use tabs where possible
Signed-off-by: Slawomir Stepien <sst@poczta.fm>
---
drivers/iio/adc/at91_adc.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/drivers/iio/adc/at91_adc.c b/drivers/iio/adc/at91_adc.c
index f284cd6..52430ba 100644
--- a/drivers/iio/adc/at91_adc.c
+++ b/drivers/iio/adc/at91_adc.c
@@ -797,8 +797,8 @@ static u32 calc_startup_ticks_9x5(u32 startup_time, u32 adc_clk_khz)
* Startup Time = <lookup_table_value> / ADC Clock
*/
const int startup_lookup[] = {
- 0 , 8 , 16 , 24 ,
- 64 , 80 , 96 , 112,
+ 0, 8, 16, 24,
+ 64, 80, 96, 112,
512, 576, 640, 704,
768, 832, 896, 960
};
@@ -924,14 +924,14 @@ static int at91_adc_probe_dt(struct at91_adc_state *st,
ret = -EINVAL;
goto error_ret;
}
- trig->name = name;
+ trig->name = name;
if (of_property_read_u32(trig_node, "trigger-value", &prop)) {
dev_err(&idev->dev, "Missing trigger-value property in the DT.\n");
ret = -EINVAL;
goto error_ret;
}
- trig->value = prop;
+ trig->value = prop;
trig->is_external = of_property_read_bool(trig_node, "trigger-external");
i++;
}
--
2.8.0
^ permalink raw reply related [flat|nested] 48+ messages in thread
* [PATCH 05/10] iio: adc: at91_adc: fix errors reported by checkpatch.pl
@ 2016-04-14 19:36 ` Slawomir Stepien
0 siblings, 0 replies; 48+ messages in thread
From: Slawomir Stepien @ 2016-04-14 19:36 UTC (permalink / raw)
To: jic23, knaack.h, pmeerw; +Cc: linux-iio, kernel-janitors, Slawomir Stepien
This fixes the errors reported by checkpatch.pl:
ERROR: space prohibited before that ',' (ctx:WxW)
ERROR: code indent should use tabs where possible
Signed-off-by: Slawomir Stepien <sst@poczta.fm>
---
drivers/iio/adc/at91_adc.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/drivers/iio/adc/at91_adc.c b/drivers/iio/adc/at91_adc.c
index f284cd6..52430ba 100644
--- a/drivers/iio/adc/at91_adc.c
+++ b/drivers/iio/adc/at91_adc.c
@@ -797,8 +797,8 @@ static u32 calc_startup_ticks_9x5(u32 startup_time, u32 adc_clk_khz)
* Startup Time = <lookup_table_value> / ADC Clock
*/
const int startup_lookup[] = {
- 0 , 8 , 16 , 24 ,
- 64 , 80 , 96 , 112,
+ 0, 8, 16, 24,
+ 64, 80, 96, 112,
512, 576, 640, 704,
768, 832, 896, 960
};
@@ -924,14 +924,14 @@ static int at91_adc_probe_dt(struct at91_adc_state *st,
ret = -EINVAL;
goto error_ret;
}
- trig->name = name;
+ trig->name = name;
if (of_property_read_u32(trig_node, "trigger-value", &prop)) {
dev_err(&idev->dev, "Missing trigger-value property in the DT.\n");
ret = -EINVAL;
goto error_ret;
}
- trig->value = prop;
+ trig->value = prop;
trig->is_external = of_property_read_bool(trig_node, "trigger-external");
i++;
}
--
2.8.0
^ permalink raw reply related [flat|nested] 48+ messages in thread
* [PATCH 06/10] iio: adc: ad799x: remove space before comma
2016-04-14 19:36 ` Slawomir Stepien
@ 2016-04-14 19:36 ` Slawomir Stepien
-1 siblings, 0 replies; 48+ messages in thread
From: Slawomir Stepien @ 2016-04-14 19:36 UTC (permalink / raw)
To: jic23, knaack.h, pmeerw; +Cc: linux-iio, kernel-janitors, Slawomir Stepien
This fixes the error reported by checkpatch.pl:
ERROR: space prohibited before that ',' (ctx:WxW)
Signed-off-by: Slawomir Stepien <sst@poczta.fm>
---
drivers/iio/adc/ad799x.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/iio/adc/ad799x.c b/drivers/iio/adc/ad799x.c
index 01d7158..a3f5254 100644
--- a/drivers/iio/adc/ad799x.c
+++ b/drivers/iio/adc/ad799x.c
@@ -477,7 +477,7 @@ static int ad799x_read_event_value(struct iio_dev *indio_dev,
if (ret < 0)
return ret;
*val = (ret >> chan->scan_type.shift) &
- GENMASK(chan->scan_type.realbits - 1 , 0);
+ GENMASK(chan->scan_type.realbits - 1, 0);
return IIO_VAL_INT;
}
--
2.8.0
^ permalink raw reply related [flat|nested] 48+ messages in thread
* [PATCH 06/10] iio: adc: ad799x: remove space before comma
@ 2016-04-14 19:36 ` Slawomir Stepien
0 siblings, 0 replies; 48+ messages in thread
From: Slawomir Stepien @ 2016-04-14 19:36 UTC (permalink / raw)
To: jic23, knaack.h, pmeerw; +Cc: linux-iio, kernel-janitors, Slawomir Stepien
This fixes the error reported by checkpatch.pl:
ERROR: space prohibited before that ',' (ctx:WxW)
Signed-off-by: Slawomir Stepien <sst@poczta.fm>
---
drivers/iio/adc/ad799x.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/iio/adc/ad799x.c b/drivers/iio/adc/ad799x.c
index 01d7158..a3f5254 100644
--- a/drivers/iio/adc/ad799x.c
+++ b/drivers/iio/adc/ad799x.c
@@ -477,7 +477,7 @@ static int ad799x_read_event_value(struct iio_dev *indio_dev,
if (ret < 0)
return ret;
*val = (ret >> chan->scan_type.shift) &
- GENMASK(chan->scan_type.realbits - 1 , 0);
+ GENMASK(chan->scan_type.realbits - 1, 0);
return IIO_VAL_INT;
}
--
2.8.0
^ permalink raw reply related [flat|nested] 48+ messages in thread
* [PATCH 07/10] iio: common: ms_sensors: use tab for indention
2016-04-14 19:36 ` Slawomir Stepien
@ 2016-04-14 19:36 ` Slawomir Stepien
-1 siblings, 0 replies; 48+ messages in thread
From: Slawomir Stepien @ 2016-04-14 19:36 UTC (permalink / raw)
To: jic23, knaack.h, pmeerw; +Cc: linux-iio, kernel-janitors, Slawomir Stepien
This fixes the error reported by checkpatch.pl:
ERROR: code indent should use tabs where possible
Signed-off-by: Slawomir Stepien <sst@poczta.fm>
---
drivers/iio/common/ms_sensors/ms_sensors_i2c.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/iio/common/ms_sensors/ms_sensors_i2c.c b/drivers/iio/common/ms_sensors/ms_sensors_i2c.c
index 669dc7c..ecf7721 100644
--- a/drivers/iio/common/ms_sensors/ms_sensors_i2c.c
+++ b/drivers/iio/common/ms_sensors/ms_sensors_i2c.c
@@ -106,7 +106,7 @@ int ms_sensors_convert_and_read(void *cli, u8 conv, u8 rd,
unsigned int delay, u32 *adc)
{
int ret;
- __be32 buf = 0;
+ __be32 buf = 0;
struct i2c_client *client = (struct i2c_client *)cli;
/* Trigger conversion */
--
2.8.0
^ permalink raw reply related [flat|nested] 48+ messages in thread
* [PATCH 07/10] iio: common: ms_sensors: use tab for indention
@ 2016-04-14 19:36 ` Slawomir Stepien
0 siblings, 0 replies; 48+ messages in thread
From: Slawomir Stepien @ 2016-04-14 19:36 UTC (permalink / raw)
To: jic23, knaack.h, pmeerw; +Cc: linux-iio, kernel-janitors, Slawomir Stepien
This fixes the error reported by checkpatch.pl:
ERROR: code indent should use tabs where possible
Signed-off-by: Slawomir Stepien <sst@poczta.fm>
---
drivers/iio/common/ms_sensors/ms_sensors_i2c.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/iio/common/ms_sensors/ms_sensors_i2c.c b/drivers/iio/common/ms_sensors/ms_sensors_i2c.c
index 669dc7c..ecf7721 100644
--- a/drivers/iio/common/ms_sensors/ms_sensors_i2c.c
+++ b/drivers/iio/common/ms_sensors/ms_sensors_i2c.c
@@ -106,7 +106,7 @@ int ms_sensors_convert_and_read(void *cli, u8 conv, u8 rd,
unsigned int delay, u32 *adc)
{
int ret;
- __be32 buf = 0;
+ __be32 buf = 0;
struct i2c_client *client = (struct i2c_client *)cli;
/* Trigger conversion */
--
2.8.0
^ permalink raw reply related [flat|nested] 48+ messages in thread
* [PATCH 08/10] iio: common: hid-sensors: use tab for indention
2016-04-14 19:36 ` Slawomir Stepien
@ 2016-04-14 19:36 ` Slawomir Stepien
-1 siblings, 0 replies; 48+ messages in thread
From: Slawomir Stepien @ 2016-04-14 19:36 UTC (permalink / raw)
To: jic23, knaack.h, pmeerw; +Cc: linux-iio, kernel-janitors, Slawomir Stepien
This fixes the error reported by checkpatch.pl:
ERROR: code indent should use tabs where possible
Signed-off-by: Slawomir Stepien <sst@poczta.fm>
---
drivers/iio/common/hid-sensors/hid-sensor-trigger.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/iio/common/hid-sensors/hid-sensor-trigger.c b/drivers/iio/common/hid-sensors/hid-sensor-trigger.c
index 5955110..5b41f9d 100644
--- a/drivers/iio/common/hid-sensors/hid-sensor-trigger.c
+++ b/drivers/iio/common/hid-sensors/hid-sensor-trigger.c
@@ -115,7 +115,7 @@ int hid_sensor_power_state(struct hid_sensor_common *st, bool state)
return ret;
}
- return 0;
+ return 0;
#else
atomic_set(&st->user_requested_state, state);
return _hid_sensor_power_state(st, state);
--
2.8.0
^ permalink raw reply related [flat|nested] 48+ messages in thread
* [PATCH 08/10] iio: common: hid-sensors: use tab for indention
@ 2016-04-14 19:36 ` Slawomir Stepien
0 siblings, 0 replies; 48+ messages in thread
From: Slawomir Stepien @ 2016-04-14 19:36 UTC (permalink / raw)
To: jic23, knaack.h, pmeerw; +Cc: linux-iio, kernel-janitors, Slawomir Stepien
This fixes the error reported by checkpatch.pl:
ERROR: code indent should use tabs where possible
Signed-off-by: Slawomir Stepien <sst@poczta.fm>
---
drivers/iio/common/hid-sensors/hid-sensor-trigger.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/iio/common/hid-sensors/hid-sensor-trigger.c b/drivers/iio/common/hid-sensors/hid-sensor-trigger.c
index 5955110..5b41f9d 100644
--- a/drivers/iio/common/hid-sensors/hid-sensor-trigger.c
+++ b/drivers/iio/common/hid-sensors/hid-sensor-trigger.c
@@ -115,7 +115,7 @@ int hid_sensor_power_state(struct hid_sensor_common *st, bool state)
return ret;
}
- return 0;
+ return 0;
#else
atomic_set(&st->user_requested_state, state);
return _hid_sensor_power_state(st, state);
--
2.8.0
^ permalink raw reply related [flat|nested] 48+ messages in thread
* [PATCH 09/10] iio: magnetometer: ak8975: put else and brace at the same line
2016-04-14 19:36 ` Slawomir Stepien
@ 2016-04-14 19:36 ` Slawomir Stepien
-1 siblings, 0 replies; 48+ messages in thread
From: Slawomir Stepien @ 2016-04-14 19:36 UTC (permalink / raw)
To: jic23, knaack.h, pmeerw; +Cc: linux-iio, kernel-janitors, Slawomir Stepien
This fixes the error reported by checkpatch.pl:
ERROR: else should follow close brace '}'
Signed-off-by: Slawomir Stepien <sst@poczta.fm>
---
drivers/iio/magnetometer/ak8975.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/drivers/iio/magnetometer/ak8975.c b/drivers/iio/magnetometer/ak8975.c
index 48d127a..6bc855f 100644
--- a/drivers/iio/magnetometer/ak8975.c
+++ b/drivers/iio/magnetometer/ak8975.c
@@ -810,8 +810,7 @@ static int ak8975_probe(struct i2c_client *client,
name = ak8975_match_acpi_device(&client->dev, &chipset);
if (!name)
return -ENODEV;
- }
- else
+ } else
return -ENOSYS;
if (chipset >= AK_MAX_TYPE) {
--
2.8.0
^ permalink raw reply related [flat|nested] 48+ messages in thread
* [PATCH 09/10] iio: magnetometer: ak8975: put else and brace at the same line
@ 2016-04-14 19:36 ` Slawomir Stepien
0 siblings, 0 replies; 48+ messages in thread
From: Slawomir Stepien @ 2016-04-14 19:36 UTC (permalink / raw)
To: jic23, knaack.h, pmeerw; +Cc: linux-iio, kernel-janitors, Slawomir Stepien
This fixes the error reported by checkpatch.pl:
ERROR: else should follow close brace '}'
Signed-off-by: Slawomir Stepien <sst@poczta.fm>
---
drivers/iio/magnetometer/ak8975.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/drivers/iio/magnetometer/ak8975.c b/drivers/iio/magnetometer/ak8975.c
index 48d127a..6bc855f 100644
--- a/drivers/iio/magnetometer/ak8975.c
+++ b/drivers/iio/magnetometer/ak8975.c
@@ -810,8 +810,7 @@ static int ak8975_probe(struct i2c_client *client,
name = ak8975_match_acpi_device(&client->dev, &chipset);
if (!name)
return -ENODEV;
- }
- else
+ } else
return -ENOSYS;
if (chipset >= AK_MAX_TYPE) {
--
2.8.0
^ permalink raw reply related [flat|nested] 48+ messages in thread
* [PATCH 10/10] iio: pressure: ms5611: use tab for indention
2016-04-14 19:36 ` Slawomir Stepien
@ 2016-04-14 19:36 ` Slawomir Stepien
-1 siblings, 0 replies; 48+ messages in thread
From: Slawomir Stepien @ 2016-04-14 19:36 UTC (permalink / raw)
To: jic23, knaack.h, pmeerw; +Cc: linux-iio, kernel-janitors, Slawomir Stepien
This fixes the errors reported by checkpatch.pl:
ERROR: code indent should use tabs where possible
Signed-off-by: Slawomir Stepien <sst@poczta.fm>
---
drivers/iio/pressure/ms5611_core.c | 2 +-
drivers/iio/pressure/ms5611_spi.c | 2 +-
2 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/iio/pressure/ms5611_core.c b/drivers/iio/pressure/ms5611_core.c
index c4e6586..9d192bf 100644
--- a/drivers/iio/pressure/ms5611_core.c
+++ b/drivers/iio/pressure/ms5611_core.c
@@ -429,7 +429,7 @@ static void ms5611_fini(const struct iio_dev *indio_dev)
}
int ms5611_probe(struct iio_dev *indio_dev, struct device *dev,
- const char *name, int type)
+ const char *name, int type)
{
int ret;
struct ms5611_state *st = iio_priv(indio_dev);
diff --git a/drivers/iio/pressure/ms5611_spi.c b/drivers/iio/pressure/ms5611_spi.c
index 7600483..8f75532 100644
--- a/drivers/iio/pressure/ms5611_spi.c
+++ b/drivers/iio/pressure/ms5611_spi.c
@@ -108,7 +108,7 @@ static int ms5611_spi_probe(struct spi_device *spi)
st->client = spi;
return ms5611_probe(indio_dev, &spi->dev, spi_get_device_id(spi)->name,
- spi_get_device_id(spi)->driver_data);
+ spi_get_device_id(spi)->driver_data);
}
static int ms5611_spi_remove(struct spi_device *spi)
--
2.8.0
^ permalink raw reply related [flat|nested] 48+ messages in thread
* [PATCH 10/10] iio: pressure: ms5611: use tab for indention
@ 2016-04-14 19:36 ` Slawomir Stepien
0 siblings, 0 replies; 48+ messages in thread
From: Slawomir Stepien @ 2016-04-14 19:36 UTC (permalink / raw)
To: jic23, knaack.h, pmeerw; +Cc: linux-iio, kernel-janitors, Slawomir Stepien
This fixes the errors reported by checkpatch.pl:
ERROR: code indent should use tabs where possible
Signed-off-by: Slawomir Stepien <sst@poczta.fm>
---
drivers/iio/pressure/ms5611_core.c | 2 +-
drivers/iio/pressure/ms5611_spi.c | 2 +-
2 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/iio/pressure/ms5611_core.c b/drivers/iio/pressure/ms5611_core.c
index c4e6586..9d192bf 100644
--- a/drivers/iio/pressure/ms5611_core.c
+++ b/drivers/iio/pressure/ms5611_core.c
@@ -429,7 +429,7 @@ static void ms5611_fini(const struct iio_dev *indio_dev)
}
int ms5611_probe(struct iio_dev *indio_dev, struct device *dev,
- const char *name, int type)
+ const char *name, int type)
{
int ret;
struct ms5611_state *st = iio_priv(indio_dev);
diff --git a/drivers/iio/pressure/ms5611_spi.c b/drivers/iio/pressure/ms5611_spi.c
index 7600483..8f75532 100644
--- a/drivers/iio/pressure/ms5611_spi.c
+++ b/drivers/iio/pressure/ms5611_spi.c
@@ -108,7 +108,7 @@ static int ms5611_spi_probe(struct spi_device *spi)
st->client = spi;
return ms5611_probe(indio_dev, &spi->dev, spi_get_device_id(spi)->name,
- spi_get_device_id(spi)->driver_data);
+ spi_get_device_id(spi)->driver_data);
}
static int ms5611_spi_remove(struct spi_device *spi)
--
2.8.0
^ permalink raw reply related [flat|nested] 48+ messages in thread
* Re: [PATCH 01/10] iio: light apds9960: fix wrong use of brace
2016-04-14 19:36 ` Slawomir Stepien
@ 2016-04-14 23:29 ` Matt Ranostay
-1 siblings, 0 replies; 48+ messages in thread
From: Matt Ranostay @ 2016-04-14 23:29 UTC (permalink / raw)
To: Slawomir Stepien
Cc: Jonathan Cameron, Hartmut Knaack, Peter Meerwald-Stadler,
linux-iio, kernel-janitors
On Thu, Apr 14, 2016 at 12:36 PM, Slawomir Stepien <sst@poczta.fm> wrote:
> This fixes the error reported by checkpatch.pl:
>
> ERROR: that open brace { should be on the previous line
>
> Signed-off-by: Slawomir Stepien <sst@poczta.fm>
> ---
> drivers/iio/light/apds9960.c | 8 ++++++--
> 1 file changed, 6 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/iio/light/apds9960.c b/drivers/iio/light/apds9960.c
> index a6af56a..ade18aa 100644
> --- a/drivers/iio/light/apds9960.c
> +++ b/drivers/iio/light/apds9960.c
> @@ -321,8 +321,12 @@ static const struct iio_chan_spec apds9960_channels[] = {
> };
>
> /* integration time in us */
> -static const int apds9960_int_time[][2] > - { {28000, 246}, {100000, 219}, {200000, 182}, {700000, 0} };
> +static const int apds9960_int_time[][2] = {
> + { 28000, 246},
> + {100000, 219},
> + {200000, 182},
> + {700000, 0}
Extra space between the comma and zero. Or was this intended for alignment?
> +};
>
> /* gain mapping */
> static const int apds9960_pxs_gain_map[] = {1, 2, 4, 8};
> --
> 2.8.0
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-iio" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
^ permalink raw reply [flat|nested] 48+ messages in thread
* Re: [PATCH 01/10] iio: light apds9960: fix wrong use of brace
@ 2016-04-14 23:29 ` Matt Ranostay
0 siblings, 0 replies; 48+ messages in thread
From: Matt Ranostay @ 2016-04-14 23:29 UTC (permalink / raw)
To: Slawomir Stepien
Cc: Jonathan Cameron, Hartmut Knaack, Peter Meerwald-Stadler,
linux-iio, kernel-janitors
On Thu, Apr 14, 2016 at 12:36 PM, Slawomir Stepien <sst@poczta.fm> wrote:
> This fixes the error reported by checkpatch.pl:
>
> ERROR: that open brace { should be on the previous line
>
> Signed-off-by: Slawomir Stepien <sst@poczta.fm>
> ---
> drivers/iio/light/apds9960.c | 8 ++++++--
> 1 file changed, 6 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/iio/light/apds9960.c b/drivers/iio/light/apds9960.c
> index a6af56a..ade18aa 100644
> --- a/drivers/iio/light/apds9960.c
> +++ b/drivers/iio/light/apds9960.c
> @@ -321,8 +321,12 @@ static const struct iio_chan_spec apds9960_channels[] = {
> };
>
> /* integration time in us */
> -static const int apds9960_int_time[][2] =
> - { {28000, 246}, {100000, 219}, {200000, 182}, {700000, 0} };
> +static const int apds9960_int_time[][2] = {
> + { 28000, 246},
> + {100000, 219},
> + {200000, 182},
> + {700000, 0}
Extra space between the comma and zero. Or was this intended for alignment?
> +};
>
> /* gain mapping */
> static const int apds9960_pxs_gain_map[] = {1, 2, 4, 8};
> --
> 2.8.0
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-iio" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
^ permalink raw reply [flat|nested] 48+ messages in thread
* Re: [PATCH 01/10] iio: light apds9960: fix wrong use of brace
2016-04-14 23:29 ` Matt Ranostay
@ 2016-04-15 14:56 ` Slawomir Stepien
-1 siblings, 0 replies; 48+ messages in thread
From: Slawomir Stepien @ 2016-04-15 14:56 UTC (permalink / raw)
To: Matt Ranostay
Cc: Jonathan Cameron, Hartmut Knaack, Peter Meerwald-Stadler,
linux-iio, kernel-janitors
On Apr 14, 2016 16:29, Matt Ranostay wrote:
> On Thu, Apr 14, 2016 at 12:36 PM, Slawomir Stepien <sst@poczta.fm> wrote:
> > This fixes the error reported by checkpatch.pl:
> >
> > ERROR: that open brace { should be on the previous line
> >
> > Signed-off-by: Slawomir Stepien <sst@poczta.fm>
> > ---
> > drivers/iio/light/apds9960.c | 8 ++++++--
> > 1 file changed, 6 insertions(+), 2 deletions(-)
> >
> > diff --git a/drivers/iio/light/apds9960.c b/drivers/iio/light/apds9960.c
> > index a6af56a..ade18aa 100644
> > --- a/drivers/iio/light/apds9960.c
> > +++ b/drivers/iio/light/apds9960.c
> > @@ -321,8 +321,12 @@ static const struct iio_chan_spec apds9960_channels[] = {
> > };
> >
> > /* integration time in us */
> > -static const int apds9960_int_time[][2] > > - { {28000, 246}, {100000, 219}, {200000, 182}, {700000, 0} };
> > +static const int apds9960_int_time[][2] = {
> > + { 28000, 246},
> > + {100000, 219},
> > + {200000, 182},
> > + {700000, 0}
> Extra space between the comma and zero. Or was this intended for alignment?
Just for alignment. Are you OK with that?
--
Slawomir Stepien
^ permalink raw reply [flat|nested] 48+ messages in thread
* Re: [PATCH 01/10] iio: light apds9960: fix wrong use of brace
@ 2016-04-15 14:56 ` Slawomir Stepien
0 siblings, 0 replies; 48+ messages in thread
From: Slawomir Stepien @ 2016-04-15 14:56 UTC (permalink / raw)
To: Matt Ranostay
Cc: Jonathan Cameron, Hartmut Knaack, Peter Meerwald-Stadler,
linux-iio, kernel-janitors
On Apr 14, 2016 16:29, Matt Ranostay wrote:
> On Thu, Apr 14, 2016 at 12:36 PM, Slawomir Stepien <sst@poczta.fm> wrote:
> > This fixes the error reported by checkpatch.pl:
> >
> > ERROR: that open brace { should be on the previous line
> >
> > Signed-off-by: Slawomir Stepien <sst@poczta.fm>
> > ---
> > drivers/iio/light/apds9960.c | 8 ++++++--
> > 1 file changed, 6 insertions(+), 2 deletions(-)
> >
> > diff --git a/drivers/iio/light/apds9960.c b/drivers/iio/light/apds9960.c
> > index a6af56a..ade18aa 100644
> > --- a/drivers/iio/light/apds9960.c
> > +++ b/drivers/iio/light/apds9960.c
> > @@ -321,8 +321,12 @@ static const struct iio_chan_spec apds9960_channels[] = {
> > };
> >
> > /* integration time in us */
> > -static const int apds9960_int_time[][2] =
> > - { {28000, 246}, {100000, 219}, {200000, 182}, {700000, 0} };
> > +static const int apds9960_int_time[][2] = {
> > + { 28000, 246},
> > + {100000, 219},
> > + {200000, 182},
> > + {700000, 0}
> Extra space between the comma and zero. Or was this intended for alignment?
Just for alignment. Are you OK with that?
--
Slawomir Stepien
^ permalink raw reply [flat|nested] 48+ messages in thread
* Re: [PATCH 01/10] iio: light apds9960: fix wrong use of brace
2016-04-15 14:56 ` Slawomir Stepien
@ 2016-04-16 9:48 ` Dan Carpenter
-1 siblings, 0 replies; 48+ messages in thread
From: Dan Carpenter @ 2016-04-16 9:48 UTC (permalink / raw)
To: Slawomir Stepien
Cc: Matt Ranostay, Jonathan Cameron, Hartmut Knaack,
Peter Meerwald-Stadler, linux-iio, kernel-janitors
On Fri, Apr 15, 2016 at 04:56:41PM +0200, Slawomir Stepien wrote:
> On Apr 14, 2016 16:29, Matt Ranostay wrote:
> > On Thu, Apr 14, 2016 at 12:36 PM, Slawomir Stepien <sst@poczta.fm> wrote:
> > > This fixes the error reported by checkpatch.pl:
> > >
> > > ERROR: that open brace { should be on the previous line
> > >
> > > Signed-off-by: Slawomir Stepien <sst@poczta.fm>
> > > ---
> > > drivers/iio/light/apds9960.c | 8 ++++++--
> > > 1 file changed, 6 insertions(+), 2 deletions(-)
> > >
> > > diff --git a/drivers/iio/light/apds9960.c b/drivers/iio/light/apds9960.c
> > > index a6af56a..ade18aa 100644
> > > --- a/drivers/iio/light/apds9960.c
> > > +++ b/drivers/iio/light/apds9960.c
> > > @@ -321,8 +321,12 @@ static const struct iio_chan_spec apds9960_channels[] = {
> > > };
> > >
> > > /* integration time in us */
> > > -static const int apds9960_int_time[][2] > > > - { {28000, 246}, {100000, 219}, {200000, 182}, {700000, 0} };
> > > +static const int apds9960_int_time[][2] = {
> > > + { 28000, 246},
> > > + {100000, 219},
> > > + {200000, 182},
> > > + {700000, 0}
> > Extra space between the comma and zero. Or was this intended for alignment?
>
> Just for alignment. Are you OK with that?
Yeah. Looks fine.
regards,
dan carpenter
^ permalink raw reply [flat|nested] 48+ messages in thread
* Re: [PATCH 01/10] iio: light apds9960: fix wrong use of brace
@ 2016-04-16 9:48 ` Dan Carpenter
0 siblings, 0 replies; 48+ messages in thread
From: Dan Carpenter @ 2016-04-16 9:48 UTC (permalink / raw)
To: Slawomir Stepien
Cc: Matt Ranostay, Jonathan Cameron, Hartmut Knaack,
Peter Meerwald-Stadler, linux-iio, kernel-janitors
On Fri, Apr 15, 2016 at 04:56:41PM +0200, Slawomir Stepien wrote:
> On Apr 14, 2016 16:29, Matt Ranostay wrote:
> > On Thu, Apr 14, 2016 at 12:36 PM, Slawomir Stepien <sst@poczta.fm> wrote:
> > > This fixes the error reported by checkpatch.pl:
> > >
> > > ERROR: that open brace { should be on the previous line
> > >
> > > Signed-off-by: Slawomir Stepien <sst@poczta.fm>
> > > ---
> > > drivers/iio/light/apds9960.c | 8 ++++++--
> > > 1 file changed, 6 insertions(+), 2 deletions(-)
> > >
> > > diff --git a/drivers/iio/light/apds9960.c b/drivers/iio/light/apds9960.c
> > > index a6af56a..ade18aa 100644
> > > --- a/drivers/iio/light/apds9960.c
> > > +++ b/drivers/iio/light/apds9960.c
> > > @@ -321,8 +321,12 @@ static const struct iio_chan_spec apds9960_channels[] = {
> > > };
> > >
> > > /* integration time in us */
> > > -static const int apds9960_int_time[][2] =
> > > - { {28000, 246}, {100000, 219}, {200000, 182}, {700000, 0} };
> > > +static const int apds9960_int_time[][2] = {
> > > + { 28000, 246},
> > > + {100000, 219},
> > > + {200000, 182},
> > > + {700000, 0}
> > Extra space between the comma and zero. Or was this intended for alignment?
>
> Just for alignment. Are you OK with that?
Yeah. Looks fine.
regards,
dan carpenter
^ permalink raw reply [flat|nested] 48+ messages in thread
* Re: [PATCH 01/10] iio: light apds9960: fix wrong use of brace
2016-04-15 14:56 ` Slawomir Stepien
@ 2016-04-16 12:30 ` Jonathan Cameron
-1 siblings, 0 replies; 48+ messages in thread
From: Jonathan Cameron @ 2016-04-16 12:30 UTC (permalink / raw)
To: Slawomir Stepien, Matt Ranostay
Cc: Hartmut Knaack, Peter Meerwald-Stadler, linux-iio, kernel-janitors
On 15/04/16 15:56, Slawomir Stepien wrote:
> On Apr 14, 2016 16:29, Matt Ranostay wrote:
>> On Thu, Apr 14, 2016 at 12:36 PM, Slawomir Stepien <sst@poczta.fm> wrote:
>>> This fixes the error reported by checkpatch.pl:
>>>
>>> ERROR: that open brace { should be on the previous line
>>>
>>> Signed-off-by: Slawomir Stepien <sst@poczta.fm>
I find it rather hard to care about this, but perhaps it is just a 'tiny' bit
more readable and there are definite advantages in suppressing some of the
output of checkpatch so the 'real' issues are easily spotted!
Applied to the togreg branch of iio.git - initially pushed out as testing
for the autobuilders to play with it.
Thanks,
Jonathan
>>> ---
>>> drivers/iio/light/apds9960.c | 8 ++++++--
>>> 1 file changed, 6 insertions(+), 2 deletions(-)
>>>
>>> diff --git a/drivers/iio/light/apds9960.c b/drivers/iio/light/apds9960.c
>>> index a6af56a..ade18aa 100644
>>> --- a/drivers/iio/light/apds9960.c
>>> +++ b/drivers/iio/light/apds9960.c
>>> @@ -321,8 +321,12 @@ static const struct iio_chan_spec apds9960_channels[] = {
>>> };
>>>
>>> /* integration time in us */
>>> -static const int apds9960_int_time[][2] >>> - { {28000, 246}, {100000, 219}, {200000, 182}, {700000, 0} };
>>> +static const int apds9960_int_time[][2] = {
>>> + { 28000, 246},
>>> + {100000, 219},
>>> + {200000, 182},
>>> + {700000, 0}
>> Extra space between the comma and zero. Or was this intended for alignment?
>
> Just for alignment. Are you OK with that?
>
^ permalink raw reply [flat|nested] 48+ messages in thread
* Re: [PATCH 01/10] iio: light apds9960: fix wrong use of brace
@ 2016-04-16 12:30 ` Jonathan Cameron
0 siblings, 0 replies; 48+ messages in thread
From: Jonathan Cameron @ 2016-04-16 12:30 UTC (permalink / raw)
To: Slawomir Stepien, Matt Ranostay
Cc: Hartmut Knaack, Peter Meerwald-Stadler, linux-iio, kernel-janitors
On 15/04/16 15:56, Slawomir Stepien wrote:
> On Apr 14, 2016 16:29, Matt Ranostay wrote:
>> On Thu, Apr 14, 2016 at 12:36 PM, Slawomir Stepien <sst@poczta.fm> wrote:
>>> This fixes the error reported by checkpatch.pl:
>>>
>>> ERROR: that open brace { should be on the previous line
>>>
>>> Signed-off-by: Slawomir Stepien <sst@poczta.fm>
I find it rather hard to care about this, but perhaps it is just a 'tiny' bit
more readable and there are definite advantages in suppressing some of the
output of checkpatch so the 'real' issues are easily spotted!
Applied to the togreg branch of iio.git - initially pushed out as testing
for the autobuilders to play with it.
Thanks,
Jonathan
>>> ---
>>> drivers/iio/light/apds9960.c | 8 ++++++--
>>> 1 file changed, 6 insertions(+), 2 deletions(-)
>>>
>>> diff --git a/drivers/iio/light/apds9960.c b/drivers/iio/light/apds9960.c
>>> index a6af56a..ade18aa 100644
>>> --- a/drivers/iio/light/apds9960.c
>>> +++ b/drivers/iio/light/apds9960.c
>>> @@ -321,8 +321,12 @@ static const struct iio_chan_spec apds9960_channels[] = {
>>> };
>>>
>>> /* integration time in us */
>>> -static const int apds9960_int_time[][2] =
>>> - { {28000, 246}, {100000, 219}, {200000, 182}, {700000, 0} };
>>> +static const int apds9960_int_time[][2] = {
>>> + { 28000, 246},
>>> + {100000, 219},
>>> + {200000, 182},
>>> + {700000, 0}
>> Extra space between the comma and zero. Or was this intended for alignment?
>
> Just for alignment. Are you OK with that?
>
^ permalink raw reply [flat|nested] 48+ messages in thread
* Re: [PATCH 02/10] iio: inkern: add a missing space before if
2016-04-14 19:36 ` Slawomir Stepien
@ 2016-04-16 12:31 ` Jonathan Cameron
-1 siblings, 0 replies; 48+ messages in thread
From: Jonathan Cameron @ 2016-04-16 12:31 UTC (permalink / raw)
To: Slawomir Stepien, knaack.h, pmeerw; +Cc: linux-iio, kernel-janitors
On 14/04/16 20:36, Slawomir Stepien wrote:
> This fixes the error reported by checkpatch.pl:
>
> ERROR: space required before the open parenthesis '('
>
> Signed-off-by: Slawomir Stepien <sst@poczta.fm>
This one is more clear cut! Thanks for fixing it.
Applied to the togreg branch of iio.git - initially pushed out as testing etc etc.
Jonathan
> ---
> drivers/iio/inkern.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/iio/inkern.c b/drivers/iio/inkern.c
> index 734a004..2fc7928 100644
> --- a/drivers/iio/inkern.c
> +++ b/drivers/iio/inkern.c
> @@ -452,7 +452,7 @@ static int iio_channel_read(struct iio_channel *chan, int *val, int *val2,
> if (val2 = NULL)
> val2 = &unused;
>
> - if(!iio_channel_has_info(chan->channel, info))
> + if (!iio_channel_has_info(chan->channel, info))
> return -EINVAL;
>
> if (chan->indio_dev->info->read_raw_multi) {
>
^ permalink raw reply [flat|nested] 48+ messages in thread
* Re: [PATCH 02/10] iio: inkern: add a missing space before if
@ 2016-04-16 12:31 ` Jonathan Cameron
0 siblings, 0 replies; 48+ messages in thread
From: Jonathan Cameron @ 2016-04-16 12:31 UTC (permalink / raw)
To: Slawomir Stepien, knaack.h, pmeerw; +Cc: linux-iio, kernel-janitors
On 14/04/16 20:36, Slawomir Stepien wrote:
> This fixes the error reported by checkpatch.pl:
>
> ERROR: space required before the open parenthesis '('
>
> Signed-off-by: Slawomir Stepien <sst@poczta.fm>
This one is more clear cut! Thanks for fixing it.
Applied to the togreg branch of iio.git - initially pushed out as testing etc etc.
Jonathan
> ---
> drivers/iio/inkern.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/iio/inkern.c b/drivers/iio/inkern.c
> index 734a004..2fc7928 100644
> --- a/drivers/iio/inkern.c
> +++ b/drivers/iio/inkern.c
> @@ -452,7 +452,7 @@ static int iio_channel_read(struct iio_channel *chan, int *val, int *val2,
> if (val2 == NULL)
> val2 = &unused;
>
> - if(!iio_channel_has_info(chan->channel, info))
> + if (!iio_channel_has_info(chan->channel, info))
> return -EINVAL;
>
> if (chan->indio_dev->info->read_raw_multi) {
>
^ permalink raw reply [flat|nested] 48+ messages in thread
* Re: [PATCH 03/10] iio: adc: vf610_adc: fix case label indent
2016-04-14 19:36 ` Slawomir Stepien
@ 2016-04-16 12:31 ` Jonathan Cameron
-1 siblings, 0 replies; 48+ messages in thread
From: Jonathan Cameron @ 2016-04-16 12:31 UTC (permalink / raw)
To: Slawomir Stepien, knaack.h, pmeerw; +Cc: linux-iio, kernel-janitors
On 14/04/16 20:36, Slawomir Stepien wrote:
> This fixes the error reported by checkpatch.pl:
>
> ERROR: switch and case should be at the same indent
>
> Signed-off-by: Slawomir Stepien <sst@poczta.fm>
Applied.
Thanks,
Jonathan
> ---
> drivers/iio/adc/vf610_adc.c | 24 ++++++++++++------------
> 1 file changed, 12 insertions(+), 12 deletions(-)
>
> diff --git a/drivers/iio/adc/vf610_adc.c b/drivers/iio/adc/vf610_adc.c
> index b10f629..653bf13 100644
> --- a/drivers/iio/adc/vf610_adc.c
> +++ b/drivers/iio/adc/vf610_adc.c
> @@ -714,19 +714,19 @@ static int vf610_write_raw(struct iio_dev *indio_dev,
> int i;
>
> switch (mask) {
> - case IIO_CHAN_INFO_SAMP_FREQ:
> - for (i = 0;
> - i < ARRAY_SIZE(info->sample_freq_avail);
> - i++)
> - if (val = info->sample_freq_avail[i]) {
> - info->adc_feature.sample_rate = i;
> - vf610_adc_sample_set(info);
> - return 0;
> - }
> - break;
> + case IIO_CHAN_INFO_SAMP_FREQ:
> + for (i = 0;
> + i < ARRAY_SIZE(info->sample_freq_avail);
> + i++)
> + if (val = info->sample_freq_avail[i]) {
> + info->adc_feature.sample_rate = i;
> + vf610_adc_sample_set(info);
> + return 0;
> + }
> + break;
>
> - default:
> - break;
> + default:
> + break;
> }
>
> return -EINVAL;
>
^ permalink raw reply [flat|nested] 48+ messages in thread
* Re: [PATCH 03/10] iio: adc: vf610_adc: fix case label indent
@ 2016-04-16 12:31 ` Jonathan Cameron
0 siblings, 0 replies; 48+ messages in thread
From: Jonathan Cameron @ 2016-04-16 12:31 UTC (permalink / raw)
To: Slawomir Stepien, knaack.h, pmeerw; +Cc: linux-iio, kernel-janitors
On 14/04/16 20:36, Slawomir Stepien wrote:
> This fixes the error reported by checkpatch.pl:
>
> ERROR: switch and case should be at the same indent
>
> Signed-off-by: Slawomir Stepien <sst@poczta.fm>
Applied.
Thanks,
Jonathan
> ---
> drivers/iio/adc/vf610_adc.c | 24 ++++++++++++------------
> 1 file changed, 12 insertions(+), 12 deletions(-)
>
> diff --git a/drivers/iio/adc/vf610_adc.c b/drivers/iio/adc/vf610_adc.c
> index b10f629..653bf13 100644
> --- a/drivers/iio/adc/vf610_adc.c
> +++ b/drivers/iio/adc/vf610_adc.c
> @@ -714,19 +714,19 @@ static int vf610_write_raw(struct iio_dev *indio_dev,
> int i;
>
> switch (mask) {
> - case IIO_CHAN_INFO_SAMP_FREQ:
> - for (i = 0;
> - i < ARRAY_SIZE(info->sample_freq_avail);
> - i++)
> - if (val == info->sample_freq_avail[i]) {
> - info->adc_feature.sample_rate = i;
> - vf610_adc_sample_set(info);
> - return 0;
> - }
> - break;
> + case IIO_CHAN_INFO_SAMP_FREQ:
> + for (i = 0;
> + i < ARRAY_SIZE(info->sample_freq_avail);
> + i++)
> + if (val == info->sample_freq_avail[i]) {
> + info->adc_feature.sample_rate = i;
> + vf610_adc_sample_set(info);
> + return 0;
> + }
> + break;
>
> - default:
> - break;
> + default:
> + break;
> }
>
> return -EINVAL;
>
^ permalink raw reply [flat|nested] 48+ messages in thread
* Re: [PATCH 04/10] iio: adc: mcp3422: remove spaces before comma
2016-04-14 19:36 ` Slawomir Stepien
@ 2016-04-16 12:32 ` Jonathan Cameron
-1 siblings, 0 replies; 48+ messages in thread
From: Jonathan Cameron @ 2016-04-16 12:32 UTC (permalink / raw)
To: Slawomir Stepien, knaack.h, pmeerw; +Cc: linux-iio, kernel-janitors
On 14/04/16 20:36, Slawomir Stepien wrote:
> This fixes the error reported by checkpatch.pl:
>
> ERROR: space prohibited before that ',' (ctx:WxW)
>
> Signed-off-by: Slawomir Stepien <sst@poczta.fm>
Applied - thanks
> ---
> drivers/iio/adc/mcp3422.c | 6 +++---
> 1 file changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/iio/adc/mcp3422.c b/drivers/iio/adc/mcp3422.c
> index d7b36ef..d1172dc 100644
> --- a/drivers/iio/adc/mcp3422.c
> +++ b/drivers/iio/adc/mcp3422.c
> @@ -61,9 +61,9 @@
>
> static const int mcp3422_scales[4][4] = {
> { 1000000, 500000, 250000, 125000 },
> - { 250000 , 125000, 62500 , 31250 },
> - { 62500 , 31250 , 15625 , 7812 },
> - { 15625 , 7812 , 3906 , 1953 } };
> + { 250000, 125000, 62500, 31250 },
> + { 62500, 31250, 15625, 7812 },
> + { 15625, 7812, 3906, 1953 } };
>
> /* Constant msleep times for data acquisitions */
> static const int mcp3422_read_times[4] = {
>
^ permalink raw reply [flat|nested] 48+ messages in thread
* Re: [PATCH 04/10] iio: adc: mcp3422: remove spaces before comma
@ 2016-04-16 12:32 ` Jonathan Cameron
0 siblings, 0 replies; 48+ messages in thread
From: Jonathan Cameron @ 2016-04-16 12:32 UTC (permalink / raw)
To: Slawomir Stepien, knaack.h, pmeerw; +Cc: linux-iio, kernel-janitors
On 14/04/16 20:36, Slawomir Stepien wrote:
> This fixes the error reported by checkpatch.pl:
>
> ERROR: space prohibited before that ',' (ctx:WxW)
>
> Signed-off-by: Slawomir Stepien <sst@poczta.fm>
Applied - thanks
> ---
> drivers/iio/adc/mcp3422.c | 6 +++---
> 1 file changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/iio/adc/mcp3422.c b/drivers/iio/adc/mcp3422.c
> index d7b36ef..d1172dc 100644
> --- a/drivers/iio/adc/mcp3422.c
> +++ b/drivers/iio/adc/mcp3422.c
> @@ -61,9 +61,9 @@
>
> static const int mcp3422_scales[4][4] = {
> { 1000000, 500000, 250000, 125000 },
> - { 250000 , 125000, 62500 , 31250 },
> - { 62500 , 31250 , 15625 , 7812 },
> - { 15625 , 7812 , 3906 , 1953 } };
> + { 250000, 125000, 62500, 31250 },
> + { 62500, 31250, 15625, 7812 },
> + { 15625, 7812, 3906, 1953 } };
>
> /* Constant msleep times for data acquisitions */
> static const int mcp3422_read_times[4] = {
>
^ permalink raw reply [flat|nested] 48+ messages in thread
* Re: [PATCH 05/10] iio: adc: at91_adc: fix errors reported by checkpatch.pl
2016-04-14 19:36 ` Slawomir Stepien
@ 2016-04-16 12:33 ` Jonathan Cameron
-1 siblings, 0 replies; 48+ messages in thread
From: Jonathan Cameron @ 2016-04-16 12:33 UTC (permalink / raw)
To: Slawomir Stepien, knaack.h, pmeerw; +Cc: linux-iio, kernel-janitors
On 14/04/16 20:36, Slawomir Stepien wrote:
> This fixes the errors reported by checkpatch.pl:
>
> ERROR: space prohibited before that ',' (ctx:WxW)
> ERROR: code indent should use tabs where possible
Ouch - not sure how that one snuck in!
Applied and thanks,
Jonathan
>
> Signed-off-by: Slawomir Stepien <sst@poczta.fm>
> ---
> drivers/iio/adc/at91_adc.c | 8 ++++----
> 1 file changed, 4 insertions(+), 4 deletions(-)
>
> diff --git a/drivers/iio/adc/at91_adc.c b/drivers/iio/adc/at91_adc.c
> index f284cd6..52430ba 100644
> --- a/drivers/iio/adc/at91_adc.c
> +++ b/drivers/iio/adc/at91_adc.c
> @@ -797,8 +797,8 @@ static u32 calc_startup_ticks_9x5(u32 startup_time, u32 adc_clk_khz)
> * Startup Time = <lookup_table_value> / ADC Clock
> */
> const int startup_lookup[] = {
> - 0 , 8 , 16 , 24 ,
> - 64 , 80 , 96 , 112,
> + 0, 8, 16, 24,
> + 64, 80, 96, 112,
> 512, 576, 640, 704,
> 768, 832, 896, 960
> };
> @@ -924,14 +924,14 @@ static int at91_adc_probe_dt(struct at91_adc_state *st,
> ret = -EINVAL;
> goto error_ret;
> }
> - trig->name = name;
> + trig->name = name;
>
> if (of_property_read_u32(trig_node, "trigger-value", &prop)) {
> dev_err(&idev->dev, "Missing trigger-value property in the DT.\n");
> ret = -EINVAL;
> goto error_ret;
> }
> - trig->value = prop;
> + trig->value = prop;
> trig->is_external = of_property_read_bool(trig_node, "trigger-external");
> i++;
> }
>
^ permalink raw reply [flat|nested] 48+ messages in thread
* Re: [PATCH 05/10] iio: adc: at91_adc: fix errors reported by checkpatch.pl
@ 2016-04-16 12:33 ` Jonathan Cameron
0 siblings, 0 replies; 48+ messages in thread
From: Jonathan Cameron @ 2016-04-16 12:33 UTC (permalink / raw)
To: Slawomir Stepien, knaack.h, pmeerw; +Cc: linux-iio, kernel-janitors
On 14/04/16 20:36, Slawomir Stepien wrote:
> This fixes the errors reported by checkpatch.pl:
>
> ERROR: space prohibited before that ',' (ctx:WxW)
> ERROR: code indent should use tabs where possible
Ouch - not sure how that one snuck in!
Applied and thanks,
Jonathan
>
> Signed-off-by: Slawomir Stepien <sst@poczta.fm>
> ---
> drivers/iio/adc/at91_adc.c | 8 ++++----
> 1 file changed, 4 insertions(+), 4 deletions(-)
>
> diff --git a/drivers/iio/adc/at91_adc.c b/drivers/iio/adc/at91_adc.c
> index f284cd6..52430ba 100644
> --- a/drivers/iio/adc/at91_adc.c
> +++ b/drivers/iio/adc/at91_adc.c
> @@ -797,8 +797,8 @@ static u32 calc_startup_ticks_9x5(u32 startup_time, u32 adc_clk_khz)
> * Startup Time = <lookup_table_value> / ADC Clock
> */
> const int startup_lookup[] = {
> - 0 , 8 , 16 , 24 ,
> - 64 , 80 , 96 , 112,
> + 0, 8, 16, 24,
> + 64, 80, 96, 112,
> 512, 576, 640, 704,
> 768, 832, 896, 960
> };
> @@ -924,14 +924,14 @@ static int at91_adc_probe_dt(struct at91_adc_state *st,
> ret = -EINVAL;
> goto error_ret;
> }
> - trig->name = name;
> + trig->name = name;
>
> if (of_property_read_u32(trig_node, "trigger-value", &prop)) {
> dev_err(&idev->dev, "Missing trigger-value property in the DT.\n");
> ret = -EINVAL;
> goto error_ret;
> }
> - trig->value = prop;
> + trig->value = prop;
> trig->is_external = of_property_read_bool(trig_node, "trigger-external");
> i++;
> }
>
^ permalink raw reply [flat|nested] 48+ messages in thread
* Re: [PATCH 06/10] iio: adc: ad799x: remove space before comma
2016-04-14 19:36 ` Slawomir Stepien
@ 2016-04-16 12:34 ` Jonathan Cameron
-1 siblings, 0 replies; 48+ messages in thread
From: Jonathan Cameron @ 2016-04-16 12:34 UTC (permalink / raw)
To: Slawomir Stepien, knaack.h, pmeerw; +Cc: linux-iio, kernel-janitors
On 14/04/16 20:36, Slawomir Stepien wrote:
> This fixes the error reported by checkpatch.pl:
>
> ERROR: space prohibited before that ',' (ctx:WxW)
>
> Signed-off-by: Slawomir Stepien <sst@poczta.fm>
Applied,
Thanks,
Jonathan
> ---
> drivers/iio/adc/ad799x.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/iio/adc/ad799x.c b/drivers/iio/adc/ad799x.c
> index 01d7158..a3f5254 100644
> --- a/drivers/iio/adc/ad799x.c
> +++ b/drivers/iio/adc/ad799x.c
> @@ -477,7 +477,7 @@ static int ad799x_read_event_value(struct iio_dev *indio_dev,
> if (ret < 0)
> return ret;
> *val = (ret >> chan->scan_type.shift) &
> - GENMASK(chan->scan_type.realbits - 1 , 0);
> + GENMASK(chan->scan_type.realbits - 1, 0);
>
> return IIO_VAL_INT;
> }
>
^ permalink raw reply [flat|nested] 48+ messages in thread
* Re: [PATCH 06/10] iio: adc: ad799x: remove space before comma
@ 2016-04-16 12:34 ` Jonathan Cameron
0 siblings, 0 replies; 48+ messages in thread
From: Jonathan Cameron @ 2016-04-16 12:34 UTC (permalink / raw)
To: Slawomir Stepien, knaack.h, pmeerw; +Cc: linux-iio, kernel-janitors
On 14/04/16 20:36, Slawomir Stepien wrote:
> This fixes the error reported by checkpatch.pl:
>
> ERROR: space prohibited before that ',' (ctx:WxW)
>
> Signed-off-by: Slawomir Stepien <sst@poczta.fm>
Applied,
Thanks,
Jonathan
> ---
> drivers/iio/adc/ad799x.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/iio/adc/ad799x.c b/drivers/iio/adc/ad799x.c
> index 01d7158..a3f5254 100644
> --- a/drivers/iio/adc/ad799x.c
> +++ b/drivers/iio/adc/ad799x.c
> @@ -477,7 +477,7 @@ static int ad799x_read_event_value(struct iio_dev *indio_dev,
> if (ret < 0)
> return ret;
> *val = (ret >> chan->scan_type.shift) &
> - GENMASK(chan->scan_type.realbits - 1 , 0);
> + GENMASK(chan->scan_type.realbits - 1, 0);
>
> return IIO_VAL_INT;
> }
>
^ permalink raw reply [flat|nested] 48+ messages in thread
* Re: [PATCH 07/10] iio: common: ms_sensors: use tab for indention
2016-04-14 19:36 ` Slawomir Stepien
@ 2016-04-16 12:34 ` Jonathan Cameron
-1 siblings, 0 replies; 48+ messages in thread
From: Jonathan Cameron @ 2016-04-16 12:34 UTC (permalink / raw)
To: Slawomir Stepien, knaack.h, pmeerw; +Cc: linux-iio, kernel-janitors
On 14/04/16 20:36, Slawomir Stepien wrote:
> This fixes the error reported by checkpatch.pl:
>
> ERROR: code indent should use tabs where possible
>
> Signed-off-by: Slawomir Stepien <sst@poczta.fm>
Applied,
Thanks,
Jonathan
> ---
> drivers/iio/common/ms_sensors/ms_sensors_i2c.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/iio/common/ms_sensors/ms_sensors_i2c.c b/drivers/iio/common/ms_sensors/ms_sensors_i2c.c
> index 669dc7c..ecf7721 100644
> --- a/drivers/iio/common/ms_sensors/ms_sensors_i2c.c
> +++ b/drivers/iio/common/ms_sensors/ms_sensors_i2c.c
> @@ -106,7 +106,7 @@ int ms_sensors_convert_and_read(void *cli, u8 conv, u8 rd,
> unsigned int delay, u32 *adc)
> {
> int ret;
> - __be32 buf = 0;
> + __be32 buf = 0;
> struct i2c_client *client = (struct i2c_client *)cli;
>
> /* Trigger conversion */
>
^ permalink raw reply [flat|nested] 48+ messages in thread
* Re: [PATCH 07/10] iio: common: ms_sensors: use tab for indention
@ 2016-04-16 12:34 ` Jonathan Cameron
0 siblings, 0 replies; 48+ messages in thread
From: Jonathan Cameron @ 2016-04-16 12:34 UTC (permalink / raw)
To: Slawomir Stepien, knaack.h, pmeerw; +Cc: linux-iio, kernel-janitors
On 14/04/16 20:36, Slawomir Stepien wrote:
> This fixes the error reported by checkpatch.pl:
>
> ERROR: code indent should use tabs where possible
>
> Signed-off-by: Slawomir Stepien <sst@poczta.fm>
Applied,
Thanks,
Jonathan
> ---
> drivers/iio/common/ms_sensors/ms_sensors_i2c.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/iio/common/ms_sensors/ms_sensors_i2c.c b/drivers/iio/common/ms_sensors/ms_sensors_i2c.c
> index 669dc7c..ecf7721 100644
> --- a/drivers/iio/common/ms_sensors/ms_sensors_i2c.c
> +++ b/drivers/iio/common/ms_sensors/ms_sensors_i2c.c
> @@ -106,7 +106,7 @@ int ms_sensors_convert_and_read(void *cli, u8 conv, u8 rd,
> unsigned int delay, u32 *adc)
> {
> int ret;
> - __be32 buf = 0;
> + __be32 buf = 0;
> struct i2c_client *client = (struct i2c_client *)cli;
>
> /* Trigger conversion */
>
^ permalink raw reply [flat|nested] 48+ messages in thread
* Re: [PATCH 08/10] iio: common: hid-sensors: use tab for indention
2016-04-14 19:36 ` Slawomir Stepien
@ 2016-04-16 12:35 ` Jonathan Cameron
-1 siblings, 0 replies; 48+ messages in thread
From: Jonathan Cameron @ 2016-04-16 12:35 UTC (permalink / raw)
To: Slawomir Stepien, knaack.h, pmeerw; +Cc: linux-iio, kernel-janitors
On 14/04/16 20:36, Slawomir Stepien wrote:
> This fixes the error reported by checkpatch.pl:
>
> ERROR: code indent should use tabs where possible
>
> Signed-off-by: Slawomir Stepien <sst@poczta.fm>
Applied,
Thanks,
Jonathan
> ---
> drivers/iio/common/hid-sensors/hid-sensor-trigger.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/iio/common/hid-sensors/hid-sensor-trigger.c b/drivers/iio/common/hid-sensors/hid-sensor-trigger.c
> index 5955110..5b41f9d 100644
> --- a/drivers/iio/common/hid-sensors/hid-sensor-trigger.c
> +++ b/drivers/iio/common/hid-sensors/hid-sensor-trigger.c
> @@ -115,7 +115,7 @@ int hid_sensor_power_state(struct hid_sensor_common *st, bool state)
> return ret;
> }
>
> - return 0;
> + return 0;
> #else
> atomic_set(&st->user_requested_state, state);
> return _hid_sensor_power_state(st, state);
>
^ permalink raw reply [flat|nested] 48+ messages in thread
* Re: [PATCH 08/10] iio: common: hid-sensors: use tab for indention
@ 2016-04-16 12:35 ` Jonathan Cameron
0 siblings, 0 replies; 48+ messages in thread
From: Jonathan Cameron @ 2016-04-16 12:35 UTC (permalink / raw)
To: Slawomir Stepien, knaack.h, pmeerw; +Cc: linux-iio, kernel-janitors
On 14/04/16 20:36, Slawomir Stepien wrote:
> This fixes the error reported by checkpatch.pl:
>
> ERROR: code indent should use tabs where possible
>
> Signed-off-by: Slawomir Stepien <sst@poczta.fm>
Applied,
Thanks,
Jonathan
> ---
> drivers/iio/common/hid-sensors/hid-sensor-trigger.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/iio/common/hid-sensors/hid-sensor-trigger.c b/drivers/iio/common/hid-sensors/hid-sensor-trigger.c
> index 5955110..5b41f9d 100644
> --- a/drivers/iio/common/hid-sensors/hid-sensor-trigger.c
> +++ b/drivers/iio/common/hid-sensors/hid-sensor-trigger.c
> @@ -115,7 +115,7 @@ int hid_sensor_power_state(struct hid_sensor_common *st, bool state)
> return ret;
> }
>
> - return 0;
> + return 0;
> #else
> atomic_set(&st->user_requested_state, state);
> return _hid_sensor_power_state(st, state);
>
^ permalink raw reply [flat|nested] 48+ messages in thread
* Re: [PATCH 09/10] iio: magnetometer: ak8975: put else and brace at the same line
2016-04-14 19:36 ` Slawomir Stepien
@ 2016-04-16 12:35 ` Jonathan Cameron
-1 siblings, 0 replies; 48+ messages in thread
From: Jonathan Cameron @ 2016-04-16 12:35 UTC (permalink / raw)
To: Slawomir Stepien, knaack.h, pmeerw; +Cc: linux-iio, kernel-janitors
On 14/04/16 20:36, Slawomir Stepien wrote:
> This fixes the error reported by checkpatch.pl:
>
> ERROR: else should follow close brace '}'
>
> Signed-off-by: Slawomir Stepien <sst@poczta.fm>
Applied and thanks,
Jonathan
> ---
> drivers/iio/magnetometer/ak8975.c | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/drivers/iio/magnetometer/ak8975.c b/drivers/iio/magnetometer/ak8975.c
> index 48d127a..6bc855f 100644
> --- a/drivers/iio/magnetometer/ak8975.c
> +++ b/drivers/iio/magnetometer/ak8975.c
> @@ -810,8 +810,7 @@ static int ak8975_probe(struct i2c_client *client,
> name = ak8975_match_acpi_device(&client->dev, &chipset);
> if (!name)
> return -ENODEV;
> - }
> - else
> + } else
> return -ENOSYS;
>
> if (chipset >= AK_MAX_TYPE) {
>
^ permalink raw reply [flat|nested] 48+ messages in thread
* Re: [PATCH 09/10] iio: magnetometer: ak8975: put else and brace at the same line
@ 2016-04-16 12:35 ` Jonathan Cameron
0 siblings, 0 replies; 48+ messages in thread
From: Jonathan Cameron @ 2016-04-16 12:35 UTC (permalink / raw)
To: Slawomir Stepien, knaack.h, pmeerw; +Cc: linux-iio, kernel-janitors
On 14/04/16 20:36, Slawomir Stepien wrote:
> This fixes the error reported by checkpatch.pl:
>
> ERROR: else should follow close brace '}'
>
> Signed-off-by: Slawomir Stepien <sst@poczta.fm>
Applied and thanks,
Jonathan
> ---
> drivers/iio/magnetometer/ak8975.c | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/drivers/iio/magnetometer/ak8975.c b/drivers/iio/magnetometer/ak8975.c
> index 48d127a..6bc855f 100644
> --- a/drivers/iio/magnetometer/ak8975.c
> +++ b/drivers/iio/magnetometer/ak8975.c
> @@ -810,8 +810,7 @@ static int ak8975_probe(struct i2c_client *client,
> name = ak8975_match_acpi_device(&client->dev, &chipset);
> if (!name)
> return -ENODEV;
> - }
> - else
> + } else
> return -ENOSYS;
>
> if (chipset >= AK_MAX_TYPE) {
>
^ permalink raw reply [flat|nested] 48+ messages in thread
* Re: [PATCH 10/10] iio: pressure: ms5611: use tab for indention
2016-04-14 19:36 ` Slawomir Stepien
@ 2016-04-16 12:40 ` Jonathan Cameron
-1 siblings, 0 replies; 48+ messages in thread
From: Jonathan Cameron @ 2016-04-16 12:40 UTC (permalink / raw)
To: Slawomir Stepien, knaack.h, pmeerw; +Cc: linux-iio, kernel-janitors
On 14/04/16 20:36, Slawomir Stepien wrote:
> This fixes the errors reported by checkpatch.pl:
>
> ERROR: code indent should use tabs where possible
>
> Signed-off-by: Slawomir Stepien <sst@poczta.fm>
I modified this one slightly to add the 'extra' spaces needed to maintain the
alignment of the parameters with the open bracket.
Otherwise, good and applied.
Thanks,
Jonathan
> ---
> drivers/iio/pressure/ms5611_core.c | 2 +-
> drivers/iio/pressure/ms5611_spi.c | 2 +-
> 2 files changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/iio/pressure/ms5611_core.c b/drivers/iio/pressure/ms5611_core.c
> index c4e6586..9d192bf 100644
> --- a/drivers/iio/pressure/ms5611_core.c
> +++ b/drivers/iio/pressure/ms5611_core.c
> @@ -429,7 +429,7 @@ static void ms5611_fini(const struct iio_dev *indio_dev)
> }
>
> int ms5611_probe(struct iio_dev *indio_dev, struct device *dev,
> - const char *name, int type)
> + const char *name, int type)
> {
> int ret;
> struct ms5611_state *st = iio_priv(indio_dev);
> diff --git a/drivers/iio/pressure/ms5611_spi.c b/drivers/iio/pressure/ms5611_spi.c
> index 7600483..8f75532 100644
> --- a/drivers/iio/pressure/ms5611_spi.c
> +++ b/drivers/iio/pressure/ms5611_spi.c
> @@ -108,7 +108,7 @@ static int ms5611_spi_probe(struct spi_device *spi)
> st->client = spi;
>
> return ms5611_probe(indio_dev, &spi->dev, spi_get_device_id(spi)->name,
> - spi_get_device_id(spi)->driver_data);
> + spi_get_device_id(spi)->driver_data);
> }
>
> static int ms5611_spi_remove(struct spi_device *spi)
>
^ permalink raw reply [flat|nested] 48+ messages in thread
* Re: [PATCH 10/10] iio: pressure: ms5611: use tab for indention
@ 2016-04-16 12:40 ` Jonathan Cameron
0 siblings, 0 replies; 48+ messages in thread
From: Jonathan Cameron @ 2016-04-16 12:40 UTC (permalink / raw)
To: Slawomir Stepien, knaack.h, pmeerw; +Cc: linux-iio, kernel-janitors
On 14/04/16 20:36, Slawomir Stepien wrote:
> This fixes the errors reported by checkpatch.pl:
>
> ERROR: code indent should use tabs where possible
>
> Signed-off-by: Slawomir Stepien <sst@poczta.fm>
I modified this one slightly to add the 'extra' spaces needed to maintain the
alignment of the parameters with the open bracket.
Otherwise, good and applied.
Thanks,
Jonathan
> ---
> drivers/iio/pressure/ms5611_core.c | 2 +-
> drivers/iio/pressure/ms5611_spi.c | 2 +-
> 2 files changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/iio/pressure/ms5611_core.c b/drivers/iio/pressure/ms5611_core.c
> index c4e6586..9d192bf 100644
> --- a/drivers/iio/pressure/ms5611_core.c
> +++ b/drivers/iio/pressure/ms5611_core.c
> @@ -429,7 +429,7 @@ static void ms5611_fini(const struct iio_dev *indio_dev)
> }
>
> int ms5611_probe(struct iio_dev *indio_dev, struct device *dev,
> - const char *name, int type)
> + const char *name, int type)
> {
> int ret;
> struct ms5611_state *st = iio_priv(indio_dev);
> diff --git a/drivers/iio/pressure/ms5611_spi.c b/drivers/iio/pressure/ms5611_spi.c
> index 7600483..8f75532 100644
> --- a/drivers/iio/pressure/ms5611_spi.c
> +++ b/drivers/iio/pressure/ms5611_spi.c
> @@ -108,7 +108,7 @@ static int ms5611_spi_probe(struct spi_device *spi)
> st->client = spi;
>
> return ms5611_probe(indio_dev, &spi->dev, spi_get_device_id(spi)->name,
> - spi_get_device_id(spi)->driver_data);
> + spi_get_device_id(spi)->driver_data);
> }
>
> static int ms5611_spi_remove(struct spi_device *spi)
>
^ permalink raw reply [flat|nested] 48+ messages in thread
end of thread, other threads:[~2016-04-16 12:40 UTC | newest]
Thread overview: 48+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2016-04-14 19:36 [PATCH 00/10] iio: fix errors reported by checkpatch.pl Slawomir Stepien
2016-04-14 19:36 ` Slawomir Stepien
2016-04-14 19:36 ` [PATCH 01/10] iio: light apds9960: fix wrong use of brace Slawomir Stepien
2016-04-14 19:36 ` Slawomir Stepien
2016-04-14 23:29 ` Matt Ranostay
2016-04-14 23:29 ` Matt Ranostay
2016-04-15 14:56 ` Slawomir Stepien
2016-04-15 14:56 ` Slawomir Stepien
2016-04-16 9:48 ` Dan Carpenter
2016-04-16 9:48 ` Dan Carpenter
2016-04-16 12:30 ` Jonathan Cameron
2016-04-16 12:30 ` Jonathan Cameron
2016-04-14 19:36 ` [PATCH 02/10] iio: inkern: add a missing space before if Slawomir Stepien
2016-04-14 19:36 ` Slawomir Stepien
2016-04-16 12:31 ` Jonathan Cameron
2016-04-16 12:31 ` Jonathan Cameron
2016-04-14 19:36 ` [PATCH 03/10] iio: adc: vf610_adc: fix case label indent Slawomir Stepien
2016-04-14 19:36 ` Slawomir Stepien
2016-04-16 12:31 ` Jonathan Cameron
2016-04-16 12:31 ` Jonathan Cameron
2016-04-14 19:36 ` [PATCH 04/10] iio: adc: mcp3422: remove spaces before comma Slawomir Stepien
2016-04-14 19:36 ` Slawomir Stepien
2016-04-16 12:32 ` Jonathan Cameron
2016-04-16 12:32 ` Jonathan Cameron
2016-04-14 19:36 ` [PATCH 05/10] iio: adc: at91_adc: fix errors reported by checkpatch.pl Slawomir Stepien
2016-04-14 19:36 ` Slawomir Stepien
2016-04-16 12:33 ` Jonathan Cameron
2016-04-16 12:33 ` Jonathan Cameron
2016-04-14 19:36 ` [PATCH 06/10] iio: adc: ad799x: remove space before comma Slawomir Stepien
2016-04-14 19:36 ` Slawomir Stepien
2016-04-16 12:34 ` Jonathan Cameron
2016-04-16 12:34 ` Jonathan Cameron
2016-04-14 19:36 ` [PATCH 07/10] iio: common: ms_sensors: use tab for indention Slawomir Stepien
2016-04-14 19:36 ` Slawomir Stepien
2016-04-16 12:34 ` Jonathan Cameron
2016-04-16 12:34 ` Jonathan Cameron
2016-04-14 19:36 ` [PATCH 08/10] iio: common: hid-sensors: " Slawomir Stepien
2016-04-14 19:36 ` Slawomir Stepien
2016-04-16 12:35 ` Jonathan Cameron
2016-04-16 12:35 ` Jonathan Cameron
2016-04-14 19:36 ` [PATCH 09/10] iio: magnetometer: ak8975: put else and brace at the same line Slawomir Stepien
2016-04-14 19:36 ` Slawomir Stepien
2016-04-16 12:35 ` Jonathan Cameron
2016-04-16 12:35 ` Jonathan Cameron
2016-04-14 19:36 ` [PATCH 10/10] iio: pressure: ms5611: use tab for indention Slawomir Stepien
2016-04-14 19:36 ` Slawomir Stepien
2016-04-16 12:40 ` Jonathan Cameron
2016-04-16 12:40 ` Jonathan Cameron
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.