* [U-Boot] [PATCH 1/2] board/t4240rdb: Disable the non-existent ethernet port on T4240RDB
@ 2016-04-15 6:19 ying.zhang at freescale.com
2016-04-15 6:19 ` [U-Boot] [PATCH 2/2] board/t4240rdb: some ethernet ports shouldn't be detected ying.zhang at freescale.com
0 siblings, 1 reply; 6+ messages in thread
From: ying.zhang at freescale.com @ 2016-04-15 6:19 UTC (permalink / raw)
To: u-boot
From: Ying Zhang <b40530@freescale.com>
There are 12 ethernet port on T4240RDB, but there need to set 16
MAC addressed for ethernets.
There need to disable non-existent ethernet ports in U-boot
Signed-off-by: Ying Zhang <b40530@freescale.com>
---
board/freescale/t4rdb/eth.c | 5 +++++
1 file changed, 5 insertions(+)
diff --git a/board/freescale/t4rdb/eth.c b/board/freescale/t4rdb/eth.c
index e563a61..ae2451e 100644
--- a/board/freescale/t4rdb/eth.c
+++ b/board/freescale/t4rdb/eth.c
@@ -77,6 +77,9 @@ int board_eth_init(bd_t *bis)
puts("Invalid SerDes1 protocol for T4240RDB\n");
}
+ fm_disable_port(FM1_DTSEC5);
+ fm_disable_port(FM1_DTSEC6);
+
for (i = FM1_DTSEC1; i < FM1_DTSEC1 + CONFIG_SYS_NUM_FM1_DTSEC; i++) {
interface = fm_info_get_enet_if(i);
switch (interface) {
@@ -115,6 +118,8 @@ int board_eth_init(bd_t *bis)
puts("Invalid SerDes2 protocol for T4240RDB\n");
}
+ fm_disable_port(FM2_DTSEC5);
+ fm_disable_port(FM2_DTSEC6);
for (i = FM2_DTSEC1; i < FM2_DTSEC1 + CONFIG_SYS_NUM_FM2_DTSEC; i++) {
interface = fm_info_get_enet_if(i);
switch (interface) {
--
2.1.0.27.g96db324
^ permalink raw reply related [flat|nested] 6+ messages in thread
* [U-Boot] [PATCH 2/2] board/t4240rdb: some ethernet ports shouldn't be detected
2016-04-15 6:19 [U-Boot] [PATCH 1/2] board/t4240rdb: Disable the non-existent ethernet port on T4240RDB ying.zhang at freescale.com
@ 2016-04-15 6:19 ` ying.zhang at freescale.com
2016-04-15 7:45 ` Shengzhou Liu
` (2 more replies)
0 siblings, 3 replies; 6+ messages in thread
From: ying.zhang at freescale.com @ 2016-04-15 6:19 UTC (permalink / raw)
To: u-boot
From: Ying Zhang <b40530@freescale.com>
FM1_DTSEC9 & FM1_DTSEC10 should not be detected.
Signed-off-by: Ying Zhang <b40530@freescale.com>
---
drivers/net/fm/t4240.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/net/fm/t4240.c b/drivers/net/fm/t4240.c
index ae5aca4..70887fa 100644
--- a/drivers/net/fm/t4240.c
+++ b/drivers/net/fm/t4240.c
@@ -74,7 +74,7 @@ phy_interface_t fman_port_enet_if(enum fm_port port)
if ((port == FM1_DTSEC9 || port == FM1_DTSEC10) &&
((is_serdes_configured(XFI_FM1_MAC9)) ||
(is_serdes_configured(XFI_FM1_MAC10))))
- return PHY_INTERFACE_MODE_XGMII;
+ return PHY_INTERFACE_MODE_NONE;
if ((port == FM2_10GEC1 || port == FM2_10GEC2) &&
((is_serdes_configured(XAUI_FM2_MAC9)) ||
--
2.1.0.27.g96db324
^ permalink raw reply related [flat|nested] 6+ messages in thread
* [U-Boot] [PATCH 2/2] board/t4240rdb: some ethernet ports shouldn't be detected
2016-04-15 6:19 ` [U-Boot] [PATCH 2/2] board/t4240rdb: some ethernet ports shouldn't be detected ying.zhang at freescale.com
@ 2016-04-15 7:45 ` Shengzhou Liu
2016-04-15 7:52 ` Wolfgang Denk
2016-04-15 7:58 ` Shengzhou Liu
2 siblings, 0 replies; 6+ messages in thread
From: Shengzhou Liu @ 2016-04-15 7:45 UTC (permalink / raw)
To: u-boot
> -----Original Message-----
> From: U-Boot [mailto:u-boot-bounces at lists.denx.de] On Behalf Of
> ying.zhang at freescale.com
> Sent: Friday, April 15, 2016 2:19 PM
> To: u-boot at lists.denx.de
> Cc: yorksun at freescale.com; Ying Zhang <b40530@freescale.com>
> Subject: [U-Boot] [PATCH 2/2] board/t4240rdb: some ethernet ports
> shouldn't be detected
>
> From: Ying Zhang <b40530@freescale.com>
>
> FM1_DTSEC9 & FM1_DTSEC10 should not be detected.
>
> Signed-off-by: Ying Zhang <b40530@freescale.com>
> ---
> drivers/net/fm/t4240.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/net/fm/t4240.c b/drivers/net/fm/t4240.c index
> ae5aca4..70887fa 100644
> --- a/drivers/net/fm/t4240.c
> +++ b/drivers/net/fm/t4240.c
> @@ -74,7 +74,7 @@ phy_interface_t fman_port_enet_if(enum fm_port port)
> if ((port == FM1_DTSEC9 || port == FM1_DTSEC10) &&
> ((is_serdes_configured(XFI_FM1_MAC9)) ||
> (is_serdes_configured(XFI_FM1_MAC10))))
> - return PHY_INTERFACE_MODE_XGMII;
> + return PHY_INTERFACE_MODE_NONE;
This patch is making things wrongly, FM1_DTSEC9 & FM1_DTSEC10 should be configured when RCW uses the these MACs.
-Shengzhou
^ permalink raw reply [flat|nested] 6+ messages in thread
* [U-Boot] [PATCH 2/2] board/t4240rdb: some ethernet ports shouldn't be detected
2016-04-15 6:19 ` [U-Boot] [PATCH 2/2] board/t4240rdb: some ethernet ports shouldn't be detected ying.zhang at freescale.com
2016-04-15 7:45 ` Shengzhou Liu
@ 2016-04-15 7:52 ` Wolfgang Denk
2016-04-15 7:58 ` Shengzhou Liu
2 siblings, 0 replies; 6+ messages in thread
From: Wolfgang Denk @ 2016-04-15 7:52 UTC (permalink / raw)
To: u-boot
Dear ying.zhang at freescale.com,
In message <1460701149-36278-2-git-send-email-ying.zhang@freescale.com> you wrote:
> From: Ying Zhang <b40530@freescale.com>
>
> FM1_DTSEC9 & FM1_DTSEC10 should not be detected.
Can you please explain (and add the explanation to the commit message)
what this means?
Are this ports detected, but not predent on this board? Or should
they be hidden for some purpose? Why? Or what else?
Best regards,
Wolfgang Denk
--
DENX Software Engineering GmbH, Managing Director: Wolfgang Denk
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
In Nature there are neither rewards nor punishments, there are conse-
quences. -- R.G. Ingersoll
^ permalink raw reply [flat|nested] 6+ messages in thread
* [U-Boot] [PATCH 2/2] board/t4240rdb: some ethernet ports shouldn't be detected
2016-04-15 6:19 ` [U-Boot] [PATCH 2/2] board/t4240rdb: some ethernet ports shouldn't be detected ying.zhang at freescale.com
2016-04-15 7:45 ` Shengzhou Liu
2016-04-15 7:52 ` Wolfgang Denk
@ 2016-04-15 7:58 ` Shengzhou Liu
2016-04-15 8:17 ` Shaohui Xie
2 siblings, 1 reply; 6+ messages in thread
From: Shengzhou Liu @ 2016-04-15 7:58 UTC (permalink / raw)
To: u-boot
> -----Original Message-----
> From: Shengzhou Liu
> Sent: Friday, April 15, 2016 3:45 PM
> To: 'ying.zhang at freescale.com' <ying.zhang@freescale.com>; u-
> boot at lists.denx.de
> Cc: yorksun at freescale.com; Ying Zhang <b40530@freescale.com>
> Subject: RE: [U-Boot] [PATCH 2/2] board/t4240rdb: some ethernet ports
> shouldn't be detected
>
>
> > -----Original Message-----
> > From: U-Boot [mailto:u-boot-bounces at lists.denx.de] On Behalf Of
> > ying.zhang at freescale.com
> > Sent: Friday, April 15, 2016 2:19 PM
> > To: u-boot at lists.denx.de
> > Cc: yorksun at freescale.com; Ying Zhang <b40530@freescale.com>
> > Subject: [U-Boot] [PATCH 2/2] board/t4240rdb: some ethernet ports
> > shouldn't be detected
> >
> > From: Ying Zhang <b40530@freescale.com>
> >
> > FM1_DTSEC9 & FM1_DTSEC10 should not be detected.
> >
> > Signed-off-by: Ying Zhang <b40530@freescale.com>
> > ---
> > drivers/net/fm/t4240.c | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/drivers/net/fm/t4240.c b/drivers/net/fm/t4240.c index
> > ae5aca4..70887fa 100644
> > --- a/drivers/net/fm/t4240.c
> > +++ b/drivers/net/fm/t4240.c
> > @@ -74,7 +74,7 @@ phy_interface_t fman_port_enet_if(enum fm_port
> port)
> > if ((port == FM1_DTSEC9 || port == FM1_DTSEC10) &&
> > ((is_serdes_configured(XFI_FM1_MAC9)) ||
> > (is_serdes_configured(XFI_FM1_MAC10))))
> > - return PHY_INTERFACE_MODE_XGMII;
> > + return PHY_INTERFACE_MODE_NONE;
>
> This patch is making things wrongly, FM1_DTSEC9 & FM1_DTSEC10 should
> be configured when RCW uses the these MACs.
> -Shengzhou
Sorry, I missed the condition, the change is right.
Shengzhou
^ permalink raw reply [flat|nested] 6+ messages in thread
* [U-Boot] [PATCH 2/2] board/t4240rdb: some ethernet ports shouldn't be detected
2016-04-15 7:58 ` Shengzhou Liu
@ 2016-04-15 8:17 ` Shaohui Xie
0 siblings, 0 replies; 6+ messages in thread
From: Shaohui Xie @ 2016-04-15 8:17 UTC (permalink / raw)
To: u-boot
Hi Ying,
The commit message should be more clear about what is wrong.
Like when using protocols to support 10G on MAC9 and MAC10, these
MACs should not be identified as 1G interface, otherwise, one MAC will be
Listed as two Ethernet ports, for ex. MAC9 will be listed as FM1 at TGEC1
And FM1 at DTSEC9.
Thanks,
Shaohui
> -----Original Message-----
> From: U-Boot [mailto:u-boot-bounces at lists.denx.de] On Behalf Of Shengzhou Liu
> Sent: Friday, April 15, 2016 3:58 PM
> To: ying.zhang at freescale.com; u-boot at lists.denx.de
> Cc: yorksun at freescale.com; Ying Zhang <b40530@freescale.com>
> Subject: Re: [U-Boot] [PATCH 2/2] board/t4240rdb: some ethernet ports shouldn't
> be detected
>
>
>
> > -----Original Message-----
> > From: Shengzhou Liu
> > Sent: Friday, April 15, 2016 3:45 PM
> > To: 'ying.zhang at freescale.com' <ying.zhang@freescale.com>; u-
> > boot at lists.denx.de
> > Cc: yorksun at freescale.com; Ying Zhang <b40530@freescale.com>
> > Subject: RE: [U-Boot] [PATCH 2/2] board/t4240rdb: some ethernet ports
> > shouldn't be detected
> >
> >
> > > -----Original Message-----
> > > From: U-Boot [mailto:u-boot-bounces at lists.denx.de] On Behalf Of
> > > ying.zhang at freescale.com
> > > Sent: Friday, April 15, 2016 2:19 PM
> > > To: u-boot at lists.denx.de
> > > Cc: yorksun at freescale.com; Ying Zhang <b40530@freescale.com>
> > > Subject: [U-Boot] [PATCH 2/2] board/t4240rdb: some ethernet ports
> > > shouldn't be detected
> > >
> > > From: Ying Zhang <b40530@freescale.com>
> > >
> > > FM1_DTSEC9 & FM1_DTSEC10 should not be detected.
> > >
> > > Signed-off-by: Ying Zhang <b40530@freescale.com>
> > > ---
> > > drivers/net/fm/t4240.c | 2 +-
> > > 1 file changed, 1 insertion(+), 1 deletion(-)
> > >
> > > diff --git a/drivers/net/fm/t4240.c b/drivers/net/fm/t4240.c index
> > > ae5aca4..70887fa 100644
> > > --- a/drivers/net/fm/t4240.c
> > > +++ b/drivers/net/fm/t4240.c
> > > @@ -74,7 +74,7 @@ phy_interface_t fman_port_enet_if(enum fm_port
> > port)
> > > if ((port == FM1_DTSEC9 || port == FM1_DTSEC10) &&
> > > ((is_serdes_configured(XFI_FM1_MAC9)) ||
> > > (is_serdes_configured(XFI_FM1_MAC10))))
> > > - return PHY_INTERFACE_MODE_XGMII;
> > > + return PHY_INTERFACE_MODE_NONE;
> >
> > This patch is making things wrongly, FM1_DTSEC9 & FM1_DTSEC10 should
> > be configured when RCW uses the these MACs.
> > -Shengzhou
> Sorry, I missed the condition, the change is right.
> Shengzhou
> _______________________________________________
> U-Boot mailing list
> U-Boot at lists.denx.de
> http://lists.denx.de/mailman/listinfo/u-boot
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2016-04-15 8:17 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2016-04-15 6:19 [U-Boot] [PATCH 1/2] board/t4240rdb: Disable the non-existent ethernet port on T4240RDB ying.zhang at freescale.com
2016-04-15 6:19 ` [U-Boot] [PATCH 2/2] board/t4240rdb: some ethernet ports shouldn't be detected ying.zhang at freescale.com
2016-04-15 7:45 ` Shengzhou Liu
2016-04-15 7:52 ` Wolfgang Denk
2016-04-15 7:58 ` Shengzhou Liu
2016-04-15 8:17 ` Shaohui Xie
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.