* [PATCH] drivers/leds/leds-ss4200.c: add DMI data for FSC SCALEO Home Server
@ 2016-04-17 11:14 Martin Dummer
2016-04-18 9:00 ` Jacek Anaszewski
2016-04-19 5:51 ` [PATCH v2] " Martin Dummer
0 siblings, 2 replies; 5+ messages in thread
From: Martin Dummer @ 2016-04-17 11:14 UTC (permalink / raw)
To: j.anaszewski, rpurdie; +Cc: Martin Dummer, linux-leds
The Intel NAS SS4200 was also sold by Fujitsu Siemens (FSC) under
the name "SCALEO Home Server". The hardware is equivalent.
This patch adds the DMI data of this rebranded device.
Signed-off-by: Martin Dummer <martin.dummer@gmx.net>
---
drivers/leds/leds-ss4200.c | 10 ++++++++++
1 file changed, 10 insertions(+)
diff --git a/drivers/leds/leds-ss4200.c b/drivers/leds/leds-ss4200.c
index 046cb70..a3aa02e 100644
--- a/drivers/leds/leds-ss4200.c
+++ b/drivers/leds/leds-ss4200.c
@@ -101,6 +101,16 @@ static struct dmi_system_id nas_led_whitelist[] __initdata = {
DMI_MATCH(DMI_PRODUCT_VERSION, "1.00.00")
}
},
+ {
+ // FUJITSU SIEMENS SCALEO Home Server/SS4200-E, BIOS V090L 12/19/2007
+ .callback = ss4200_led_dmi_callback,
+ .ident = "Fujitsu Siemens SCALEO Home Server",
+ .matches = {
+ DMI_MATCH(DMI_SYS_VENDOR, "FUJITSU SIEMENS"),
+ DMI_MATCH(DMI_PRODUCT_NAME, "SCALEO Home Server"),
+ DMI_MATCH(DMI_PRODUCT_VERSION, "1.00.00")
+ }
+ },
{}
};
--
2.7.3
^ permalink raw reply related [flat|nested] 5+ messages in thread
* Re: [PATCH] drivers/leds/leds-ss4200.c: add DMI data for FSC SCALEO Home Server
2016-04-17 11:14 [PATCH] drivers/leds/leds-ss4200.c: add DMI data for FSC SCALEO Home Server Martin Dummer
@ 2016-04-18 9:00 ` Jacek Anaszewski
2016-04-19 5:12 ` Martin Dummer
2016-04-19 5:51 ` [PATCH v2] " Martin Dummer
1 sibling, 1 reply; 5+ messages in thread
From: Jacek Anaszewski @ 2016-04-18 9:00 UTC (permalink / raw)
To: Martin Dummer; +Cc: rpurdie, linux-leds
Hi Martin,
Thanks for the patch. I have one remark below.
On 04/17/2016 01:14 PM, Martin Dummer wrote:
> The Intel NAS SS4200 was also sold by Fujitsu Siemens (FSC) under
> the name "SCALEO Home Server". The hardware is equivalent.
>
> This patch adds the DMI data of this rebranded device.
>
> Signed-off-by: Martin Dummer <martin.dummer@gmx.net>
> ---
> drivers/leds/leds-ss4200.c | 10 ++++++++++
> 1 file changed, 10 insertions(+)
>
> diff --git a/drivers/leds/leds-ss4200.c b/drivers/leds/leds-ss4200.c
> index 046cb70..a3aa02e 100644
> --- a/drivers/leds/leds-ss4200.c
> +++ b/drivers/leds/leds-ss4200.c
> @@ -101,6 +101,16 @@ static struct dmi_system_id nas_led_whitelist[] __initdata = {
> DMI_MATCH(DMI_PRODUCT_VERSION, "1.00.00")
> }
> },
> + {
> + // FUJITSU SIEMENS SCALEO Home Server/SS4200-E, BIOS V090L 12/19/2007
checkpatch.pl complains here:
WARNING: line over 80 characters
ERROR: do not use C99 // comments
> + .callback = ss4200_led_dmi_callback,
> + .ident = "Fujitsu Siemens SCALEO Home Server",
> + .matches = {
> + DMI_MATCH(DMI_SYS_VENDOR, "FUJITSU SIEMENS"),
> + DMI_MATCH(DMI_PRODUCT_NAME, "SCALEO Home Server"),
> + DMI_MATCH(DMI_PRODUCT_VERSION, "1.00.00")
> + }
> + },
> {}
> };
>
>
--
Best regards,
Jacek Anaszewski
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] drivers/leds/leds-ss4200.c: add DMI data for FSC SCALEO Home Server
2016-04-18 9:00 ` Jacek Anaszewski
@ 2016-04-19 5:12 ` Martin Dummer
0 siblings, 0 replies; 5+ messages in thread
From: Martin Dummer @ 2016-04-19 5:12 UTC (permalink / raw)
To: Jacek Anaszewski; +Cc: rpurdie, linux-leds
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1
Hello Jacek,
Am 18.04.2016 um 11:00 schrieb Jacek Anaszewski:
> checkpatch.pl complains here:
yes - you're right, I'll send a V2
Regards,
Martin
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v2
iEYEARECAAYFAlcVvjUACgkQrl/4JlwVxHi9iQCfflEf9TuvfEWDXCiVSs9bZFns
//AAoPAoOC2AySGAt8NyLkVccnSwCynw
=aJm0
-----END PGP SIGNATURE-----
^ permalink raw reply [flat|nested] 5+ messages in thread
* [PATCH v2] drivers/leds/leds-ss4200.c: add DMI data for FSC SCALEO Home Server
2016-04-17 11:14 [PATCH] drivers/leds/leds-ss4200.c: add DMI data for FSC SCALEO Home Server Martin Dummer
2016-04-18 9:00 ` Jacek Anaszewski
@ 2016-04-19 5:51 ` Martin Dummer
2016-04-19 7:14 ` Jacek Anaszewski
1 sibling, 1 reply; 5+ messages in thread
From: Martin Dummer @ 2016-04-19 5:51 UTC (permalink / raw)
To: j.anaszewski; +Cc: Martin Dummer, rpurdie, linux-leds
The Intel NAS SS4200 was also sold by Fujitsu Siemens (FSC) under
the name "SCALEO Home Server". The hardware is equivalent.
This patch adds the DMI data of this rebranded device.
Signed-off-by: Martin Dummer <martin.dummer@gmx.net>
---
drivers/leds/leds-ss4200.c | 13 +++++++++++++
1 file changed, 13 insertions(+)
diff --git a/drivers/leds/leds-ss4200.c b/drivers/leds/leds-ss4200.c
index 046cb70..732eb86 100644
--- a/drivers/leds/leds-ss4200.c
+++ b/drivers/leds/leds-ss4200.c
@@ -101,6 +101,19 @@ static struct dmi_system_id nas_led_whitelist[] __initdata = {
DMI_MATCH(DMI_PRODUCT_VERSION, "1.00.00")
}
},
+ {
+ /*
+ * FUJITSU SIEMENS SCALEO Home Server/SS4200-E
+ * BIOS V090L 12/19/2007
+ */
+ .callback = ss4200_led_dmi_callback,
+ .ident = "Fujitsu Siemens SCALEO Home Server",
+ .matches = {
+ DMI_MATCH(DMI_SYS_VENDOR, "FUJITSU SIEMENS"),
+ DMI_MATCH(DMI_PRODUCT_NAME, "SCALEO Home Server"),
+ DMI_MATCH(DMI_PRODUCT_VERSION, "1.00.00")
+ }
+ },
{}
};
--
2.7.3
^ permalink raw reply related [flat|nested] 5+ messages in thread
* Re: [PATCH v2] drivers/leds/leds-ss4200.c: add DMI data for FSC SCALEO Home Server
2016-04-19 5:51 ` [PATCH v2] " Martin Dummer
@ 2016-04-19 7:14 ` Jacek Anaszewski
0 siblings, 0 replies; 5+ messages in thread
From: Jacek Anaszewski @ 2016-04-19 7:14 UTC (permalink / raw)
To: Martin Dummer; +Cc: rpurdie, linux-leds
Hi Martin,
On 04/19/2016 07:51 AM, Martin Dummer wrote:
> The Intel NAS SS4200 was also sold by Fujitsu Siemens (FSC) under
> the name "SCALEO Home Server". The hardware is equivalent.
>
> This patch adds the DMI data of this rebranded device.
>
> Signed-off-by: Martin Dummer <martin.dummer@gmx.net>
> ---
> drivers/leds/leds-ss4200.c | 13 +++++++++++++
> 1 file changed, 13 insertions(+)
>
> diff --git a/drivers/leds/leds-ss4200.c b/drivers/leds/leds-ss4200.c
> index 046cb70..732eb86 100644
> --- a/drivers/leds/leds-ss4200.c
> +++ b/drivers/leds/leds-ss4200.c
> @@ -101,6 +101,19 @@ static struct dmi_system_id nas_led_whitelist[] __initdata = {
> DMI_MATCH(DMI_PRODUCT_VERSION, "1.00.00")
> }
> },
> + {
> + /*
> + * FUJITSU SIEMENS SCALEO Home Server/SS4200-E
> + * BIOS V090L 12/19/2007
> + */
> + .callback = ss4200_led_dmi_callback,
> + .ident = "Fujitsu Siemens SCALEO Home Server",
> + .matches = {
> + DMI_MATCH(DMI_SYS_VENDOR, "FUJITSU SIEMENS"),
> + DMI_MATCH(DMI_PRODUCT_NAME, "SCALEO Home Server"),
> + DMI_MATCH(DMI_PRODUCT_VERSION, "1.00.00")
> + }
> + },
> {}
> };
>
>
Thanks for the update, applied.
--
Best regards,
Jacek Anaszewski
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2016-04-19 7:14 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2016-04-17 11:14 [PATCH] drivers/leds/leds-ss4200.c: add DMI data for FSC SCALEO Home Server Martin Dummer
2016-04-18 9:00 ` Jacek Anaszewski
2016-04-19 5:12 ` Martin Dummer
2016-04-19 5:51 ` [PATCH v2] " Martin Dummer
2016-04-19 7:14 ` Jacek Anaszewski
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.