[PATCH] cxl: static-ify variables to fix sparse warnings

[PATCH] cxl: static-ify variables to fix sparse warnings

[Andrew Donnellan]

Make a couple more variables static. Found by sparse.

Signed-off-by: Andrew Donnellan <andrew.donnellan@au1.ibm.com>
---
 drivers/misc/cxl/flash.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/misc/cxl/flash.c b/drivers/misc/cxl/flash.c
index 68dd0b7..c63d61e 100644
--- a/drivers/misc/cxl/flash.c
+++ b/drivers/misc/cxl/flash.c
@@ -24,8 +24,8 @@ struct ai_header {
 };
 
 static struct semaphore sem;
-unsigned long *buffer[CXL_AI_MAX_ENTRIES];
-struct sg_list *le;
+static unsigned long *buffer[CXL_AI_MAX_ENTRIES];
+static struct sg_list *le;
 static u64 continue_token;
 static unsigned int transfer;
 
-- 
Andrew Donnellan              OzLabs, ADL Canberra
andrew.donnellan@au1.ibm.com  IBM Australia Limited

Re: [PATCH] cxl: static-ify variables to fix sparse warnings

[Frederic Barrat]

Thanks Andrew!

Reviewed-by: fbarrat@linux.vnet.ibm.com

  Fred


Le 18/04/2016 07:03, Andrew Donnellan a écrit :
> Make a couple more variables static. Found by sparse.
>
> Signed-off-by: Andrew Donnellan <andrew.donnellan@au1.ibm.com>
> ---
>   drivers/misc/cxl/flash.c | 4 ++--
>   1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/misc/cxl/flash.c b/drivers/misc/cxl/flash.c
> index 68dd0b7..c63d61e 100644
> --- a/drivers/misc/cxl/flash.c
> +++ b/drivers/misc/cxl/flash.c
> @@ -24,8 +24,8 @@ struct ai_header {
>   };
>
>   static struct semaphore sem;
> -unsigned long *buffer[CXL_AI_MAX_ENTRIES];
> -struct sg_list *le;
> +static unsigned long *buffer[CXL_AI_MAX_ENTRIES];
> +static struct sg_list *le;
>   static u64 continue_token;
>   static unsigned int transfer;
>
>

Re: [PATCH] cxl: static-ify variables to fix sparse warnings

[Matthew R. Ochs]

Reviewed-by: Matthew R. Ochs <mrochs@linux.vnet.ibm.com>

Re: [PATCH] cxl: static-ify variables to fix sparse warnings

[Ian Munsie]

Acked-by: Ian Munsie <imunsie@au1.ibm.com>

Re: cxl: static-ify variables to fix sparse warnings

[Michael Ellerman]

On Mon, 2016-18-04 at 05:03:50 UTC, Andrew Donnellan wrote:
> Make a couple more variables static. Found by sparse.
> 
> Signed-off-by: Andrew Donnellan <andrew.donnellan@au1.ibm.com>
> Reviewed-by: fbarrat@linux.vnet.ibm.com
> Reviewed-by: Matthew R. Ochs <mrochs@linux.vnet.ibm.com>
> Acked-by: Ian Munsie <imunsie@au1.ibm.com>

Applied to powerpc next, thanks.

https://git.kernel.org/powerpc/c/64417a398973d964139306c0b1

cheers