* [PATCH 0/3] staging: unisys: add polish to structs: visor_driver and visor_device
@ 2016-04-19 3:21 David Kershner
2016-04-19 3:22 ` [PATCH 1/3] staging: unisys: include: remove unused fields from struct visor_driver David Kershner
` (2 more replies)
0 siblings, 3 replies; 4+ messages in thread
From: David Kershner @ 2016-04-19 3:21 UTC (permalink / raw)
To: gregkh, driverdev-devel, sparmaintainer
For 'struct visor_driver' and 'struct visor_device':
* unused members have been removed
* kernel-doc comments have been added
Alexander Curtin (2):
staging: unisys: include: Added kernel-doc for struct visor_driver
staging: unisys: include: Added kerneldoc comments to visor_device
Tim Sell (1):
staging: unisys: include: remove unused fields from struct
visor_driver
drivers/staging/unisys/include/visorbus.h | 112 ++++++++++++++++++------------
1 file changed, 68 insertions(+), 44 deletions(-)
--
1.9.1
_______________________________________________
devel mailing list
devel@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
^ permalink raw reply [flat|nested] 4+ messages in thread
* [PATCH 1/3] staging: unisys: include: remove unused fields from struct visor_driver
2016-04-19 3:21 [PATCH 0/3] staging: unisys: add polish to structs: visor_driver and visor_device David Kershner
@ 2016-04-19 3:22 ` David Kershner
2016-04-19 3:22 ` [PATCH 2/3] staging: unisys: include: Added kernel-doc for " David Kershner
2016-04-19 3:22 ` [PATCH 3/3] staging: unisys: include: Added kerneldoc comments to visor_device David Kershner
2 siblings, 0 replies; 4+ messages in thread
From: David Kershner @ 2016-04-19 3:22 UTC (permalink / raw)
To: gregkh, driverdev-devel, sparmaintainer; +Cc: Tim Sell
From: Tim Sell <Timothy.Sell@unisys.com>
The build_date and build_time fields are not used, and have been removed.
Signed-off-by: Tim Sell <Timothy.Sell@unisys.com>
Signed-off-by: David Kershner <david.kershner@unisys.com>
---
drivers/staging/unisys/include/visorbus.h | 2 --
1 file changed, 2 deletions(-)
diff --git a/drivers/staging/unisys/include/visorbus.h b/drivers/staging/unisys/include/visorbus.h
index db59d97..3cc511f 100644
--- a/drivers/staging/unisys/include/visorbus.h
+++ b/drivers/staging/unisys/include/visorbus.h
@@ -68,8 +68,6 @@ struct visor_driver {
const char *name;
const char *version;
const char *vertag;
- const char *build_date;
- const char *build_time;
struct module *owner;
/** Types of channels handled by this driver, ending with 0 GUID.
--
1.9.1
_______________________________________________
devel mailing list
devel@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
^ permalink raw reply related [flat|nested] 4+ messages in thread
* [PATCH 2/3] staging: unisys: include: Added kernel-doc for struct visor_driver
2016-04-19 3:21 [PATCH 0/3] staging: unisys: add polish to structs: visor_driver and visor_device David Kershner
2016-04-19 3:22 ` [PATCH 1/3] staging: unisys: include: remove unused fields from struct visor_driver David Kershner
@ 2016-04-19 3:22 ` David Kershner
2016-04-19 3:22 ` [PATCH 3/3] staging: unisys: include: Added kerneldoc comments to visor_device David Kershner
2 siblings, 0 replies; 4+ messages in thread
From: David Kershner @ 2016-04-19 3:22 UTC (permalink / raw)
To: gregkh, driverdev-devel, sparmaintainer; +Cc: Tim Sell
From: Alexander Curtin <alexander.curtin@unisys.com>
This adds kerneldoc style comments to the visor_driver struct since
it's shared between multiple modules.
Signed-off-by: Alexander Curtin <alexander.curtin@unisys.com>
Signed-off-by: Tim Sell <Timothy.Sell@unisys.com>
Signed-off-by: David Kershner <david.kershner@unisys.com>
---
drivers/staging/unisys/include/visorbus.h | 65 ++++++++++++++++---------------
1 file changed, 34 insertions(+), 31 deletions(-)
diff --git a/drivers/staging/unisys/include/visorbus.h b/drivers/staging/unisys/include/visorbus.h
index 3cc511f..9cc492a 100644
--- a/drivers/staging/unisys/include/visorbus.h
+++ b/drivers/staging/unisys/include/visorbus.h
@@ -61,52 +61,55 @@ struct visor_channeltype_descriptor {
const char *name;
};
-/** Information provided by each visor driver when it registers with the
- * visorbus driver.
+/**
+ * struct visor_driver - Information provided by each visor driver when it
+ * registers with the visorbus driver.
+ * @name: Name of the visor driver.
+ * @version: The numbered version of the driver (x.x.xxx).
+ * @vertag: A human readable version string.
+ * @owner: The module owner.
+ * @channel_types: Types of channels handled by this driver, ending with
+ * a zero GUID. Our specialized BUS.match() method knows
+ * about this list, and uses it to determine whether this
+ * driver will in fact handle a new device that it has
+ * detected.
+ * @probe: Called when a new device comes online, by our probe()
+ * function specified by driver.probe() (triggered
+ * ultimately by some call to driver_register(),
+ * bus_add_driver(), or driver_attach()).
+ * @remove: Called when a new device is removed, by our remove()
+ * function specified by driver.remove() (triggered
+ * ultimately by some call to device_release_driver()).
+ * @channel_interrupt: Called periodically, whenever there is a possiblity
+ * that "something interesting" may have happened to the
+ * channel.
+ * @pause: Called to initiate a change of the device's state. If
+ * the return valu`e is < 0, there was an error and the
+ * state transition will NOT occur. If the return value
+ * is >= 0, then the state transition was INITIATED
+ * successfully, and complete_func() will be called (or
+ * was just called) with the final status when either the
+ * state transition fails or completes successfully.
+ * @resume: Behaves similar to pause.
+ * @driver: Private reference to the device driver. For use by bus
+ * driver only.
+ * @version_attr: Private version field. For use by bus driver only.
*/
struct visor_driver {
const char *name;
const char *version;
const char *vertag;
struct module *owner;
-
- /** Types of channels handled by this driver, ending with 0 GUID.
- * Our specialized BUS.match() method knows about this list, and
- * uses it to determine whether this driver will in fact handle a
- * new device that it has detected.
- */
struct visor_channeltype_descriptor *channel_types;
-
- /** Called when a new device comes online, by our probe() function
- * specified by driver.probe() (triggered ultimately by some call
- * to driver_register() / bus_add_driver() / driver_attach()).
- */
int (*probe)(struct visor_device *dev);
-
- /** Called when a new device is removed, by our remove() function
- * specified by driver.remove() (triggered ultimately by some call
- * to device_release_driver()).
- */
void (*remove)(struct visor_device *dev);
-
- /** Called periodically, whenever there is a possibility that
- * "something interesting" may have happened to the channel state.
- */
void (*channel_interrupt)(struct visor_device *dev);
-
- /** Called to initiate a change of the device's state. If the return
- * valu`e is < 0, there was an error and the state transition will NOT
- * occur. If the return value is >= 0, then the state transition was
- * INITIATED successfully, and complete_func() will be called (or was
- * just called) with the final status when either the state transition
- * fails or completes successfully.
- */
int (*pause)(struct visor_device *dev,
visorbus_state_complete_func complete_func);
int (*resume)(struct visor_device *dev,
visorbus_state_complete_func complete_func);
- /** These fields are for private use by the bus driver only. */
+ /* These fields are for private use by the bus driver only. */
struct device_driver driver;
struct driver_attribute version_attr;
};
--
1.9.1
_______________________________________________
devel mailing list
devel@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
^ permalink raw reply related [flat|nested] 4+ messages in thread
* [PATCH 3/3] staging: unisys: include: Added kerneldoc comments to visor_device
2016-04-19 3:21 [PATCH 0/3] staging: unisys: add polish to structs: visor_driver and visor_device David Kershner
2016-04-19 3:22 ` [PATCH 1/3] staging: unisys: include: remove unused fields from struct visor_driver David Kershner
2016-04-19 3:22 ` [PATCH 2/3] staging: unisys: include: Added kernel-doc for " David Kershner
@ 2016-04-19 3:22 ` David Kershner
2 siblings, 0 replies; 4+ messages in thread
From: David Kershner @ 2016-04-19 3:22 UTC (permalink / raw)
To: gregkh, driverdev-devel, sparmaintainer; +Cc: Tim Sell
From: Alexander Curtin <alexander.curtin@unisys.com>
The visor_device struct is used between multiple drivers, so this
adds kerneldoc comments to the fields.
Signed-off-by: Alexander Curtin <alexander.curtin@unisys.com>
Signed-off-by: Tim Sell <Timothy.Sell@unisys.com>
Signed-off-by: David Kershner <david.kershner@unisys.com>
---
drivers/staging/unisys/include/visorbus.h | 45 +++++++++++++++++++++++--------
1 file changed, 34 insertions(+), 11 deletions(-)
diff --git a/drivers/staging/unisys/include/visorbus.h b/drivers/staging/unisys/include/visorbus.h
index 9cc492a..9baf1ec 100644
--- a/drivers/staging/unisys/include/visorbus.h
+++ b/drivers/staging/unisys/include/visorbus.h
@@ -117,25 +117,48 @@ struct visor_driver {
#define to_visor_driver(x) ((x) ? \
(container_of(x, struct visor_driver, driver)) : (NULL))
-/** A device type for things "plugged" into the visorbus bus */
+/**
+ * struct visor_device - A device type for things "plugged" into the visorbus
+ * bus
+ * visorchannel: Points to the channel that the device is
+ * associated with.
+ * channel_type_guid: Identifies the channel type to the bus driver.
+ * device: Device struct meant for use by the bus driver
+ * only.
+ * list_all: Used by the bus driver to enumerate devices.
+ * periodic_work: Device work queue. Private use by bus driver
+ * only.
+ * being_removed: Indicates that the device is being removed from
+ * the bus. Private bus driver use only.
+ * visordriver_callback_lock: Used by the bus driver to lock when handling
+ * channel events.
+ * pausing: Indicates that a change towards a paused state.
+ * is in progress. Only modified by the bus driver.
+ * resuming: Indicates that a change towards a running state
+ * is in progress. Only modified by the bus driver.
+ * chipset_bus_no: Private field used by the bus driver.
+ * chipset_dev_no: Private field used the bus driver.
+ * state: Used to indicate the current state of the
+ * device.
+ * inst: Unique GUID for this instance of the device.
+ * name: Name of the device.
+ * pending_msg_hdr: For private use by bus driver to respond to
+ * hypervisor requests.
+ * vbus_hdr_info: A pointer to header info. Private use by bus
+ * driver.
+ * partition_uuid: Indicates client partion id. This should be the
+ * same across all visor_devices in the current
+ * guest. Private use by bus driver only.
+ */
struct visor_device {
- /** visor driver can use the visorchannel member with the functions
- * defined in visorchannel.h to access the channel
- */
struct visorchannel *visorchannel;
uuid_le channel_type_guid;
-
- /** These fields are for private use by the bus driver only.
- * A notable exception is that the visor driver can use
- * visor_get_drvdata() and visor_set_drvdata() to retrieve or stash
- * private visor driver specific data within the device member.
- */
+ /* These fields are for private use by the bus driver only. */
struct device device;
struct list_head list_all;
struct periodic_work *periodic_work;
bool being_removed;
- /* the code will detect and behave appropriately) */
struct semaphore visordriver_callback_lock;
bool pausing;
bool resuming;
--
1.9.1
_______________________________________________
devel mailing list
devel@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
^ permalink raw reply related [flat|nested] 4+ messages in thread
end of thread, other threads:[~2016-04-19 3:22 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2016-04-19 3:21 [PATCH 0/3] staging: unisys: add polish to structs: visor_driver and visor_device David Kershner
2016-04-19 3:22 ` [PATCH 1/3] staging: unisys: include: remove unused fields from struct visor_driver David Kershner
2016-04-19 3:22 ` [PATCH 2/3] staging: unisys: include: Added kernel-doc for " David Kershner
2016-04-19 3:22 ` [PATCH 3/3] staging: unisys: include: Added kerneldoc comments to visor_device David Kershner
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.