All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH] ASoC: core: export snd_soc_get_dai_name
@ 2016-04-19 11:36 ` PC Liao
  0 siblings, 0 replies; 5+ messages in thread
From: PC Liao @ 2016-04-19 11:36 UTC (permalink / raw)
  To: broonie, tiwai
  Cc: srv_heupstream, linux-mediatek, s.hauer, linux-arm-kernel,
	linux-kernel, alsa-devel, koro.chen, Jean-Francois Moine,
	PC Liao

From: Jean-Francois Moine <moinejf@free.fr>

snd_soc_get_dai_name() may be used to define a sound card with
a different syntax from the one of the simple-card.

Signed-off-by: Jean-Francois Moine <moinejf@free.fr>
Signed-off-by: PC Liao <pc.liao@mediatek.com>
---
[1] is applied and needs this patch.
Otherwise, [1] will build fail.

[1] https://patchwork.kernel.org/patch/8878491/
("ASoC: mediatek: Add second I2S on mt8173-rt5650 machine driver")
---
 include/sound/soc.h  |    2 ++
 sound/soc/soc-core.c |    5 +++--
 2 files changed, 5 insertions(+), 2 deletions(-)

diff --git a/include/sound/soc.h b/include/sound/soc.h
index 02b4a21..03b2d19 100644
--- a/include/sound/soc.h
+++ b/include/sound/soc.h
@@ -1669,6 +1669,8 @@ unsigned int snd_soc_of_parse_daifmt(struct device_node *np,
 				     const char *prefix,
 				     struct device_node **bitclkmaster,
 				     struct device_node **framemaster);
+int snd_soc_get_dai_name(struct of_phandle_args *args,
+			 const char **dai_name);
 int snd_soc_of_get_dai_name(struct device_node *of_node,
 			    const char **dai_name);
 int snd_soc_of_get_dai_link_codecs(struct device *dev,
diff --git a/sound/soc/soc-core.c b/sound/soc/soc-core.c
index d2e62b15..69cbbb0 100644
--- a/sound/soc/soc-core.c
+++ b/sound/soc/soc-core.c
@@ -3786,8 +3786,8 @@ unsigned int snd_soc_of_parse_daifmt(struct device_node *np,
 }
 EXPORT_SYMBOL_GPL(snd_soc_of_parse_daifmt);
 
-static int snd_soc_get_dai_name(struct of_phandle_args *args,
-				const char **dai_name)
+int snd_soc_get_dai_name(struct of_phandle_args *args,
+			 const char **dai_name)
 {
 	struct snd_soc_component *pos;
 	struct device_node *component_of_node;
@@ -3838,6 +3838,7 @@ static int snd_soc_get_dai_name(struct of_phandle_args *args,
 	mutex_unlock(&client_mutex);
 	return ret;
 }
+EXPORT_SYMBOL_GPL(snd_soc_get_dai_name);
 
 int snd_soc_of_get_dai_name(struct device_node *of_node,
 			    const char **dai_name)
-- 
1.7.9.5

^ permalink raw reply related	[flat|nested] 5+ messages in thread
* [PATCH] ASoC: core: export snd_soc_get_dai_name
@ 2016-04-19 11:36 ` PC Liao
  0 siblings, 0 replies; 5+ messages in thread
From: PC Liao @ 2016-04-19 11:36 UTC (permalink / raw)
  To: broonie, tiwai
  Cc: srv_heupstream, linux-mediatek, s.hauer, linux-arm-kernel,
	linux-kernel, alsa-devel, koro.chen, Jean-Francois Moine,
	PC Liao

From: Jean-Francois Moine <moinejf@free.fr>

snd_soc_get_dai_name() may be used to define a sound card with
a different syntax from the one of the simple-card.

Signed-off-by: Jean-Francois Moine <moinejf@free.fr>
Signed-off-by: PC Liao <pc.liao@mediatek.com>
---
[1] is applied and needs this patch.
Otherwise, [1] will build fail.

[1] https://patchwork.kernel.org/patch/8878491/
("ASoC: mediatek: Add second I2S on mt8173-rt5650 machine driver")
---
 include/sound/soc.h  |    2 ++
 sound/soc/soc-core.c |    5 +++--
 2 files changed, 5 insertions(+), 2 deletions(-)

diff --git a/include/sound/soc.h b/include/sound/soc.h
index 02b4a21..03b2d19 100644
--- a/include/sound/soc.h
+++ b/include/sound/soc.h
@@ -1669,6 +1669,8 @@ unsigned int snd_soc_of_parse_daifmt(struct device_node *np,
 				     const char *prefix,
 				     struct device_node **bitclkmaster,
 				     struct device_node **framemaster);
+int snd_soc_get_dai_name(struct of_phandle_args *args,
+			 const char **dai_name);
 int snd_soc_of_get_dai_name(struct device_node *of_node,
 			    const char **dai_name);
 int snd_soc_of_get_dai_link_codecs(struct device *dev,
diff --git a/sound/soc/soc-core.c b/sound/soc/soc-core.c
index d2e62b15..69cbbb0 100644
--- a/sound/soc/soc-core.c
+++ b/sound/soc/soc-core.c
@@ -3786,8 +3786,8 @@ unsigned int snd_soc_of_parse_daifmt(struct device_node *np,
 }
 EXPORT_SYMBOL_GPL(snd_soc_of_parse_daifmt);
 
-static int snd_soc_get_dai_name(struct of_phandle_args *args,
-				const char **dai_name)
+int snd_soc_get_dai_name(struct of_phandle_args *args,
+			 const char **dai_name)
 {
 	struct snd_soc_component *pos;
 	struct device_node *component_of_node;
@@ -3838,6 +3838,7 @@ static int snd_soc_get_dai_name(struct of_phandle_args *args,
 	mutex_unlock(&client_mutex);
 	return ret;
 }
+EXPORT_SYMBOL_GPL(snd_soc_get_dai_name);
 
 int snd_soc_of_get_dai_name(struct device_node *of_node,
 			    const char **dai_name)
-- 
1.7.9.5

^ permalink raw reply related	[flat|nested] 5+ messages in thread
* [PATCH] ASoC: core: export snd_soc_get_dai_name
@ 2016-04-19 11:36 ` PC Liao
  0 siblings, 0 replies; 5+ messages in thread
From: PC Liao @ 2016-04-19 11:36 UTC (permalink / raw)
  To: linux-arm-kernel

From: Jean-Francois Moine <moinejf@free.fr>

snd_soc_get_dai_name() may be used to define a sound card with
a different syntax from the one of the simple-card.

Signed-off-by: Jean-Francois Moine <moinejf@free.fr>
Signed-off-by: PC Liao <pc.liao@mediatek.com>
---
[1] is applied and needs this patch.
Otherwise, [1] will build fail.

[1] https://patchwork.kernel.org/patch/8878491/
("ASoC: mediatek: Add second I2S on mt8173-rt5650 machine driver")
---
 include/sound/soc.h  |    2 ++
 sound/soc/soc-core.c |    5 +++--
 2 files changed, 5 insertions(+), 2 deletions(-)

diff --git a/include/sound/soc.h b/include/sound/soc.h
index 02b4a21..03b2d19 100644
--- a/include/sound/soc.h
+++ b/include/sound/soc.h
@@ -1669,6 +1669,8 @@ unsigned int snd_soc_of_parse_daifmt(struct device_node *np,
 				     const char *prefix,
 				     struct device_node **bitclkmaster,
 				     struct device_node **framemaster);
+int snd_soc_get_dai_name(struct of_phandle_args *args,
+			 const char **dai_name);
 int snd_soc_of_get_dai_name(struct device_node *of_node,
 			    const char **dai_name);
 int snd_soc_of_get_dai_link_codecs(struct device *dev,
diff --git a/sound/soc/soc-core.c b/sound/soc/soc-core.c
index d2e62b15..69cbbb0 100644
--- a/sound/soc/soc-core.c
+++ b/sound/soc/soc-core.c
@@ -3786,8 +3786,8 @@ unsigned int snd_soc_of_parse_daifmt(struct device_node *np,
 }
 EXPORT_SYMBOL_GPL(snd_soc_of_parse_daifmt);
 
-static int snd_soc_get_dai_name(struct of_phandle_args *args,
-				const char **dai_name)
+int snd_soc_get_dai_name(struct of_phandle_args *args,
+			 const char **dai_name)
 {
 	struct snd_soc_component *pos;
 	struct device_node *component_of_node;
@@ -3838,6 +3838,7 @@ static int snd_soc_get_dai_name(struct of_phandle_args *args,
 	mutex_unlock(&client_mutex);
 	return ret;
 }
+EXPORT_SYMBOL_GPL(snd_soc_get_dai_name);
 
 int snd_soc_of_get_dai_name(struct device_node *of_node,
 			    const char **dai_name)
-- 
1.7.9.5

^ permalink raw reply related	[flat|nested] 5+ messages in thread
* Re: [PATCH] ASoC: core: export snd_soc_get_dai_name
  2016-04-19 11:36 ` PC Liao
@ 2016-04-19 16:46   ` Mark Brown
  -1 siblings, 0 replies; 5+ messages in thread
From: Mark Brown @ 2016-04-19 16:46 UTC (permalink / raw)
  To: PC Liao
  Cc: tiwai, srv_heupstream, linux-mediatek, s.hauer, linux-arm-kernel,
	linux-kernel, alsa-devel, koro.chen, Jean-Francois Moine

[-- Attachment #1: Type: text/plain, Size: 316 bytes --]

On Tue, Apr 19, 2016 at 07:36:41PM +0800, PC Liao wrote:

> [1] is applied and needs this patch.
> Otherwise, [1] will build fail.

I dropped your patch and replied with a suggestion for respinning it.
When referencing patches please use the title and (if relevant) commit
ID inline, it makes things easier to read.

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 473 bytes --]

^ permalink raw reply	[flat|nested] 5+ messages in thread
* [PATCH] ASoC: core: export snd_soc_get_dai_name
@ 2016-04-19 16:46   ` Mark Brown
  0 siblings, 0 replies; 5+ messages in thread
From: Mark Brown @ 2016-04-19 16:46 UTC (permalink / raw)
  To: linux-arm-kernel

On Tue, Apr 19, 2016 at 07:36:41PM +0800, PC Liao wrote:

> [1] is applied and needs this patch.
> Otherwise, [1] will build fail.

I dropped your patch and replied with a suggestion for respinning it.
When referencing patches please use the title and (if relevant) commit
ID inline, it makes things easier to read.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 473 bytes
Desc: not available
URL: <http://lists.infradead.org/pipermail/linux-arm-kernel/attachments/20160419/52d63ca5/attachment.sig>

^ permalink raw reply	[flat|nested] 5+ messages in thread
end of thread, other threads:[~2016-04-19 16:47 UTC | newest]

Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2016-04-19 11:36 [PATCH] ASoC: core: export snd_soc_get_dai_name PC Liao
2016-04-19 11:36 ` PC Liao
2016-04-19 11:36 ` PC Liao
2016-04-19 16:46 ` Mark Brown
2016-04-19 16:46   ` Mark Brown

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.