All of lore.kernel.org
 help / color / mirror / Atom feed
From: Andrew Goodbody <andrew.goodbody@cambrionix.com>
To: <netdev@vger.kernel.org>
Cc: <linux-kernel@vger.kernel.org>, <linux-omap@vger.kernel.org>,
	<mugunthanvnm@ti.com>, <grygorii.strashko@ti.com>,
	<tony@atomide.com>,
	"Andrew Goodbody" <andrew.goodbody@cambrionix.com>
Subject: [PATCH v2 0/1] drivers: net: cpsw: Fix NULL pointer dereference with two slave PHYs
Date: Tue, 19 Apr 2016 14:56:25 +0100	[thread overview]
Message-ID: <1461074186-25535-1-git-send-email-andrew.goodbody@cambrionix.com> (raw)

Resend to add more people on Cc: as requested by Grygrii Strashko.

This is a fix for a NULL pointer dereference from cpsw which is triggered
by having two slave PHYs attached to a cpsw network device. The problem is
due to only maintaining a single reference to a PHY node in the prive data
which gets overwritten by the second PHY probe. So move the PHY node
reference to the individual slave data so that there is now one per slave.

v1 had a problem that data->slaves was used before it had been filled in

Andrew Goodbody (1):
  Prevent NUll pointer dereference with two PHYs on cpsw

 drivers/net/ethernet/ti/cpsw.c | 30 +++++++++++++++---------------
 1 file changed, 15 insertions(+), 15 deletions(-)

-- 
2.5.0

WARNING: multiple messages have this Message-ID (diff)
From: Andrew Goodbody <andrew.goodbody@cambrionix.com>
To: netdev@vger.kernel.org
Cc: linux-kernel@vger.kernel.org, linux-omap@vger.kernel.org,
	mugunthanvnm@ti.com, grygorii.strashko@ti.com, tony@atomide.com,
	Andrew Goodbody <andrew.goodbody@cambrionix.com>
Subject: [PATCH v2 0/1] drivers: net: cpsw: Fix NULL pointer dereference with two slave PHYs
Date: Tue, 19 Apr 2016 14:56:25 +0100	[thread overview]
Message-ID: <1461074186-25535-1-git-send-email-andrew.goodbody@cambrionix.com> (raw)

Resend to add more people on Cc: as requested by Grygrii Strashko.

This is a fix for a NULL pointer dereference from cpsw which is triggered
by having two slave PHYs attached to a cpsw network device. The problem is
due to only maintaining a single reference to a PHY node in the prive data
which gets overwritten by the second PHY probe. So move the PHY node
reference to the individual slave data so that there is now one per slave.

v1 had a problem that data->slaves was used before it had been filled in

Andrew Goodbody (1):
  Prevent NUll pointer dereference with two PHYs on cpsw

 drivers/net/ethernet/ti/cpsw.c | 30 +++++++++++++++---------------
 1 file changed, 15 insertions(+), 15 deletions(-)

-- 
2.5.0

             reply	other threads:[~2016-04-19 13:57 UTC|newest]

Thread overview: 24+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-04-19 13:56 Andrew Goodbody [this message]
2016-04-19 13:56 ` [PATCH v2 0/1] drivers: net: cpsw: Fix NULL pointer dereference with two slave PHYs Andrew Goodbody
2016-04-19 13:56 ` [PATCH v2 1/1] drivers: net: cpsw: Prevent NUll pointer dereference with two PHYs Andrew Goodbody
2016-04-19 13:56   ` Andrew Goodbody
2016-04-19 14:41   ` Grygorii Strashko
2016-04-19 14:41     ` Grygorii Strashko
2016-04-19 15:01     ` David Rivshin (Allworx)
2016-04-19 15:01       ` David Rivshin (Allworx)
2016-04-19 15:44       ` Grygorii Strashko
2016-04-19 15:44         ` Grygorii Strashko
2016-04-19 17:14         ` David Rivshin (Allworx)
2016-04-19 17:14           ` David Rivshin (Allworx)
2016-04-19 17:44           ` Florian Fainelli
2016-04-19 18:44           ` Grygorii Strashko
2016-04-19 18:44             ` Grygorii Strashko
2016-04-19 22:43             ` David Miller
2016-04-19 23:38               ` David Rivshin (Allworx)
2016-04-20  9:37                 ` Grygorii Strashko
2016-04-20  9:37                   ` Grygorii Strashko
2016-04-19 16:05     ` David Miller
  -- strict thread matches above, loose matches on Subject: below --
2016-04-18 13:53 [PATCH v2 0/1] drivers: net: cpsw: Fix NULL pointer dereference with two slave PHYs Andrew Goodbody
2016-04-20  0:15 ` David Miller
2016-04-20  8:49   ` Andrew Goodbody
2016-04-20 14:56     ` David Miller

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1461074186-25535-1-git-send-email-andrew.goodbody@cambrionix.com \
    --to=andrew.goodbody@cambrionix.com \
    --cc=grygorii.strashko@ti.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-omap@vger.kernel.org \
    --cc=mugunthanvnm@ti.com \
    --cc=netdev@vger.kernel.org \
    --cc=tony@atomide.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.