All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Noralf Trønnes" <noralf@tronnes.org>
To: dri-devel@lists.freedesktop.org, linux-fbdev@vger.kernel.org
Cc: daniel@ffwll.ch, laurent.pinchart@ideasonboard.com,
	tomi.valkeinen@ti.com, linux-kernel@vger.kernel.org,
	"Noralf Trønnes" <noralf@tronnes.org>
Subject: [PATCH 5/8] fbdev: fb_defio: Export fb_deferred_io_mmap
Date: Wed, 20 Apr 2016 17:25:26 +0200	[thread overview]
Message-ID: <1461165929-11344-6-git-send-email-noralf@tronnes.org> (raw)
In-Reply-To: <1461165929-11344-1-git-send-email-noralf@tronnes.org>

Export fb_deferred_io_mmap so drivers can change vma->vm_page_prot.
When the framebuffer memory is allocated using dma_alloc_writecombine()
instead of vmalloc(), I get cache syncing problems.
This solves it:

static int drm_fbdev_cma_deferred_io_mmap(struct fb_info *info,
					  struct vm_area_struct *vma)
{
	fb_deferred_io_mmap(info, vma);
	vma->vm_page_prot = pgprot_writecombine(vma->vm_page_prot);

	return 0;
}

Signed-off-by: Noralf Trønnes <noralf@tronnes.org>
---
 drivers/video/fbdev/core/fb_defio.c | 3 ++-
 include/linux/fb.h                  | 1 +
 2 files changed, 3 insertions(+), 1 deletion(-)

diff --git a/drivers/video/fbdev/core/fb_defio.c b/drivers/video/fbdev/core/fb_defio.c
index 57721c7..74b5bca 100644
--- a/drivers/video/fbdev/core/fb_defio.c
+++ b/drivers/video/fbdev/core/fb_defio.c
@@ -164,7 +164,7 @@ static const struct address_space_operations fb_deferred_io_aops = {
 	.set_page_dirty = fb_deferred_io_set_page_dirty,
 };
 
-static int fb_deferred_io_mmap(struct fb_info *info, struct vm_area_struct *vma)
+int fb_deferred_io_mmap(struct fb_info *info, struct vm_area_struct *vma)
 {
 	vma->vm_ops = &fb_deferred_io_vm_ops;
 	vma->vm_flags |= VM_DONTEXPAND | VM_DONTDUMP;
@@ -173,6 +173,7 @@ static int fb_deferred_io_mmap(struct fb_info *info, struct vm_area_struct *vma)
 	vma->vm_private_data = info;
 	return 0;
 }
+EXPORT_SYMBOL(fb_deferred_io_mmap);
 
 /* workqueue callback */
 static void fb_deferred_io_work(struct work_struct *work)
diff --git a/include/linux/fb.h b/include/linux/fb.h
index dfe8835..a964d07 100644
--- a/include/linux/fb.h
+++ b/include/linux/fb.h
@@ -673,6 +673,7 @@ static inline void __fb_pad_aligned_buffer(u8 *dst, u32 d_pitch,
 }
 
 /* drivers/video/fb_defio.c */
+int fb_deferred_io_mmap(struct fb_info *info, struct vm_area_struct *vma);
 extern void fb_deferred_io_init(struct fb_info *info);
 extern void fb_deferred_io_open(struct fb_info *info,
 				struct inode *inode,
-- 
2.2.2

WARNING: multiple messages have this Message-ID (diff)
From: "Noralf Trønnes" <noralf@tronnes.org>
To: dri-devel@lists.freedesktop.org, linux-fbdev@vger.kernel.org
Cc: tomi.valkeinen@ti.com, laurent.pinchart@ideasonboard.com,
	linux-kernel@vger.kernel.org
Subject: [PATCH 5/8] fbdev: fb_defio: Export fb_deferred_io_mmap
Date: Wed, 20 Apr 2016 15:25:26 +0000	[thread overview]
Message-ID: <1461165929-11344-6-git-send-email-noralf@tronnes.org> (raw)
In-Reply-To: <1461165929-11344-1-git-send-email-noralf@tronnes.org>

Export fb_deferred_io_mmap so drivers can change vma->vm_page_prot.
When the framebuffer memory is allocated using dma_alloc_writecombine()
instead of vmalloc(), I get cache syncing problems.
This solves it:

static int drm_fbdev_cma_deferred_io_mmap(struct fb_info *info,
					  struct vm_area_struct *vma)
{
	fb_deferred_io_mmap(info, vma);
	vma->vm_page_prot = pgprot_writecombine(vma->vm_page_prot);

	return 0;
}

Signed-off-by: Noralf Trønnes <noralf@tronnes.org>
---
 drivers/video/fbdev/core/fb_defio.c | 3 ++-
 include/linux/fb.h                  | 1 +
 2 files changed, 3 insertions(+), 1 deletion(-)

diff --git a/drivers/video/fbdev/core/fb_defio.c b/drivers/video/fbdev/core/fb_defio.c
index 57721c7..74b5bca 100644
--- a/drivers/video/fbdev/core/fb_defio.c
+++ b/drivers/video/fbdev/core/fb_defio.c
@@ -164,7 +164,7 @@ static const struct address_space_operations fb_deferred_io_aops = {
 	.set_page_dirty = fb_deferred_io_set_page_dirty,
 };
 
-static int fb_deferred_io_mmap(struct fb_info *info, struct vm_area_struct *vma)
+int fb_deferred_io_mmap(struct fb_info *info, struct vm_area_struct *vma)
 {
 	vma->vm_ops = &fb_deferred_io_vm_ops;
 	vma->vm_flags |= VM_DONTEXPAND | VM_DONTDUMP;
@@ -173,6 +173,7 @@ static int fb_deferred_io_mmap(struct fb_info *info, struct vm_area_struct *vma)
 	vma->vm_private_data = info;
 	return 0;
 }
+EXPORT_SYMBOL(fb_deferred_io_mmap);
 
 /* workqueue callback */
 static void fb_deferred_io_work(struct work_struct *work)
diff --git a/include/linux/fb.h b/include/linux/fb.h
index dfe8835..a964d07 100644
--- a/include/linux/fb.h
+++ b/include/linux/fb.h
@@ -673,6 +673,7 @@ static inline void __fb_pad_aligned_buffer(u8 *dst, u32 d_pitch,
 }
 
 /* drivers/video/fb_defio.c */
+int fb_deferred_io_mmap(struct fb_info *info, struct vm_area_struct *vma);
 extern void fb_deferred_io_init(struct fb_info *info);
 extern void fb_deferred_io_open(struct fb_info *info,
 				struct inode *inode,
-- 
2.2.2


WARNING: multiple messages have this Message-ID (diff)
From: "Noralf Trønnes" <noralf@tronnes.org>
To: dri-devel@lists.freedesktop.org, linux-fbdev@vger.kernel.org
Cc: tomi.valkeinen@ti.com, laurent.pinchart@ideasonboard.com,
	linux-kernel@vger.kernel.org
Subject: [PATCH 5/8] fbdev: fb_defio: Export fb_deferred_io_mmap
Date: Wed, 20 Apr 2016 17:25:26 +0200	[thread overview]
Message-ID: <1461165929-11344-6-git-send-email-noralf@tronnes.org> (raw)
In-Reply-To: <1461165929-11344-1-git-send-email-noralf@tronnes.org>

Export fb_deferred_io_mmap so drivers can change vma->vm_page_prot.
When the framebuffer memory is allocated using dma_alloc_writecombine()
instead of vmalloc(), I get cache syncing problems.
This solves it:

static int drm_fbdev_cma_deferred_io_mmap(struct fb_info *info,
					  struct vm_area_struct *vma)
{
	fb_deferred_io_mmap(info, vma);
	vma->vm_page_prot = pgprot_writecombine(vma->vm_page_prot);

	return 0;
}

Signed-off-by: Noralf Trønnes <noralf@tronnes.org>
---
 drivers/video/fbdev/core/fb_defio.c | 3 ++-
 include/linux/fb.h                  | 1 +
 2 files changed, 3 insertions(+), 1 deletion(-)

diff --git a/drivers/video/fbdev/core/fb_defio.c b/drivers/video/fbdev/core/fb_defio.c
index 57721c7..74b5bca 100644
--- a/drivers/video/fbdev/core/fb_defio.c
+++ b/drivers/video/fbdev/core/fb_defio.c
@@ -164,7 +164,7 @@ static const struct address_space_operations fb_deferred_io_aops = {
 	.set_page_dirty = fb_deferred_io_set_page_dirty,
 };
 
-static int fb_deferred_io_mmap(struct fb_info *info, struct vm_area_struct *vma)
+int fb_deferred_io_mmap(struct fb_info *info, struct vm_area_struct *vma)
 {
 	vma->vm_ops = &fb_deferred_io_vm_ops;
 	vma->vm_flags |= VM_DONTEXPAND | VM_DONTDUMP;
@@ -173,6 +173,7 @@ static int fb_deferred_io_mmap(struct fb_info *info, struct vm_area_struct *vma)
 	vma->vm_private_data = info;
 	return 0;
 }
+EXPORT_SYMBOL(fb_deferred_io_mmap);
 
 /* workqueue callback */
 static void fb_deferred_io_work(struct work_struct *work)
diff --git a/include/linux/fb.h b/include/linux/fb.h
index dfe8835..a964d07 100644
--- a/include/linux/fb.h
+++ b/include/linux/fb.h
@@ -673,6 +673,7 @@ static inline void __fb_pad_aligned_buffer(u8 *dst, u32 d_pitch,
 }
 
 /* drivers/video/fb_defio.c */
+int fb_deferred_io_mmap(struct fb_info *info, struct vm_area_struct *vma);
 extern void fb_deferred_io_init(struct fb_info *info);
 extern void fb_deferred_io_open(struct fb_info *info,
 				struct inode *inode,
-- 
2.2.2

_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

  parent reply	other threads:[~2016-04-20 15:35 UTC|newest]

Thread overview: 101+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-04-20 15:25 [PATCH 0/8] drm: Add fbdev deferred io support to helpers Noralf Trønnes
2016-04-20 15:25 ` Noralf Trønnes
2016-04-20 15:25 ` Noralf Trønnes
2016-04-20 15:25 ` [PATCH 1/8] drm/rect: Add some drm_clip_rect utility functions Noralf Trønnes
2016-04-20 15:25   ` Noralf Trønnes
2016-04-20 15:25   ` Noralf Trønnes
2016-04-20 15:25 ` [PATCH 2/8] drm/udl: Change drm_fb_helper_sys_*() calls to sys_*() Noralf Trønnes
2016-04-20 15:25   ` Noralf Trønnes
2016-04-20 15:25   ` Noralf Trønnes
2016-04-20 17:42   ` Daniel Vetter
2016-04-20 17:42     ` Daniel Vetter
2016-04-20 17:42     ` Daniel Vetter
2016-04-20 18:15     ` Noralf Trønnes
2016-04-20 18:15       ` Noralf Trønnes
2016-04-20 18:15       ` Noralf Trønnes
2016-04-21  7:28       ` Daniel Vetter
2016-04-21  7:28         ` Daniel Vetter
2016-04-21  7:28         ` Daniel Vetter
2016-04-21 18:18         ` Noralf Trønnes
2016-04-21 18:18           ` Noralf Trønnes
2016-04-22  8:24           ` Daniel Vetter
2016-04-22  8:24             ` Daniel Vetter
2016-04-22  8:24             ` Daniel Vetter
2016-04-24 10:16             ` Emil Velikov
2016-04-24 10:16               ` Emil Velikov
2016-04-24 10:16               ` Emil Velikov
2016-04-25  8:31               ` Daniel Vetter
2016-04-25  8:31                 ` Daniel Vetter
2016-04-25  8:31                 ` Daniel Vetter
2016-04-20 15:25 ` [PATCH 3/8] drm/qxl: " Noralf Trønnes
2016-04-20 15:25   ` Noralf Trønnes
2016-04-20 15:25   ` Noralf Trønnes
2016-04-20 15:25 ` [PATCH 4/8] drm/fb-helper: Add fb_deferred_io support Noralf Trønnes
2016-04-20 15:25   ` Noralf Trønnes
2016-04-20 15:25   ` Noralf Trønnes
2016-04-20 16:42   ` kbuild test robot
2016-04-20 16:42     ` kbuild test robot
2016-04-20 16:42     ` kbuild test robot
2016-04-21 18:54   ` Noralf Trønnes
2016-04-21 18:54     ` Noralf Trønnes
2016-04-21 18:54     ` Noralf Trønnes
2016-04-22  8:27     ` Daniel Vetter
2016-04-22  8:27       ` Daniel Vetter
2016-04-22  8:27       ` Daniel Vetter
2016-04-22 14:17       ` Noralf Trønnes
2016-04-22 14:17         ` Noralf Trønnes
2016-04-22 14:17         ` Noralf Trønnes
2016-04-22 17:05         ` Daniel Vetter
2016-04-22 17:05           ` Daniel Vetter
2016-04-22 17:05           ` Daniel Vetter
2016-04-22 17:28           ` Noralf Trønnes
2016-04-22 17:28             ` Noralf Trønnes
2016-04-22 17:28             ` Noralf Trønnes
2016-04-22 17:36             ` Daniel Vetter
2016-04-22 17:36               ` Daniel Vetter
2016-04-22 17:36               ` Daniel Vetter
2016-04-20 15:25 ` Noralf Trønnes [this message]
2016-04-20 15:25   ` [PATCH 5/8] fbdev: fb_defio: Export fb_deferred_io_mmap Noralf Trønnes
2016-04-20 15:25   ` Noralf Trønnes
2016-04-20 17:44   ` Daniel Vetter
2016-04-20 17:44     ` Daniel Vetter
2016-04-20 17:44     ` Daniel Vetter
2016-04-20 18:33     ` Noralf Trønnes
2016-04-20 18:33       ` Noralf Trønnes
2016-04-20 18:33       ` Noralf Trønnes
2016-04-21  7:30       ` Daniel Vetter
2016-04-21  7:30         ` Daniel Vetter
2016-04-21  7:30         ` Daniel Vetter
2016-04-20 15:25 ` [PATCH 6/8] drm/fb-cma-helper: Add fb_deferred_io support Noralf Trønnes
2016-04-20 15:25   ` Noralf Trønnes
2016-04-20 15:25   ` Noralf Trønnes
2016-04-20 15:25 ` [PATCH 7/8] drm/qxl: Use drm_fb_helper deferred_io support Noralf Trønnes
2016-04-20 15:25   ` Noralf Trønnes
2016-04-20 15:25   ` Noralf Trønnes
2016-04-20 17:47   ` Daniel Vetter
2016-04-20 17:47     ` Daniel Vetter
2016-04-20 17:47     ` Daniel Vetter
2016-04-20 19:04     ` Noralf Trønnes
2016-04-20 19:04       ` Noralf Trønnes
2016-04-20 19:04       ` Noralf Trønnes
2016-04-21  7:41       ` Daniel Vetter
2016-04-21  7:41         ` Daniel Vetter
2016-04-21  7:41         ` Daniel Vetter
2016-04-21  7:49         ` Daniel Vetter
2016-04-21  7:49           ` Daniel Vetter
2016-04-21  7:49           ` Daniel Vetter
2016-04-21  7:52           ` Daniel Vetter
2016-04-21  7:52             ` Daniel Vetter
2016-04-21  7:52             ` Daniel Vetter
2016-04-20 15:25 ` [PATCH 8/8] drm/udl: " Noralf Trønnes
2016-04-20 15:25   ` Noralf Trønnes
2016-04-20 15:25   ` Noralf Trønnes
2016-04-20 17:59   ` Daniel Vetter
2016-04-20 17:59     ` Daniel Vetter
2016-04-20 17:59     ` Daniel Vetter
2016-04-20 19:20     ` Noralf Trønnes
2016-04-20 19:20       ` Noralf Trønnes
2016-04-20 19:20       ` Noralf Trønnes
2016-04-20 21:22       ` Daniel Vetter
2016-04-20 21:22         ` Daniel Vetter
2016-04-20 21:22         ` Daniel Vetter

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1461165929-11344-6-git-send-email-noralf@tronnes.org \
    --to=noralf@tronnes.org \
    --cc=daniel@ffwll.ch \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=laurent.pinchart@ideasonboard.com \
    --cc=linux-fbdev@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=tomi.valkeinen@ti.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.