[PATCH] voicecall: fix CreateMultiparty method introspection

[PATCH] voicecall: fix CreateMultiparty method introspection

[John Ernberg]

[-- Attachment #1: Type: text/plain, Size: 730 bytes --]

From: John Ernberg <john.ernberg@actia.se>

This caused problems with stricter dbus wrappers such as dbus-c++.

---
 src/voicecall.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/src/voicecall.c b/src/voicecall.c
index 2d15d12..bdad125 100644
--- a/src/voicecall.c
+++ b/src/voicecall.c
@@ -2165,7 +2165,7 @@ static const GDBusMethodTable manager_methods[] = {
 						GDBUS_ARGS({ "calls", "ao" }),
 						multiparty_private_chat) },
 	{ GDBUS_ASYNC_METHOD("CreateMultiparty",
-					NULL, GDBUS_ARGS({ "calls", "o" }),
+					NULL, GDBUS_ARGS({ "calls", "ao" }),
 					multiparty_create) },
 	{ GDBUS_ASYNC_METHOD("HangupMultiparty", NULL, NULL,
 							multiparty_hangup) },
-- 
1.9.1

[PATCH] voicecall: limit g_drivers variable exposure

[John Ernberg]

[-- Attachment #1: Type: text/plain, Size: 473 bytes --]

From: John Ernberg <john.ernberg@actia.se>

---
 src/voicecall.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/src/voicecall.c b/src/voicecall.c
index c9b1b43..2d15d12 100644
--- a/src/voicecall.c
+++ b/src/voicecall.c
@@ -47,7 +47,7 @@
 #define SETTINGS_STORE "voicecall"
 #define SETTINGS_GROUP "Settings"
 
-GSList *g_drivers = NULL;
+static GSList *g_drivers = NULL;
 
 struct ofono_voicecall {
 	GSList *call_list;
-- 
1.9.1

Re: [PATCH] voicecall: fix CreateMultiparty method introspection

[Denis Kenzior]

[-- Attachment #1: Type: text/plain, Size: 310 bytes --]

Hi John,

On 04/22/2016 08:06 AM, John Ernberg wrote:
> From: John Ernberg <john.ernberg@actia.se>
>
> This caused problems with stricter dbus wrappers such as dbus-c++.
>
> ---
>   src/voicecall.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
>

Applied, thanks.

Regards,
-Denis

Re: [PATCH] voicecall: limit g_drivers variable exposure

[Denis Kenzior]

[-- Attachment #1: Type: text/plain, Size: 237 bytes --]

Hi John,

On 04/22/2016 08:06 AM, John Ernberg wrote:
> From: John Ernberg <john.ernberg@actia.se>
>
> ---
>   src/voicecall.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
>

Applied, thanks.

Regards,
-Denis