[meta-networking][PATCH] samba: fix QA warnings.

[meta-networking][PATCH] samba: fix QA warnings.

[Armin Kuster]

WARNING: samba-4.4.2-r0 do_package_qa: QA Issue: samba rdepends on libaio, but it isn't a build dependency, missing libaio in DEPENDS or PACKAGECONFIG? [build-deps]
WARNING: samba-4.4.2-r0 do_package_qa: QA Issue: samba rdepends on lttng-ust, but it isn't a build dependency, missing lttng-ust in DEPENDS or PACKAGECONFIG? [build-deps]

Signed-off-by: Armin Kuster <akuster808@gmail.com>
---
 meta-networking/recipes-connectivity/samba/samba_4.4.2.bb | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/meta-networking/recipes-connectivity/samba/samba_4.4.2.bb b/meta-networking/recipes-connectivity/samba/samba_4.4.2.bb
index 9358ca5..8ba2aeb 100644
--- a/meta-networking/recipes-connectivity/samba/samba_4.4.2.bb
+++ b/meta-networking/recipes-connectivity/samba/samba_4.4.2.bb
@@ -27,7 +27,7 @@ inherit systemd waf-samba cpan-base perlnative
 # remove default added RDEPENDS on perl
 RDEPENDS_${PN}_remove = "perl"
 
-DEPENDS += "readline virtual/libiconv zlib popt libtalloc libtdb libtevent libldb krb5 ctdb libbsd"
+DEPENDS += "readline virtual/libiconv zlib popt libtalloc libtdb libtevent libldb krb5 ctdb libbsd libaio"
 
 SYSVINITTYPE_linuxstdbase = "lsb"
 SYSVINITTYPE = "sysv"
@@ -54,6 +54,7 @@ PACKAGECONFIG[systemd] = "--with-systemd,--without-systemd,systemd"
 PACKAGECONFIG[dmapi] = "--with-dmapi,--without-dmapi,dmapi"
 PACKAGECONFIG[zeroconf] = "--enable-avahi,--disable-avahi,avahi"
 PACKAGECONFIG[valgrind] = ",--without-valgrind,valgrind,"
+PACKAGECONFIG[lttng] = "--with-lttng, --without-lttng,lttng-ust"
 
 SAMBA4_IDMAP_MODULES="idmap_ad,idmap_rid,idmap_adex,idmap_hash,idmap_tdb2"
 SAMBA4_PDB_MODULES="pdb_tdbsam,${@bb.utils.contains('PACKAGECONFIG', 'ldap', 'pdb_ldap,', '', d)}pdb_ads,pdb_smbpasswd,pdb_wbc_sam,pdb_samba4"
-- 
2.3.5

Re: [meta-networking][PATCH] samba: fix QA warnings.

[Martin Jansa]

[-- Attachment #1: Type: text/plain, Size: 2524 bytes --]

On Mon, Apr 25, 2016 at 09:12:29AM -0700, Armin Kuster wrote:
> WARNING: samba-4.4.2-r0 do_package_qa: QA Issue: samba rdepends on libaio, but it isn't a build dependency, missing libaio in DEPENDS or PACKAGECONFIG? [build-deps]
> WARNING: samba-4.4.2-r0 do_package_qa: QA Issue: samba rdepends on lttng-ust, but it isn't a build dependency, missing lttng-ust in DEPENDS or PACKAGECONFIG? [build-deps]
> 

We used to have PACKAGECONFIG for aio, maybe it's worth trying to fix it
instead of adding libaio directly to DEPENDS?

Also there is still:
WARN: samba: samba rdepends on libpam, but it isn't a build dependency?

and also new:
WARN: samba: samba rdepends on libarchive, but it isn't a build dependency?


> Signed-off-by: Armin Kuster <akuster808@gmail.com>
> ---
>  meta-networking/recipes-connectivity/samba/samba_4.4.2.bb | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
> 
> diff --git a/meta-networking/recipes-connectivity/samba/samba_4.4.2.bb b/meta-networking/recipes-connectivity/samba/samba_4.4.2.bb
> index 9358ca5..8ba2aeb 100644
> --- a/meta-networking/recipes-connectivity/samba/samba_4.4.2.bb
> +++ b/meta-networking/recipes-connectivity/samba/samba_4.4.2.bb
> @@ -27,7 +27,7 @@ inherit systemd waf-samba cpan-base perlnative
>  # remove default added RDEPENDS on perl
>  RDEPENDS_${PN}_remove = "perl"
>  
> -DEPENDS += "readline virtual/libiconv zlib popt libtalloc libtdb libtevent libldb krb5 ctdb libbsd"
> +DEPENDS += "readline virtual/libiconv zlib popt libtalloc libtdb libtevent libldb krb5 ctdb libbsd libaio"
>  
>  SYSVINITTYPE_linuxstdbase = "lsb"
>  SYSVINITTYPE = "sysv"
> @@ -54,6 +54,7 @@ PACKAGECONFIG[systemd] = "--with-systemd,--without-systemd,systemd"
>  PACKAGECONFIG[dmapi] = "--with-dmapi,--without-dmapi,dmapi"
>  PACKAGECONFIG[zeroconf] = "--enable-avahi,--disable-avahi,avahi"
>  PACKAGECONFIG[valgrind] = ",--without-valgrind,valgrind,"
> +PACKAGECONFIG[lttng] = "--with-lttng, --without-lttng,lttng-ust"
>  
>  SAMBA4_IDMAP_MODULES="idmap_ad,idmap_rid,idmap_adex,idmap_hash,idmap_tdb2"
>  SAMBA4_PDB_MODULES="pdb_tdbsam,${@bb.utils.contains('PACKAGECONFIG', 'ldap', 'pdb_ldap,', '', d)}pdb_ads,pdb_smbpasswd,pdb_wbc_sam,pdb_samba4"
> -- 
> 2.3.5
> 
> -- 
> _______________________________________________
> Openembedded-devel mailing list
> Openembedded-devel@lists.openembedded.org
> http://lists.openembedded.org/mailman/listinfo/openembedded-devel

-- 
Martin 'JaMa' Jansa     jabber: Martin.Jansa@gmail.com

[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 188 bytes --]

Re: [meta-networking][PATCH] samba: fix QA warnings.

[akuster808]

On 04/26/2016 07:26 AM, Martin Jansa wrote:
> On Mon, Apr 25, 2016 at 09:12:29AM -0700, Armin Kuster wrote:
>> WARNING: samba-4.4.2-r0 do_package_qa: QA Issue: samba rdepends on libaio, but it isn't a build dependency, missing libaio in DEPENDS or PACKAGECONFIG? [build-deps]
>> WARNING: samba-4.4.2-r0 do_package_qa: QA Issue: samba rdepends on lttng-ust, but it isn't a build dependency, missing lttng-ust in DEPENDS or PACKAGECONFIG? [build-deps]
>>
> 
> We used to have PACKAGECONFIG for aio, maybe it's worth trying to fix it
> instead of adding libaio directly to DEPENDS?

correct. that option is no longer available. Removed in 4.4.0



> 
> Also there is still:
> WARN: samba: samba rdepends on libpam, but it isn't a build dependency?

I think Joe is looking into this. He has some fixes not yet published.
> 
> and also new:
> WARN: samba: samba rdepends on libarchive, but it isn't a build dependency?

that is new to me too. Not sure if Joe has that addressed. I can resend
patch to deal with this.

thanks,
Armin


> 
> 
>> Signed-off-by: Armin Kuster <akuster808@gmail.com>
>> ---
>>  meta-networking/recipes-connectivity/samba/samba_4.4.2.bb | 3 ++-
>>  1 file changed, 2 insertions(+), 1 deletion(-)
>>
>> diff --git a/meta-networking/recipes-connectivity/samba/samba_4.4.2.bb b/meta-networking/recipes-connectivity/samba/samba_4.4.2.bb
>> index 9358ca5..8ba2aeb 100644
>> --- a/meta-networking/recipes-connectivity/samba/samba_4.4.2.bb
>> +++ b/meta-networking/recipes-connectivity/samba/samba_4.4.2.bb
>> @@ -27,7 +27,7 @@ inherit systemd waf-samba cpan-base perlnative
>>  # remove default added RDEPENDS on perl
>>  RDEPENDS_${PN}_remove = "perl"
>>  
>> -DEPENDS += "readline virtual/libiconv zlib popt libtalloc libtdb libtevent libldb krb5 ctdb libbsd"
>> +DEPENDS += "readline virtual/libiconv zlib popt libtalloc libtdb libtevent libldb krb5 ctdb libbsd libaio"
>>  
>>  SYSVINITTYPE_linuxstdbase = "lsb"
>>  SYSVINITTYPE = "sysv"
>> @@ -54,6 +54,7 @@ PACKAGECONFIG[systemd] = "--with-systemd,--without-systemd,systemd"
>>  PACKAGECONFIG[dmapi] = "--with-dmapi,--without-dmapi,dmapi"
>>  PACKAGECONFIG[zeroconf] = "--enable-avahi,--disable-avahi,avahi"
>>  PACKAGECONFIG[valgrind] = ",--without-valgrind,valgrind,"
>> +PACKAGECONFIG[lttng] = "--with-lttng, --without-lttng,lttng-ust"
>>  
>>  SAMBA4_IDMAP_MODULES="idmap_ad,idmap_rid,idmap_adex,idmap_hash,idmap_tdb2"
>>  SAMBA4_PDB_MODULES="pdb_tdbsam,${@bb.utils.contains('PACKAGECONFIG', 'ldap', 'pdb_ldap,', '', d)}pdb_ads,pdb_smbpasswd,pdb_wbc_sam,pdb_samba4"
>> -- 
>> 2.3.5
>>
>> -- 
>> _______________________________________________
>> Openembedded-devel mailing list
>> Openembedded-devel@lists.openembedded.org
>> http://lists.openembedded.org/mailman/listinfo/openembedded-devel
> 
> 
>