From: Michal Hocko <mhocko@kernel.org> To: <linux-mm@kvack.org>, Andrew Morton <akpm@linux-foundation.org> Cc: LKML <linux-kernel@vger.kernel.org>, "Alexander Viro" <viro@zeniv.linux.org.uk>, "Alex Deucher" <alexander.deucher@amd.com>, "Alex Thorlton" <athorlton@sgi.com>, "Andrea Arcangeli" <aarcange@redhat.com>, "Andy Lutomirski" <luto@amacapital.net>, "Benamin LaHaise" <bcrl@kvack.org>, "Christian König" <christian.koenig@amd.com>, "Daniel Vetter" <daniel.vetter@intel.com>, "Dave Hansen" <dave.hansen@linux.intel.com>, "David Airlie" <airlied@linux.ie>, "Davidlohr Bueso" <dave@stgolabs.net>, "David Rientjes" <rientjes@google.com>, "H. Peter Anvin" <hpa@zytor.com>, "Hugh Dickins" <hughd@google.com>, "Ingo Molnar" <mingo@kernel.org>, "Ingo Molnar" <mingo@redhat.com>, "Jeff Moyer" <jmoyer@redhat.com>, "Johannes Weiner" <hannes@cmpxchg.org>, "Kirill A. Shutemov" <kirill.shutemov@linux.intel.com>, "Konstantin Khlebnikov" <koct9i@gmail.com>, "Mel Gorman" <mgorman@suse.de>, "Michal Hocko" <mhocko@suse.com>, "Oleg Nesterov" <oleg@redhat.com>, "Peter Zijlstra" <peterz@infradead.org>, "Petr Cermak" <petrcermak@chromium.org>, "Thomas Gleixner" <tglx@linutronix.de>, "Vlastimil Babka" <vbabka@suse.cz> Subject: [PATCH 0/18] change mmap_sem taken for write killable v2 Date: Tue, 26 Apr 2016 14:56:07 +0200 [thread overview] Message-ID: <1461675385-5934-1-git-send-email-mhocko@kernel.org> (raw) Hi, The previous version of the series was posted here [0]. There were no large changes since then. I have rebased the series on top of the current linux-next (next-20160426) and added few clarifications based on the review feedback and acks/reviewed-by. This is a follow up work for oom_reaper [1]. As the async OOM killing depends on oom_sem for read we would really appreciate if a holder for write didn't stood in the way. This patchset is changing many of down_write calls to be killable to help those cases when the writer is blocked and waiting for readers to release the lock and so help __oom_reap_task to process the oom victim. Most of the patches are really trivial because the lock is help from a shallow syscall paths where we can return EINTR trivially and allow the current task to die (note that EINTR will never get to the userspace as the task has fatal signal pending). Others seem to be easy as well as the callers are already handling fatal errors and bail and return to userspace which should be sufficient to handle the failure gracefully. I am not familiar with all those code paths so a deeper review is really appreciated. As this work is touching more areas which are not directly connected I have tried to keep the CC list as small as possible and people who I believed would be familiar are CCed only to the specific patches (all should have received the cover though). This patchset is based on linux-next and it depends on down_write_killable for rw_semaphores which got merged into tip locking/rwsem branch and it is merged into this next tree. I guess it would be easiest to route these patches via mmotm because of the dependency on the tip tree but if respective maintainers prefer other way I have no objections. I haven't covered all the mmap_write(mm->mmap_sem) instances here $ git grep "down_write(.*\<mmap_sem\>)" next/master | wc -l 98 $ git grep "down_write(.*\<mmap_sem\>)" | wc -l 62 I have tried to cover those which should be relatively easy to review in this series because this alone should be a nice improvement. Other places can be changed on top. Any feedback is highly appreciated. --- [0] http://lkml.kernel.org/r/1456752417-9626-1-git-send-email-mhocko@kernel.org [1] http://lkml.kernel.org/r/1452094975-551-1-git-send-email-mhocko@kernel.org [2] http://lkml.kernel.org/r/1456750705-7141-1-git-send-email-mhocko@kernel.org
WARNING: multiple messages have this Message-ID (diff)
From: Michal Hocko <mhocko@kernel.org> To: linux-mm@kvack.org, Andrew Morton <akpm@linux-foundation.org> Cc: LKML <linux-kernel@vger.kernel.org>, "Alexander Viro" <viro@zeniv.linux.org.uk>, "Alex Deucher" <alexander.deucher@amd.com>, "Alex Thorlton" <athorlton@sgi.com>, "Andrea Arcangeli" <aarcange@redhat.com>, "Andy Lutomirski" <luto@amacapital.net>, "Benamin LaHaise" <bcrl@kvack.org>, "Christian König" <christian.koenig@amd.com>, "Daniel Vetter" <daniel.vetter@intel.com>, "Dave Hansen" <dave.hansen@linux.intel.com>, "David Airlie" <airlied@linux.ie>, "Davidlohr Bueso" <dave@stgolabs.net>, "David Rientjes" <rientjes@google.com>, "H. Peter Anvin" <hpa@zytor.com>, "Hugh Dickins" <hughd@google.com>, "Ingo Molnar" <mingo@kernel.org>, "Ingo Molnar" <mingo@redhat.com>, "Jeff Moyer" <jmoyer@redhat.com>, "Johannes Weiner" <hannes@cmpxchg.org>, "Kirill A. Shutemov" <kirill.shutemov@linux.intel.com>, "Konstantin Khlebnikov" <koct9i@gmail.com>, "Mel Gorman" <mgorman@suse.de>, "Michal Hocko" <mhocko@suse.com>, "Oleg Nesterov" <oleg@redhat.com>, "Peter Zijlstra" <peterz@infradead.org>, "Petr Cermak" <petrcermak@chromium.org>, "Thomas Gleixner" <tglx@linutronix.de>, "Vlastimil Babka" <vbabka@suse.cz> Subject: [PATCH 0/18] change mmap_sem taken for write killable v2 Date: Tue, 26 Apr 2016 14:56:07 +0200 [thread overview] Message-ID: <1461675385-5934-1-git-send-email-mhocko@kernel.org> (raw) Hi, The previous version of the series was posted here [0]. There were no large changes since then. I have rebased the series on top of the current linux-next (next-20160426) and added few clarifications based on the review feedback and acks/reviewed-by. This is a follow up work for oom_reaper [1]. As the async OOM killing depends on oom_sem for read we would really appreciate if a holder for write didn't stood in the way. This patchset is changing many of down_write calls to be killable to help those cases when the writer is blocked and waiting for readers to release the lock and so help __oom_reap_task to process the oom victim. Most of the patches are really trivial because the lock is help from a shallow syscall paths where we can return EINTR trivially and allow the current task to die (note that EINTR will never get to the userspace as the task has fatal signal pending). Others seem to be easy as well as the callers are already handling fatal errors and bail and return to userspace which should be sufficient to handle the failure gracefully. I am not familiar with all those code paths so a deeper review is really appreciated. As this work is touching more areas which are not directly connected I have tried to keep the CC list as small as possible and people who I believed would be familiar are CCed only to the specific patches (all should have received the cover though). This patchset is based on linux-next and it depends on down_write_killable for rw_semaphores which got merged into tip locking/rwsem branch and it is merged into this next tree. I guess it would be easiest to route these patches via mmotm because of the dependency on the tip tree but if respective maintainers prefer other way I have no objections. I haven't covered all the mmap_write(mm->mmap_sem) instances here $ git grep "down_write(.*\<mmap_sem\>)" next/master | wc -l 98 $ git grep "down_write(.*\<mmap_sem\>)" | wc -l 62 I have tried to cover those which should be relatively easy to review in this series because this alone should be a nice improvement. Other places can be changed on top. Any feedback is highly appreciated. --- [0] http://lkml.kernel.org/r/1456752417-9626-1-git-send-email-mhocko@kernel.org [1] http://lkml.kernel.org/r/1452094975-551-1-git-send-email-mhocko@kernel.org [2] http://lkml.kernel.org/r/1456750705-7141-1-git-send-email-mhocko@kernel.org -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
next reply other threads:[~2016-04-26 12:56 UTC|newest] Thread overview: 41+ messages / expand[flat|nested] mbox.gz Atom feed top 2016-04-26 12:56 Michal Hocko [this message] 2016-04-26 12:56 ` [PATCH 0/18] change mmap_sem taken for write killable v2 Michal Hocko 2016-04-26 12:56 ` [PATCH 01/18] mm: Make mmap_sem for write waits killable for mm syscalls Michal Hocko 2016-04-26 12:56 ` Michal Hocko 2016-04-26 12:56 ` [PATCH 02/18] mm: make vm_mmap killable Michal Hocko 2016-04-26 12:56 ` Michal Hocko 2016-04-26 12:56 ` [PATCH 03/18] mm: make vm_munmap killable Michal Hocko 2016-04-26 12:56 ` Michal Hocko 2016-04-26 12:56 ` [PATCH 04/18] mm, aout: handle vm_brk failures Michal Hocko 2016-04-26 12:56 ` Michal Hocko 2016-04-26 12:56 ` [PATCH 05/18] mm, elf: handle vm_brk error Michal Hocko 2016-04-26 12:56 ` Michal Hocko 2016-04-26 12:56 ` [PATCH 06/18] mm: make vm_brk killable Michal Hocko 2016-04-26 12:56 ` Michal Hocko 2016-04-26 12:56 ` [PATCH 07/18] mm, proc: make clear_refs killable Michal Hocko 2016-04-26 12:56 ` Michal Hocko 2016-04-26 12:56 ` [PATCH 08/18] mm, fork: make dup_mmap wait for mmap_sem for write killable Michal Hocko 2016-04-26 12:56 ` Michal Hocko 2016-04-26 12:56 ` [PATCH 09/18] ipc, shm: make shmem attach/detach wait for mmap_sem killable Michal Hocko 2016-04-26 12:56 ` Michal Hocko 2016-04-26 12:56 ` [PATCH 10/18] vdso: make arch_setup_additional_pages wait for mmap_sem for write killable Michal Hocko 2016-04-26 12:56 ` Michal Hocko 2016-04-26 12:56 ` Michal Hocko 2016-04-26 12:56 ` [PATCH 11/18] coredump: make coredump_wait " Michal Hocko 2016-04-26 12:56 ` Michal Hocko 2016-04-26 12:56 ` [PATCH 12/18] aio: make aio_setup_ring killable Michal Hocko 2016-04-26 12:56 ` Michal Hocko 2016-04-26 12:56 ` [PATCH 13/18] exec: make exec path waiting for mmap_sem killable Michal Hocko 2016-04-26 12:56 ` Michal Hocko 2016-04-26 12:56 ` [PATCH 14/18] prctl: make PR_SET_THP_DISABLE wait " Michal Hocko 2016-04-26 12:56 ` Michal Hocko 2016-04-26 15:18 ` Alex Thorlton 2016-04-26 15:18 ` Alex Thorlton 2016-04-26 12:56 ` [PATCH 15/18] uprobes: wait for mmap_sem for write killable Michal Hocko 2016-04-26 12:56 ` Michal Hocko 2016-04-26 12:56 ` [PATCH 16/18] drm/i915: make i915_gem_mmap_ioctl wait for mmap_sem killable Michal Hocko 2016-04-26 12:56 ` Michal Hocko 2016-04-26 12:56 ` [PATCH 17/18] drm/radeon: make radeon_mn_get " Michal Hocko 2016-04-26 12:56 ` Michal Hocko 2016-04-26 12:56 ` [PATCH 18/18] drm/amdgpu: make amdgpu_mn_get " Michal Hocko 2016-04-26 12:56 ` Michal Hocko
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=1461675385-5934-1-git-send-email-mhocko@kernel.org \ --to=mhocko@kernel.org \ --cc=aarcange@redhat.com \ --cc=airlied@linux.ie \ --cc=akpm@linux-foundation.org \ --cc=alexander.deucher@amd.com \ --cc=athorlton@sgi.com \ --cc=bcrl@kvack.org \ --cc=christian.koenig@amd.com \ --cc=daniel.vetter@intel.com \ --cc=dave.hansen@linux.intel.com \ --cc=dave@stgolabs.net \ --cc=hannes@cmpxchg.org \ --cc=hpa@zytor.com \ --cc=hughd@google.com \ --cc=jmoyer@redhat.com \ --cc=kirill.shutemov@linux.intel.com \ --cc=koct9i@gmail.com \ --cc=linux-kernel@vger.kernel.org \ --cc=linux-mm@kvack.org \ --cc=luto@amacapital.net \ --cc=mgorman@suse.de \ --cc=mhocko@suse.com \ --cc=mingo@kernel.org \ --cc=mingo@redhat.com \ --cc=oleg@redhat.com \ --cc=peterz@infradead.org \ --cc=petrcermak@chromium.org \ --cc=rientjes@google.com \ --cc=tglx@linutronix.de \ --cc=vbabka@suse.cz \ --cc=viro@zeniv.linux.org.uk \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.