* linux-4.6-rc5/arch/arm/mach-vexpress/spc.c:332: possible typo ?
@ 2016-04-25 20:31 David Binderman
2016-04-26 13:11 ` Sudeep Holla
2016-04-26 13:11 ` [PATCH] ARM: vexpress/spc: remove unused variable perf_stat_reg Sudeep Holla
0 siblings, 2 replies; 3+ messages in thread
From: David Binderman @ 2016-04-25 20:31 UTC (permalink / raw)
To: linux-arm-kernel
Hello there,
linux-4.6-rc5/arch/arm/mach-vexpress/spc.c:332]: (style) Variable 'perf_stat_reg' is assigned a value that is never used.
?? if (cluster_is_a15(cluster)) {
??????? req_type = CA15_DVFS;
??????? perf_cfg_reg = PERF_LVL_A15;
??????? perf_stat_reg = PERF_REQ_A15;
??? } else {
??????? req_type = CA7_DVFS;
??????? perf_cfg_reg = PERF_LVL_A7;
??????? perf_stat_reg = PERF_REQ_A7;
??? }
But local variable perf_stat_reg doesn't get used anywhere.
Suggest either delete or use.
Regards
David Binderman
^ permalink raw reply [flat|nested] 3+ messages in thread
* linux-4.6-rc5/arch/arm/mach-vexpress/spc.c:332: possible typo ?
2016-04-25 20:31 linux-4.6-rc5/arch/arm/mach-vexpress/spc.c:332: possible typo ? David Binderman
@ 2016-04-26 13:11 ` Sudeep Holla
2016-04-26 13:11 ` [PATCH] ARM: vexpress/spc: remove unused variable perf_stat_reg Sudeep Holla
1 sibling, 0 replies; 3+ messages in thread
From: Sudeep Holla @ 2016-04-26 13:11 UTC (permalink / raw)
To: linux-arm-kernel
On 25/04/16 21:31, David Binderman wrote:
> Hello there,
>
> linux-4.6-rc5/arch/arm/mach-vexpress/spc.c:332]: (style) Variable 'perf_stat_reg' is assigned a value that is never used.
>
> if (cluster_is_a15(cluster)) {
> req_type = CA15_DVFS;
> perf_cfg_reg = PERF_LVL_A15;
> perf_stat_reg = PERF_REQ_A15;
> } else {
> req_type = CA7_DVFS;
> perf_cfg_reg = PERF_LVL_A7;
> perf_stat_reg = PERF_REQ_A7;
> }
>
> But local variable perf_stat_reg doesn't get used anywhere.
>
> Suggest either delete or use.
>
You are always welcome to post the patch especially after all your
efforts to find it. Anyways I will post the patch for now.
--
Regards,
Sudeep
^ permalink raw reply [flat|nested] 3+ messages in thread
* [PATCH] ARM: vexpress/spc: remove unused variable perf_stat_reg
2016-04-25 20:31 linux-4.6-rc5/arch/arm/mach-vexpress/spc.c:332: possible typo ? David Binderman
2016-04-26 13:11 ` Sudeep Holla
@ 2016-04-26 13:11 ` Sudeep Holla
1 sibling, 0 replies; 3+ messages in thread
From: Sudeep Holla @ 2016-04-26 13:11 UTC (permalink / raw)
To: linux-arm-kernel
The variable 'perf_stat_reg' in ve_spc_set_performance is assigned a
value but that is never used.
So let's remove the variable 'perf_stat_reg'
Reported-by: David Binderman <dcb314@hotmail.com>
Cc: Liviu Dudau <liviu.dudau@arm.com>
Cc: Lorenzo Pieralisi <lorenzo.pieralisi@arm.com>
Signed-off-by: Sudeep Holla <sudeep.holla@arm.com>
---
arch/arm/mach-vexpress/spc.c | 4 +---
1 file changed, 1 insertion(+), 3 deletions(-)
diff --git a/arch/arm/mach-vexpress/spc.c b/arch/arm/mach-vexpress/spc.c
index 5766ce2be32b..0d89257ddc0a 100644
--- a/arch/arm/mach-vexpress/spc.c
+++ b/arch/arm/mach-vexpress/spc.c
@@ -319,17 +319,15 @@ static int ve_spc_waitforcompletion(int req_type)
static int ve_spc_set_performance(int cluster, u32 freq)
{
- u32 perf_cfg_reg, perf_stat_reg;
+ u32 perf_cfg_reg;
int ret, perf, req_type;
if (cluster_is_a15(cluster)) {
req_type = CA15_DVFS;
perf_cfg_reg = PERF_LVL_A15;
- perf_stat_reg = PERF_REQ_A15;
} else {
req_type = CA7_DVFS;
perf_cfg_reg = PERF_LVL_A7;
- perf_stat_reg = PERF_REQ_A7;
}
perf = ve_spc_find_performance_index(cluster, freq);
--
1.9.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
end of thread, other threads:[~2016-04-26 13:11 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2016-04-25 20:31 linux-4.6-rc5/arch/arm/mach-vexpress/spc.c:332: possible typo ? David Binderman
2016-04-26 13:11 ` Sudeep Holla
2016-04-26 13:11 ` [PATCH] ARM: vexpress/spc: remove unused variable perf_stat_reg Sudeep Holla
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.