From: Hans Verkuil <hverkuil@xs4all.nl> To: linux-media@vger.kernel.org Cc: tomi.valkeinen@ti.com, dri-devel@lists.freedesktop.org Subject: [RFC PATCH 1/3] drm/omap: fix OMAP4 hdmi_core_powerdown_disable() Date: Fri, 29 Apr 2016 11:39:04 +0200 [thread overview] Message-ID: <1461922746-17521-2-git-send-email-hverkuil@xs4all.nl> (raw) In-Reply-To: <1461922746-17521-1-git-send-email-hverkuil@xs4all.nl> From: Tomi Valkeinen <tomi.valkeinen@ti.com> hdmi_core_powerdown_disable() is supposed to disable HDMI core's power-down mode. However, the function sets the power-down bit to 0, which means "enable power-down". This hasn't caused any issues as the PD seems to affect only interrupts from HDMI core, and none of those interrupts are used at the moment. CEC functionality requires core interrupts, and the PD mode needs to be fixed. This patch fixes hdmi_core_powerdown_disable() to actually disable the PD mode. Signed-off-by: Tomi Valkeinen <tomi.valkeinen@ti.com> Reported-by: Hans Verkuil <hverkuil@xs4all.nl> --- drivers/gpu/drm/omapdrm/dss/hdmi4_core.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/omapdrm/dss/hdmi4_core.c b/drivers/gpu/drm/omapdrm/dss/hdmi4_core.c index fa72e73..ef3afe9 100644 --- a/drivers/gpu/drm/omapdrm/dss/hdmi4_core.c +++ b/drivers/gpu/drm/omapdrm/dss/hdmi4_core.c @@ -211,7 +211,7 @@ static void hdmi_core_init(struct hdmi_core_video_config *video_cfg) static void hdmi_core_powerdown_disable(struct hdmi_core_data *core) { DSSDBG("Enter hdmi_core_powerdown_disable\n"); - REG_FLD_MOD(core->base, HDMI_CORE_SYS_SYS_CTRL1, 0x0, 0, 0); + REG_FLD_MOD(core->base, HDMI_CORE_SYS_SYS_CTRL1, 0x1, 0, 0); } static void hdmi_core_swreset_release(struct hdmi_core_data *core) -- 2.8.1
WARNING: multiple messages have this Message-ID (diff)
From: Hans Verkuil <hverkuil@xs4all.nl> To: linux-media@vger.kernel.org Cc: tomi.valkeinen@ti.com, dri-devel@lists.freedesktop.org Subject: [RFC PATCH 1/3] drm/omap: fix OMAP4 hdmi_core_powerdown_disable() Date: Fri, 29 Apr 2016 11:39:04 +0200 [thread overview] Message-ID: <1461922746-17521-2-git-send-email-hverkuil@xs4all.nl> (raw) In-Reply-To: <1461922746-17521-1-git-send-email-hverkuil@xs4all.nl> From: Tomi Valkeinen <tomi.valkeinen@ti.com> hdmi_core_powerdown_disable() is supposed to disable HDMI core's power-down mode. However, the function sets the power-down bit to 0, which means "enable power-down". This hasn't caused any issues as the PD seems to affect only interrupts from HDMI core, and none of those interrupts are used at the moment. CEC functionality requires core interrupts, and the PD mode needs to be fixed. This patch fixes hdmi_core_powerdown_disable() to actually disable the PD mode. Signed-off-by: Tomi Valkeinen <tomi.valkeinen@ti.com> Reported-by: Hans Verkuil <hverkuil@xs4all.nl> --- drivers/gpu/drm/omapdrm/dss/hdmi4_core.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/omapdrm/dss/hdmi4_core.c b/drivers/gpu/drm/omapdrm/dss/hdmi4_core.c index fa72e73..ef3afe9 100644 --- a/drivers/gpu/drm/omapdrm/dss/hdmi4_core.c +++ b/drivers/gpu/drm/omapdrm/dss/hdmi4_core.c @@ -211,7 +211,7 @@ static void hdmi_core_init(struct hdmi_core_video_config *video_cfg) static void hdmi_core_powerdown_disable(struct hdmi_core_data *core) { DSSDBG("Enter hdmi_core_powerdown_disable\n"); - REG_FLD_MOD(core->base, HDMI_CORE_SYS_SYS_CTRL1, 0x0, 0, 0); + REG_FLD_MOD(core->base, HDMI_CORE_SYS_SYS_CTRL1, 0x1, 0, 0); } static void hdmi_core_swreset_release(struct hdmi_core_data *core) -- 2.8.1 _______________________________________________ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-devel
next prev parent reply other threads:[~2016-04-29 9:39 UTC|newest] Thread overview: 31+ messages / expand[flat|nested] mbox.gz Atom feed top 2016-04-29 9:39 [RFC PATCH 0/3] OMAP4 HDMI CEC support Hans Verkuil 2016-04-29 9:39 ` Hans Verkuil 2016-04-29 9:39 ` Hans Verkuil [this message] 2016-04-29 9:39 ` [RFC PATCH 1/3] drm/omap: fix OMAP4 hdmi_core_powerdown_disable() Hans Verkuil 2016-04-29 9:39 ` [RFC PATCH 2/3] omap4: add CEC support Hans Verkuil 2016-04-29 9:39 ` Hans Verkuil 2016-05-10 12:01 ` Tomi Valkeinen 2016-05-10 12:01 ` Tomi Valkeinen 2016-05-10 12:26 ` Hans Verkuil 2016-05-10 12:41 ` Tomi Valkeinen 2016-05-10 12:41 ` Tomi Valkeinen 2016-04-29 9:39 ` [RFC PATCH 3/3] encoder-tpd12s015: keep the ls_oe_gpio on while the phys_addr is valid Hans Verkuil 2016-04-29 9:39 ` Hans Verkuil 2016-05-10 11:36 ` Tomi Valkeinen 2016-05-10 11:36 ` Tomi Valkeinen 2017-04-08 10:11 ` Hans Verkuil 2017-04-08 10:57 ` Hans Verkuil 2017-04-08 10:57 ` Hans Verkuil 2017-04-10 11:59 ` Tomi Valkeinen 2017-04-10 11:59 ` Tomi Valkeinen 2017-04-12 13:03 ` Hans Verkuil 2017-04-12 13:10 ` Hans Verkuil 2017-04-12 13:21 ` Tomi Valkeinen 2017-04-12 13:21 ` Tomi Valkeinen 2017-04-12 14:04 ` Hans Verkuil 2017-04-13 8:43 ` Tomi Valkeinen 2017-04-13 8:43 ` Tomi Valkeinen 2017-04-13 9:12 ` Hans Verkuil 2017-04-13 9:12 ` Hans Verkuil 2017-04-13 9:26 ` Tomi Valkeinen 2017-04-13 9:26 ` Tomi Valkeinen
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=1461922746-17521-2-git-send-email-hverkuil@xs4all.nl \ --to=hverkuil@xs4all.nl \ --cc=dri-devel@lists.freedesktop.org \ --cc=linux-media@vger.kernel.org \ --cc=tomi.valkeinen@ti.com \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.