[Buildroot] [PATH RFC] Fix glmark2 error with Vivante

[Buildroot] [PATH RFC] Fix glmark2 error with Vivante

[Mylène Josserand]

While using Vivante OpenGL driver, I got an error on glmark2 :
   "Checking for 'gbm' : not found
    The configuration failed [...]"

This is due to the fact that, with Vivante driver, mesa3d is not
configured to enable "gdm" (as BR2_PACKAGE_MESA3D_OPENGL_EGL=n).
As the gdm is used only on "drm" flavors of glmark2, this patch
proposes to check if the MESA3D OpenGL is enabled before adding
"drm" flavors on configuration (so the need of "gbm").

This is a RFC patch because I do not really know how all OpenGL stuff
are handled in buildroot and maybe, this is not the best way to do it.

If you have any ideas, remarks or questions, do not hesitate.

Best regards,

Myl?ne Josserand (1):
  glmark2: check mesa3d opengl when adding drm

 package/glmark2/glmark2.mk | 2 ++
 1 file changed, 2 insertions(+)

-- 
2.8.0.rc3

[Buildroot] [PATH RFC] glmark2: check mesa3d opengl when adding drm

[Mylène Josserand]

When using Vivante OpenGL, the mesa3d is not enabling gbm which is
needed by glmark3 with flavor "drm".

This patch adds a check to enable "drm" flavors only in case of mesa3d
opengl enabled.

Signed-off-by: Myl?ne Josserand <mylene.josserand@free-electrons.com>
---
 package/glmark2/glmark2.mk | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/package/glmark2/glmark2.mk b/package/glmark2/glmark2.mk
index bd5b51a..9588576 100644
--- a/package/glmark2/glmark2.mk
+++ b/package/glmark2/glmark2.mk
@@ -23,6 +23,7 @@ GLMARK2_FLAVORS += x11-gl
 endif
 endif
 
+ifeq ($(BR2_PACKAGE_MESA3D_OPENGL_EGL),y)
 ifeq ($(BR2_PACKAGE_HAS_LIBEGL)$(BR2_PACKAGE_HAS_LIBGLES),yy)
 GLMARK2_FLAVORS += drm-glesv2
 endif
@@ -30,6 +31,7 @@ endif
 ifeq ($(BR2_PACKAGE_HAS_LIBEGL)$(BR2_PACKAGE_HAS_LIBGL),yy)
 GLMARK2_FLAVORS += drm-gl
 endif
+endif
 
 ifeq ($(BR2_PACKAGE_WAYLAND)$(BR2_PACKAGE_HAS_LIBEGL)$(BR2_PACKAGE_HAS_LIBGLES),yyy)
 GLMARK2_DEPENDENCIES += wayland
-- 
2.8.0.rc3

[Buildroot] [PATH RFC] glmark2: check mesa3d opengl when adding drm

[Thomas Petazzoni]

Hello,

On Fri, 29 Apr 2016 13:40:52 +0200, Myl?ne Josserand wrote:
> When using Vivante OpenGL, the mesa3d is not enabling gbm which is
> needed by glmark3 with flavor "drm".
> 
> This patch adds a check to enable "drm" flavors only in case of mesa3d
> opengl enabled.
> 
> Signed-off-by: Myl?ne Josserand <mylene.josserand@free-electrons.com>

I *think* this problem is already solved by patch
http://patchwork.ozlabs.org/patch/610921/ from Gustavo, which I have
just applied to our master branch. Let me know if that is not the case.

Thomas
-- 
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com

[Buildroot] [PATH RFC] glmark2: check mesa3d opengl when adding drm

[Bernd Kuhls]

Am Fri, 29 Apr 2016 13:40:52 +0200 schrieb Myl?ne Josserand:

> When using Vivante OpenGL, the mesa3d is not enabling gbm which is
> needed by glmark3 with flavor "drm".

Hi,

there are other reasons why mesa3d does not provide gbm.
I think this patch is still valid because it fixes
http://autobuild.buildroot.net/results/cb7/cb765a1dbcbe6956a44974c3af35cf17420a6bf4/

Regards, Bernd