* [U-Boot] [PATCH] fit_image: Fix a double close() on the error path
@ 2016-05-01 23:12 Simon Glass
2016-05-02 23:31 ` [U-Boot] " Tom Rini
0 siblings, 1 reply; 2+ messages in thread
From: Simon Glass @ 2016-05-01 23:12 UTC (permalink / raw)
To: u-boot
There is an extra close() call which is not needed.
Reported-by: Coverity (CID: 143065)
Signed-off-by: Simon Glass <sjg@chromium.org>
---
tools/fit_image.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/tools/fit_image.c b/tools/fit_image.c
index ddefa72..0551572 100644
--- a/tools/fit_image.c
+++ b/tools/fit_image.c
@@ -343,7 +343,6 @@ static int fit_build(struct image_tool_params *params, const char *fname)
if (ret != size) {
fprintf(stderr, "%s: Can't write %s: %s\n",
params->cmdname, fname, strerror(errno));
- close(fd);
goto err;
}
close(fd);
--
2.8.0.rc3.226.g39d4020
^ permalink raw reply related [flat|nested] 2+ messages in thread
* [U-Boot] fit_image: Fix a double close() on the error path
2016-05-01 23:12 [U-Boot] [PATCH] fit_image: Fix a double close() on the error path Simon Glass
@ 2016-05-02 23:31 ` Tom Rini
0 siblings, 0 replies; 2+ messages in thread
From: Tom Rini @ 2016-05-02 23:31 UTC (permalink / raw)
To: u-boot
On Sun, May 01, 2016 at 05:12:24PM -0600, Simon Glass wrote:
> There is an extra close() call which is not needed.
>
> Reported-by: Coverity (CID: 143065)
> Signed-off-by: Simon Glass <sjg@chromium.org>
Applied to u-boot/master, thanks!
--
Tom
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: Digital signature
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20160502/6cc57ca1/attachment.sig>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2016-05-02 23:31 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2016-05-01 23:12 [U-Boot] [PATCH] fit_image: Fix a double close() on the error path Simon Glass
2016-05-02 23:31 ` [U-Boot] " Tom Rini
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.