* [PATCH] image_types.bbclass: add WIC_CREATE_EXTRA_ARGS
@ 2016-05-03 0:06 Christopher Larson
2016-05-03 7:27 ` Ed Bartosh
0 siblings, 1 reply; 3+ messages in thread
From: Christopher Larson @ 2016-05-03 0:06 UTC (permalink / raw)
To: openembedded-core; +Cc: Christopher Larson
From: Christopher Larson <chris_larson@mentor.com>
This'll be of use to pass things like --bmap.
Signed-off-by: Christopher Larson <chris_larson@mentor.com>
---
meta/classes/image_types.bbclass | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/meta/classes/image_types.bbclass b/meta/classes/image_types.bbclass
index 19f89f3..385d47e 100644
--- a/meta/classes/image_types.bbclass
+++ b/meta/classes/image_types.bbclass
@@ -193,6 +193,8 @@ def wks_search(files, search_path):
if searched:
return searched
+WIC_CREATE_EXTRA_ARGS ?= ""
+
IMAGE_CMD_wic () {
out="${DEPLOY_DIR_IMAGE}/${IMAGE_NAME}"
wks="${WKS_FULL_PATH}"
@@ -200,7 +202,7 @@ IMAGE_CMD_wic () {
bbfatal "No kickstart files from WKS_FILES were found: ${WKS_FILES}. Please set WKS_FILE or WKS_FILES appropriately."
fi
- BUILDDIR="${TOPDIR}" wic create "$wks" --vars "${STAGING_DIR_TARGET}/imgdata/" -e "${IMAGE_BASENAME}" -o "$out/"
+ BUILDDIR="${TOPDIR}" wic create "$wks" --vars "${STAGING_DIR_TARGET}/imgdata/" -e "${IMAGE_BASENAME}" -o "$out/" ${WIC_CREATE_EXTRA_ARGS}
mv "$out/build/$(basename "${wks%.wks}")"*.direct "$out${IMAGE_NAME_SUFFIX}.wic"
rm -rf "$out/"
}
--
2.8.0
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] image_types.bbclass: add WIC_CREATE_EXTRA_ARGS
2016-05-03 0:06 [PATCH] image_types.bbclass: add WIC_CREATE_EXTRA_ARGS Christopher Larson
@ 2016-05-03 7:27 ` Ed Bartosh
2016-05-03 15:02 ` Christopher Larson
0 siblings, 1 reply; 3+ messages in thread
From: Ed Bartosh @ 2016-05-03 7:27 UTC (permalink / raw)
To: Christopher Larson; +Cc: Christopher Larson, openembedded-core
Hi Christopher,
Thank you for the patch! I like the idea.
Would you mind adding or modifying wic oe-selftest to cover this?
Signed-off-by: Ed Bartosh <ed.bartosh@linux.intel.com>
PS: You've mentioned --bmap as a possible use case scenario for this. I
don't think this is the case as it's simpler to use wic.bmap image
type to achieve this. It's implemented by this patchset:
http://lists.openembedded.org/pipermail/openembedded-core/2016-April/120644.html
On Mon, May 02, 2016 at 05:06:03PM -0700, Christopher Larson wrote:
> From: Christopher Larson <chris_larson@mentor.com>
>
> This'll be of use to pass things like --bmap.
>
> Signed-off-by: Christopher Larson <chris_larson@mentor.com>
> ---
> meta/classes/image_types.bbclass | 4 +++-
> 1 file changed, 3 insertions(+), 1 deletion(-)
>
> diff --git a/meta/classes/image_types.bbclass b/meta/classes/image_types.bbclass
> index 19f89f3..385d47e 100644
> --- a/meta/classes/image_types.bbclass
> +++ b/meta/classes/image_types.bbclass
> @@ -193,6 +193,8 @@ def wks_search(files, search_path):
> if searched:
> return searched
>
> +WIC_CREATE_EXTRA_ARGS ?= ""
> +
> IMAGE_CMD_wic () {
> out="${DEPLOY_DIR_IMAGE}/${IMAGE_NAME}"
> wks="${WKS_FULL_PATH}"
> @@ -200,7 +202,7 @@ IMAGE_CMD_wic () {
> bbfatal "No kickstart files from WKS_FILES were found: ${WKS_FILES}. Please set WKS_FILE or WKS_FILES appropriately."
> fi
>
> - BUILDDIR="${TOPDIR}" wic create "$wks" --vars "${STAGING_DIR_TARGET}/imgdata/" -e "${IMAGE_BASENAME}" -o "$out/"
> + BUILDDIR="${TOPDIR}" wic create "$wks" --vars "${STAGING_DIR_TARGET}/imgdata/" -e "${IMAGE_BASENAME}" -o "$out/" ${WIC_CREATE_EXTRA_ARGS}
> mv "$out/build/$(basename "${wks%.wks}")"*.direct "$out${IMAGE_NAME_SUFFIX}.wic"
> rm -rf "$out/"
> }
> --
> 2.8.0
>
> --
> _______________________________________________
> Openembedded-core mailing list
> Openembedded-core@lists.openembedded.org
> http://lists.openembedded.org/mailman/listinfo/openembedded-core
--
--
Regards,
Ed
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] image_types.bbclass: add WIC_CREATE_EXTRA_ARGS
2016-05-03 7:27 ` Ed Bartosh
@ 2016-05-03 15:02 ` Christopher Larson
0 siblings, 0 replies; 3+ messages in thread
From: Christopher Larson @ 2016-05-03 15:02 UTC (permalink / raw)
To: Ed Bartosh; +Cc: Patches and discussions about the oe-core layer
[-- Attachment #1: Type: text/plain, Size: 789 bytes --]
On Tue, May 3, 2016 at 7:27 AM, Ed Bartosh <ed.bartosh@linux.intel.com>
wrote:
> Hi Christopher,
>
> Thank you for the patch! I like the idea.
>
> Would you mind adding or modifying wic oe-selftest to cover this?
>
> Signed-off-by: Ed Bartosh <ed.bartosh@linux.intel.com>
>
> PS: You've mentioned --bmap as a possible use case scenario for this. I
> don't think this is the case as it's simpler to use wic.bmap image
> type to achieve this. It's implemented by this patchset:
>
> http://lists.openembedded.org/pipermail/openembedded-core/2016-April/120644.html
>
Ah! Thanks. Will do. Thanks for the feedback.
--
Christopher Larson
kergoth at gmail dot com
Founder - BitBake, OpenEmbedded, OpenZaurus
Maintainer - Tslib
Senior Software Engineer, Mentor Graphics
[-- Attachment #2: Type: text/html, Size: 1407 bytes --]
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2016-05-03 15:02 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2016-05-03 0:06 [PATCH] image_types.bbclass: add WIC_CREATE_EXTRA_ARGS Christopher Larson
2016-05-03 7:27 ` Ed Bartosh
2016-05-03 15:02 ` Christopher Larson
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.