* [U-Boot] [PATCH] gpio: at91: Fix pullup/pulldown configuration on PIO3
@ 2016-05-04 21:05 Marek Vasut
2016-05-28 22:15 ` Andreas Bießmann
` (2 more replies)
0 siblings, 3 replies; 4+ messages in thread
From: Marek Vasut @ 2016-05-04 21:05 UTC (permalink / raw)
To: u-boot
On systems with PIO3 (SAMA5D3/D4/..), the pullup and pulldown configuration
is mutualy exclusive. This patch assures that the opposite pull resistor gets
disabled before the requested pull resistor is enabled. This changes behavior
of at91_set_pio_pulldown() such that the pullup is only disabled if pulldown
is to be enabled. This changes behavior of at91_set_pio_pullup() such that
the pulldown is only disabled if pullup is to be enabled.
Signed-off-by: Marek Vasut <marex@denx.de>
Cc: Andreas Bie?mann <andreas.devel@googlemail.com>
Cc: Josh Wu <josh.wu@atmel.com>
Cc: Simon Glass <sjg@chromium.org>
---
drivers/gpio/at91_gpio.c | 11 ++++++++---
1 file changed, 8 insertions(+), 3 deletions(-)
diff --git a/drivers/gpio/at91_gpio.c b/drivers/gpio/at91_gpio.c
index 75a32ee..8e52e3d 100644
--- a/drivers/gpio/at91_gpio.c
+++ b/drivers/gpio/at91_gpio.c
@@ -59,6 +59,11 @@ int at91_set_pio_pullup(unsigned port, unsigned pin, int use_pullup)
{
struct at91_port *at91_port = at91_pio_get_port(port);
+#if defined(CPU_HAS_PIO3)
+ if (use_pullup)
+ at91_set_pio_pulldown(port, pin, 0);
+#endif
+
if (at91_port && (pin < GPIO_PER_BANK))
at91_set_port_pullup(at91_port, pin, use_pullup);
@@ -305,10 +310,10 @@ int at91_set_pio_pulldown(unsigned port, unsigned pin, int is_on)
if (at91_port && (pin < GPIO_PER_BANK)) {
mask = 1 << pin;
- writel(mask, &at91_port->pudr);
- if (is_on)
+ if (is_on) {
+ at91_set_pio_pullup(port, pin, 0);
writel(mask, &at91_port->ppder);
- else
+ } else
writel(mask, &at91_port->ppddr);
}
--
2.7.0
^ permalink raw reply related [flat|nested] 4+ messages in thread
* [U-Boot] [PATCH] gpio: at91: Fix pullup/pulldown configuration on PIO3
2016-05-04 21:05 [U-Boot] [PATCH] gpio: at91: Fix pullup/pulldown configuration on PIO3 Marek Vasut
@ 2016-05-28 22:15 ` Andreas Bießmann
2016-06-12 20:20 ` Andreas Bießmann
2016-06-12 22:00 ` [U-Boot] " Andreas Bießmann
2 siblings, 0 replies; 4+ messages in thread
From: Andreas Bießmann @ 2016-05-28 22:15 UTC (permalink / raw)
To: u-boot
On 04.05.16 23:05, Marek Vasut wrote:
> On systems with PIO3 (SAMA5D3/D4/..), the pullup and pulldown configuration
> is mutualy exclusive. This patch assures that the opposite pull resistor gets
> disabled before the requested pull resistor is enabled. This changes behavior
> of at91_set_pio_pulldown() such that the pullup is only disabled if pulldown
> is to be enabled. This changes behavior of at91_set_pio_pullup() such that
> the pulldown is only disabled if pullup is to be enabled.
>
> Signed-off-by: Marek Vasut <marex@denx.de>
> Cc: Andreas Bie?mann <andreas.devel@googlemail.com>
> Cc: Josh Wu <josh.wu@atmel.com>
> Cc: Simon Glass <sjg@chromium.org>
Reviewed-by: Andreas Bie?mann <andreas@biessmann.org>
^ permalink raw reply [flat|nested] 4+ messages in thread
* [U-Boot] [PATCH] gpio: at91: Fix pullup/pulldown configuration on PIO3
2016-05-04 21:05 [U-Boot] [PATCH] gpio: at91: Fix pullup/pulldown configuration on PIO3 Marek Vasut
2016-05-28 22:15 ` Andreas Bießmann
@ 2016-06-12 20:20 ` Andreas Bießmann
2016-06-12 22:00 ` [U-Boot] " Andreas Bießmann
2 siblings, 0 replies; 4+ messages in thread
From: Andreas Bießmann @ 2016-06-12 20:20 UTC (permalink / raw)
To: u-boot
On 04.05.16 23:05, Marek Vasut wrote:
> On systems with PIO3 (SAMA5D3/D4/..), the pullup and pulldown configuration
> is mutualy exclusive. This patch assures that the opposite pull resistor gets
> disabled before the requested pull resistor is enabled. This changes behavior
> of at91_set_pio_pulldown() such that the pullup is only disabled if pulldown
> is to be enabled. This changes behavior of at91_set_pio_pullup() such that
> the pulldown is only disabled if pullup is to be enabled.
>
> Signed-off-by: Marek Vasut <marex@denx.de>
> Cc: Andreas Bie?mann <andreas.devel@googlemail.com>
> Cc: Josh Wu <josh.wu@atmel.com>
> Cc: Simon Glass <sjg@chromium.org>
Reviewed-by: Andreas Bie?mann <andreas@biessmann.org>
> ---
> drivers/gpio/at91_gpio.c | 11 ++++++++---
> 1 file changed, 8 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/gpio/at91_gpio.c b/drivers/gpio/at91_gpio.c
> index 75a32ee..8e52e3d 100644
> --- a/drivers/gpio/at91_gpio.c
> +++ b/drivers/gpio/at91_gpio.c
> @@ -59,6 +59,11 @@ int at91_set_pio_pullup(unsigned port, unsigned pin, int use_pullup)
> {
> struct at91_port *at91_port = at91_pio_get_port(port);
>
> +#if defined(CPU_HAS_PIO3)
> + if (use_pullup)
> + at91_set_pio_pulldown(port, pin, 0);
> +#endif
> +
> if (at91_port && (pin < GPIO_PER_BANK))
> at91_set_port_pullup(at91_port, pin, use_pullup);
>
> @@ -305,10 +310,10 @@ int at91_set_pio_pulldown(unsigned port, unsigned pin, int is_on)
>
> if (at91_port && (pin < GPIO_PER_BANK)) {
> mask = 1 << pin;
> - writel(mask, &at91_port->pudr);
> - if (is_on)
> + if (is_on) {
> + at91_set_pio_pullup(port, pin, 0);
> writel(mask, &at91_port->ppder);
> - else
> + } else
> writel(mask, &at91_port->ppddr);
> }
>
>
^ permalink raw reply [flat|nested] 4+ messages in thread
* [U-Boot] gpio: at91: Fix pullup/pulldown configuration on PIO3
2016-05-04 21:05 [U-Boot] [PATCH] gpio: at91: Fix pullup/pulldown configuration on PIO3 Marek Vasut
2016-05-28 22:15 ` Andreas Bießmann
2016-06-12 20:20 ` Andreas Bießmann
@ 2016-06-12 22:00 ` Andreas Bießmann
2 siblings, 0 replies; 4+ messages in thread
From: Andreas Bießmann @ 2016-06-12 22:00 UTC (permalink / raw)
To: u-boot
Dear Marek Vasut,
Marek Vasut <marex@denx.de> writes:
>On systems with PIO3 (SAMA5D3/D4/..), the pullup and pulldown configuration
>is mutualy exclusive. This patch assures that the opposite pull resistor gets
>disabled before the requested pull resistor is enabled. This changes behavior
>of at91_set_pio_pulldown() such that the pullup is only disabled if pulldown
>is to be enabled. This changes behavior of at91_set_pio_pullup() such that
>the pulldown is only disabled if pullup is to be enabled.
>
>Signed-off-by: Marek Vasut <marex@denx.de>
>Cc: Andreas Bie?mann <andreas.devel@googlemail.com>
>Cc: Josh Wu <josh.wu@atmel.com>
>Cc: Simon Glass <sjg@chromium.org>
>Reviewed-by: Andreas Bie?mann <andreas@biessmann.org>
>---
> drivers/gpio/at91_gpio.c | 11 ++++++++---
> 1 file changed, 8 insertions(+), 3 deletions(-)
applied to u-boot-atmel/master, thanks!
Best regards,
Andreas Bie?mann
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2016-06-12 22:00 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2016-05-04 21:05 [U-Boot] [PATCH] gpio: at91: Fix pullup/pulldown configuration on PIO3 Marek Vasut
2016-05-28 22:15 ` Andreas Bießmann
2016-06-12 20:20 ` Andreas Bießmann
2016-06-12 22:00 ` [U-Boot] " Andreas Bießmann
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.