* [PATCH] Fix "failed sanity test tmpdir" for libnice and update PNBLACKLIST.
@ 2016-05-05 16:22 Noor, Ahsan
2016-05-05 17:05 ` Christopher Larson
2016-05-05 17:13 ` Martin Jansa
0 siblings, 2 replies; 6+ messages in thread
From: Noor, Ahsan @ 2016-05-05 16:22 UTC (permalink / raw)
To: openembedded-devel
From: Noor Ahsan <noor_ahsan@mentor.com>
* Update do_compile_append where it was updating *.pc from ${S} and
removing staging dir folder. Now we have seperate build folder
where packages got build. We have to search pc in ${B} not in ${S}.
After updating the tmp dir pathc is removed from nice.pc file.
* Remove PNBLACKLIST for libnice and farsight recipes.
Signed-off-by: Noor Ahsan <noor_ahsan@mentor.com>
---
meta-oe/recipes-support/farsight/farsight2_0.0.22.bb | 1 -
meta-oe/recipes-support/farsight/libnice_0.0.13.bb | 3 +--
2 files changed, 1 insertion(+), 3 deletions(-)
diff --git a/meta-oe/recipes-support/farsight/farsight2_0.0.22.bb b/meta-oe/recipes-support/farsight/farsight2_0.0.22.bb
index ffb222b..beb6108 100644
--- a/meta-oe/recipes-support/farsight/farsight2_0.0.22.bb
+++ b/meta-oe/recipes-support/farsight/farsight2_0.0.22.bb
@@ -29,4 +29,3 @@ FILES_${PN}-dbg += "${libdir}/*/.debug"
SRC_URI[md5sum] = "e1f540cf3ebab06c3d7db1f46b44ac88"
SRC_URI[sha256sum] = "3ae59aa61a8071c9fad111e5fd606aabc27961eb4192f8729987a27dae6b3974"
-PNBLACKLIST[farsight2] ?= "Depends on broken libnice"
diff --git a/meta-oe/recipes-support/farsight/libnice_0.0.13.bb b/meta-oe/recipes-support/farsight/libnice_0.0.13.bb
index a9081dc..3d99622 100644
--- a/meta-oe/recipes-support/farsight/libnice_0.0.13.bb
+++ b/meta-oe/recipes-support/farsight/libnice_0.0.13.bb
@@ -28,7 +28,7 @@ do_configure_prepend() {
}
do_compile_append() {
- for i in $(find ${S} -name "*.pc") ; do
+ for i in $(find ${B} -name "*.pc") ; do
sed -i -e s:${STAGING_DIR_TARGET}::g \
-e s:/${TARGET_SYS}::g \
$i
@@ -39,4 +39,3 @@ do_compile_append() {
SRC_URI[md5sum] = "e5b9f799a57cb939ea2658ec35253ab9"
SRC_URI[sha256sum] = "d8dd260c486a470a6052a5323920878a084e44a19df09b15728b85c9e3d6edf0"
-PNBLACKLIST[libnice] ?= "BROKEN: QA Issue: nice.pc failed sanity test (tmpdir)"
--
2.8.1
^ permalink raw reply related [flat|nested] 6+ messages in thread
* Re: [PATCH] Fix "failed sanity test tmpdir" for libnice and update PNBLACKLIST.
2016-05-05 16:22 [PATCH] Fix "failed sanity test tmpdir" for libnice and update PNBLACKLIST Noor, Ahsan
@ 2016-05-05 17:05 ` Christopher Larson
2016-05-06 10:16 ` Ahsan, Noor
2016-05-05 17:13 ` Martin Jansa
1 sibling, 1 reply; 6+ messages in thread
From: Christopher Larson @ 2016-05-05 17:05 UTC (permalink / raw)
To: Openembedded Discussion
On Thu, May 5, 2016 at 9:22 AM, Noor, Ahsan <noor_ahsan@mentor.com> wrote:
> From: Noor Ahsan <noor_ahsan@mentor.com>
>
> * Update do_compile_append where it was updating *.pc from ${S} and
> removing staging dir folder. Now we have seperate build folder
> where packages got build. We have to search pc in ${B} not in ${S}.
> After updating the tmp dir pathc is removed from nice.pc file.
> * Remove PNBLACKLIST for libnice and farsight recipes.
>
> Signed-off-by: Noor Ahsan <noor_ahsan@mentor.com>
>
The commit message doesn't meet the OE guidelines (not prefixed by the
recipe being changed) and you don't mention farsight2 in the message at all
-- should that be a separate commit?
--
Christopher Larson
clarson at kergoth dot com
Founder - BitBake, OpenEmbedded, OpenZaurus
Maintainer - Tslib
Senior Software Engineer, Mentor Graphics
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] Fix "failed sanity test tmpdir" for libnice and update PNBLACKLIST.
2016-05-05 16:22 [PATCH] Fix "failed sanity test tmpdir" for libnice and update PNBLACKLIST Noor, Ahsan
2016-05-05 17:05 ` Christopher Larson
@ 2016-05-05 17:13 ` Martin Jansa
2016-05-06 10:07 ` Ahsan, Noor
1 sibling, 1 reply; 6+ messages in thread
From: Martin Jansa @ 2016-05-05 17:13 UTC (permalink / raw)
To: openembedded-devel
[-- Attachment #1: Type: text/plain, Size: 2409 bytes --]
On Thu, May 05, 2016 at 09:22:30PM +0500, Noor, Ahsan wrote:
> From: Noor Ahsan <noor_ahsan@mentor.com>
>
> * Update do_compile_append where it was updating *.pc from ${S} and
> removing staging dir folder. Now we have seperate build folder
> where packages got build. We have to search pc in ${B} not in ${S}.
> After updating the tmp dir pathc is removed from nice.pc file.
typo pathc
> * Remove PNBLACKLIST for libnice and farsight recipes.
>
> Signed-off-by: Noor Ahsan <noor_ahsan@mentor.com>
> ---
> meta-oe/recipes-support/farsight/farsight2_0.0.22.bb | 1 -
> meta-oe/recipes-support/farsight/libnice_0.0.13.bb | 3 +--
> 2 files changed, 1 insertion(+), 3 deletions(-)
>
> diff --git a/meta-oe/recipes-support/farsight/farsight2_0.0.22.bb b/meta-oe/recipes-support/farsight/farsight2_0.0.22.bb
> index ffb222b..beb6108 100644
> --- a/meta-oe/recipes-support/farsight/farsight2_0.0.22.bb
> +++ b/meta-oe/recipes-support/farsight/farsight2_0.0.22.bb
> @@ -29,4 +29,3 @@ FILES_${PN}-dbg += "${libdir}/*/.debug"
> SRC_URI[md5sum] = "e1f540cf3ebab06c3d7db1f46b44ac88"
> SRC_URI[sha256sum] = "3ae59aa61a8071c9fad111e5fd606aabc27961eb4192f8729987a27dae6b3974"
>
> -PNBLACKLIST[farsight2] ?= "Depends on broken libnice"
> diff --git a/meta-oe/recipes-support/farsight/libnice_0.0.13.bb b/meta-oe/recipes-support/farsight/libnice_0.0.13.bb
> index a9081dc..3d99622 100644
> --- a/meta-oe/recipes-support/farsight/libnice_0.0.13.bb
> +++ b/meta-oe/recipes-support/farsight/libnice_0.0.13.bb
> @@ -28,7 +28,7 @@ do_configure_prepend() {
> }
>
> do_compile_append() {
> - for i in $(find ${S} -name "*.pc") ; do
> + for i in $(find ${B} -name "*.pc") ; do
> sed -i -e s:${STAGING_DIR_TARGET}::g \
> -e s:/${TARGET_SYS}::g \
> $i
> @@ -39,4 +39,3 @@ do_compile_append() {
> SRC_URI[md5sum] = "e5b9f799a57cb939ea2658ec35253ab9"
> SRC_URI[sha256sum] = "d8dd260c486a470a6052a5323920878a084e44a19df09b15728b85c9e3d6edf0"
>
> -PNBLACKLIST[libnice] ?= "BROKEN: QA Issue: nice.pc failed sanity test (tmpdir)"
> --
> 2.8.1
>
> --
> _______________________________________________
> Openembedded-devel mailing list
> Openembedded-devel@lists.openembedded.org
> http://lists.openembedded.org/mailman/listinfo/openembedded-devel
--
Martin 'JaMa' Jansa jabber: Martin.Jansa@gmail.com
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 188 bytes --]
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] Fix "failed sanity test tmpdir" for libnice and update PNBLACKLIST.
2016-05-05 17:13 ` Martin Jansa
@ 2016-05-06 10:07 ` Ahsan, Noor
0 siblings, 0 replies; 6+ messages in thread
From: Ahsan, Noor @ 2016-05-06 10:07 UTC (permalink / raw)
To: openembedded-devel
I have sent V2 patch after fixing this.
-----Original Message-----
From: openembedded-devel-bounces@lists.openembedded.org [mailto:openembedded-devel-bounces@lists.openembedded.org] On Behalf Of Martin Jansa
Sent: Thursday, May 05, 2016 10:13 PM
To: openembedded-devel@lists.openembedded.org
Subject: Re: [oe] [PATCH] Fix "failed sanity test tmpdir" for libnice and update PNBLACKLIST.
On Thu, May 05, 2016 at 09:22:30PM +0500, Noor, Ahsan wrote:
> From: Noor Ahsan <noor_ahsan@mentor.com>
>
> * Update do_compile_append where it was updating *.pc from ${S} and
> removing staging dir folder. Now we have seperate build folder
> where packages got build. We have to search pc in ${B} not in ${S}.
> After updating the tmp dir pathc is removed from nice.pc file.
typo pathc
> * Remove PNBLACKLIST for libnice and farsight recipes.
>
> Signed-off-by: Noor Ahsan <noor_ahsan@mentor.com>
> ---
> meta-oe/recipes-support/farsight/farsight2_0.0.22.bb | 1 -
> meta-oe/recipes-support/farsight/libnice_0.0.13.bb | 3 +--
> 2 files changed, 1 insertion(+), 3 deletions(-)
>
> diff --git a/meta-oe/recipes-support/farsight/farsight2_0.0.22.bb
> b/meta-oe/recipes-support/farsight/farsight2_0.0.22.bb
> index ffb222b..beb6108 100644
> --- a/meta-oe/recipes-support/farsight/farsight2_0.0.22.bb
> +++ b/meta-oe/recipes-support/farsight/farsight2_0.0.22.bb
> @@ -29,4 +29,3 @@ FILES_${PN}-dbg += "${libdir}/*/.debug"
> SRC_URI[md5sum] = "e1f540cf3ebab06c3d7db1f46b44ac88"
> SRC_URI[sha256sum] = "3ae59aa61a8071c9fad111e5fd606aabc27961eb4192f8729987a27dae6b3974"
>
> -PNBLACKLIST[farsight2] ?= "Depends on broken libnice"
> diff --git a/meta-oe/recipes-support/farsight/libnice_0.0.13.bb
> b/meta-oe/recipes-support/farsight/libnice_0.0.13.bb
> index a9081dc..3d99622 100644
> --- a/meta-oe/recipes-support/farsight/libnice_0.0.13.bb
> +++ b/meta-oe/recipes-support/farsight/libnice_0.0.13.bb
> @@ -28,7 +28,7 @@ do_configure_prepend() { }
>
> do_compile_append() {
> - for i in $(find ${S} -name "*.pc") ; do
> + for i in $(find ${B} -name "*.pc") ; do
> sed -i -e s:${STAGING_DIR_TARGET}::g \
> -e s:/${TARGET_SYS}::g \
> $i
> @@ -39,4 +39,3 @@ do_compile_append() { SRC_URI[md5sum] =
> "e5b9f799a57cb939ea2658ec35253ab9"
> SRC_URI[sha256sum] = "d8dd260c486a470a6052a5323920878a084e44a19df09b15728b85c9e3d6edf0"
>
> -PNBLACKLIST[libnice] ?= "BROKEN: QA Issue: nice.pc failed sanity test (tmpdir)"
> --
> 2.8.1
>
> --
> _______________________________________________
> Openembedded-devel mailing list
> Openembedded-devel@lists.openembedded.org
> http://lists.openembedded.org/mailman/listinfo/openembedded-devel
--
Martin 'JaMa' Jansa jabber: Martin.Jansa@gmail.com
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] Fix "failed sanity test tmpdir" for libnice and update PNBLACKLIST.
2016-05-05 17:05 ` Christopher Larson
@ 2016-05-06 10:16 ` Ahsan, Noor
2016-05-06 10:55 ` Martin Jansa
0 siblings, 1 reply; 6+ messages in thread
From: Ahsan, Noor @ 2016-05-06 10:16 UTC (permalink / raw)
To: openembedded-devel
Doesn't recipe name is mentioned when only that recipe is changed in the patch. I though when multiple recipes are changed then we don't mention the name of the files in the commit summary. Correct me if my interpretation is wrong.
Secondly I thought both are inter related. That is why added both in signed patch. Farsight is mentioned in the details
Remove PNBLACKLIST for libnice and farsight recipes.
Noor
-----Original Message-----
From: openembedded-devel-bounces@lists.openembedded.org [mailto:openembedded-devel-bounces@lists.openembedded.org] On Behalf Of Christopher Larson
Sent: Thursday, May 05, 2016 10:05 PM
To: Openembedded Discussion
Subject: Re: [oe] [PATCH] Fix "failed sanity test tmpdir" for libnice and update PNBLACKLIST.
On Thu, May 5, 2016 at 9:22 AM, Noor, Ahsan <noor_ahsan@mentor.com> wrote:
> From: Noor Ahsan <noor_ahsan@mentor.com>
>
> * Update do_compile_append where it was updating *.pc from ${S} and
> removing staging dir folder. Now we have seperate build folder
> where packages got build. We have to search pc in ${B} not in ${S}.
> After updating the tmp dir pathc is removed from nice.pc file.
> * Remove PNBLACKLIST for libnice and farsight recipes.
>
> Signed-off-by: Noor Ahsan <noor_ahsan@mentor.com>
>
The commit message doesn't meet the OE guidelines (not prefixed by the recipe being changed) and you don't mention farsight2 in the message at all
-- should that be a separate commit?
--
Christopher Larson
clarson at kergoth dot com
Founder - BitBake, OpenEmbedded, OpenZaurus Maintainer - Tslib Senior Software Engineer, Mentor Graphics
--
_______________________________________________
Openembedded-devel mailing list
Openembedded-devel@lists.openembedded.org
http://lists.openembedded.org/mailman/listinfo/openembedded-devel
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] Fix "failed sanity test tmpdir" for libnice and update PNBLACKLIST.
2016-05-06 10:16 ` Ahsan, Noor
@ 2016-05-06 10:55 ` Martin Jansa
0 siblings, 0 replies; 6+ messages in thread
From: Martin Jansa @ 2016-05-06 10:55 UTC (permalink / raw)
To: openembedded-devel
[-- Attachment #1: Type: text/plain, Size: 2590 bytes --]
On Fri, May 06, 2016 at 10:16:18AM +0000, Ahsan, Noor wrote:
> Doesn't recipe name is mentioned when only that recipe is changed in the patch. I though when multiple recipes are changed then we don't mention the name of the files in the commit summary. Correct me if my interpretation is wrong.
Listing 2 is short enough, so the summary should start with them, just
like in the commit where I've blacklisted them:
libnice, farsight2, pidgin: Blacklist because libnice's nice.pc
> Secondly I thought both are inter related. That is why added both in signed patch. Farsight is mentioned in the details
I'm fine with farsight unblacklisted in the same commit as the reason
for blacklist is the same and resolved here. Just remove added blank
lines as well please.
> Remove PNBLACKLIST for libnice and farsight recipes.
>
> Noor
>
> -----Original Message-----
> From: openembedded-devel-bounces@lists.openembedded.org [mailto:openembedded-devel-bounces@lists.openembedded.org] On Behalf Of Christopher Larson
> Sent: Thursday, May 05, 2016 10:05 PM
> To: Openembedded Discussion
> Subject: Re: [oe] [PATCH] Fix "failed sanity test tmpdir" for libnice and update PNBLACKLIST.
>
> On Thu, May 5, 2016 at 9:22 AM, Noor, Ahsan <noor_ahsan@mentor.com> wrote:
>
> > From: Noor Ahsan <noor_ahsan@mentor.com>
> >
> > * Update do_compile_append where it was updating *.pc from ${S} and
> > removing staging dir folder. Now we have seperate build folder
> > where packages got build. We have to search pc in ${B} not in ${S}.
> > After updating the tmp dir pathc is removed from nice.pc file.
> > * Remove PNBLACKLIST for libnice and farsight recipes.
> >
> > Signed-off-by: Noor Ahsan <noor_ahsan@mentor.com>
> >
>
> The commit message doesn't meet the OE guidelines (not prefixed by the recipe being changed) and you don't mention farsight2 in the message at all
> -- should that be a separate commit?
> --
> Christopher Larson
> clarson at kergoth dot com
> Founder - BitBake, OpenEmbedded, OpenZaurus Maintainer - Tslib Senior Software Engineer, Mentor Graphics
> --
> _______________________________________________
> Openembedded-devel mailing list
> Openembedded-devel@lists.openembedded.org
> http://lists.openembedded.org/mailman/listinfo/openembedded-devel
> --
> _______________________________________________
> Openembedded-devel mailing list
> Openembedded-devel@lists.openembedded.org
> http://lists.openembedded.org/mailman/listinfo/openembedded-devel
--
Martin 'JaMa' Jansa jabber: Martin.Jansa@gmail.com
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 188 bytes --]
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2016-05-06 10:54 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2016-05-05 16:22 [PATCH] Fix "failed sanity test tmpdir" for libnice and update PNBLACKLIST Noor, Ahsan
2016-05-05 17:05 ` Christopher Larson
2016-05-06 10:16 ` Ahsan, Noor
2016-05-06 10:55 ` Martin Jansa
2016-05-05 17:13 ` Martin Jansa
2016-05-06 10:07 ` Ahsan, Noor
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.