All of lore.kernel.org
 help / color / mirror / Atom feed
* [Buildroot] [PATCH] configs: freescale_imx6ulevk_defconfig: Add alsa-utils
@ 2016-05-05 23:47 Fabio Estevam
  2016-05-06 10:13 ` Julien Boibessot
  2016-05-06 13:28 ` Thomas Petazzoni
  0 siblings, 2 replies; 3+ messages in thread
From: Fabio Estevam @ 2016-05-05 23:47 UTC (permalink / raw)
  To: buildroot

From: Fabio Estevam <fabio.estevam@nxp.com>

Add support for alsa-utils.

Also select BR2_TOOLCHAIN_BUILDROOT_WCHAR as this is a requirement
for alsamixer.

Signed-off-by: Fabio Estevam <fabio.estevam@nxp.com>
---
 configs/freescale_imx6ulevk_defconfig | 6 ++++++
 1 file changed, 6 insertions(+)

diff --git a/configs/freescale_imx6ulevk_defconfig b/configs/freescale_imx6ulevk_defconfig
index b8a1f86..8f36971 100644
--- a/configs/freescale_imx6ulevk_defconfig
+++ b/configs/freescale_imx6ulevk_defconfig
@@ -6,6 +6,7 @@ BR2_cortex_a7=y
 BR2_PACKAGE_HOST_LINUX_HEADERS_CUSTOM_3_14=y
 
 # system
+BR2_TOOLCHAIN_BUILDROOT_WCHAR=y
 BR2_TARGET_GENERIC_GETTY_PORT="ttymxc0"
 
 # kernel
@@ -31,5 +32,10 @@ BR2_PACKAGE_HOST_GENIMAGE=y
 BR2_PACKAGE_HOST_MTOOLS=y
 
 # filesystem / image
+BR2_PACKAGE_ALSA_UTILS=y
+BR2_PACKAGE_ALSA_UTILS_ALSACONF=y
+BR2_PACKAGE_ALSA_UTILS_APLAY=y
+BR2_PACKAGE_ALSA_UTILS_SPEAKER_TEST=y
+BR2_TARGET_ROOTFS_EXT2=y
 BR2_ROOTFS_POST_IMAGE_SCRIPT="board/freescale/imx6ulevk/post-image.sh"
 BR2_TARGET_ROOTFS_EXT2=y
-- 
1.9.1

^ permalink raw reply related	[flat|nested] 3+ messages in thread

* [Buildroot] [PATCH] configs: freescale_imx6ulevk_defconfig: Add alsa-utils
  2016-05-05 23:47 [Buildroot] [PATCH] configs: freescale_imx6ulevk_defconfig: Add alsa-utils Fabio Estevam
@ 2016-05-06 10:13 ` Julien Boibessot
  2016-05-06 13:28 ` Thomas Petazzoni
  1 sibling, 0 replies; 3+ messages in thread
From: Julien Boibessot @ 2016-05-06 10:13 UTC (permalink / raw)
  To: buildroot

Hello Fabio,

On 06/05/2016 01:47, Fabio Estevam wrote:
> From: Fabio Estevam <fabio.estevam@nxp.com>
>
> Add support for alsa-utils.
>
> Also select BR2_TOOLCHAIN_BUILDROOT_WCHAR as this is a requirement
> for alsamixer.
>
> Signed-off-by: Fabio Estevam <fabio.estevam@nxp.com>
> ---
>  configs/freescale_imx6ulevk_defconfig | 6 ++++++
>  1 file changed, 6 insertions(+)
>
> diff --git a/configs/freescale_imx6ulevk_defconfig b/configs/freescale_imx6ulevk_defconfig
> index b8a1f86..8f36971 100644
> --- a/configs/freescale_imx6ulevk_defconfig
> +++ b/configs/freescale_imx6ulevk_defconfig
> @@ -6,6 +6,7 @@ BR2_cortex_a7=y
>  BR2_PACKAGE_HOST_LINUX_HEADERS_CUSTOM_3_14=y
>  
>  # system
> +BR2_TOOLCHAIN_BUILDROOT_WCHAR=y
>  BR2_TARGET_GENERIC_GETTY_PORT="ttymxc0"
>  
>  # kernel
> @@ -31,5 +32,10 @@ BR2_PACKAGE_HOST_GENIMAGE=y
>  BR2_PACKAGE_HOST_MTOOLS=y
>  
>  # filesystem / image
> +BR2_PACKAGE_ALSA_UTILS=y
> +BR2_PACKAGE_ALSA_UTILS_ALSACONF=y
> +BR2_PACKAGE_ALSA_UTILS_APLAY=y
> +BR2_PACKAGE_ALSA_UTILS_SPEAKER_TEST=y
> +BR2_TARGET_ROOTFS_EXT2=y

I think this one can be removed because it's already defined 2 lines below:

>  BR2_ROOTFS_POST_IMAGE_SCRIPT="board/freescale/imx6ulevk/post-image.sh"
>  BR2_TARGET_ROOTFS_EXT2=y						<<<<<<<<<<<<<<

Thomas will confirm but, IIRC, Buildroot mainlined defconfigs only
define the mininal options to boot the boards and then it's up to the
user to choose the packages it needs.

Best regards,
Julien

^ permalink raw reply	[flat|nested] 3+ messages in thread

* [Buildroot] [PATCH] configs: freescale_imx6ulevk_defconfig: Add alsa-utils
  2016-05-05 23:47 [Buildroot] [PATCH] configs: freescale_imx6ulevk_defconfig: Add alsa-utils Fabio Estevam
  2016-05-06 10:13 ` Julien Boibessot
@ 2016-05-06 13:28 ` Thomas Petazzoni
  1 sibling, 0 replies; 3+ messages in thread
From: Thomas Petazzoni @ 2016-05-06 13:28 UTC (permalink / raw)
  To: buildroot

Hello,

On Thu,  5 May 2016 20:47:25 -0300, Fabio Estevam wrote:
> From: Fabio Estevam <fabio.estevam@nxp.com>
> 
> Add support for alsa-utils.
> 
> Also select BR2_TOOLCHAIN_BUILDROOT_WCHAR as this is a requirement
> for alsamixer.
> 
> Signed-off-by: Fabio Estevam <fabio.estevam@nxp.com>

Thanks Fabio! However, as Julien explained, the principle of Buildroot
defconfigs is that they should be "minimal" configuration, i.e
configurations that just build a basic toolchain + bootloader + kernel
+ minimal rootfs with just Busybox.

In addition to those minimal configurations, we have started accepting
"demo" configurations, such as firefly_rk3288_demo_defconfig. But they
should be a bit more "useful" than just having alsa-utils. For example,
firefly_rk3288_demo_defconfig adds Qt5 with OpenGL support, as well as
Qt5 examples.

Best regards,

Thomas
-- 
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2016-05-06 13:28 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2016-05-05 23:47 [Buildroot] [PATCH] configs: freescale_imx6ulevk_defconfig: Add alsa-utils Fabio Estevam
2016-05-06 10:13 ` Julien Boibessot
2016-05-06 13:28 ` Thomas Petazzoni

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.