[PATCH v2 0/1] staging: unisys: Updates to the patch remove unused struct members

[PATCH v2 0/1] staging: unisys: Updates to the patch remove unused struct members

[David Kershner]

The patch staging: unisys: remove unused struct members did not remove a
comment that referenced pnext. This series resends that.

Changes since v1: 
	- Remove additional comment line referencing pnext

Erik Arfvidson (1):
  staging: unisys: remove unused struct members

 drivers/staging/unisys/visorbus/visorchipset.c | 6 ------
 1 file changed, 6 deletions(-)

-- 
1.9.1

_______________________________________________
devel mailing list
devel@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel

[PATCH v2 1/1] staging: unisys: remove unused struct members

[David Kershner]

From: Erik Arfvidson <erik.arfvidson@unisys.com>

The following struct members were never used:
 putfile_active_buffer::pnext
 putfile_request::file_request_number
 putfile_request::data_sequence_number

Signed-off-by: Erik Arfvidson <erik.arfvidson@unisys.com>
Signed-off-by: David Kershner <david.kershner@unisys.com>
---
 drivers/staging/unisys/visorbus/visorchipset.c | 6 ------
 1 file changed, 6 deletions(-)

diff --git a/drivers/staging/unisys/visorbus/visorchipset.c b/drivers/staging/unisys/visorbus/visorchipset.c
index 7522559..f0bbf52 100644
--- a/drivers/staging/unisys/visorbus/visorchipset.c
+++ b/drivers/staging/unisys/visorbus/visorchipset.c
@@ -151,8 +151,6 @@ struct putfile_active_buffer {
 	/* a payload from a controlvm message, containing a file data buffer */
 	struct parser_context *parser_ctx;
 	/* points within data area of parser_ctx to next byte of data */
-	u8 *pnext;
-	/* # bytes left from <pnext> to the end of this data buffer */
 	size_t bytes_remaining;
 };
 
@@ -166,14 +164,10 @@ struct putfile_request {
 
 	/* header from original TransmitFile request */
 	struct controlvm_message_header controlvm_header;
-	u64 file_request_number;	/* from original TransmitFile request */
 
 	/* link to next struct putfile_request */
 	struct list_head next_putfile_request;
 
-	/* most-recent sequence number supplied via a controlvm message */
-	u64 data_sequence_number;
-
 	/* head of putfile_buffer_entry list, which describes the data to be
 	 * supplied as putfile data;
 	 * - this list is added to when controlvm messages come in that supply
-- 
1.9.1

_______________________________________________
devel mailing list
devel@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel

Re: [PATCH v2 1/1] staging: unisys: remove unused struct members

[Luis de Bethencourt]

On 06/05/16 02:05, David Kershner wrote:
> From: Erik Arfvidson <erik.arfvidson@unisys.com>
> 
> The following struct members were never used:
>  putfile_active_buffer::pnext
>  putfile_request::file_request_number
>  putfile_request::data_sequence_number
> 
> Signed-off-by: Erik Arfvidson <erik.arfvidson@unisys.com>
> Signed-off-by: David Kershner <david.kershner@unisys.com>
> ---
>  drivers/staging/unisys/visorbus/visorchipset.c | 6 ------
>  1 file changed, 6 deletions(-)
> 
> diff --git a/drivers/staging/unisys/visorbus/visorchipset.c b/drivers/staging/unisys/visorbus/visorchipset.c
> index 7522559..f0bbf52 100644
> --- a/drivers/staging/unisys/visorbus/visorchipset.c
> +++ b/drivers/staging/unisys/visorbus/visorchipset.c
> @@ -151,8 +151,6 @@ struct putfile_active_buffer {
>  	/* a payload from a controlvm message, containing a file data buffer */
>  	struct parser_context *parser_ctx;
>  	/* points within data area of parser_ctx to next byte of data */
> -	u8 *pnext;
> -	/* # bytes left from <pnext> to the end of this data buffer */
>  	size_t bytes_remaining;
>  };
>  
> @@ -166,14 +164,10 @@ struct putfile_request {
>  
>  	/* header from original TransmitFile request */
>  	struct controlvm_message_header controlvm_header;
> -	u64 file_request_number;	/* from original TransmitFile request */
>  
>  	/* link to next struct putfile_request */
>  	struct list_head next_putfile_request;
>  
> -	/* most-recent sequence number supplied via a controlvm message */
> -	u64 data_sequence_number;
> -
>  	/* head of putfile_buffer_entry list, which describes the data to be
>  	 * supplied as putfile data;
>  	 * - this list is added to when controlvm messages come in that supply
> 

Looks good.

Small note, when it is one patch and not a series. Instead of having a cover email
[0/1] you can write comments about the patch that won't end in the git log right
after the "---" line, after the Signed-off-bys and the diff.

Here are two examples:
https://lkml.org/lkml/2016/5/5/483
https://lkml.org/lkml/2016/5/5/335

Thanks :)
Luis