All of lore.kernel.org
 help / color / mirror / Atom feed
From: Roger Quadros <rogerq@ti.com>
To: <peter.chen@freescale.com>
Cc: <balbi@kernel.org>, <tony@atomide.com>,
	<gregkh@linuxfoundation.org>, <dan.j.williams@intel.com>,
	<mathias.nyman@linux.intel.com>, <Joao.Pinto@synopsys.com>,
	<sergei.shtylyov@cogentembedded.com>, <jun.li@freescale.com>,
	<grygorii.strashko@ti.com>, <yoshihiro.shimoda.uh@renesas.com>,
	<robh@kernel.org>, <nsekhar@ti.com>, <b-liu@ti.com>,
	<linux-usb@vger.kernel.org>, <linux-omap@vger.kernel.org>,
	<linux-kernel@vger.kernel.org>, <devicetree@vger.kernel.org>,
	Roger Quadros <rogerq@ti.com>
Subject: [PATCH v8 11/14] usb: otg: use dev_dbg() instead of VDBG()
Date: Fri, 13 May 2016 13:03:25 +0300	[thread overview]
Message-ID: <1463133808-10630-12-git-send-email-rogerq@ti.com> (raw)
In-Reply-To: <1463133808-10630-1-git-send-email-rogerq@ti.com>

Now that we have a device reference in struct usb_otg
let's use dev_dbg() for debug messages.

Signed-off-by: Roger Quadros <rogerq@ti.com>
Acked-by: Peter Chen <peter.chen@nxp.com>
---
 drivers/usb/common/usb-otg-fsm.c | 19 +++++++------------
 1 file changed, 7 insertions(+), 12 deletions(-)

diff --git a/drivers/usb/common/usb-otg-fsm.c b/drivers/usb/common/usb-otg-fsm.c
index 2986b66..e6e58c2 100644
--- a/drivers/usb/common/usb-otg-fsm.c
+++ b/drivers/usb/common/usb-otg-fsm.c
@@ -30,13 +30,6 @@
 #include <linux/usb/otg.h>
 #include <linux/usb/otg-fsm.h>
 
-#ifdef VERBOSE
-#define VDBG(fmt, args...) pr_debug("[%s]  " fmt , \
-				 __func__, ## args)
-#else
-#define VDBG(stuff...)	do {} while (0)
-#endif
-
 /* Change USB protocol when there is a protocol change */
 static int otg_set_protocol(struct otg_fsm *fsm, int protocol)
 {
@@ -44,8 +37,9 @@ static int otg_set_protocol(struct otg_fsm *fsm, int protocol)
 	int ret = 0;
 
 	if (fsm->protocol != protocol) {
-		VDBG("Changing role fsm->protocol= %d; new protocol= %d\n",
-			fsm->protocol, protocol);
+		dev_vdbg(otg->dev,
+			 "Changing role fsm->protocol= %d; new protocol= %d\n",
+			 fsm->protocol, protocol);
 		/* stop old protocol */
 		if (fsm->protocol == PROTO_HOST)
 			ret = otg_start_host(otg, 0);
@@ -226,7 +220,7 @@ static int otg_set_state(struct otg_fsm *fsm, enum usb_otg_state new_state)
 
 	if (otg->state == new_state)
 		return 0;
-	VDBG("Set state: %s\n", usb_otg_state_string(new_state));
+	dev_vdbg(otg->dev, "Set state: %s\n", usb_otg_state_string(new_state));
 	otg_leave_state(fsm, otg->state);
 	switch (new_state) {
 	case OTG_STATE_B_IDLE:
@@ -358,7 +352,7 @@ int otg_statemachine(struct usb_otg *otg)
 
 	switch (state) {
 	case OTG_STATE_UNDEFINED:
-		VDBG("fsm->id = %d\n", fsm->id);
+		dev_vdbg(otg->dev, "fsm->id = %d\n", fsm->id);
 		if (fsm->id)
 			otg_set_state(fsm, OTG_STATE_B_IDLE);
 		else
@@ -466,7 +460,8 @@ int otg_statemachine(struct usb_otg *otg)
 	}
 	mutex_unlock(&fsm->lock);
 
-	VDBG("quit statemachine, changed = %d\n", fsm->state_changed);
+	dev_vdbg(otg->dev, "quit statemachine, changed = %d\n",
+		 fsm->state_changed);
 	return fsm->state_changed;
 }
 EXPORT_SYMBOL_GPL(otg_statemachine);
-- 
2.7.4

WARNING: multiple messages have this Message-ID (diff)
From: Roger Quadros <rogerq@ti.com>
To: peter.chen@freescale.com
Cc: balbi@kernel.org, tony@atomide.com, gregkh@linuxfoundation.org,
	dan.j.williams@intel.com, mathias.nyman@linux.intel.com,
	Joao.Pinto@synopsys.com, sergei.shtylyov@cogentembedded.com,
	jun.li@freescale.com, grygorii.strashko@ti.com,
	yoshihiro.shimoda.uh@renesas.com, robh@kernel.org,
	nsekhar@ti.com, b-liu@ti.com, linux-usb@vger.kernel.org,
	linux-omap@vger.kernel.org, linux-kernel@vger.kernel.org,
	devicetree@vger.kernel.org, Roger Quadros <rogerq@ti.com>
Subject: [PATCH v8 11/14] usb: otg: use dev_dbg() instead of VDBG()
Date: Fri, 13 May 2016 13:03:25 +0300	[thread overview]
Message-ID: <1463133808-10630-12-git-send-email-rogerq@ti.com> (raw)
In-Reply-To: <1463133808-10630-1-git-send-email-rogerq@ti.com>

Now that we have a device reference in struct usb_otg
let's use dev_dbg() for debug messages.

Signed-off-by: Roger Quadros <rogerq@ti.com>
Acked-by: Peter Chen <peter.chen@nxp.com>
---
 drivers/usb/common/usb-otg-fsm.c | 19 +++++++------------
 1 file changed, 7 insertions(+), 12 deletions(-)

diff --git a/drivers/usb/common/usb-otg-fsm.c b/drivers/usb/common/usb-otg-fsm.c
index 2986b66..e6e58c2 100644
--- a/drivers/usb/common/usb-otg-fsm.c
+++ b/drivers/usb/common/usb-otg-fsm.c
@@ -30,13 +30,6 @@
 #include <linux/usb/otg.h>
 #include <linux/usb/otg-fsm.h>
 
-#ifdef VERBOSE
-#define VDBG(fmt, args...) pr_debug("[%s]  " fmt , \
-				 __func__, ## args)
-#else
-#define VDBG(stuff...)	do {} while (0)
-#endif
-
 /* Change USB protocol when there is a protocol change */
 static int otg_set_protocol(struct otg_fsm *fsm, int protocol)
 {
@@ -44,8 +37,9 @@ static int otg_set_protocol(struct otg_fsm *fsm, int protocol)
 	int ret = 0;
 
 	if (fsm->protocol != protocol) {
-		VDBG("Changing role fsm->protocol= %d; new protocol= %d\n",
-			fsm->protocol, protocol);
+		dev_vdbg(otg->dev,
+			 "Changing role fsm->protocol= %d; new protocol= %d\n",
+			 fsm->protocol, protocol);
 		/* stop old protocol */
 		if (fsm->protocol == PROTO_HOST)
 			ret = otg_start_host(otg, 0);
@@ -226,7 +220,7 @@ static int otg_set_state(struct otg_fsm *fsm, enum usb_otg_state new_state)
 
 	if (otg->state == new_state)
 		return 0;
-	VDBG("Set state: %s\n", usb_otg_state_string(new_state));
+	dev_vdbg(otg->dev, "Set state: %s\n", usb_otg_state_string(new_state));
 	otg_leave_state(fsm, otg->state);
 	switch (new_state) {
 	case OTG_STATE_B_IDLE:
@@ -358,7 +352,7 @@ int otg_statemachine(struct usb_otg *otg)
 
 	switch (state) {
 	case OTG_STATE_UNDEFINED:
-		VDBG("fsm->id = %d\n", fsm->id);
+		dev_vdbg(otg->dev, "fsm->id = %d\n", fsm->id);
 		if (fsm->id)
 			otg_set_state(fsm, OTG_STATE_B_IDLE);
 		else
@@ -466,7 +460,8 @@ int otg_statemachine(struct usb_otg *otg)
 	}
 	mutex_unlock(&fsm->lock);
 
-	VDBG("quit statemachine, changed = %d\n", fsm->state_changed);
+	dev_vdbg(otg->dev, "quit statemachine, changed = %d\n",
+		 fsm->state_changed);
 	return fsm->state_changed;
 }
 EXPORT_SYMBOL_GPL(otg_statemachine);
-- 
2.7.4

  parent reply	other threads:[~2016-05-13 10:04 UTC|newest]

Thread overview: 121+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-05-13 10:03 [PATCH v8 00/14] USB OTG/dual-role framework Roger Quadros
2016-05-13 10:03 ` Roger Quadros
2016-05-13 10:03 ` [PATCH v8 01/14] usb: hcd: Initialize hcd->flags to 0 Roger Quadros
2016-05-13 10:03   ` Roger Quadros
2016-05-13 10:03 ` [PATCH v8 02/14] usb: otg-fsm: Prevent build warning "VDBG" redefined Roger Quadros
2016-05-13 10:03   ` Roger Quadros
2016-05-13 10:03 ` [PATCH v8 03/14] usb: hcd.h: Add OTG to HCD interface Roger Quadros
2016-05-13 10:03   ` Roger Quadros
2016-05-13 10:03 ` [PATCH v8 04/14] usb: otg-fsm: use usb_otg wherever possible Roger Quadros
2016-05-13 10:03   ` Roger Quadros
2016-05-13 10:03 ` [PATCH v8 05/14] usb: otg-fsm: move host controller operations into usb_otg->hcd_ops Roger Quadros
2016-05-13 10:03   ` Roger Quadros
2016-05-13 10:03 ` [PATCH v8 06/14] usb: gadget.h: Add OTG to gadget interface Roger Quadros
2016-05-13 10:03   ` Roger Quadros
2016-05-13 10:03 ` [PATCH v8 07/14] usb: otg: get rid of CONFIG_USB_OTG_FSM in favour of CONFIG_USB_OTG Roger Quadros
2016-05-13 10:03   ` Roger Quadros
2016-05-13 10:03 ` [PATCH v8 08/14] usb: otg: add OTG/dual-role core Roger Quadros
2016-05-13 10:03   ` Roger Quadros
2016-05-16  9:00   ` Roger Quadros
2016-05-16  9:00     ` Roger Quadros
2016-05-18  7:45     ` Peter Chen
2016-05-18 12:59       ` Roger Quadros
2016-05-18 12:59         ` Roger Quadros
2016-05-20  8:31         ` Roger Quadros
2016-05-20  8:31           ` Roger Quadros
2016-05-20  9:19           ` Roger Quadros
2016-05-20  9:19             ` Roger Quadros
2016-05-20  9:53             ` Peter Chen
2016-05-20  9:53               ` Peter Chen
2016-05-23 10:06               ` Roger Quadros
2016-05-23 10:06                 ` Roger Quadros
2016-05-24  9:45   ` Roger Quadros
2016-05-24  9:45     ` Roger Quadros
2016-05-25  2:44     ` Peter Chen
2016-05-25  3:19       ` Jun Li
2016-05-25  3:19         ` Jun Li
2016-05-25 12:26         ` Roger Quadros
2016-05-25 12:26           ` Roger Quadros
2016-05-25 12:21       ` Roger Quadros
2016-05-25 12:21         ` Roger Quadros
2016-05-25 14:44         ` Jun Li
2016-05-25 14:44           ` Jun Li
2016-05-27  8:03           ` Peter Chen
2016-05-27  8:12         ` Peter Chen
2016-05-13 10:03 ` [PATCH v8 09/14] usb: of: add an API to get OTG device from USB controller node Roger Quadros
2016-05-13 10:03   ` Roger Quadros
2016-05-20  9:29   ` [PATCH v9 " Roger Quadros
2016-05-20  9:29     ` Roger Quadros
2016-05-23 21:06     ` Rob Herring
2016-05-13 10:03 ` [PATCH v8 10/14] usb: otg: add hcd companion support Roger Quadros
2016-05-13 10:03   ` Roger Quadros
2016-05-13 18:13   ` Rob Herring
2016-05-13 18:13     ` Rob Herring
2016-05-16  8:12     ` Roger Quadros
2016-05-16  8:12       ` Roger Quadros
2016-05-20  9:32   ` [PATCH v9 " Roger Quadros
2016-05-20  9:32     ` Roger Quadros
2016-05-23 21:07     ` Rob Herring
2016-05-13 10:03 ` Roger Quadros [this message]
2016-05-13 10:03   ` [PATCH v8 11/14] usb: otg: use dev_dbg() instead of VDBG() Roger Quadros
2016-05-13 10:03 ` [PATCH v8 12/14] usb: hcd: Adapt to OTG core Roger Quadros
2016-05-13 10:03   ` Roger Quadros
2016-05-13 10:03 ` [PATCH v8 13/14] usb: gadget: udc: adapt " Roger Quadros
2016-05-13 10:03   ` Roger Quadros
2016-05-16  7:02   ` Peter Chen
2016-05-16  8:26     ` Roger Quadros
2016-05-16  8:26       ` Roger Quadros
2016-05-16  9:23       ` Peter Chen
2016-05-16  9:23         ` Peter Chen
2016-05-16  9:51         ` Roger Quadros
2016-05-16  9:51           ` Roger Quadros
2016-05-17  7:38           ` Jun Li
2016-05-17  7:38             ` Jun Li
2016-05-17  8:08             ` Roger Quadros
2016-05-17  8:08               ` Roger Quadros
2016-05-17  8:28               ` Jun Li
2016-05-17  8:28                 ` Jun Li
2016-05-18 12:42                 ` Roger Quadros
2016-05-18 12:42                   ` Roger Quadros
2016-05-18 13:12                   ` Jun Li
2016-05-18 13:12                     ` Jun Li
2016-05-18 13:43                     ` Roger Quadros
2016-05-18 13:43                       ` Roger Quadros
2016-05-18 14:46                       ` Jun Li
2016-05-18 14:46                         ` Jun Li
2016-05-19  7:32                         ` Roger Quadros
2016-05-19  7:32                           ` Roger Quadros
2016-05-21  2:29                           ` Peter Chen
2016-05-21  2:29                             ` Peter Chen
2016-05-23  3:21                             ` Peter Chen
2016-05-23  3:21                               ` Peter Chen
2016-05-23 10:11                               ` Roger Quadros
2016-05-23 10:11                                 ` Roger Quadros
2016-05-23 10:34                                 ` Jun Li
2016-05-23 10:34                                   ` Jun Li
2016-05-23 10:36                                   ` Roger Quadros
2016-05-23 10:36                                     ` Roger Quadros
2016-05-24  2:53                                     ` Peter Chen
2016-05-24  2:53                                       ` Peter Chen
2016-06-08  7:32                                       ` Roger Quadros
2016-06-08  7:32                                         ` Roger Quadros
2016-06-08  9:05                                         ` Peter Chen
2016-06-08  9:05                                           ` Peter Chen
2016-05-18  3:18           ` Peter Chen
2016-05-18 12:45             ` Roger Quadros
2016-05-18 12:45               ` Roger Quadros
2016-05-20  1:39               ` Peter Chen
2016-05-20  1:39                 ` Peter Chen
2016-05-20  7:26                 ` Roger Quadros
2016-05-20  7:26                   ` Roger Quadros
2016-05-21  2:44                   ` Peter Chen
2016-05-21  2:44                     ` Peter Chen
2016-06-01  7:38   ` Peter Chen
2016-06-02 11:07     ` Roger Quadros
2016-06-02 11:07       ` Roger Quadros
2016-05-13 10:03 ` [PATCH v8 14/14] usb: host: xhci-plat: Add otg device to platform data Roger Quadros
2016-05-13 10:03   ` Roger Quadros
2016-05-30  9:29 ` [PATCH v8 00/14] USB OTG/dual-role framework Peter Chen
2016-05-30  9:29   ` Peter Chen
2016-05-30 14:04   ` Roger Quadros
2016-05-30 14:04     ` Roger Quadros

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1463133808-10630-12-git-send-email-rogerq@ti.com \
    --to=rogerq@ti.com \
    --cc=Joao.Pinto@synopsys.com \
    --cc=b-liu@ti.com \
    --cc=balbi@kernel.org \
    --cc=dan.j.williams@intel.com \
    --cc=devicetree@vger.kernel.org \
    --cc=gregkh@linuxfoundation.org \
    --cc=grygorii.strashko@ti.com \
    --cc=jun.li@freescale.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-omap@vger.kernel.org \
    --cc=linux-usb@vger.kernel.org \
    --cc=mathias.nyman@linux.intel.com \
    --cc=nsekhar@ti.com \
    --cc=peter.chen@freescale.com \
    --cc=robh@kernel.org \
    --cc=sergei.shtylyov@cogentembedded.com \
    --cc=tony@atomide.com \
    --cc=yoshihiro.shimoda.uh@renesas.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.