Re: [PATCH 2/2] HID: multitouch: enable the Surface 3 Type Cover to report multitouch data

From: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
To: Benjamin Tissoires <benjamin.tissoires@redhat.com>
Cc: Jiri Kosina <jikos@kernel.org>,
	Bastien Nocera <hadess@hadess.net>,
	linux-input@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 2/2] HID: multitouch: enable the Surface 3 Type Cover to report multitouch data
Date: Fri, 13 May 2016 19:28:28 +0300	[thread overview]
Message-ID: <1463156908.17131.353.camel@linux.intel.com> (raw)
In-Reply-To: <1463155787.17131.351.camel@linux.intel.com>

On Fri, 2016-05-13 at 19:09 +0300, Andy Shevchenko wrote:
> On Fri, 2016-05-13 at 16:49 +0200, Benjamin Tissoires wrote:
> > 
> > On May 13 2016 or thereabouts, Andy Shevchenko wrote:
> > > 
> > > 
> > > On Thu, 2016-05-12 at 16:12 +0200, Benjamin Tissoires wrote:
> > > > 
> > > > 
> > > > There is no reasons to filter out keyboard and consumer control
> > > > collections
> > > > in hid-multitouch.
> > > > With the previous hid-input fix, there is now a full support of
> > > > the
> > > > Type
> > > > Cover and we can remove all specific bits from hid-core and hid-
> > > > microsoft.
> > > > 
> > > > hid-multitouch will automatically set HID_QUIRK_NO_INIT_REPORTS
> > > > so
> > > > we
> > > > can
> > > > also remove it from the list of ushbid quirks.
> > > > 
> > > > Signed-off-by: Benjamin Tissoires <benjamin.tissoires@redhat.com
> > > > >
> > > > ---
> > > > 
> > > > Andy, would you mind checking if this series is sufficient to
> > > > enable
> > > > the
> > > > TypeCover of the Surface Book?
> > > Tested-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
> > > 
> > > Noticed little difference that there is no event for the device
> > > anymore,
> > > just /dev/usb/hiddev0. Would it work properly under X?
> > Not sure what you mean.
> > I get 3 input nodes:
> > Microsoft Surface Type Cover Keyboard
> > Microsoft Surface Type Cover Consumer Control
> > Microsoft Surface Type Cover Touchpad
> > 
> > Each on this input device is properly assigned an event node and X
> > works
> > with them.
> > 
> > If there is no /dev/input/eventX created for your cover, then this
> > is
> > not normal and needs to be investigated.
> There is no /dev/input/eventX for the touchpad. 
> It prints that input device is under /usb.../input8, but the actual
> node
> I got events from is /dev/usb/hiddev0.

Correction, it seems the event node is there (event6), but I got nothing
from it

total 0
lrwxrwxrwx    1 root     root             0 May 13 19:17 event0 ->
../../devices/LNXSYSTM:00/LNXSYBUS:00/PNP0C0E:00/input/input0/event0
lrwxrwxrwx    1 root     root             0 May 13 19:17 event1 ->
../../devices/LNXSYSTM:00/LNXSYBUS:00/PNP0C0D:00/input/input1/event1
lrwxrwxrwx    1 root     root             0 May 13 19:17 event2 ->
../../devices/LNXSYSTM:00/LNXPWRBN:00/input/input2/event2
lrwxrwxrwx    1 root     root             0 May 13 19:17 event3 ->
../../devices/LNXSYSTM:00/LNXSYBUS:00/PNP0A08:00/device:18/PNP0C09:00/MS
HW0040:00/input/input3/event3
lrwxrwxrwx    1 root     root             0 May 13 19:19 event4 ->
../../devices/pci0000:00/0000:00:14.0/usb1/1-1/1-1.4/1-
1.4:1.0/0003:045E:07CD.0001/input/input4/event4
lrwxrwxrwx    1 root     root             0 May 13 19:19 event5 ->
../../devices/pci0000:00/0000:00:14.0/usb1/1-1/1-1.4/1-
1.4:1.0/0003:045E:07CD.0001/input/input6/event5
lrwxrwxrwx    1 root     root             0 May 13 19:19 event6 ->
../../devices/pci0000:00/0000:00:14.0/usb1/1-1/1-1.4/1-
1.4:1.0/0003:045E:07CD.0001/input/input8/event6
lrwxrwxrwx    1 root     root             0 May 13 19:17 input0 ->
../../devices/LNXSYSTM:00/LNXSYBUS:00/PNP0C0E:00/input/input0
lrwxrwxrwx    1 root     root             0 May 13 19:17 input1 ->
../../devices/LNXSYSTM:00/LNXSYBUS:00/PNP0C0D:00/input/input1
lrwxrwxrwx    1 root     root             0 May 13 19:17 input2 ->
../../devices/LNXSYSTM:00/LNXPWRBN:00/input/input2
lrwxrwxrwx    1 root     root             0 May 13 19:17 input3 ->
../../devices/LNXSYSTM:00/LNXSYBUS:00/PNP0A08:00/device:18/PNP0C09:00/MS
HW0040:00/input/input3
lrwxrwxrwx    1 root     root             0 May 13 19:19 input4 ->
../../devices/pci0000:00/0000:00:14.0/usb1/1-1/1-1.4/1-
1.4:1.0/0003:045E:07CD.0001/input/input4
lrwxrwxrwx    1 root     root             0 May 13 19:19 input6 ->
../../devices/pci0000:00/0000:00:14.0/usb1/1-1/1-1.4/1-
1.4:1.0/0003:045E:07CD.0001/input/input6
lrwxrwxrwx    1 root     root             0 May 13 19:19 input8 ->
../../devices/pci0000:00/0000:00:14.0/usb1/1-1/1-1.4/1-
1.4:1.0/0003:045E:07CD.0001/input/input8
lrwxrwxrwx    1 root     root             0 May 13 19:17 mice ->
../../devices/virtual/input/mice
lrwxrwxrwx    1 root     root             0 May 13 19:19 mouse0 ->
../../devices/pci0000:00/0000:00:14.0/usb1/1-1/1-1.4/1-
1.4:1.0/0003:045E:07CD.0001/input/input8/mouse0

I tried today's linux-next + your patches.

-- 
Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Intel Finland Oy