Patch "decnet: Do not build routes to devices without decnet private data." has been added to the 4.4-stable tree

Patch "decnet: Do not build routes to devices without decnet private data." has been added to the 4.4-stable tree

[gregkh]

This is a note to let you know that I've just added the patch titled

    decnet: Do not build routes to devices without decnet private data.

to the 4.4-stable tree which can be found at:
    http://www.kernel.org/git/?p=linux/kernel/git/stable/stable-queue.git;a=summary

The filename of the patch is:
     decnet-do-not-build-routes-to-devices-without-decnet-private-data.patch
and it can be found in the queue-4.4 subdirectory.

If you, or anyone else, feels it should not be added to the stable tree,
please let <stable@vger.kernel.org> know about it.


>From foo@baz Mon May 16 11:21:32 PDT 2016
From: "David S. Miller" <davem@davemloft.net>
Date: Sun, 10 Apr 2016 23:01:30 -0400
Subject: decnet: Do not build routes to devices without decnet private data.

From: "David S. Miller" <davem@davemloft.net>

[ Upstream commit a36a0d4008488fa545c74445d69eaf56377d5d4e ]

In particular, make sure we check for decnet private presence
for loopback devices.

Signed-off-by: David S. Miller <davem@davemloft.net>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
---
 net/decnet/dn_route.c |    9 ++++++++-
 1 file changed, 8 insertions(+), 1 deletion(-)

--- a/net/decnet/dn_route.c
+++ b/net/decnet/dn_route.c
@@ -1034,10 +1034,13 @@ source_ok:
 	if (!fld.daddr) {
 		fld.daddr = fld.saddr;
 
-		err = -EADDRNOTAVAIL;
 		if (dev_out)
 			dev_put(dev_out);
+		err = -EINVAL;
 		dev_out = init_net.loopback_dev;
+		if (!dev_out->dn_ptr)
+			goto out;
+		err = -EADDRNOTAVAIL;
 		dev_hold(dev_out);
 		if (!fld.daddr) {
 			fld.daddr =
@@ -1110,6 +1113,8 @@ source_ok:
 		if (dev_out == NULL)
 			goto out;
 		dn_db = rcu_dereference_raw(dev_out->dn_ptr);
+		if (!dn_db)
+			goto e_inval;
 		/* Possible improvement - check all devices for local addr */
 		if (dn_dev_islocal(dev_out, fld.daddr)) {
 			dev_put(dev_out);
@@ -1151,6 +1156,8 @@ select_source:
 			dev_put(dev_out);
 		dev_out = init_net.loopback_dev;
 		dev_hold(dev_out);
+		if (!dev_out->dn_ptr)
+			goto e_inval;
 		fld.flowidn_oif = dev_out->ifindex;
 		if (res.fi)
 			dn_fib_info_put(res.fi);


Patches currently in stable-queue which might be from davem@davemloft.net are

queue-4.4/net-mlx5e-device-s-mtu-field-is-u16-and-not-int.patch
queue-4.4/uapi-glibc-compat-fix-compile-errors-when-glibc-net-if.h-included-before-linux-if.h-mime-version-1.0.patch
queue-4.4/bridge-fix-igmp-mld-query-parsing.patch
queue-4.4/bpf-fix-double-fdput-in-replace_map_fd_with_map_ptr.patch
queue-4.4/atl2-disable-unimplemented-scatter-gather-feature.patch
queue-4.4/samples-bpf-fix-trace_output-example.patch
queue-4.4/net-fec-only-clear-a-queue-s-work-bit-if-the-queue-was-emptied.patch
queue-4.4/ipv4-fib-don-t-warn-when-primary-address-is-missing-if-in_dev-is-dead.patch
queue-4.4/packet-fix-heap-info-leak-in-packet_diag_mclist-sock_diag-interface.patch
queue-4.4/tcp-refresh-skb-timestamp-at-retransmit-time.patch
queue-4.4/net-implement-net_dbg_ratelimited-for-config_dynamic_debug-case.patch
queue-4.4/vlan-pull-on-__vlan_insert_tag-error-path-and-fix-csum-correction.patch
queue-4.4/netem-segment-gso-packets-on-enqueue.patch
queue-4.4/net-mlx4_en-fix-endianness-bug-in-ipv6-csum-calculation.patch
queue-4.4/net-mlx4_en-fix-spurious-timestamping-callbacks.patch
queue-4.4/sch_htb-update-backlog-as-well.patch
queue-4.4/gre-do-not-pull-header-in-icmp-error-processing.patch
queue-4.4/sch_dsmark-update-backlog-as-well.patch
queue-4.4/bpf-fix-refcnt-overflow.patch
queue-4.4/net-mlx5e-fix-minimum-mtu.patch
queue-4.4/bpf-verifier-reject-invalid-ld_abs-bpf_dw-instruction.patch
queue-4.4/net_sched-update-hierarchical-backlog-too.patch
queue-4.4/net-route-enforce-hoplimit-max-value.patch
queue-4.4/net-bridge-fix-old-ioctl-unlocked-net-device-walk.patch
queue-4.4/cdc_mbim-apply-ndp-to-end-quirk-to-all-huawei-devices.patch
queue-4.4/decnet-do-not-build-routes-to-devices-without-decnet-private-data.patch
queue-4.4/net_sched-introduce-qdisc_replace-helper.patch
queue-4.4/net-fix-infoleak-in-llc.patch
queue-4.4/net-fix-a-kernel-infoleak-in-x25-module.patch
queue-4.4/net-use-skb_postpush_rcsum-instead-of-own-implementations.patch
queue-4.4/net-thunderx-avoid-exposing-kernel-stack.patch
queue-4.4/route-do-not-cache-fib-route-info-on-local-routes-with-oif.patch
queue-4.4/openvswitch-use-flow-protocol-when-recalculating-ipv6-checksums.patch
queue-4.4/net-fix-infoleak-in-rtnetlink.patch
queue-4.4/vsock-do-not-disconnect-socket-when-peer-has-shutdown-send-only.patch
queue-4.4/net-sched-do-not-requeue-a-null-skb.patch
queue-4.4/bpf-fix-check_map_func_compatibility-logic.patch
queue-4.4/soreuseport-fix-ordering-for-mixed-v4-v6-sockets.patch