* [PATCH pyphosphor] Fix bug injected during skeleton port
@ 2016-05-16 19:40 OpenBMC Patches
2016-05-16 19:40 ` OpenBMC Patches
0 siblings, 1 reply; 2+ messages in thread
From: OpenBMC Patches @ 2016-05-16 19:40 UTC (permalink / raw)
To: openbmc
This library method originally came from the skeleton project.
While running pep8 after porting it I injected a logic bug.
https://github.com/openbmc/pyphosphor/pull/2
Brad Bishop (1):
Fix bug injected during skeleton port
obmc/dbuslib/bindings.py | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
--
2.8.2
^ permalink raw reply [flat|nested] 2+ messages in thread
* [PATCH pyphosphor] Fix bug injected during skeleton port
2016-05-16 19:40 [PATCH pyphosphor] Fix bug injected during skeleton port OpenBMC Patches
@ 2016-05-16 19:40 ` OpenBMC Patches
0 siblings, 0 replies; 2+ messages in thread
From: OpenBMC Patches @ 2016-05-16 19:40 UTC (permalink / raw)
To: openbmc; +Cc: Brad Bishop
From: Brad Bishop <bradleyb@fuzziesquirrel.com>
This library method originally came from the skeleton project.
While running pep8 after porting it I injected a logic bug.
---
obmc/dbuslib/bindings.py | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/obmc/dbuslib/bindings.py b/obmc/dbuslib/bindings.py
index 51b9e59..c7da8b8 100644
--- a/obmc/dbuslib/bindings.py
+++ b/obmc/dbuslib/bindings.py
@@ -90,7 +90,7 @@ class DbusProperties(dbus.service.Object):
@dbus.service.method(
"org.openbmc.Object.Properties", in_signature='sa{sv}')
def SetMultiple(self, interface_name, prop_dict):
- if (interface_name in self.properties):
+ if (interface_name not in self.properties):
self.properties[interface_name] = {}
value_changed = False
--
2.8.2
^ permalink raw reply related [flat|nested] 2+ messages in thread
end of thread, other threads:[~2016-05-16 19:41 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2016-05-16 19:40 [PATCH pyphosphor] Fix bug injected during skeleton port OpenBMC Patches
2016-05-16 19:40 ` OpenBMC Patches
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.