[meta-raspberrypi][PATCH 0/8] Support for vc4 graphics driver

[meta-raspberrypi][PATCH 0/8] Support for vc4 graphics driver

[Herve Jourdain]

This patch series enables the support for the VC4 graphics driver from Eric Anholt.
There was a previous patch series by Javier Martinez Canillas, but it required use of a different kernel.
VC4 is now supported in the raspberrypi official kernel, at least for 4.4.9+, but probably also for 4.1.
This patch series proposes to support VC4 by only adding 'vc4graphics' to MACHINE_FEATURES, for raspberrypi. If this is set, it will trigger all the necessary configuration/changes to use the VC4 driver, including mesa/wayland/weston currently, and adding the overlay required.
In order for this series to work, some previous patches are needed (support for .dtbo, and fix of the mesa packaging when there is no DRI driver).
It was tested with wayland/weston, without the support for X11.

Herve Jourdain (8):
  Support fo vc4 graphics driver: change the default providers
  Support fo vc4 graphics driver: add vc4-kms-v3d to the overlays
  Support fo vc4 graphics driver: upgrade firmware to prevent userland
    to interfere with v4 graphics
  Support fo vc4 graphics driver: add kernel configuration options
    needed for VC4
  Support fo vc4 graphics driver: upgrade 4.4 kernel to 4.4.10
  Support fo vc4 graphics driver: modify the wayland configuration for
    vc4
  Support fo vc4 graphics driver: modify the weston configuration for
    vc4
  Support fo vc4 graphics driver: modify the configuration for mesa

 conf/machine/include/rpi-default-providers.inc |  8 ++++----
 recipes-bsp/bootfiles/rpi-config_git.bb        |  8 ++++++++
 recipes-bsp/common/firmware.inc                |  4 ++--
 recipes-graphics/mesa/mesa_%.bbappend          |  4 ++++
 recipes-graphics/wayland/weston_%.bbappend     |  7 +++----
 recipes-graphics/weston/weston_%.bbappend      | 13 +++++++------
 recipes-kernel/linux/linux-raspberrypi_4.4.bb  |  4 ++--
 recipes-kernel/linux/linux-rpi.inc             | 10 ++++++++++
 8 files changed, 40 insertions(+), 18 deletions(-)
 create mode 100644 recipes-graphics/mesa/mesa_%.bbappend

-- 
2.7.4

[meta-raspberrypi][PATCH 1/8] Support for vc4 graphics driver: change the default providers

[Herve Jourdain]

This patch series enables the support for the VC4 graphics driver from Eric Anholt.
Configure the default providers, depending on whether 'vc4graphics' is in MACHINE_FEATURES or not.

Signed-off-by: Herve Jourdain <herve.jourdain@neuf.fr>
---
 conf/machine/include/rpi-default-providers.inc | 8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)

diff --git a/conf/machine/include/rpi-default-providers.inc b/conf/machine/include/rpi-default-providers.inc
index cabbd43..0bc8838 100644
--- a/conf/machine/include/rpi-default-providers.inc
+++ b/conf/machine/include/rpi-default-providers.inc
@@ -3,8 +3,8 @@
 PREFERRED_PROVIDER_virtual/kernel ?= "linux-raspberrypi"
 PREFERRED_PROVIDER_u-boot ?= "u-boot-rpi"
 PREFERRED_PROVIDER_virtual/xserver ?= "xserver-xorg"
-PREFERRED_PROVIDER_virtual/egl ?= "userland"
-PREFERRED_PROVIDER_virtual/libgles2 ?= "userland"
-PREFERRED_PROVIDER_virtual/libgl ?= "mesa-gl"
-PREFERRED_PROVIDER_virtual/mesa ?= "mesa-gl"
+PREFERRED_PROVIDER_virtual/egl ?= "${@bb.utils.contains("MACHINE_FEATURES", "vc4graphics", "mesa", "userland", d)}"
+PREFERRED_PROVIDER_virtual/libgles2 ?= "${@bb.utils.contains("MACHINE_FEATURES", "vc4graphics", "mesa", "userland", d)}"
+PREFERRED_PROVIDER_virtual/libgl ?= "${@bb.utils.contains("MACHINE_FEATURES", "vc4graphics", "mesa", "mesa-gl", d)}"
+PREFERRED_PROVIDER_virtual/mesa ?= "${@bb.utils.contains("MACHINE_FEATURES", "vc4graphics", "mesa", "mesa-gl", d)}"
 PREFERRED_PROVIDER_jpeg ?= "jpeg"
-- 
2.7.4

[meta-raspberrypi][PATCH 2/8] Support for vc4 graphics driver: add vc4-kms-v3d to the overlays

[Herve Jourdain]

This patch series enables the support for the VC4 graphics driver from Eric Anholt.
Add vc4-kms-v3d overlay if 'vc4graphics' is in MACHINE_FEATURES.
(This patch has a dependency on the patch that enables the support of .dtbo overlay files)

Signed-off-by: Herve Jourdain <herve.jourdain@neuf.fr>
---
 recipes-bsp/bootfiles/rpi-config_git.bb | 8 ++++++++
 1 file changed, 8 insertions(+)

diff --git a/recipes-bsp/bootfiles/rpi-config_git.bb b/recipes-bsp/bootfiles/rpi-config_git.bb
index 4bc8eb7..79e436d 100644
--- a/recipes-bsp/bootfiles/rpi-config_git.bb
+++ b/recipes-bsp/bootfiles/rpi-config_git.bb
@@ -19,6 +19,8 @@ PITFT="${@bb.utils.contains("MACHINE_FEATURES", "pitft", "1", "0", d)}"
 PITFT22="${@bb.utils.contains("MACHINE_FEATURES", "pitft22", "1", "0", d)}"
 PITFT28r="${@bb.utils.contains("MACHINE_FEATURES", "pitft28r", "1", "0", d)}"
 
+VC4GRAPHICS="${@bb.utils.contains("MACHINE_FEATURES", "vc4graphics", "1", "0", d)}"
+
 inherit deploy
 
 do_deploy() {
@@ -102,6 +104,12 @@ do_deploy() {
         echo "# Enable UART" >>${DEPLOYDIR}/bcm2835-bootfiles/config.txt
         echo "enable_uart=1" >>${DEPLOYDIR}/bcm2835-bootfiles/config.txt
     fi
+
+    # VC4 Graphics support
+    if [ "${VC4GRAPHICS}" = "1" ]; then
+        echo "# Enable VC4 Graphics" >>${DEPLOYDIR}/bcm2835-bootfiles/config.txt
+        echo "dtoverlay=vc4-kms-v3d,cma-256" >>${DEPLOYDIR}/bcm2835-bootfiles/config.txt
+    fi
 }
 
 addtask deploy before do_package after do_install
-- 
2.7.4

[meta-raspberrypi][PATCH 3/8] Support for vc4 graphics driver: upgrade firmware to prevent userland to interfere with v4 graphics

[Herve Jourdain]

This patch series enables the support for the VC4 graphics driver from Eric Anholt.
That specific firmware version solves a competition problem between dispmanx and VC4, when VC4 is enabled.
https://github.com/raspberrypi/firmware/issues/595
(I've also tested BEFORE getting the new firmware, and I can confirm it's unusable)

Signed-off-by: Herve Jourdain <herve.jourdain@neuf.fr>
---
 recipes-bsp/common/firmware.inc | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/recipes-bsp/common/firmware.inc b/recipes-bsp/common/firmware.inc
index 8f095b9..b467fc6 100644
--- a/recipes-bsp/common/firmware.inc
+++ b/recipes-bsp/common/firmware.inc
@@ -1,5 +1,5 @@
-RPIFW_SRCREV ?= "c5e131971c323f5658c7c5d4b1dd105d37903a99"
-RPIFW_DATE ?= "20160421"
+RPIFW_SRCREV ?= "c17fa41b8e8321d891230f97837fee98feebc1ac"
+RPIFW_DATE ?= "20160513"
 RPIFW_SRC_URI ?= "git://github.com/raspberrypi/firmware.git;protocol=git;branch=master"
 RPIFW_S ?= "${WORKDIR}/git"
 
-- 
2.7.4

[meta-raspberrypi][PATCH 4/8] Support for vc4 graphics driver: add kernel configuration options needed for VC4

[Herve Jourdain]

This patch series enables the support for the VC4 graphics driver from Eric Anholt.
Set the kernel configuration options that are required to enable the VC4 driver.

Signed-off-by: Herve Jourdain <herve.jourdain@neuf.fr>
---
 recipes-kernel/linux/linux-rpi.inc | 10 ++++++++++
 1 file changed, 10 insertions(+)

diff --git a/recipes-kernel/linux/linux-rpi.inc b/recipes-kernel/linux/linux-rpi.inc
index fae78b7..9b91bd5 100644
--- a/recipes-kernel/linux/linux-rpi.inc
+++ b/recipes-kernel/linux/linux-rpi.inc
@@ -107,6 +107,16 @@ do_configure_prepend() {
     # Activate CONFIG_LEGACY_PTYS
     kernel_configure_variable LEGACY_PTYS y
 
+    # Activate the configuration options for VC4
+    VC4GRAPHICS="${@bb.utils.contains("MACHINE_FEATURES", "vc4graphics", "1", "0", d)}"
+    if [ ${VC4GRAPHICS} = "1" ]; then
+        kernel_configure_variable I2C_BCM2835 y
+        kernel_configure_variable DRM y
+        kernel_configure_variable DRM_FBDEV_EMULATION n
+        kernel_configure_variable DRM_VC4 y
+        kernel_configure_variable FB_BCM2708 n
+    fi
+
     # Keep this the last line
     # Remove all modified configs and add the rest to .config
     sed -e "${CONF_SED_SCRIPT}" < '${WORKDIR}/defconfig' >> '${B}/.config'
-- 
2.7.4

[meta-raspberrypi][PATCH 5/8] Support for vc4 graphics driver: upgrade 4.4 kernel to 4.4.10

[Herve Jourdain]

This patch series enables the support for the VC4 graphics driver from Eric Anholt.
Kernel upgrade to 4.4.10 (some 4.4.9 version would be enough, but the required firmware supports 4.4.10, so bump it anyway)

Signed-off-by: Herve Jourdain <herve.jourdain@neuf.fr>
---
 recipes-kernel/linux/linux-raspberrypi_4.4.bb | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/recipes-kernel/linux/linux-raspberrypi_4.4.bb b/recipes-kernel/linux/linux-raspberrypi_4.4.bb
index 831ac5a..0bc6531 100644
--- a/recipes-kernel/linux/linux-raspberrypi_4.4.bb
+++ b/recipes-kernel/linux/linux-raspberrypi_4.4.bb
@@ -1,8 +1,8 @@
 FILESEXTRAPATHS_prepend := "${THISDIR}/${PN}-${PV}:"
 
-LINUX_VERSION ?= "4.4.8"
+LINUX_VERSION ?= "4.4.10"
 
-SRCREV = "fe7ad6aa5c6940817fe971d80a7b2a1d6052190a"
+SRCREV = "4c2795dd50f98fa162cb53190eb557be44f92f58"
 SRC_URI = "git://github.com/raspberrypi/linux.git;protocol=git;branch=rpi-4.4.y \
            file://0001-fix-dtbo-rules.patch \
 "
-- 
2.7.4

[meta-raspberrypi][PATCH 6/8] Support for vc4 graphics driver: modify the wayland configuration for vc4

[Herve Jourdain]

This patch series enables the support for the VC4 graphics driver from Eric Anholt.
Configure the configuration options for Wayland, depending on whether 'vc4graphics' is in MACHINE_FEATURES or not.

Signed-off-by: Herve Jourdain <herve.jourdain@neuf.fr>
---
 recipes-graphics/wayland/weston_%.bbappend | 7 +++----
 1 file changed, 3 insertions(+), 4 deletions(-)

diff --git a/recipes-graphics/wayland/weston_%.bbappend b/recipes-graphics/wayland/weston_%.bbappend
index c3a7421..76bab9f 100644
--- a/recipes-graphics/wayland/weston_%.bbappend
+++ b/recipes-graphics/wayland/weston_%.bbappend
@@ -1,4 +1,3 @@
-EXTRA_OECONF_append_rpi = "\
-        --enable-rpi-compositor \
-        WESTON_NATIVE_BACKEND=rpi-backend.so \
-       "
+EXTRA_OECONF_append_rpi = "${@bb.utils.contains('MACHINE_FEATURES', 'vc4graphics', '', ' --enable-rpi-compositor', d)}"
+EXTRA_OECONF_append_rpi = "${@bb.utils.contains('MACHINE_FEATURES', 'vc4graphics', '', ' WESTON_NATIVE_BACKEND=rpi-backend.so', d)}"
+
-- 
2.7.4

[meta-raspberrypi][PATCH 7/8] Support for vc4 graphics driver: modify the weston configuration for vc4

[Herve Jourdain]

This patch series enables the support for the VC4 graphics driver from Eric Anholt.
Configure the configuration options for Weston, depending on whether 'vc4graphics' is in MACHINE_FEATURES or not.

Signed-off-by: Herve Jourdain <herve.jourdain@neuf.fr>
---
 recipes-graphics/weston/weston_%.bbappend | 13 +++++++------
 1 file changed, 7 insertions(+), 6 deletions(-)

diff --git a/recipes-graphics/weston/weston_%.bbappend b/recipes-graphics/weston/weston_%.bbappend
index 3ec311d..70f4360 100644
--- a/recipes-graphics/weston/weston_%.bbappend
+++ b/recipes-graphics/weston/weston_%.bbappend
@@ -1,7 +1,8 @@
-EXTRA_OECONF += "--enable-rpi-compositor \
-             --disable-resize-optimization \
-             --disable-setuid-install \
-             --disable-xwayland-test \
-             --disable-simple-egl-clients \
-             WESTON_NATIVE_BACKEND=rpi-backend.so \
+PACKAGECONFIG_rpi_remove = "${@bb.utils.contains('MACHINE_FEATURES', 'vc4graphics', ' fbdev', '', d)}"
+EXTRA_OECONF += "--disable-xwayland-test \
+                 --disable-simple-egl-clients \
 "
+EXTRA_OECONF += "${@bb.utils.contains('MACHINE_FEATURES', 'vc4graphics', '', '--enable-rpi-compositor', d)}"
+EXTRA_OECONF += "${@bb.utils.contains('MACHINE_FEATURES', 'vc4graphics', '', '--disable-resize-optimization', d)}"
+EXTRA_OECONF += "${@bb.utils.contains('MACHINE_FEATURES', 'vc4graphics', '', '--disable-setuid-install', d)}"
+EXTRA_OECONF += "${@bb.utils.contains('MACHINE_FEATURES', 'vc4graphics', '', 'WESTON_NATIVE_BACKEND=rpi-backend.so', d)}"
-- 
2.7.4

[meta-raspberrypi][PATCH 8/8] Support for vc4 graphics driver: modify the configuration for mesa

[Herve Jourdain]

This patch series enables the support for the VC4 graphics driver from Eric Anholt.
Add some configuration for building mesa, on raspberrypi, when VC4 is in use.

Signed-off-by: Herve Jourdain <herve.jourdain@neuf.fr>
---
 recipes-graphics/mesa/mesa_%.bbappend | 4 ++++
 1 file changed, 4 insertions(+)
 create mode 100644 recipes-graphics/mesa/mesa_%.bbappend

diff --git a/recipes-graphics/mesa/mesa_%.bbappend b/recipes-graphics/mesa/mesa_%.bbappend
new file mode 100644
index 0000000..b182388
--- /dev/null
+++ b/recipes-graphics/mesa/mesa_%.bbappend
@@ -0,0 +1,4 @@
+PACKAGECONFIG_append_rpi = " gallium"
+GALLIUMDRIVERS_rpi = "vc4"
+DRIDRIVERS_rpi = ""
+
-- 
2.7.4

Re: [meta-raspberrypi][PATCH 5/8] Support for vc4 graphics driver: upgrade 4.4 kernel to 4.4.10

[Herve Jourdain]

Hi,

There has been a revision mismatch for the kernel version, in this patch.
It should be c317a023583b17a4350f066924d5fff47a81f91e, instead of
4c2795dd50f98fa162cb53190eb557be44f92f58.
Shall I resend the whole patch series as v2, or is it acceptable to only
send again the faulty patch as v2?

Herve

-----Original Message-----
From: Herve Jourdain [mailto:herve.jourdain@neuf.fr] 
Sent: mercredi 18 mai 2016 14:21
To: yocto@yoctoproject.org
Cc: Herve Jourdain <herve.jourdain@neuf.fr>
Subject: [yocto][meta-raspberrypi][PATCH 5/8] Support for vc4 graphics
driver: upgrade 4.4 kernel to 4.4.10

This patch series enables the support for the VC4 graphics driver from Eric
Anholt.
Kernel upgrade to 4.4.10 (some 4.4.9 version would be enough, but the
required firmware supports 4.4.10, so bump it anyway)

Signed-off-by: Herve Jourdain <herve.jourdain@neuf.fr>
---
 recipes-kernel/linux/linux-raspberrypi_4.4.bb | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/recipes-kernel/linux/linux-raspberrypi_4.4.bb
b/recipes-kernel/linux/linux-raspberrypi_4.4.bb
index 831ac5a..0bc6531 100644
--- a/recipes-kernel/linux/linux-raspberrypi_4.4.bb
+++ b/recipes-kernel/linux/linux-raspberrypi_4.4.bb
@@ -1,8 +1,8 @@
 FILESEXTRAPATHS_prepend := "${THISDIR}/${PN}-${PV}:"
 
-LINUX_VERSION ?= "4.4.8"
+LINUX_VERSION ?= "4.4.10"
 
-SRCREV = "fe7ad6aa5c6940817fe971d80a7b2a1d6052190a"
+SRCREV = "4c2795dd50f98fa162cb53190eb557be44f92f58"
 SRC_URI =
"git://github.com/raspberrypi/linux.git;protocol=git;branch=rpi-4.4.y \
            file://0001-fix-dtbo-rules.patch \  "
--
2.7.4

Re: [meta-raspberrypi][PATCH 5/8] Support for vc4 graphics driver: upgrade 4.4 kernel to 4.4.10

[Khem Raj]

[-- Attachment #1: Type: text/plain, Size: 1371 bytes --]


> On May 18, 2016, at 5:21 AM, Herve Jourdain <herve.jourdain@neuf.fr> wrote:
> 
> This patch series enables the support for the VC4 graphics driver from Eric Anholt.
> Kernel upgrade to 4.4.10 (some 4.4.9 version would be enough, but the required firmware supports 4.4.10, so bump it anyway)

I have sent a patch for similar update. Have you looked at that

> 
> Signed-off-by: Herve Jourdain <herve.jourdain@neuf.fr>
> ---
> recipes-kernel/linux/linux-raspberrypi_4.4.bb | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/recipes-kernel/linux/linux-raspberrypi_4.4.bb b/recipes-kernel/linux/linux-raspberrypi_4.4.bb
> index 831ac5a..0bc6531 100644
> --- a/recipes-kernel/linux/linux-raspberrypi_4.4.bb
> +++ b/recipes-kernel/linux/linux-raspberrypi_4.4.bb
> @@ -1,8 +1,8 @@
> FILESEXTRAPATHS_prepend := "${THISDIR}/${PN}-${PV}:"
> 
> -LINUX_VERSION ?= "4.4.8"
> +LINUX_VERSION ?= "4.4.10"
> 
> -SRCREV = "fe7ad6aa5c6940817fe971d80a7b2a1d6052190a"
> +SRCREV = "4c2795dd50f98fa162cb53190eb557be44f92f58"
> SRC_URI = "git://github.com/raspberrypi/linux.git;protocol=git;branch=rpi-4.4.y \
>            file://0001-fix-dtbo-rules.patch \
> "
> --
> 2.7.4
> 
> --
> _______________________________________________
> yocto mailing list
> yocto@yoctoproject.org
> https://lists.yoctoproject.org/listinfo/yocto


[-- Attachment #2: Message signed with OpenPGP using GPGMail --]
[-- Type: application/pgp-signature, Size: 211 bytes --]

Re: [meta-raspberrypi][PATCH 5/8] Support for vc4 graphics driver: upgrade 4.4 kernel to 4.4.10

[Herve Jourdain]

Hi Khem,

Yes, I've seen that you had sent a patch to upgrade to some revision of 4.4.9.
Here, I upgrade to 4.4.10, but VC4 should work with the 4.4.9 revision you sent before.
I mostly bumped to 4.4.10 because the firmware bumped to 4.4.10 - and the firmware bump is mandatory for VC4 to work effectively on RPI.

Herve

> Le 19 mai 2016 à 00:27, Khem Raj <raj.khem@gmail.com> a écrit :
> 
> 
>> On May 18, 2016, at 5:21 AM, Herve Jourdain <herve.jourdain@neuf.fr> wrote:
>> 
>> This patch series enables the support for the VC4 graphics driver from Eric Anholt.
>> Kernel upgrade to 4.4.10 (some 4.4.9 version would be enough, but the required firmware supports 4.4.10, so bump it anyway)
> 
> I have sent a patch for similar update. Have you looked at that
> 
>> 
>> Signed-off-by: Herve Jourdain <herve.jourdain@neuf.fr>
>> ---
>> recipes-kernel/linux/linux-raspberrypi_4.4.bb | 4 ++--
>> 1 file changed, 2 insertions(+), 2 deletions(-)
>> 
>> diff --git a/recipes-kernel/linux/linux-raspberrypi_4.4.bb b/recipes-kernel/linux/linux-raspberrypi_4.4.bb
>> index 831ac5a..0bc6531 100644
>> --- a/recipes-kernel/linux/linux-raspberrypi_4.4.bb
>> +++ b/recipes-kernel/linux/linux-raspberrypi_4.4.bb
>> @@ -1,8 +1,8 @@
>> FILESEXTRAPATHS_prepend := "${THISDIR}/${PN}-${PV}:"
>> 
>> -LINUX_VERSION ?= "4.4.8"
>> +LINUX_VERSION ?= "4.4.10"
>> 
>> -SRCREV = "fe7ad6aa5c6940817fe971d80a7b2a1d6052190a"
>> +SRCREV = "4c2795dd50f98fa162cb53190eb557be44f92f58"
>> SRC_URI = "git://github.com/raspberrypi/linux.git;protocol=git;branch=rpi-4.4.y \
>>           file://0001-fix-dtbo-rules.patch \
>> "
>> --
>> 2.7.4
>> 
>> --
>> _______________________________________________
>> yocto mailing list
>> yocto@yoctoproject.org
>> https://lists.yoctoproject.org/listinfo/yocto
> 

Re: [meta-raspberrypi][PATCH 2/8] Support for vc4 graphics driver: add vc4-kms-v3d to the overlays

[Khem Raj]

[-- Attachment #1: Type: text/plain, Size: 1865 bytes --]


> On May 18, 2016, at 5:21 AM, Herve Jourdain <herve.jourdain@neuf.fr> wrote:
> 
> This patch series enables the support for the VC4 graphics driver from Eric Anholt.
> Add vc4-kms-v3d overlay if 'vc4graphics' is in MACHINE_FEATURES.
> (This patch has a dependency on the patch that enables the support of .dtbo overlay files)
> 
> Signed-off-by: Herve Jourdain <herve.jourdain@neuf.fr>
> ---
> recipes-bsp/bootfiles/rpi-config_git.bb | 8 ++++++++
> 1 file changed, 8 insertions(+)
> 
> diff --git a/recipes-bsp/bootfiles/rpi-config_git.bb b/recipes-bsp/bootfiles/rpi-config_git.bb
> index 4bc8eb7..79e436d 100644
> --- a/recipes-bsp/bootfiles/rpi-config_git.bb
> +++ b/recipes-bsp/bootfiles/rpi-config_git.bb
> @@ -19,6 +19,8 @@ PITFT="${@bb.utils.contains("MACHINE_FEATURES", "pitft", "1", "0", d)}"
> PITFT22="${@bb.utils.contains("MACHINE_FEATURES", "pitft22", "1", "0", d)}"
> PITFT28r="${@bb.utils.contains("MACHINE_FEATURES", "pitft28r", "1", "0", d)}"
> 
> +VC4GRAPHICS="${@bb.utils.contains("MACHINE_FEATURES", "vc4graphics", "1", "0", d)}"
> +
> inherit deploy
> 
> do_deploy() {
> @@ -102,6 +104,12 @@ do_deploy() {
>         echo "# Enable UART" >>${DEPLOYDIR}/bcm2835-bootfiles/config.txt
>         echo "enable_uart=1" >>${DEPLOYDIR}/bcm2835-bootfiles/config.txt
>     fi
> +
> +    # VC4 Graphics support
> +    if [ "${VC4GRAPHICS}" = "1" ]; then
> +        echo "# Enable VC4 Graphics" >>${DEPLOYDIR}/bcm2835-bootfiles/config.txt
> +        echo "dtoverlay=vc4-kms-v3d,cma-256" >>${DEPLOYDIR}/bcm2835-bootfiles/config.txt
> +    fi


will this keep appending overtime ?

> }
> 
> addtask deploy before do_package after do_install
> --
> 2.7.4
> 
> --
> _______________________________________________
> yocto mailing list
> yocto@yoctoproject.org
> https://lists.yoctoproject.org/listinfo/yocto


[-- Attachment #2: Message signed with OpenPGP using GPGMail --]
[-- Type: application/pgp-signature, Size: 211 bytes --]

Re: [meta-raspberrypi][PATCH 0/8] Support for vc4 graphics driver

[Khem Raj]

[-- Attachment #1: Type: text/plain, Size: 2423 bytes --]


> On May 18, 2016, at 5:21 AM, Herve Jourdain <herve.jourdain@neuf.fr> wrote:
> 
> This patch series enables the support for the VC4 graphics driver from Eric Anholt.
> There was a previous patch series by Javier Martinez Canillas, but it required use of a different kernel.
> VC4 is now supported in the raspberrypi official kernel, at least for 4.4.9+, but probably also for 4.1.
> This patch series proposes to support VC4 by only adding 'vc4graphics' to MACHINE_FEATURES, for raspberrypi. If this is set, it will trigger all the necessary configuration/changes to use the VC4 driver, including mesa/wayland/weston currently, and adding the overlay required.
> In order for this series to work, some previous patches are needed (support for .dtbo, and fix of the mesa packaging when there is no DRI driver).
> It was tested with wayland/weston, without the support for X11.


most of them look ok to me except 1 where I have asked a question.

> 
> Herve Jourdain (8):
>  Support fo vc4 graphics driver: change the default providers
>  Support fo vc4 graphics driver: add vc4-kms-v3d to the overlays
>  Support fo vc4 graphics driver: upgrade firmware to prevent userland
>    to interfere with v4 graphics
>  Support fo vc4 graphics driver: add kernel configuration options
>    needed for VC4
>  Support fo vc4 graphics driver: upgrade 4.4 kernel to 4.4.10
>  Support fo vc4 graphics driver: modify the wayland configuration for
>    vc4
>  Support fo vc4 graphics driver: modify the weston configuration for
>    vc4
>  Support fo vc4 graphics driver: modify the configuration for mesa
> 
> conf/machine/include/rpi-default-providers.inc |  8 ++++----
> recipes-bsp/bootfiles/rpi-config_git.bb        |  8 ++++++++
> recipes-bsp/common/firmware.inc                |  4 ++--
> recipes-graphics/mesa/mesa_%.bbappend          |  4 ++++
> recipes-graphics/wayland/weston_%.bbappend     |  7 +++----
> recipes-graphics/weston/weston_%.bbappend      | 13 +++++++------
> recipes-kernel/linux/linux-raspberrypi_4.4.bb  |  4 ++--
> recipes-kernel/linux/linux-rpi.inc             | 10 ++++++++++
> 8 files changed, 40 insertions(+), 18 deletions(-)
> create mode 100644 recipes-graphics/mesa/mesa_%.bbappend
> 
> --
> 2.7.4
> 
> --
> _______________________________________________
> yocto mailing list
> yocto@yoctoproject.org
> https://lists.yoctoproject.org/listinfo/yocto


[-- Attachment #2: Message signed with OpenPGP using GPGMail --]
[-- Type: application/pgp-signature, Size: 211 bytes --]

Re: [meta-raspberrypi][PATCH 5/8] Support for vc4 graphics driver: upgrade 4.4 kernel to 4.4.10

[Khem Raj]

On Wed, May 18, 2016 at 9:43 AM, Herve Jourdain <herve.jourdain@neuf.fr> wrote:
> Hi Khem,
>
> Yes, I've seen that you had sent a patch to upgrade to some revision of 4.4.9.
> Here, I upgrade to 4.4.10, but VC4 should work with the 4.4.9 revision you sent before.
> I mostly bumped to 4.4.10 because the firmware bumped to 4.4.10 - and the firmware bump is mandatory for VC4 to work effectively on RPI.

should be ok.

>
> Herve
>
>> Le 19 mai 2016 à 00:27, Khem Raj <raj.khem@gmail.com> a écrit :
>>
>>
>>> On May 18, 2016, at 5:21 AM, Herve Jourdain <herve.jourdain@neuf.fr> wrote:
>>>
>>> This patch series enables the support for the VC4 graphics driver from Eric Anholt.
>>> Kernel upgrade to 4.4.10 (some 4.4.9 version would be enough, but the required firmware supports 4.4.10, so bump it anyway)
>>
>> I have sent a patch for similar update. Have you looked at that
>>
>>>
>>> Signed-off-by: Herve Jourdain <herve.jourdain@neuf.fr>
>>> ---
>>> recipes-kernel/linux/linux-raspberrypi_4.4.bb | 4 ++--
>>> 1 file changed, 2 insertions(+), 2 deletions(-)
>>>
>>> diff --git a/recipes-kernel/linux/linux-raspberrypi_4.4.bb b/recipes-kernel/linux/linux-raspberrypi_4.4.bb
>>> index 831ac5a..0bc6531 100644
>>> --- a/recipes-kernel/linux/linux-raspberrypi_4.4.bb
>>> +++ b/recipes-kernel/linux/linux-raspberrypi_4.4.bb
>>> @@ -1,8 +1,8 @@
>>> FILESEXTRAPATHS_prepend := "${THISDIR}/${PN}-${PV}:"
>>>
>>> -LINUX_VERSION ?= "4.4.8"
>>> +LINUX_VERSION ?= "4.4.10"
>>>
>>> -SRCREV = "fe7ad6aa5c6940817fe971d80a7b2a1d6052190a"
>>> +SRCREV = "4c2795dd50f98fa162cb53190eb557be44f92f58"
>>> SRC_URI = "git://github.com/raspberrypi/linux.git;protocol=git;branch=rpi-4.4.y \
>>>           file://0001-fix-dtbo-rules.patch \
>>> "
>>> --
>>> 2.7.4
>>>
>>> --
>>> _______________________________________________
>>> yocto mailing list
>>> yocto@yoctoproject.org
>>> https://lists.yoctoproject.org/listinfo/yocto
>>

Re: [meta-raspberrypi][PATCH 2/8] Support for vc4 graphics driver: add vc4-kms-v3d to the overlays

[Herve Jourdain]

Hi Khem,

Well, it seems to be the way it will be activated in the future as well, through a device tree overlay.
The rationale being that people may not want/need the VC4 driver, because they prefer to use userland or other reasons, and that only the persons who want to activate it will load the overlay.
One thing to remember is that vc4 has the potential to conflict with other pieces, and it might not be for everybody (the firmware patch helps in that regards, but before it, weston/drm was conflicting with the splash screen for instance on my test setup, creating very disturbing images).

If your question is, will userland disappear one day and vc4 graphics becoming the only graphics driver, the overlay could be included in the base device tree itself, in like a few years from now, then I clearly don't have an answer to that...

But I believe the overlay will stick some time around.

Herve

> Le 19 mai 2016 à 00:53, Khem Raj <raj.khem@gmail.com> a écrit :
> 
> 
>> On May 18, 2016, at 5:21 AM, Herve Jourdain <herve.jourdain@neuf.fr> wrote:
>> 
>> This patch series enables the support for the VC4 graphics driver from Eric Anholt.
>> Add vc4-kms-v3d overlay if 'vc4graphics' is in MACHINE_FEATURES.
>> (This patch has a dependency on the patch that enables the support of .dtbo overlay files)
>> 
>> Signed-off-by: Herve Jourdain <herve.jourdain@neuf.fr>
>> ---
>> recipes-bsp/bootfiles/rpi-config_git.bb | 8 ++++++++
>> 1 file changed, 8 insertions(+)
>> 
>> diff --git a/recipes-bsp/bootfiles/rpi-config_git.bb b/recipes-bsp/bootfiles/rpi-config_git.bb
>> index 4bc8eb7..79e436d 100644
>> --- a/recipes-bsp/bootfiles/rpi-config_git.bb
>> +++ b/recipes-bsp/bootfiles/rpi-config_git.bb
>> @@ -19,6 +19,8 @@ PITFT="${@bb.utils.contains("MACHINE_FEATURES", "pitft", "1", "0", d)}"
>> PITFT22="${@bb.utils.contains("MACHINE_FEATURES", "pitft22", "1", "0", d)}"
>> PITFT28r="${@bb.utils.contains("MACHINE_FEATURES", "pitft28r", "1", "0", d)}"
>> 
>> +VC4GRAPHICS="${@bb.utils.contains("MACHINE_FEATURES", "vc4graphics", "1", "0", d)}"
>> +
>> inherit deploy
>> 
>> do_deploy() {
>> @@ -102,6 +104,12 @@ do_deploy() {
>>        echo "# Enable UART" >>${DEPLOYDIR}/bcm2835-bootfiles/config.txt
>>        echo "enable_uart=1" >>${DEPLOYDIR}/bcm2835-bootfiles/config.txt
>>    fi
>> +
>> +    # VC4 Graphics support
>> +    if [ "${VC4GRAPHICS}" = "1" ]; then
>> +        echo "# Enable VC4 Graphics" >>${DEPLOYDIR}/bcm2835-bootfiles/config.txt
>> +        echo "dtoverlay=vc4-kms-v3d,cma-256" >>${DEPLOYDIR}/bcm2835-bootfiles/config.txt
>> +    fi
> 
> 
> will this keep appending overtime ?
> 
>> }
>> 
>> addtask deploy before do_package after do_install
>> --
>> 2.7.4
>> 
>> --
>> _______________________________________________
>> yocto mailing list
>> yocto@yoctoproject.org
>> https://lists.yoctoproject.org/listinfo/yocto
> 

Re: [meta-raspberrypi][PATCH 5/8] Support for vc4 graphics driver: upgrade 4.4 kernel to 4.4.10

[Herve Jourdain]

One thing I didn't make configurable, but that maybe could be, is the parameter passed to the overlay.
I selected cma-256, based on experience from other people, and because my configuration is RPI2/3 with 1G of memory.
I realize it might not work well with RPI0/1, which have less memory available...
So even if I believe cma-256 is a good default value, it might be made selectable by the user, if we want to consider vc4 on RPI0/1.
I'd very much like to hear other people's opinion about that...

Herve

> Le 19 mai 2016 à 00:43, Herve Jourdain <herve.jourdain@neuf.fr> a écrit :
> 
> Hi Khem,
> 
> Yes, I've seen that you had sent a patch to upgrade to some revision of 4.4.9.
> Here, I upgrade to 4.4.10, but VC4 should work with the 4.4.9 revision you sent before.
> I mostly bumped to 4.4.10 because the firmware bumped to 4.4.10 - and the firmware bump is mandatory for VC4 to work effectively on RPI.
> 
> Herve
> 
>> Le 19 mai 2016 à 00:27, Khem Raj <raj.khem@gmail.com> a écrit :
>> 
>> 
>>> On May 18, 2016, at 5:21 AM, Herve Jourdain <herve.jourdain@neuf.fr> wrote:
>>> 
>>> This patch series enables the support for the VC4 graphics driver from Eric Anholt.
>>> Kernel upgrade to 4.4.10 (some 4.4.9 version would be enough, but the required firmware supports 4.4.10, so bump it anyway)
>> 
>> I have sent a patch for similar update. Have you looked at that
>> 
>>> 
>>> Signed-off-by: Herve Jourdain <herve.jourdain@neuf.fr>
>>> ---
>>> recipes-kernel/linux/linux-raspberrypi_4.4.bb | 4 ++--
>>> 1 file changed, 2 insertions(+), 2 deletions(-)
>>> 
>>> diff --git a/recipes-kernel/linux/linux-raspberrypi_4.4.bb b/recipes-kernel/linux/linux-raspberrypi_4.4.bb
>>> index 831ac5a..0bc6531 100644
>>> --- a/recipes-kernel/linux/linux-raspberrypi_4.4.bb
>>> +++ b/recipes-kernel/linux/linux-raspberrypi_4.4.bb
>>> @@ -1,8 +1,8 @@
>>> FILESEXTRAPATHS_prepend := "${THISDIR}/${PN}-${PV}:"
>>> 
>>> -LINUX_VERSION ?= "4.4.8"
>>> +LINUX_VERSION ?= "4.4.10"
>>> 
>>> -SRCREV = "fe7ad6aa5c6940817fe971d80a7b2a1d6052190a"
>>> +SRCREV = "4c2795dd50f98fa162cb53190eb557be44f92f58"
>>> SRC_URI = "git://github.com/raspberrypi/linux.git;protocol=git;branch=rpi-4.4.y \
>>>          file://0001-fix-dtbo-rules.patch \
>>> "
>>> --
>>> 2.7.4
>>> 
>>> --
>>> _______________________________________________
>>> yocto mailing list
>>> yocto@yoctoproject.org
>>> https://lists.yoctoproject.org/listinfo/yocto
>> 

Re: [meta-raspberrypi][PATCH 5/8] Support for vc4 graphics driver: upgrade 4.4 kernel to 4.4.10

[Andreas Müller]

On Wed, May 18, 2016 at 7:32 PM, Herve Jourdain <herve.jourdain@neuf.fr> wrote:
> One thing I didn't make configurable, but that maybe could be, is the parameter passed to the overlay.
> I selected cma-256, based on experience from other people, and because my configuration is RPI2/3 with 1G of memory.
> I realize it might not work well with RPI0/1, which have less memory available...
> So even if I believe cma-256 is a good default value, it might be made selectable by the user, if we want to consider vc4 on RPI0/1.
I played around with vc4 to but did not manage to get it work for an
elder version 4.1 of kernel.

I did in rpi-config:

CMA_SIZE = "cma-256"
CMA_SIZE_raspberrypi = "cma-64"
CMA_SIZE_raspberrypi0 = "cma-128"
...
echo "dtoverlay=vc4-kms-v3d-overlay,${CMA_SIZE}"
>>${DEPLOYDIR}/bcm2835-bootfiles/config.txt

This is nothing but an untested suggestion.

Without testing your series I would be very happy to see this or very
similar applied in master: Since vc4 works, RaspberryPi turned into my
reference test board - e.g. have not seen kde5 running that nice on
another board..

Andreas

Re: [meta-raspberrypi][PATCH 8/8] Support for vc4 graphics driver: modify the configuration for mesa

[Andreas Müller]

On Wed, May 18, 2016 at 2:21 PM, Herve Jourdain <herve.jourdain@neuf.fr> wrote:
> This patch series enables the support for the VC4 graphics driver from Eric Anholt.
> Add some configuration for building mesa, on raspberrypi, when VC4 is in use.
>
> Signed-off-by: Herve Jourdain <herve.jourdain@neuf.fr>
> ---
>  recipes-graphics/mesa/mesa_%.bbappend | 4 ++++
>  1 file changed, 4 insertions(+)
>  create mode 100644 recipes-graphics/mesa/mesa_%.bbappend
>
> diff --git a/recipes-graphics/mesa/mesa_%.bbappend b/recipes-graphics/mesa/mesa_%.bbappend
> new file mode 100644
> index 0000000..b182388
> --- /dev/null
> +++ b/recipes-graphics/mesa/mesa_%.bbappend
> @@ -0,0 +1,4 @@
> +PACKAGECONFIG_append_rpi = " gallium"
> +GALLIUMDRIVERS_rpi = "vc4"
> +DRIDRIVERS_rpi = ""
> +
> --
> 2.7.4
>
> --
FWIW: An update of mesa would at least help for Qt applications [1]

[1] https://github.com/anholt/mesa/issues/26

Andreas

Re: [meta-raspberrypi][PATCH 5/8] Support for vc4 graphics driver: upgrade 4.4 kernel to 4.4.10

[Andreas Müller]

On Wed, May 18, 2016 at 11:46 PM, Andreas Müller
<schnitzeltony@googlemail.com> wrote:
> On Wed, May 18, 2016 at 7:32 PM, Herve Jourdain <herve.jourdain@neuf.fr> wrote:
>> One thing I didn't make configurable, but that maybe could be, is the parameter passed to the overlay.
>> I selected cma-256, based on experience from other people, and because my configuration is RPI2/3 with 1G of memory.
>> I realize it might not work well with RPI0/1, which have less memory available...
>> So even if I believe cma-256 is a good default value, it might be made selectable by the user, if we want to consider vc4 on RPI0/1.
> I played around with vc4 to but did not manage to get it work for an
> elder version 4.1 of kernel.
what I meant: did only work for elder 4.1 - not current 4.1
>
> I did in rpi-config:
>
> CMA_SIZE = "cma-256"
> CMA_SIZE_raspberrypi = "cma-64"
> CMA_SIZE_raspberrypi0 = "cma-128"
> ...
> echo "dtoverlay=vc4-kms-v3d-overlay,${CMA_SIZE}"
>>>${DEPLOYDIR}/bcm2835-bootfiles/config.txt
>
> This is nothing but an untested suggestion.
>
> Without testing your series I would be very happy to see this or very
> similar applied in master: Since vc4 works, RaspberryPi turned into my
> reference test board - e.g. have not seen kde5 running that nice on
> another board..
>
> Andreas

Re: [meta-raspberrypi][PATCH 8/8] Support for vc4 graphics driver: modify the configuration for mesa

[Andreas Müller]

On Thu, May 19, 2016 at 12:02 AM, Andreas Müller
<schnitzeltony@googlemail.com> wrote:
> On Wed, May 18, 2016 at 2:21 PM, Herve Jourdain <herve.jourdain@neuf.fr> wrote:
>> This patch series enables the support for the VC4 graphics driver from Eric Anholt.
>> Add some configuration for building mesa, on raspberrypi, when VC4 is in use.
>>
>> Signed-off-by: Herve Jourdain <herve.jourdain@neuf.fr>
>> ---
>>  recipes-graphics/mesa/mesa_%.bbappend | 4 ++++
>>  1 file changed, 4 insertions(+)
>>  create mode 100644 recipes-graphics/mesa/mesa_%.bbappend
>>
>> diff --git a/recipes-graphics/mesa/mesa_%.bbappend b/recipes-graphics/mesa/mesa_%.bbappend
>> new file mode 100644
>> index 0000000..b182388
>> --- /dev/null
>> +++ b/recipes-graphics/mesa/mesa_%.bbappend
>> @@ -0,0 +1,4 @@
>> +PACKAGECONFIG_append_rpi = " gallium"
>> +GALLIUMDRIVERS_rpi = "vc4"
>> +DRIDRIVERS_rpi = ""
>> +
>> --
>> 2.7.4
>>
>> --
> FWIW: An update of mesa would at least help for Qt applications [1]
>
> [1] https://github.com/anholt/mesa/issues/26
>
Have checked this again: Patch 'vc4: Fix subimage accesses to LT
textures.' is included in mesa 11.2.2 build by current oe-core.

So forget about my comment

Andreas

Re: [meta-raspberrypi][PATCH 8/8] Support for vc4 graphics driver: modify the configuration for mesa

[Herve Jourdain]

Hi Andreas,

Thanks for seeing that, I did many tests, but they did not involve qt...
I can update the mesa version i guess, or add a patch for the current version...

Herve

> Le 19 mai 2016 à 06:02, Andreas Müller <schnitzeltony@googlemail.com> a écrit :
> 
>> On Wed, May 18, 2016 at 2:21 PM, Herve Jourdain <herve.jourdain@neuf.fr> wrote:
>> This patch series enables the support for the VC4 graphics driver from Eric Anholt.
>> Add some configuration for building mesa, on raspberrypi, when VC4 is in use.
>> 
>> Signed-off-by: Herve Jourdain <herve.jourdain@neuf.fr>
>> ---
>> recipes-graphics/mesa/mesa_%.bbappend | 4 ++++
>> 1 file changed, 4 insertions(+)
>> create mode 100644 recipes-graphics/mesa/mesa_%.bbappend
>> 
>> diff --git a/recipes-graphics/mesa/mesa_%.bbappend b/recipes-graphics/mesa/mesa_%.bbappend
>> new file mode 100644
>> index 0000000..b182388
>> --- /dev/null
>> +++ b/recipes-graphics/mesa/mesa_%.bbappend
>> @@ -0,0 +1,4 @@
>> +PACKAGECONFIG_append_rpi = " gallium"
>> +GALLIUMDRIVERS_rpi = "vc4"
>> +DRIDRIVERS_rpi = ""
>> +
>> --
>> 2.7.4
>> 
>> --
> FWIW: An update of mesa would at least help for Qt applications [1]
> 
> [1] https://github.com/anholt/mesa/issues/26
> 
> Andreas

Re: [meta-raspberrypi][PATCH 5/8] Support for vc4 graphics driver: upgrade 4.4 kernel to 4.4.10

[Herve Jourdain]

Hi Andreas,

I will send a v2 series soon, that will include something very similar to your suggestion for the overlay parameter.

Herve

-----Original Message-----
From: Andreas Müller [mailto:schnitzeltony@googlemail.com] 
Sent: mercredi 18 mai 2016 23:47
To: Herve Jourdain <herve.jourdain@neuf.fr>
Cc: Khem Raj <raj.khem@gmail.com>; Yocto Project <yocto@yoctoproject.org>
Subject: Re: [yocto] [meta-raspberrypi][PATCH 5/8] Support for vc4 graphics driver: upgrade 4.4 kernel to 4.4.10

On Wed, May 18, 2016 at 7:32 PM, Herve Jourdain <herve.jourdain@neuf.fr> wrote:
> One thing I didn't make configurable, but that maybe could be, is the parameter passed to the overlay.
> I selected cma-256, based on experience from other people, and because my configuration is RPI2/3 with 1G of memory.
> I realize it might not work well with RPI0/1, which have less memory available...
> So even if I believe cma-256 is a good default value, it might be made selectable by the user, if we want to consider vc4 on RPI0/1.
I played around with vc4 to but did not manage to get it work for an elder version 4.1 of kernel.

I did in rpi-config:

CMA_SIZE = "cma-256"
CMA_SIZE_raspberrypi = "cma-64"
CMA_SIZE_raspberrypi0 = "cma-128"
...
echo "dtoverlay=vc4-kms-v3d-overlay,${CMA_SIZE}"
>>${DEPLOYDIR}/bcm2835-bootfiles/config.txt

This is nothing but an untested suggestion.

Without testing your series I would be very happy to see this or very similar applied in master: Since vc4 works, RaspberryPi turned into my reference test board - e.g. have not seen kde5 running that nice on another board..

Andreas

Re: [meta-raspberrypi][PATCH 5/8] Support for vc4 graphics driver: upgrade 4.4 kernel to 4.4.10

[Herve Jourdain]

Hi Andreas,

I've been able to do some testing with the latest 4.1 kernel.
So it can actually "work" in a way, but both the device tree overlay and the driver in the kernel are "old".
This has an impact on stability: I can definitely start wayland/weston, and it's "responsive", BUT after I started playing out with the demo applications, it quickly crashed...
So we could either try to backport the newer driver / dt overlay to the 4.1, which could be possible, or we could just support vc4graphics only for 4.4.10+...

Since 4.1 is not heavily maintained anymore on github, since 4.4 is now the default revision on github, and since development branches for 4.5 and 4.6 are already there on github, I would personally be inclined to support vc4graphics only for 4.4.10+...
And I would also be in favor of moving the default version of the kernel to the 4.4 series...

What do you think is the best option there?

Herve

-----Original Message-----
From: Andreas Müller [mailto:schnitzeltony@googlemail.com] 
Sent: jeudi 19 mai 2016 00:59
To: Herve Jourdain <herve.jourdain@neuf.fr>
Cc: Khem Raj <raj.khem@gmail.com>; Yocto Project <yocto@yoctoproject.org>
Subject: Re: [yocto] [meta-raspberrypi][PATCH 5/8] Support for vc4 graphics driver: upgrade 4.4 kernel to 4.4.10

On Wed, May 18, 2016 at 11:46 PM, Andreas Müller <schnitzeltony@googlemail.com> wrote:
> On Wed, May 18, 2016 at 7:32 PM, Herve Jourdain <herve.jourdain@neuf.fr> wrote:
>> One thing I didn't make configurable, but that maybe could be, is the parameter passed to the overlay.
>> I selected cma-256, based on experience from other people, and because my configuration is RPI2/3 with 1G of memory.
>> I realize it might not work well with RPI0/1, which have less memory available...
>> So even if I believe cma-256 is a good default value, it might be made selectable by the user, if we want to consider vc4 on RPI0/1.
> I played around with vc4 to but did not manage to get it work for an 
> elder version 4.1 of kernel.
what I meant: did only work for elder 4.1 - not current 4.1
>
> I did in rpi-config:
>
> CMA_SIZE = "cma-256"
> CMA_SIZE_raspberrypi = "cma-64"
> CMA_SIZE_raspberrypi0 = "cma-128"
> ...
> echo "dtoverlay=vc4-kms-v3d-overlay,${CMA_SIZE}"
>>>${DEPLOYDIR}/bcm2835-bootfiles/config.txt
>
> This is nothing but an untested suggestion.
>
> Without testing your series I would be very happy to see this or very 
> similar applied in master: Since vc4 works, RaspberryPi turned into my 
> reference test board - e.g. have not seen kde5 running that nice on 
> another board..
>
> Andreas

Re: [meta-raspberrypi][PATCH 5/8] Support for vc4 graphics driver: upgrade 4.4 kernel to 4.4.10

[Andreas Müller]

On Thu, May 19, 2016 at 7:21 AM, Herve Jourdain <herve.jourdain@neuf.fr> wrote:
> Hi Andreas,
>
> I've been able to do some testing with the latest 4.1 kernel.
> So it can actually "work" in a way, but both the device tree overlay and the driver in the kernel are "old".
> This has an impact on stability: I can definitely start wayland/weston, and it's "responsive", BUT after I started playing out with the demo applications, it quickly crashed...
> So we could either try to backport the newer driver / dt overlay to the 4.1, which could be possible, or we could just support vc4graphics only for 4.4.10+...
>
> Since 4.1 is not heavily maintained anymore on github, since 4.4 is now the default revision on github, and since development branches for 4.5 and 4.6 are already there on github, I would personally be inclined to support vc4graphics only for 4.4.10+...
> And I would also be in favor of moving the default version of the kernel to the 4.4 series...
>
> What do you think is the best option there?
>
No need to backport to 4.1. 4.4 is fine. One question: are you able to
change screen resolution for HDMI monitor (elder sdl fullscreen games
need that)? This was not possible for kernel 4.1.

Just to avoid misunderstandings: I like this patch series very much
and would be happy to see it applied.

Andreas

Re: [meta-raspberrypi][PATCH 5/8] Support for vc4 graphics driver: upgrade 4.4 kernel to 4.4.10

[Herve Jourdain]

Hi Andreas,

Don't worry about "misunderstanding" on my part, I actually value other people's input. I started this for some needs I had, I'm happy to share it, but I'm also not able to test it in all configurations, and I might overlook some other people's needs, so I'm fine with suggestions.
There have been changes recently regarding HDMI handling by the vc4 driver, but I'm not sure if changing the screen resolution is supported/working.
I may try to test it, do you have some settings in mind that I should test?

Herve

-----Original Message-----
From: Andreas Müller [mailto:schnitzeltony@googlemail.com] 
Sent: jeudi 19 mai 2016 08:28
To: Herve Jourdain <herve.jourdain@neuf.fr>
Cc: Khem Raj <raj.khem@gmail.com>; Yocto Project <yocto@yoctoproject.org>
Subject: Re: [yocto] [meta-raspberrypi][PATCH 5/8] Support for vc4 graphics driver: upgrade 4.4 kernel to 4.4.10

On Thu, May 19, 2016 at 7:21 AM, Herve Jourdain <herve.jourdain@neuf.fr> wrote:
> Hi Andreas,
>
> I've been able to do some testing with the latest 4.1 kernel.
> So it can actually "work" in a way, but both the device tree overlay and the driver in the kernel are "old".
> This has an impact on stability: I can definitely start wayland/weston, and it's "responsive", BUT after I started playing out with the demo applications, it quickly crashed...
> So we could either try to backport the newer driver / dt overlay to the 4.1, which could be possible, or we could just support vc4graphics only for 4.4.10+...
>
> Since 4.1 is not heavily maintained anymore on github, since 4.4 is now the default revision on github, and since development branches for 4.5 and 4.6 are already there on github, I would personally be inclined to support vc4graphics only for 4.4.10+...
> And I would also be in favor of moving the default version of the kernel to the 4.4 series...
>
> What do you think is the best option there?
>
No need to backport to 4.1. 4.4 is fine. One question: are you able to change screen resolution for HDMI monitor (elder sdl fullscreen games need that)? This was not possible for kernel 4.1.

Just to avoid misunderstandings: I like this patch series very much and would be happy to see it applied.

Andreas

Re: [meta-raspberrypi][PATCH 1/8] Support for vc4 graphics driver: change the default providers

[Andrei Gherzan]

[-- Attachment #1: Type: text/plain, Size: 1946 bytes --]

Hello,

Try to keep the commit log format as we currently have the layer.
http://www.openembedded.org/wiki/Commit_Patch_Message_Guidelines

On Wed, May 18, 2016 at 08:21:15PM +0800, Herve Jourdain wrote:
> This patch series enables the support for the VC4 graphics driver from Eric Anholt.
> Configure the default providers, depending on whether 'vc4graphics' is in MACHINE_FEATURES or not.
>
> Signed-off-by: Herve Jourdain <herve.jourdain@neuf.fr>
> ---
>  conf/machine/include/rpi-default-providers.inc | 8 ++++----
>  1 file changed, 4 insertions(+), 4 deletions(-)
>
> diff --git a/conf/machine/include/rpi-default-providers.inc b/conf/machine/include/rpi-default-providers.inc
> index cabbd43..0bc8838 100644
> --- a/conf/machine/include/rpi-default-providers.inc
> +++ b/conf/machine/include/rpi-default-providers.inc
> @@ -3,8 +3,8 @@
>  PREFERRED_PROVIDER_virtual/kernel ?= "linux-raspberrypi"
>  PREFERRED_PROVIDER_u-boot ?= "u-boot-rpi"
>  PREFERRED_PROVIDER_virtual/xserver ?= "xserver-xorg"
> -PREFERRED_PROVIDER_virtual/egl ?= "userland"
> -PREFERRED_PROVIDER_virtual/libgles2 ?= "userland"
> -PREFERRED_PROVIDER_virtual/libgl ?= "mesa-gl"
> -PREFERRED_PROVIDER_virtual/mesa ?= "mesa-gl"
> +PREFERRED_PROVIDER_virtual/egl ?= "${@bb.utils.contains("MACHINE_FEATURES", "vc4graphics", "mesa", "userland", d)}"
> +PREFERRED_PROVIDER_virtual/libgles2 ?= "${@bb.utils.contains("MACHINE_FEATURES", "vc4graphics", "mesa", "userland", d)}"
> +PREFERRED_PROVIDER_virtual/libgl ?= "${@bb.utils.contains("MACHINE_FEATURES", "vc4graphics", "mesa", "mesa-gl", d)}"
> +PREFERRED_PROVIDER_virtual/mesa ?= "${@bb.utils.contains("MACHINE_FEATURES", "vc4graphics", "mesa", "mesa-gl", d)}"
>  PREFERRED_PROVIDER_jpeg ?= "jpeg"
> --
> 2.7.4
>
> --
> _______________________________________________
> yocto mailing list
> yocto@yoctoproject.org
> https://lists.yoctoproject.org/listinfo/yocto

--
Andrei Gherzan

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 836 bytes --]

Re: [meta-raspberrypi][PATCH 6/8] Support for vc4 graphics driver: modify the wayland configuration for vc4

[Andrei Gherzan]

[-- Attachment #1: Type: text/plain, Size: 1187 bytes --]

On Wed, May 18, 2016 at 08:21:20PM +0800, Herve Jourdain wrote:
> This patch series enables the support for the VC4 graphics driver from Eric Anholt.
> Configure the configuration options for Wayland, depending on whether 'vc4graphics' is in MACHINE_FEATURES or not.
>
> Signed-off-by: Herve Jourdain <herve.jourdain@neuf.fr>
> ---
>  recipes-graphics/wayland/weston_%.bbappend | 7 +++----
>  1 file changed, 3 insertions(+), 4 deletions(-)
>
> diff --git a/recipes-graphics/wayland/weston_%.bbappend b/recipes-graphics/wayland/weston_%.bbappend
> index c3a7421..76bab9f 100644
> --- a/recipes-graphics/wayland/weston_%.bbappend
> +++ b/recipes-graphics/wayland/weston_%.bbappend
> @@ -1,4 +1,3 @@
> -EXTRA_OECONF_append_rpi = "\
> -        --enable-rpi-compositor \
> -        WESTON_NATIVE_BACKEND=rpi-backend.so \
> -       "
> +EXTRA_OECONF_append_rpi = "${@bb.utils.contains('MACHINE_FEATURES', 'vc4graphics', '', ' --enable-rpi-compositor', d)}"
> +EXTRA_OECONF_append_rpi = "${@bb.utils.contains('MACHINE_FEATURES', 'vc4graphics', '', ' WESTON_NATIVE_BACKEND=rpi-backend.so', d)}"

Wondering if having this in one line would be better.

--
Andrei Gherzan

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 836 bytes --]

Re: [meta-raspberrypi][PATCH 2/8] Support for vc4 graphics driver: add vc4-kms-v3d to the overlays

[Andrei Gherzan]

[-- Attachment #1: Type: text/plain, Size: 1604 bytes --]

On Wed, May 18, 2016 at 08:21:16PM +0800, Herve Jourdain wrote:
> This patch series enables the support for the VC4 graphics driver from Eric Anholt.
> Add vc4-kms-v3d overlay if 'vc4graphics' is in MACHINE_FEATURES.
> (This patch has a dependency on the patch that enables the support of .dtbo overlay files)
>
> Signed-off-by: Herve Jourdain <herve.jourdain@neuf.fr>
> ---
>  recipes-bsp/bootfiles/rpi-config_git.bb | 8 ++++++++
>  1 file changed, 8 insertions(+)
>
> diff --git a/recipes-bsp/bootfiles/rpi-config_git.bb b/recipes-bsp/bootfiles/rpi-config_git.bb
> index 4bc8eb7..79e436d 100644
> --- a/recipes-bsp/bootfiles/rpi-config_git.bb
> +++ b/recipes-bsp/bootfiles/rpi-config_git.bb
> @@ -19,6 +19,8 @@ PITFT="${@bb.utils.contains("MACHINE_FEATURES", "pitft", "1", "0", d)}"
>  PITFT22="${@bb.utils.contains("MACHINE_FEATURES", "pitft22", "1", "0", d)}"
>  PITFT28r="${@bb.utils.contains("MACHINE_FEATURES", "pitft28r", "1", "0", d)}"
>
> +VC4GRAPHICS="${@bb.utils.contains("MACHINE_FEATURES", "vc4graphics", "1", "0", d)}"
> +
>  inherit deploy
>
>  do_deploy() {
> @@ -102,6 +104,12 @@ do_deploy() {
>          echo "# Enable UART" >>${DEPLOYDIR}/bcm2835-bootfiles/config.txt
>          echo "enable_uart=1" >>${DEPLOYDIR}/bcm2835-bootfiles/config.txt
>      fi
> +
> +    # VC4 Graphics support
> +    if [ "${VC4GRAPHICS}" = "1" ]; then
> +        echo "# Enable VC4 Graphics" >>${DEPLOYDIR}/bcm2835-bootfiles/config.txt
> +        echo "dtoverlay=vc4-kms-v3d,cma-256" >>${DEPLOYDIR}/bcm2835-bootfiles/config.txt

NIT: space after >>

--
Andrei Gherzan

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 836 bytes --]

Re: [meta-raspberrypi][PATCH 2/8] Support for vc4 graphics driver: add vc4-kms-v3d to the overlays

[Andrei Gherzan]

[-- Attachment #1: Type: text/plain, Size: 3338 bytes --]

On Thu, May 19, 2016 at 01:25:34AM +0800, Herve Jourdain wrote:
> Hi Khem,
>
> Well, it seems to be the way it will be activated in the future as well, through a device tree overlay.
> The rationale being that people may not want/need the VC4 driver, because they prefer to use userland or other reasons, and that only the persons who want to activate it will load the overlay.
> One thing to remember is that vc4 has the potential to conflict with other pieces, and it might not be for everybody (the firmware patch helps in that regards, but before it, weston/drm was conflicting with the splash screen for instance on my test setup, creating very disturbing images).
>
> If your question is, will userland disappear one day and vc4 graphics becoming the only graphics driver, the overlay could be included in the base device tree itself, in like a few years from now, then I clearly don't have an answer to that...
>
> But I believe the overlay will stick some time around.
>

I'm not sure if this is what Raj asked about. Needs some clarification.

> Herve
>
> > Le 19 mai 2016 à 00:53, Khem Raj <raj.khem@gmail.com> a écrit :
> >
> >
> >> On May 18, 2016, at 5:21 AM, Herve Jourdain <herve.jourdain@neuf.fr> wrote:
> >>
> >> This patch series enables the support for the VC4 graphics driver from Eric Anholt.
> >> Add vc4-kms-v3d overlay if 'vc4graphics' is in MACHINE_FEATURES.
> >> (This patch has a dependency on the patch that enables the support of .dtbo overlay files)
> >>
> >> Signed-off-by: Herve Jourdain <herve.jourdain@neuf.fr>
> >> ---
> >> recipes-bsp/bootfiles/rpi-config_git.bb | 8 ++++++++
> >> 1 file changed, 8 insertions(+)
> >>
> >> diff --git a/recipes-bsp/bootfiles/rpi-config_git.bb b/recipes-bsp/bootfiles/rpi-config_git.bb
> >> index 4bc8eb7..79e436d 100644
> >> --- a/recipes-bsp/bootfiles/rpi-config_git.bb
> >> +++ b/recipes-bsp/bootfiles/rpi-config_git.bb
> >> @@ -19,6 +19,8 @@ PITFT="${@bb.utils.contains("MACHINE_FEATURES", "pitft", "1", "0", d)}"
> >> PITFT22="${@bb.utils.contains("MACHINE_FEATURES", "pitft22", "1", "0", d)}"
> >> PITFT28r="${@bb.utils.contains("MACHINE_FEATURES", "pitft28r", "1", "0", d)}"
> >>
> >> +VC4GRAPHICS="${@bb.utils.contains("MACHINE_FEATURES", "vc4graphics", "1", "0", d)}"
> >> +
> >> inherit deploy
> >>
> >> do_deploy() {
> >> @@ -102,6 +104,12 @@ do_deploy() {
> >>        echo "# Enable UART" >>${DEPLOYDIR}/bcm2835-bootfiles/config.txt
> >>        echo "enable_uart=1" >>${DEPLOYDIR}/bcm2835-bootfiles/config.txt
> >>    fi
> >> +
> >> +    # VC4 Graphics support
> >> +    if [ "${VC4GRAPHICS}" = "1" ]; then
> >> +        echo "# Enable VC4 Graphics" >>${DEPLOYDIR}/bcm2835-bootfiles/config.txt
> >> +        echo "dtoverlay=vc4-kms-v3d,cma-256" >>${DEPLOYDIR}/bcm2835-bootfiles/config.txt
> >> +    fi
> >
> >
> > will this keep appending overtime ?
> >
> >> }
> >>
> >> addtask deploy before do_package after do_install
> >> --
> >> 2.7.4
> >>
> >> --
> >> _______________________________________________
> >> yocto mailing list
> >> yocto@yoctoproject.org
> >> https://lists.yoctoproject.org/listinfo/yocto
> >
> --
> _______________________________________________
> yocto mailing list
> yocto@yoctoproject.org
> https://lists.yoctoproject.org/listinfo/yocto

--
Andrei Gherzan

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 836 bytes --]

Re: [meta-raspberrypi][PATCH 2/8] Support for vc4 graphics driver: add vc4-kms-v3d to the overlays

[Andrei Gherzan]

[-- Attachment #1: Type: text/plain, Size: 2176 bytes --]

On Wed, May 18, 2016 at 08:21:16PM +0800, Herve Jourdain wrote:
> This patch series enables the support for the VC4 graphics driver from Eric Anholt.
> Add vc4-kms-v3d overlay if 'vc4graphics' is in MACHINE_FEATURES.
> (This patch has a dependency on the patch that enables the support of .dtbo overlay files)
>
> Signed-off-by: Herve Jourdain <herve.jourdain@neuf.fr>
> ---
>  recipes-bsp/bootfiles/rpi-config_git.bb | 8 ++++++++
>  1 file changed, 8 insertions(+)
>
> diff --git a/recipes-bsp/bootfiles/rpi-config_git.bb b/recipes-bsp/bootfiles/rpi-config_git.bb
> index 4bc8eb7..79e436d 100644
> --- a/recipes-bsp/bootfiles/rpi-config_git.bb
> +++ b/recipes-bsp/bootfiles/rpi-config_git.bb
> @@ -19,6 +19,8 @@ PITFT="${@bb.utils.contains("MACHINE_FEATURES", "pitft", "1", "0", d)}"
>  PITFT22="${@bb.utils.contains("MACHINE_FEATURES", "pitft22", "1", "0", d)}"
>  PITFT28r="${@bb.utils.contains("MACHINE_FEATURES", "pitft28r", "1", "0", d)}"
>
> +VC4GRAPHICS="${@bb.utils.contains("MACHINE_FEATURES", "vc4graphics", "1", "0", d)}"
> +
>  inherit deploy
>
>  do_deploy() {
> @@ -102,6 +104,12 @@ do_deploy() {
>          echo "# Enable UART" >>${DEPLOYDIR}/bcm2835-bootfiles/config.txt
>          echo "enable_uart=1" >>${DEPLOYDIR}/bcm2835-bootfiles/config.txt
>      fi
> +
> +    # VC4 Graphics support
> +    if [ "${VC4GRAPHICS}" = "1" ]; then
> +        echo "# Enable VC4 Graphics" >>${DEPLOYDIR}/bcm2835-bootfiles/config.txt
> +        echo "dtoverlay=vc4-kms-v3d,cma-256" >>${DEPLOYDIR}/bcm2835-bootfiles/config.txt

This is definitely not a good idea on rpi0/1. Let's select this based
on RPI version:
CMA_USAGE_raspberrypi = "cma-128"

Or we can set a default variable on this configurable by user. But I
would like to have a warning mechanism. Maybe a python function that
will check if we want to build rpi1 and cma-256 was selected issue a
warning.

> +    fi
>  }
>
>  addtask deploy before do_package after do_install
> --
> 2.7.4
>
> --
> _______________________________________________
> yocto mailing list
> yocto@yoctoproject.org
> https://lists.yoctoproject.org/listinfo/yocto

--
Andrei Gherzan

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 836 bytes --]

Re: [meta-raspberrypi][PATCH 5/8] Support for vc4 graphics driver: upgrade 4.4 kernel to 4.4.10

[Andrei Gherzan]

[-- Attachment #1: Type: text/plain, Size: 1669 bytes --]

On Wed, May 18, 2016 at 11:46:39PM +0200, Andreas Müller wrote:
> On Wed, May 18, 2016 at 7:32 PM, Herve Jourdain <herve.jourdain@neuf.fr> wrote:
> > One thing I didn't make configurable, but that maybe could be, is the parameter passed to the overlay.
> > I selected cma-256, based on experience from other people, and because my configuration is RPI2/3 with 1G of memory.
> > I realize it might not work well with RPI0/1, which have less memory available...
> > So even if I believe cma-256 is a good default value, it might be made selectable by the user, if we want to consider vc4 on RPI0/1.
> I played around with vc4 to but did not manage to get it work for an
> elder version 4.1 of kernel.
>
> I did in rpi-config:
>
> CMA_SIZE = "cma-256"
> CMA_SIZE_raspberrypi = "cma-64"

I sent reply about this too. This is definitely one solution would I
would rather have a CMA_SIZE default value and a python function to
check its match with board variant. Cause in this way a user might be
able to use cma-96 on rapsberrypi.

> CMA_SIZE_raspberrypi0 = "cma-128"
> ...
> echo "dtoverlay=vc4-kms-v3d-overlay,${CMA_SIZE}"
> >>${DEPLOYDIR}/bcm2835-bootfiles/config.txt
>
> This is nothing but an untested suggestion.
>
> Without testing your series I would be very happy to see this or very
> similar applied in master: Since vc4 works, RaspberryPi turned into my
> reference test board - e.g. have not seen kde5 running that nice on
> another board..
>
> Andreas
> --
> _______________________________________________
> yocto mailing list
> yocto@yoctoproject.org
> https://lists.yoctoproject.org/listinfo/yocto

--
Andrei Gherzan

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 836 bytes --]

Re: [meta-raspberrypi][PATCH 5/8] Support for vc4 graphics driver: upgrade 4.4 kernel to 4.4.10

[Andrei Gherzan]

[-- Attachment #1: Type: text/plain, Size: 1479 bytes --]

On Thu, May 19, 2016 at 08:28:00AM +0200, Andreas Müller wrote:
> On Thu, May 19, 2016 at 7:21 AM, Herve Jourdain <herve.jourdain@neuf.fr> wrote:
> > Hi Andreas,
> >
> > I've been able to do some testing with the latest 4.1 kernel.
> > So it can actually "work" in a way, but both the device tree overlay and the driver in the kernel are "old".
> > This has an impact on stability: I can definitely start wayland/weston, and it's "responsive", BUT after I started playing out with the demo applications, it quickly crashed...
> > So we could either try to backport the newer driver / dt overlay to the 4.1, which could be possible, or we could just support vc4graphics only for 4.4.10+...
> >
> > Since 4.1 is not heavily maintained anymore on github, since 4.4 is now the default revision on github, and since development branches for 4.5 and 4.6 are already there on github, I would personally be inclined to support vc4graphics only for 4.4.10+...
> > And I would also be in favor of moving the default version of the kernel to the 4.4 series...
> >
> > What do you think is the best option there?
> >
> No need to backport to 4.1. 4.4 is fine. One question: are you able to
> change screen resolution for HDMI monitor (elder sdl fullscreen games
> need that)? This was not possible for kernel 4.1.
>
> Just to avoid misunderstandings: I like this patch series very much
> and would be happy to see it applied.
>

Santa heard you.

--
Andrei Gherzan

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 836 bytes --]

Re: [meta-raspberrypi][PATCH 5/8] Support for vc4 graphics driver: upgrade 4.4 kernel to 4.4.10

[Khem Raj]

On Thu, May 19, 2016 at 8:11 AM, Andrei Gherzan <andrei@gherzan.ro> wrote:
> On Wed, May 18, 2016 at 11:46:39PM +0200, Andreas Müller wrote:
>> On Wed, May 18, 2016 at 7:32 PM, Herve Jourdain <herve.jourdain@neuf.fr> wrote:
>> > One thing I didn't make configurable, but that maybe could be, is the parameter passed to the overlay.
>> > I selected cma-256, based on experience from other people, and because my configuration is RPI2/3 with 1G of memory.
>> > I realize it might not work well with RPI0/1, which have less memory available...
>> > So even if I believe cma-256 is a good default value, it might be made selectable by the user, if we want to consider vc4 on RPI0/1.
>> I played around with vc4 to but did not manage to get it work for an
>> elder version 4.1 of kernel.
>>
>> I did in rpi-config:
>>
>> CMA_SIZE = "cma-256"
>> CMA_SIZE_raspberrypi = "cma-64"


>
> I sent reply about this too. This is definitely one solution would I
> would rather have a CMA_SIZE default value and a python function to
> check its match with board variant. Cause in this way a user might be
> able to use cma-96 on rapsberrypi.
>
>> CMA_SIZE_raspberrypi0 = "cma-128"


setting CMA_SIZE should be moved into machine.conf file IMO


>> ...
>> echo "dtoverlay=vc4-kms-v3d-overlay,${CMA_SIZE}"
>> >>${DEPLOYDIR}/bcm2835-bootfiles/config.txt
>>
>> This is nothing but an untested suggestion.
>>
>> Without testing your series I would be very happy to see this or very
>> similar applied in master: Since vc4 works, RaspberryPi turned into my
>> reference test board - e.g. have not seen kde5 running that nice on
>> another board..
>>
>> Andreas
>> --
>> _______________________________________________
>> yocto mailing list
>> yocto@yoctoproject.org
>> https://lists.yoctoproject.org/listinfo/yocto
>
> --
> Andrei Gherzan
>
> --
> _______________________________________________
> yocto mailing list
> yocto@yoctoproject.org
> https://lists.yoctoproject.org/listinfo/yocto
>

Re: [meta-raspberrypi][PATCH 5/8] Support for vc4 graphics driver: upgrade 4.4 kernel to 4.4.10

[Herve Jourdain]

Hi Andrei,

I have a v3 cooking, I will release it shortly after I have a good solution
for the management of the dtbo - I guess I've just managed to get something
working, but I need a few more tests.
I'll try to take all your remarks into account, as well as those by Andreas
and Khem.

Herve

-----Original Message-----
From: Andrei Gherzan [mailto:andrei@gherzan.ro] 
Sent: jeudi 19 mai 2016 17:13
To: Andreas Müller <schnitzeltony@googlemail.com>
Cc: Herve Jourdain <herve.jourdain@neuf.fr>; Yocto Project
<yocto@yoctoproject.org>
Subject: Re: [yocto] [meta-raspberrypi][PATCH 5/8] Support for vc4 graphics
driver: upgrade 4.4 kernel to 4.4.10

On Thu, May 19, 2016 at 08:28:00AM +0200, Andreas Müller wrote:
> On Thu, May 19, 2016 at 7:21 AM, Herve Jourdain <herve.jourdain@neuf.fr>
wrote:
> > Hi Andreas,
> >
> > I've been able to do some testing with the latest 4.1 kernel.
> > So it can actually "work" in a way, but both the device tree overlay and
the driver in the kernel are "old".
> > This has an impact on stability: I can definitely start wayland/weston,
and it's "responsive", BUT after I started playing out with the demo
applications, it quickly crashed...
> > So we could either try to backport the newer driver / dt overlay to the
4.1, which could be possible, or we could just support vc4graphics only for
4.4.10+...
> >
> > Since 4.1 is not heavily maintained anymore on github, since 4.4 is now
the default revision on github, and since development branches for 4.5 and
4.6 are already there on github, I would personally be inclined to support
vc4graphics only for 4.4.10+...
> > And I would also be in favor of moving the default version of the kernel
to the 4.4 series...
> >
> > What do you think is the best option there?
> >
> No need to backport to 4.1. 4.4 is fine. One question: are you able to 
> change screen resolution for HDMI monitor (elder sdl fullscreen games 
> need that)? This was not possible for kernel 4.1.
>
> Just to avoid misunderstandings: I like this patch series very much 
> and would be happy to see it applied.
>

Santa heard you.

--
Andrei Gherzan

Re: [meta-raspberrypi][PATCH 2/8] Support for vc4 graphics driver: add vc4-kms-v3d to the overlays

[Herve Jourdain]

Hi Andrei,

While I totally agree with that, the other lines above do not add the
space...
And I've been asked before to not modify the formatting - albeit that was in
a case of spaces replacing tabs, which is slightly different - which is why
I did this way.
Do you want me to do the modification only for my 2 lines, or also for the
other similar lines - while I'm at it...

Herve

-----Original Message-----
From: Andrei Gherzan [mailto:andrei@gherzan.ro] 
Sent: jeudi 19 mai 2016 16:57
To: Herve Jourdain <herve.jourdain@neuf.fr>
Cc: yocto@yoctoproject.org
Subject: Re: [yocto] [meta-raspberrypi][PATCH 2/8] Support for vc4 graphics
driver: add vc4-kms-v3d to the overlays

On Wed, May 18, 2016 at 08:21:16PM +0800, Herve Jourdain wrote:
> This patch series enables the support for the VC4 graphics driver from
Eric Anholt.
> Add vc4-kms-v3d overlay if 'vc4graphics' is in MACHINE_FEATURES.
> (This patch has a dependency on the patch that enables the support of
.dtbo overlay files)
>
> Signed-off-by: Herve Jourdain <herve.jourdain@neuf.fr>
> ---
>  recipes-bsp/bootfiles/rpi-config_git.bb | 8 ++++++++
>  1 file changed, 8 insertions(+)
>
> diff --git a/recipes-bsp/bootfiles/rpi-config_git.bb
b/recipes-bsp/bootfiles/rpi-config_git.bb
> index 4bc8eb7..79e436d 100644
> --- a/recipes-bsp/bootfiles/rpi-config_git.bb
> +++ b/recipes-bsp/bootfiles/rpi-config_git.bb
> @@ -19,6 +19,8 @@ PITFT="${@bb.utils.contains("MACHINE_FEATURES", "pitft",
"1", "0", d)}"
>  PITFT22="${@bb.utils.contains("MACHINE_FEATURES", "pitft22", "1", "0",
d)}"
>  PITFT28r="${@bb.utils.contains("MACHINE_FEATURES", "pitft28r", "1", "0",
d)}"
>
> +VC4GRAPHICS="${@bb.utils.contains("MACHINE_FEATURES", "vc4graphics", "1",
"0", d)}"
> +
>  inherit deploy
>
>  do_deploy() {
> @@ -102,6 +104,12 @@ do_deploy() {
>          echo "# Enable UART" >>${DEPLOYDIR}/bcm2835-bootfiles/config.txt
>          echo "enable_uart=1" >>${DEPLOYDIR}/bcm2835-bootfiles/config.txt
>      fi
> +
> +    # VC4 Graphics support
> +    if [ "${VC4GRAPHICS}" = "1" ]; then
> +        echo "# Enable VC4 Graphics"
>>${DEPLOYDIR}/bcm2835-bootfiles/config.txt
> +        echo "dtoverlay=vc4-kms-v3d,cma-256"
>>${DEPLOYDIR}/bcm2835-bootfiles/config.txt

NIT: space after >>

--
Andrei Gherzan

Re: [meta-raspberrypi][PATCH 2/8] Support for vc4 graphics driver: add vc4-kms-v3d to the overlays

[Andrei Gherzan]

[-- Attachment #1: Type: text/plain, Size: 658 bytes --]

On Fri, May 20, 2016 at 11:14:50AM +0200, Herve Jourdain wrote:
> Hi Andrei,
>
> While I totally agree with that, the other lines above do not add the
> space...
> And I've been asked before to not modify the formatting - albeit that was in
> a case of spaces replacing tabs, which is slightly different - which is why
> I did this way.
> Do you want me to do the modification only for my 2 lines, or also for the
> other similar lines - while I'm at it...
>

Definitely what we have now is not perfect in terms of formatting. But,
if a change touches lines that we can improve in formatting too, I would
definitely do it.
--
Andrei Gherzan

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 836 bytes --]

Re: [meta-raspberrypi][PATCH 5/8] Support for vc4 graphics driver: upgrade 4.4 kernel to 4.4.10

[Andrei Gherzan]

[-- Attachment #1: Type: text/plain, Size: 1652 bytes --]

On Thu, May 19, 2016 at 09:02:04AM -0700, Khem Raj wrote:
> On Thu, May 19, 2016 at 8:11 AM, Andrei Gherzan <andrei@gherzan.ro> wrote:
> > On Wed, May 18, 2016 at 11:46:39PM +0200, Andreas Müller wrote:
> >> On Wed, May 18, 2016 at 7:32 PM, Herve Jourdain <herve.jourdain@neuf.fr> wrote:
> >> > One thing I didn't make configurable, but that maybe could be, is the parameter passed to the overlay.
> >> > I selected cma-256, based on experience from other people, and because my configuration is RPI2/3 with 1G of memory.
> >> > I realize it might not work well with RPI0/1, which have less memory available...
> >> > So even if I believe cma-256 is a good default value, it might be made selectable by the user, if we want to consider vc4 on RPI0/1.
> >> I played around with vc4 to but did not manage to get it work for an
> >> elder version 4.1 of kernel.
> >>
> >> I did in rpi-config:
> >>
> >> CMA_SIZE = "cma-256"
> >> CMA_SIZE_raspberrypi = "cma-64"
>
>
> >
> > I sent reply about this too. This is definitely one solution would I
> > would rather have a CMA_SIZE default value and a python function to
> > check its match with board variant. Cause in this way a user might be
> > able to use cma-96 on rapsberrypi.
> >
> >> CMA_SIZE_raspberrypi0 = "cma-128"
>
>
> setting CMA_SIZE should be moved into machine.conf file IMO
>

That's actually a good idea. I would say to have it in machine as a
default value for that specific machine. And then be able to overwrite
it as user needs. Optionally have a python function to check that what
user requested makes sense for the selected board.

--
Andrei Gherzan

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 836 bytes --]

Re: ***SPAM*** Re: [meta-raspberrypi][PATCH 5/8] Support for vc4 graphics driver: upgrade 4.4 kernel to 4.4.10

[Herve Jourdain]

Hi Andrei, Khem,

That's what I implemented in the upcoming v2 - except for the python
checking function part.
One thing, shall I call the variable CMA_SIZE, or VC4_CMA_SIZE?
I know CMA is kind of common, but we're using this only to trigger a
parameter to the v4c overlay.
Any opinion? (in the current implementation, I went with CMA_SIZE, but I
have doubts...)

Herve

-----Original Message-----
From: yocto-bounces@yoctoproject.org [mailto:yocto-bounces@yoctoproject.org]
On Behalf Of Andrei Gherzan
Sent: vendredi 20 mai 2016 12:40
To: Khem Raj <raj.khem@gmail.com>
Cc: Yocto Project <yocto@yoctoproject.org>
Subject: ***SPAM*** Re: [yocto] [meta-raspberrypi][PATCH 5/8] Support for
vc4 graphics driver: upgrade 4.4 kernel to 4.4.10

On Thu, May 19, 2016 at 09:02:04AM -0700, Khem Raj wrote:
> On Thu, May 19, 2016 at 8:11 AM, Andrei Gherzan <andrei@gherzan.ro> wrote:
> > On Wed, May 18, 2016 at 11:46:39PM +0200, Andreas Müller wrote:
> >> On Wed, May 18, 2016 at 7:32 PM, Herve Jourdain
<herve.jourdain@neuf.fr> wrote:
> >> > One thing I didn't make configurable, but that maybe could be, is the
parameter passed to the overlay.
> >> > I selected cma-256, based on experience from other people, and
because my configuration is RPI2/3 with 1G of memory.
> >> > I realize it might not work well with RPI0/1, which have less memory
available...
> >> > So even if I believe cma-256 is a good default value, it might be
made selectable by the user, if we want to consider vc4 on RPI0/1.
> >> I played around with vc4 to but did not manage to get it work for 
> >> an elder version 4.1 of kernel.
> >>
> >> I did in rpi-config:
> >>
> >> CMA_SIZE = "cma-256"
> >> CMA_SIZE_raspberrypi = "cma-64"
>
>
> >
> > I sent reply about this too. This is definitely one solution would I 
> > would rather have a CMA_SIZE default value and a python function to 
> > check its match with board variant. Cause in this way a user might 
> > be able to use cma-96 on rapsberrypi.
> >
> >> CMA_SIZE_raspberrypi0 = "cma-128"
>
>
> setting CMA_SIZE should be moved into machine.conf file IMO
>

That's actually a good idea. I would say to have it in machine as a default
value for that specific machine. And then be able to overwrite it as user
needs. Optionally have a python function to check that what user requested
makes sense for the selected board.

--
Andrei Gherzan

Re: ***SPAM*** Re: [meta-raspberrypi][PATCH 5/8] Support for vc4 graphics driver: upgrade 4.4 kernel to 4.4.10

[Andrei Gherzan]

[-- Attachment #1: Type: text/plain, Size: 625 bytes --]

On Fri, May 20, 2016 at 12:47:40PM +0200, Herve Jourdain wrote:
> Hi Andrei, Khem,
>
> That's what I implemented in the upcoming v2 - except for the python
> checking function part.
> One thing, shall I call the variable CMA_SIZE, or VC4_CMA_SIZE?
> I know CMA is kind of common, but we're using this only to trigger a
> parameter to the v4c overlay.
> Any opinion? (in the current implementation, I went with CMA_SIZE, but I
> have doubts...)
>

Hint: Try to reply in line if possible. It is easier to follow the
discussion in this way.

I would vote for VC4_CMA_SIZE. It sounds safer.

--
Andrei Gherzan

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 836 bytes --]

Re: ***SPAM*** Re: [meta-raspberrypi][PATCH 5/8] Support for vc4 graphics driver: upgrade 4.4 kernel to 4.4.10

[Khem Raj]

On Fri, May 20, 2016 at 3:51 AM, Andrei Gherzan <andrei@gherzan.ro> wrote:
> On Fri, May 20, 2016 at 12:47:40PM +0200, Herve Jourdain wrote:
>> Hi Andrei, Khem,
>>
>> That's what I implemented in the upcoming v2 - except for the python
>> checking function part.
>> One thing, shall I call the variable CMA_SIZE, or VC4_CMA_SIZE?
>> I know CMA is kind of common, but we're using this only to trigger a
>> parameter to the v4c overlay.
>> Any opinion? (in the current implementation, I went with CMA_SIZE, but I
>> have doubts...)
>>
>
> Hint: Try to reply in line if possible. It is easier to follow the
> discussion in this way.
>
> I would vote for VC4_CMA_SIZE. It sounds safer.

yes

>
> --
> Andrei Gherzan