* [PATCH v2 3/4] Staging: comedi:Fix unsigned int to bare use of unsigned issue in s626.c
@ 2016-05-20 6:22 Ravishankar Karkala Mallikarjunayya
2016-05-20 10:14 ` Ian Abbott
0 siblings, 1 reply; 5+ messages in thread
From: Ravishankar Karkala Mallikarjunayya @ 2016-05-20 6:22 UTC (permalink / raw)
To: abbotti, hsweeten, gregkh
Cc: devel, linux-kernel, Ravishankar Karkala Mallikarjunayya
This is a patch to the s626.c file that fixes up a
WARNING: Prefer 'unsigned int' to bare use of 'unsigned'
found by the checkpatch.pl tool
Signed-off-by: Ravishankar Karkala Mallikarjunayya <ravishankarkm32@gmail.com>
---
Changes since V1:
- No change
---
drivers/staging/comedi/drivers/s626.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/drivers/staging/comedi/drivers/s626.c b/drivers/staging/comedi/drivers/s626.c
index 723504b..1d663a0 100644
--- a/drivers/staging/comedi/drivers/s626.c
+++ b/drivers/staging/comedi/drivers/s626.c
@@ -728,7 +728,7 @@ static uint16_t s626_get_mode_a(struct comedi_device *dev,
u16 cra;
u16 crb;
u16 setup;
- unsigned cntsrc, clkmult, clkpol, encmode;
+ unsigned int cntsrc, clkmult, clkpol, encmode;
/* Fetch CRA and CRB register images. */
cra = s626_debi_read(dev, S626_LP_CRA(chan));
@@ -783,7 +783,7 @@ static uint16_t s626_get_mode_b(struct comedi_device *dev,
u16 cra;
u16 crb;
u16 setup;
- unsigned cntsrc, clkmult, clkpol, encmode;
+ unsigned int cntsrc, clkmult, clkpol, encmode;
/* Fetch CRA and CRB register images. */
cra = s626_debi_read(dev, S626_LP_CRA(chan));
@@ -858,7 +858,7 @@ static void s626_set_mode_a(struct comedi_device *dev,
struct s626_private *devpriv = dev->private;
u16 cra;
u16 crb;
- unsigned cntsrc, clkmult, clkpol;
+ unsigned int cntsrc, clkmult, clkpol;
/* Initialize CRA and CRB images. */
/* Preload trigger is passed through. */
@@ -936,7 +936,7 @@ static void s626_set_mode_b(struct comedi_device *dev,
struct s626_private *devpriv = dev->private;
u16 cra;
u16 crb;
- unsigned cntsrc, clkmult, clkpol;
+ unsigned int cntsrc, clkmult, clkpol;
/* Initialize CRA and CRB images. */
/* IndexSrc is passed through. */
--
1.9.1
^ permalink raw reply related [flat|nested] 5+ messages in thread
* Re: [PATCH v2 3/4] Staging: comedi:Fix unsigned int to bare use of unsigned issue in s626.c
2016-05-20 6:22 [PATCH v2 3/4] Staging: comedi:Fix unsigned int to bare use of unsigned issue in s626.c Ravishankar Karkala Mallikarjunayya
@ 2016-05-20 10:14 ` Ian Abbott
0 siblings, 0 replies; 5+ messages in thread
From: Ian Abbott @ 2016-05-20 10:14 UTC (permalink / raw)
To: Ravishankar Karkala Mallikarjunayya, hsweeten, gregkh; +Cc: devel, linux-kernel
On 20/05/16 07:22, Ravishankar Karkala Mallikarjunayya wrote:
> This is a patch to the s626.c file that fixes up a
> WARNING: Prefer 'unsigned int' to bare use of 'unsigned'
> found by the checkpatch.pl tool
>
> Signed-off-by: Ravishankar Karkala Mallikarjunayya <ravishankarkm32@gmail.com>
> ---
> Changes since V1:
> - No change
> ---
> drivers/staging/comedi/drivers/s626.c | 8 ++++----
> 1 file changed, 4 insertions(+), 4 deletions(-)
>
Thanks!
Reviewed-by: Ian Abbott <abbotti@mev.co.uk>
--
-=( Ian Abbott @ MEV Ltd. E-mail: <abbotti@mev.co.uk> )=-
-=( Web: http://www.mev.co.uk/ )=-
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH v2 3/4] Staging: comedi:Fix unsigned int to bare use of unsigned issue in s626.c
2016-05-28 5:26 ` [PATCH v2 3/4] Staging: comedi:Fix unsigned int to bare use of unsigned issue " Ravishankar Karkala Mallikarjunayya
2016-05-30 14:15 ` Luis de Bethencourt
@ 2016-05-31 10:31 ` Ian Abbott
1 sibling, 0 replies; 5+ messages in thread
From: Ian Abbott @ 2016-05-31 10:31 UTC (permalink / raw)
To: Ravishankar Karkala Mallikarjunayya, hsweeten, gregkh; +Cc: devel, linux-kernel
On 28/05/16 06:26, Ravishankar Karkala Mallikarjunayya wrote:
> This is a patch to the s626.c file that fixes up a
> WARNING: Prefer 'unsigned int' to bare use of 'unsigned'
> found by the checkpatch.pl tool
>
> Signed-off-by: Ravishankar Karkala Mallikarjunayya <ravishankarkm32@gmail.com>
> ---
> changes since v1: No change
> ---
> drivers/staging/comedi/drivers/s626.c | 8 ++++----
> 1 file changed, 4 insertions(+), 4 deletions(-)
>
Thanks!
Reviewed-by: Ian Abbott <abbotti@mev.co.uk>
--
-=( Ian Abbott @ MEV Ltd. E-mail: <abbotti@mev.co.uk> )=-
-=( Web: http://www.mev.co.uk/ )=-
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH v2 3/4] Staging: comedi:Fix unsigned int to bare use of unsigned issue in s626.c
2016-05-28 5:26 ` [PATCH v2 3/4] Staging: comedi:Fix unsigned int to bare use of unsigned issue " Ravishankar Karkala Mallikarjunayya
@ 2016-05-30 14:15 ` Luis de Bethencourt
2016-05-31 10:31 ` Ian Abbott
1 sibling, 0 replies; 5+ messages in thread
From: Luis de Bethencourt @ 2016-05-30 14:15 UTC (permalink / raw)
To: Ravishankar Karkala Mallikarjunayya, abbotti, hsweeten, gregkh
Cc: devel, linux-kernel
On 28/05/16 06:26, Ravishankar Karkala Mallikarjunayya wrote:
> This is a patch to the s626.c file that fixes up a
> WARNING: Prefer 'unsigned int' to bare use of 'unsigned'
> found by the checkpatch.pl tool
>
> Signed-off-by: Ravishankar Karkala Mallikarjunayya <ravishankarkm32@gmail.com>
The patch looks good :) adding the int makes it more verbose.
Just the same comment as the previous patch, we can see in the diff which file
is affected by this. You can just say:
"This fixes a WARNING: Prefer 'unsigned int' ..."
Thanks,
Luis
^ permalink raw reply [flat|nested] 5+ messages in thread
* [PATCH v2 3/4] Staging: comedi:Fix unsigned int to bare use of unsigned issue in s626.c
2016-05-28 5:26 [PATCH v2 1/4] staging : comedi : fix type issues " Ravishankar Karkala Mallikarjunayya
@ 2016-05-28 5:26 ` Ravishankar Karkala Mallikarjunayya
2016-05-30 14:15 ` Luis de Bethencourt
2016-05-31 10:31 ` Ian Abbott
0 siblings, 2 replies; 5+ messages in thread
From: Ravishankar Karkala Mallikarjunayya @ 2016-05-28 5:26 UTC (permalink / raw)
To: abbotti, hsweeten, gregkh
Cc: devel, linux-kernel, Ravishankar Karkala Mallikarjunayya
This is a patch to the s626.c file that fixes up a
WARNING: Prefer 'unsigned int' to bare use of 'unsigned'
found by the checkpatch.pl tool
Signed-off-by: Ravishankar Karkala Mallikarjunayya <ravishankarkm32@gmail.com>
---
changes since v1: No change
---
drivers/staging/comedi/drivers/s626.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/drivers/staging/comedi/drivers/s626.c b/drivers/staging/comedi/drivers/s626.c
index edcd466..790ca41 100644
--- a/drivers/staging/comedi/drivers/s626.c
+++ b/drivers/staging/comedi/drivers/s626.c
@@ -728,7 +728,7 @@ static u16 s626_get_mode_a(struct comedi_device *dev,
u16 cra;
u16 crb;
u16 setup;
- unsigned cntsrc, clkmult, clkpol, encmode;
+ unsigned int cntsrc, clkmult, clkpol, encmode;
/* Fetch CRA and CRB register images. */
cra = s626_debi_read(dev, S626_LP_CRA(chan));
@@ -783,7 +783,7 @@ static u16 s626_get_mode_b(struct comedi_device *dev,
u16 cra;
u16 crb;
u16 setup;
- unsigned cntsrc, clkmult, clkpol, encmode;
+ unsigned int cntsrc, clkmult, clkpol, encmode;
/* Fetch CRA and CRB register images. */
cra = s626_debi_read(dev, S626_LP_CRA(chan));
@@ -858,7 +858,7 @@ static void s626_set_mode_a(struct comedi_device *dev,
struct s626_private *devpriv = dev->private;
u16 cra;
u16 crb;
- unsigned cntsrc, clkmult, clkpol;
+ unsigned int cntsrc, clkmult, clkpol;
/* Initialize CRA and CRB images. */
/* Preload trigger is passed through. */
@@ -936,7 +936,7 @@ static void s626_set_mode_b(struct comedi_device *dev,
struct s626_private *devpriv = dev->private;
u16 cra;
u16 crb;
- unsigned cntsrc, clkmult, clkpol;
+ unsigned int cntsrc, clkmult, clkpol;
/* Initialize CRA and CRB images. */
/* IndexSrc is passed through. */
--
1.9.1
^ permalink raw reply related [flat|nested] 5+ messages in thread
end of thread, other threads:[~2016-05-31 10:31 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2016-05-20 6:22 [PATCH v2 3/4] Staging: comedi:Fix unsigned int to bare use of unsigned issue in s626.c Ravishankar Karkala Mallikarjunayya
2016-05-20 10:14 ` Ian Abbott
2016-05-28 5:26 [PATCH v2 1/4] staging : comedi : fix type issues " Ravishankar Karkala Mallikarjunayya
2016-05-28 5:26 ` [PATCH v2 3/4] Staging: comedi:Fix unsigned int to bare use of unsigned issue " Ravishankar Karkala Mallikarjunayya
2016-05-30 14:15 ` Luis de Bethencourt
2016-05-31 10:31 ` Ian Abbott
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.