* [PATCH V3] vfio: platform: support No-IOMMU mode
@ 2016-05-23 9:47 Peng Fan
2016-06-12 9:02 ` Peng Fan
2016-06-13 13:20 ` Auger Eric
0 siblings, 2 replies; 4+ messages in thread
From: Peng Fan @ 2016-05-23 9:47 UTC (permalink / raw)
To: eric.auger, b.reynal, alex.williamson; +Cc: kvm, linux-kernel, van.freenix
The vfio No-IOMMU mode was supported by this
'commit 03a76b60f8ba2797 ("vfio: Include No-IOMMU mode")',
but it only support vfio-pci.
Using vfio_iommu_group_get/put, but not iommu_group_get/put,
the platform devices can be exposed to userspace with
CONFIG_VFIO_NOIOMMU and the "enable_unsafe_noiommu_mode"
option enabled.
>From 'commit 03a76b60f8ba2797 ("vfio: Include No-IOMMU mode")',
"This should make it very clear that this mode is not safe.
Additionally, CAP_SYS_RAWIO privileges are necessary to work
with groups and containers using this mode. Groups making
use of this support are named /dev/vfio/noiommu-$GROUP and
can only make use of the special VFIO_NOIOMMU_IOMMU for the
container. Use of this mode, specifically binding a device
without a native IOMMU group to a VFIO bus driver will taint
the kernel and should therefore not be considered supported."
Signed-off-by: Peng Fan <van.freenix@gmail.com>
Cc: Eric Auger <eric.auger@linaro.org>
Cc: Baptiste Reynal <b.reynal@virtualopensystems.com>
Cc: Alex Williamson <alex.williamson@redhat.com>
---
V3:
The platform device can be programmed to do DMA without
caring out mmap + VFIO_IOMMU_MAP_DMA which are not
support by noiommu. So drop the last sentence of commit log
in V2, which is misleading.
V2:
Rename subject to support No-IOMMU
Add more commit log.
I wrote a simple program following this
https://github.com/virtualopensystems/vfio-host-test/blob/master/src_test/vfio_device_test.c
,no dma support. The device's register can be
accessed in userspace using command './vfio_dev_test 30b60000.usdhc 0 1 platform'
drivers/vfio/platform/vfio_platform_common.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/drivers/vfio/platform/vfio_platform_common.c b/drivers/vfio/platform/vfio_platform_common.c
index e65b142..993b2f9 100644
--- a/drivers/vfio/platform/vfio_platform_common.c
+++ b/drivers/vfio/platform/vfio_platform_common.c
@@ -561,7 +561,7 @@ int vfio_platform_probe_common(struct vfio_platform_device *vdev,
vdev->device = dev;
- group = iommu_group_get(dev);
+ group = vfio_iommu_group_get(dev);
if (!group) {
pr_err("VFIO: No IOMMU group for device %s\n", vdev->name);
return -EINVAL;
@@ -569,7 +569,7 @@ int vfio_platform_probe_common(struct vfio_platform_device *vdev,
ret = vfio_add_group_dev(dev, &vfio_platform_ops, vdev);
if (ret) {
- iommu_group_put(group);
+ vfio_iommu_group_put(group, dev);
return ret;
}
@@ -589,7 +589,7 @@ struct vfio_platform_device *vfio_platform_remove_common(struct device *dev)
if (vdev) {
vfio_platform_put_reset(vdev);
- iommu_group_put(dev->iommu_group);
+ vfio_iommu_group_put(dev->iommu_group, dev);
}
return vdev;
--
2.6.2
^ permalink raw reply related [flat|nested] 4+ messages in thread* Re: [PATCH V3] vfio: platform: support No-IOMMU mode
2016-05-23 9:47 [PATCH V3] vfio: platform: support No-IOMMU mode Peng Fan
@ 2016-06-12 9:02 ` Peng Fan
2016-06-23 19:05 ` Alex Williamson
2016-06-13 13:20 ` Auger Eric
1 sibling, 1 reply; 4+ messages in thread
From: Peng Fan @ 2016-06-12 9:02 UTC (permalink / raw)
To: eric.auger, b.reynal, alex.williamson; +Cc: kvm, linux-kernel
Hi,
Kindly ping.. Any comments on V3?
Thanks,
Peng.
On Mon, May 23, 2016 at 05:47:30PM +0800, Peng Fan wrote:
>The vfio No-IOMMU mode was supported by this
>'commit 03a76b60f8ba2797 ("vfio: Include No-IOMMU mode")',
>but it only support vfio-pci.
>
>Using vfio_iommu_group_get/put, but not iommu_group_get/put,
>the platform devices can be exposed to userspace with
>CONFIG_VFIO_NOIOMMU and the "enable_unsafe_noiommu_mode"
>option enabled.
>
>From 'commit 03a76b60f8ba2797 ("vfio: Include No-IOMMU mode")',
>"This should make it very clear that this mode is not safe.
>Additionally, CAP_SYS_RAWIO privileges are necessary to work
>with groups and containers using this mode. Groups making
>use of this support are named /dev/vfio/noiommu-$GROUP and
>can only make use of the special VFIO_NOIOMMU_IOMMU for the
>container. Use of this mode, specifically binding a device
>without a native IOMMU group to a VFIO bus driver will taint
>the kernel and should therefore not be considered supported."
>
>Signed-off-by: Peng Fan <van.freenix@gmail.com>
>Cc: Eric Auger <eric.auger@linaro.org>
>Cc: Baptiste Reynal <b.reynal@virtualopensystems.com>
>Cc: Alex Williamson <alex.williamson@redhat.com>
>---
>
>V3:
> The platform device can be programmed to do DMA without
> caring out mmap + VFIO_IOMMU_MAP_DMA which are not
> support by noiommu. So drop the last sentence of commit log
> in V2, which is misleading.
>
>V2:
> Rename subject to support No-IOMMU
> Add more commit log.
> I wrote a simple program following this
> https://github.com/virtualopensystems/vfio-host-test/blob/master/src_test/vfio_device_test.c
> ,no dma support. The device's register can be
> accessed in userspace using command './vfio_dev_test 30b60000.usdhc 0 1 platform'
>
> drivers/vfio/platform/vfio_platform_common.c | 6 +++---
> 1 file changed, 3 insertions(+), 3 deletions(-)
>
>diff --git a/drivers/vfio/platform/vfio_platform_common.c b/drivers/vfio/platform/vfio_platform_common.c
>index e65b142..993b2f9 100644
>--- a/drivers/vfio/platform/vfio_platform_common.c
>+++ b/drivers/vfio/platform/vfio_platform_common.c
>@@ -561,7 +561,7 @@ int vfio_platform_probe_common(struct vfio_platform_device *vdev,
>
> vdev->device = dev;
>
>- group = iommu_group_get(dev);
>+ group = vfio_iommu_group_get(dev);
> if (!group) {
> pr_err("VFIO: No IOMMU group for device %s\n", vdev->name);
> return -EINVAL;
>@@ -569,7 +569,7 @@ int vfio_platform_probe_common(struct vfio_platform_device *vdev,
>
> ret = vfio_add_group_dev(dev, &vfio_platform_ops, vdev);
> if (ret) {
>- iommu_group_put(group);
>+ vfio_iommu_group_put(group, dev);
> return ret;
> }
>
>@@ -589,7 +589,7 @@ struct vfio_platform_device *vfio_platform_remove_common(struct device *dev)
>
> if (vdev) {
> vfio_platform_put_reset(vdev);
>- iommu_group_put(dev->iommu_group);
>+ vfio_iommu_group_put(dev->iommu_group, dev);
> }
>
> return vdev;
>--
>2.6.2
>
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [PATCH V3] vfio: platform: support No-IOMMU mode
2016-06-12 9:02 ` Peng Fan
@ 2016-06-23 19:05 ` Alex Williamson
0 siblings, 0 replies; 4+ messages in thread
From: Alex Williamson @ 2016-06-23 19:05 UTC (permalink / raw)
To: Peng Fan; +Cc: eric.auger, b.reynal, kvm, linux-kernel
On Sun, 12 Jun 2016 17:02:00 +0800
Peng Fan <van.freenix@gmail.com> wrote:
> Hi,
>
> Kindly ping.. Any comments on V3?
>
> Thanks,
> Peng.
> On Mon, May 23, 2016 at 05:47:30PM +0800, Peng Fan wrote:
> >The vfio No-IOMMU mode was supported by this
> >'commit 03a76b60f8ba2797 ("vfio: Include No-IOMMU mode")',
> >but it only support vfio-pci.
> >
> >Using vfio_iommu_group_get/put, but not iommu_group_get/put,
> >the platform devices can be exposed to userspace with
> >CONFIG_VFIO_NOIOMMU and the "enable_unsafe_noiommu_mode"
> >option enabled.
> >
> >From 'commit 03a76b60f8ba2797 ("vfio: Include No-IOMMU mode")',
> >"This should make it very clear that this mode is not safe.
> >Additionally, CAP_SYS_RAWIO privileges are necessary to work
> >with groups and containers using this mode. Groups making
> >use of this support are named /dev/vfio/noiommu-$GROUP and
> >can only make use of the special VFIO_NOIOMMU_IOMMU for the
> >container. Use of this mode, specifically binding a device
> >without a native IOMMU group to a VFIO bus driver will taint
> >the kernel and should therefore not be considered supported."
> >
> >Signed-off-by: Peng Fan <van.freenix@gmail.com>
> >Cc: Eric Auger <eric.auger@linaro.org>
> >Cc: Baptiste Reynal <b.reynal@virtualopensystems.com>
> >Cc: Alex Williamson <alex.williamson@redhat.com>
> >---
Applied with Eric's R-b to next branch for v4.8. Thanks!
Alex
> >
> >V3:
> > The platform device can be programmed to do DMA without
> > caring out mmap + VFIO_IOMMU_MAP_DMA which are not
> > support by noiommu. So drop the last sentence of commit log
> > in V2, which is misleading.
> >
> >V2:
> > Rename subject to support No-IOMMU
> > Add more commit log.
> > I wrote a simple program following this
> > https://github.com/virtualopensystems/vfio-host-test/blob/master/src_test/vfio_device_test.c
> > ,no dma support. The device's register can be
> > accessed in userspace using command './vfio_dev_test 30b60000.usdhc 0 1 platform'
> >
> > drivers/vfio/platform/vfio_platform_common.c | 6 +++---
> > 1 file changed, 3 insertions(+), 3 deletions(-)
> >
> >diff --git a/drivers/vfio/platform/vfio_platform_common.c b/drivers/vfio/platform/vfio_platform_common.c
> >index e65b142..993b2f9 100644
> >--- a/drivers/vfio/platform/vfio_platform_common.c
> >+++ b/drivers/vfio/platform/vfio_platform_common.c
> >@@ -561,7 +561,7 @@ int vfio_platform_probe_common(struct vfio_platform_device *vdev,
> >
> > vdev->device = dev;
> >
> >- group = iommu_group_get(dev);
> >+ group = vfio_iommu_group_get(dev);
> > if (!group) {
> > pr_err("VFIO: No IOMMU group for device %s\n", vdev->name);
> > return -EINVAL;
> >@@ -569,7 +569,7 @@ int vfio_platform_probe_common(struct vfio_platform_device *vdev,
> >
> > ret = vfio_add_group_dev(dev, &vfio_platform_ops, vdev);
> > if (ret) {
> >- iommu_group_put(group);
> >+ vfio_iommu_group_put(group, dev);
> > return ret;
> > }
> >
> >@@ -589,7 +589,7 @@ struct vfio_platform_device *vfio_platform_remove_common(struct device *dev)
> >
> > if (vdev) {
> > vfio_platform_put_reset(vdev);
> >- iommu_group_put(dev->iommu_group);
> >+ vfio_iommu_group_put(dev->iommu_group, dev);
> > }
> >
> > return vdev;
> >--
> >2.6.2
> >
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH V3] vfio: platform: support No-IOMMU mode
2016-05-23 9:47 [PATCH V3] vfio: platform: support No-IOMMU mode Peng Fan
2016-06-12 9:02 ` Peng Fan
@ 2016-06-13 13:20 ` Auger Eric
1 sibling, 0 replies; 4+ messages in thread
From: Auger Eric @ 2016-06-13 13:20 UTC (permalink / raw)
To: Peng Fan, eric.auger, b.reynal, alex.williamson; +Cc: kvm, linux-kernel
Hi Peng
Le 23/05/2016 à 11:47, Peng Fan a écrit :
> The vfio No-IOMMU mode was supported by this
> 'commit 03a76b60f8ba2797 ("vfio: Include No-IOMMU mode")',
> but it only support vfio-pci.
>
> Using vfio_iommu_group_get/put, but not iommu_group_get/put,
> the platform devices can be exposed to userspace with
> CONFIG_VFIO_NOIOMMU and the "enable_unsafe_noiommu_mode"
> option enabled.
>
> From 'commit 03a76b60f8ba2797 ("vfio: Include No-IOMMU mode")',
> "This should make it very clear that this mode is not safe.
> Additionally, CAP_SYS_RAWIO privileges are necessary to work
> with groups and containers using this mode. Groups making
> use of this support are named /dev/vfio/noiommu-$GROUP and
> can only make use of the special VFIO_NOIOMMU_IOMMU for the
> container. Use of this mode, specifically binding a device
> without a native IOMMU group to a VFIO bus driver will taint
> the kernel and should therefore not be considered supported."
>
> Signed-off-by: Peng Fan <van.freenix@gmail.com>
> Cc: Eric Auger <eric.auger@linaro.org>
> Cc: Baptiste Reynal <b.reynal@virtualopensystems.com>
> Cc: Alex Williamson <alex.williamson@redhat.com>
Looks good to me.
Reviewed-by: Eric Auger <eric.auger@redhat.com>
as a reminder may conflict with HiDma ACPI reset series.
Best Regards
Eric
> ---
>
> V3:
> The platform device can be programmed to do DMA without
> caring out mmap + VFIO_IOMMU_MAP_DMA which are not
> support by noiommu. So drop the last sentence of commit log
> in V2, which is misleading.
>
> V2:
> Rename subject to support No-IOMMU
> Add more commit log.
> I wrote a simple program following this
> https://github.com/virtualopensystems/vfio-host-test/blob/master/src_test/vfio_device_test.c
> ,no dma support. The device's register can be
> accessed in userspace using command './vfio_dev_test 30b60000.usdhc 0 1 platform'
>
> drivers/vfio/platform/vfio_platform_common.c | 6 +++---
> 1 file changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/vfio/platform/vfio_platform_common.c b/drivers/vfio/platform/vfio_platform_common.c
> index e65b142..993b2f9 100644
> --- a/drivers/vfio/platform/vfio_platform_common.c
> +++ b/drivers/vfio/platform/vfio_platform_common.c
> @@ -561,7 +561,7 @@ int vfio_platform_probe_common(struct vfio_platform_device *vdev,
>
> vdev->device = dev;
>
> - group = iommu_group_get(dev);
> + group = vfio_iommu_group_get(dev);
> if (!group) {
> pr_err("VFIO: No IOMMU group for device %s\n", vdev->name);
> return -EINVAL;
> @@ -569,7 +569,7 @@ int vfio_platform_probe_common(struct vfio_platform_device *vdev,
>
> ret = vfio_add_group_dev(dev, &vfio_platform_ops, vdev);
> if (ret) {
> - iommu_group_put(group);
> + vfio_iommu_group_put(group, dev);
> return ret;
> }
>
> @@ -589,7 +589,7 @@ struct vfio_platform_device *vfio_platform_remove_common(struct device *dev)
>
> if (vdev) {
> vfio_platform_put_reset(vdev);
> - iommu_group_put(dev->iommu_group);
> + vfio_iommu_group_put(dev->iommu_group, dev);
> }
>
> return vdev;
>
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2016-06-23 19:05 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2016-05-23 9:47 [PATCH V3] vfio: platform: support No-IOMMU mode Peng Fan
2016-06-12 9:02 ` Peng Fan
2016-06-23 19:05 ` Alex Williamson
2016-06-13 13:20 ` Auger Eric
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.