* [PATCH v2 1/2] ethdev: add callback to get register size in bytes
@ 2016-05-30 9:39 zr
2016-05-30 10:58 ` Panu Matilainen
0 siblings, 1 reply; 4+ messages in thread
From: zr @ 2016-05-30 9:39 UTC (permalink / raw)
To: zr; +Cc: dev
From: Zyta Szpak <zr@semihalf.com>
Version 2 of fixing the fixed register width assumption.
rte_eth_dev_get_reg_length and rte_eth_dev_get_reg callbacks
do not provide register size to the app in any way. It is
needed to allocate proper number of bytes before retrieving
registers content with rte_eth_dev_get_reg.
Signed-off-by: Zyta Szpak <zr@semihalf.com>
---
lib/librte_ether/rte_ethdev.c | 12 ++++++++++++
lib/librte_ether/rte_ethdev.h | 18 ++++++++++++++++++
lib/librte_ether/rte_ether_version.map | 1 +
3 files changed, 31 insertions(+)
diff --git a/lib/librte_ether/rte_ethdev.c b/lib/librte_ether/rte_ethdev.c
index a31018e..e0765f8 100644
--- a/lib/librte_ether/rte_ethdev.c
+++ b/lib/librte_ether/rte_ethdev.c
@@ -3231,6 +3231,18 @@ rte_eth_dev_get_reg_length(uint8_t port_id)
}
int
+rte_eth_dev_get_reg_width(uint8_t port_id)
+{
+ struct rte_eth_dev *dev;
+
+ RTE_ETH_VALID_PORTID_OR_ERR_RET(port_id, -ENODEV);
+
+ dev = &rte_eth_devices[port_id];
+ RTE_FUNC_PTR_OR_ERR_RET(*dev->dev_ops->get_reg_width, -ENOTSUP);
+ return (*dev->dev_ops->get_reg_width)(dev);
+}
+
+int
rte_eth_dev_get_reg_info(uint8_t port_id, struct rte_dev_reg_info *info)
{
struct rte_eth_dev *dev;
diff --git a/lib/librte_ether/rte_ethdev.h b/lib/librte_ether/rte_ethdev.h
index 2757510..552eaed 100644
--- a/lib/librte_ether/rte_ethdev.h
+++ b/lib/librte_ether/rte_ethdev.h
@@ -1292,6 +1292,9 @@ typedef int (*eth_timesync_write_time)(struct rte_eth_dev *dev,
typedef int (*eth_get_reg_length_t)(struct rte_eth_dev *dev);
/**< @internal Retrieve device register count */
+typedef int (*eth_get_reg_width_t)(struct rte_eth_dev *dev);
+/**< @internal Retrieve device register byte number */
+
typedef int (*eth_get_reg_t)(struct rte_eth_dev *dev,
struct rte_dev_reg_info *info);
/**< @internal Retrieve registers */
@@ -1455,6 +1458,8 @@ struct eth_dev_ops {
eth_get_reg_length_t get_reg_length;
/**< Get # of registers */
+ eth_get_reg_width_t get_reg_width;
+ /**< Get # of bytes in register */
eth_get_reg_t get_reg;
/**< Get registers */
eth_get_eeprom_length_t get_eeprom_length;
@@ -3971,6 +3976,19 @@ int rte_eth_tx_queue_info_get(uint8_t port_id, uint16_t queue_id,
*/
int rte_eth_dev_get_reg_length(uint8_t port_id);
+/*
+ * Retrieve the number of bytes in register for a specific device
+ *
+ * @param port_id
+ * The port identifier of the Ethernet device.
+ * @return
+ * - (>=0) number of registers if successful.
+ * - (-ENOTSUP) if hardware doesn't support.
+ * - (-ENODEV) if *port_id* invalid.
+ * - others depends on the specific operations implementation.
+ */
+int rte_eth_dev_get_reg_width(uint8_t port_id);
+
/**
* Retrieve device registers and register attributes
*
diff --git a/lib/librte_ether/rte_ether_version.map b/lib/librte_ether/rte_ether_version.map
index 214ecc7..288bc63 100644
--- a/lib/librte_ether/rte_ether_version.map
+++ b/lib/librte_ether/rte_ether_version.map
@@ -130,5 +130,6 @@ DPDK_16.04 {
rte_eth_tx_buffer_drop_callback;
rte_eth_tx_buffer_init;
rte_eth_tx_buffer_set_err_callback;
+ rte_eth_dev_get_reg_width;
} DPDK_2.2;
--
1.9.1
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH v2 1/2] ethdev: add callback to get register size in bytes
2016-05-30 9:39 [PATCH v2 1/2] ethdev: add callback to get register size in bytes zr
@ 2016-05-30 10:58 ` Panu Matilainen
2016-05-31 15:08 ` Zyta Szpak
0 siblings, 1 reply; 4+ messages in thread
From: Panu Matilainen @ 2016-05-30 10:58 UTC (permalink / raw)
To: zr; +Cc: dev
On 05/30/2016 12:39 PM, zr@semihalf.com wrote:
> From: Zyta Szpak <zr@semihalf.com>
>
> Version 2 of fixing the fixed register width assumption.
> rte_eth_dev_get_reg_length and rte_eth_dev_get_reg callbacks
> do not provide register size to the app in any way. It is
> needed to allocate proper number of bytes before retrieving
> registers content with rte_eth_dev_get_reg.
>
> Signed-off-by: Zyta Szpak <zr@semihalf.com>
[...]
> diff --git a/lib/librte_ether/rte_ether_version.map b/lib/librte_ether/rte_ether_version.map
> index 214ecc7..288bc63 100644
> --- a/lib/librte_ether/rte_ether_version.map
> +++ b/lib/librte_ether/rte_ether_version.map
> @@ -130,5 +130,6 @@ DPDK_16.04 {
> rte_eth_tx_buffer_drop_callback;
> rte_eth_tx_buffer_init;
> rte_eth_tx_buffer_set_err_callback;
> + rte_eth_dev_get_reg_width;
>
> } DPDK_2.2;
This symbol did not exist in DPDK 16.04 so it must not be added there.
Add a new section for 16.07 which inherits from DPDK_16.04.
- Panu -
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH v2 1/2] ethdev: add callback to get register size in bytes
2016-05-30 10:58 ` Panu Matilainen
@ 2016-05-31 15:08 ` Zyta Szpak
0 siblings, 0 replies; 4+ messages in thread
From: Zyta Szpak @ 2016-05-31 15:08 UTC (permalink / raw)
To: Panu Matilainen; +Cc: dev
On 30.05.2016 12:58, Panu Matilainen wrote:
> On 05/30/2016 12:39 PM, zr@semihalf.com wrote:
>> From: Zyta Szpak <zr@semihalf.com>
>>
>> Version 2 of fixing the fixed register width assumption.
>> rte_eth_dev_get_reg_length and rte_eth_dev_get_reg callbacks
>> do not provide register size to the app in any way. It is
>> needed to allocate proper number of bytes before retrieving
>> registers content with rte_eth_dev_get_reg.
>>
>> Signed-off-by: Zyta Szpak <zr@semihalf.com>
> [...]
>> diff --git a/lib/librte_ether/rte_ether_version.map
>> b/lib/librte_ether/rte_ether_version.map
>> index 214ecc7..288bc63 100644
>> --- a/lib/librte_ether/rte_ether_version.map
>> +++ b/lib/librte_ether/rte_ether_version.map
>> @@ -130,5 +130,6 @@ DPDK_16.04 {
>> rte_eth_tx_buffer_drop_callback;
>> rte_eth_tx_buffer_init;
>> rte_eth_tx_buffer_set_err_callback;
>> + rte_eth_dev_get_reg_width;
>>
>> } DPDK_2.2;
>
> This symbol did not exist in DPDK 16.04 so it must not be added there.
> Add a new section for 16.07 which inherits from DPDK_16.04.
>
> - Panu -
>
Right.
^ permalink raw reply [flat|nested] 4+ messages in thread
* [PATCH v2 1/2] ethdev: add callback to get register size in bytes
@ 2016-05-30 9:40 zr
0 siblings, 0 replies; 4+ messages in thread
From: zr @ 2016-05-30 9:40 UTC (permalink / raw)
To: remy.horton, thomas.monjalon; +Cc: dev, Zyta Szpak
From: Zyta Szpak <zr@semihalf.com>
Version 2 of fixing the fixed register width assumption.
rte_eth_dev_get_reg_length and rte_eth_dev_get_reg callbacks
do not provide register size to the app in any way. It is
needed to allocate proper number of bytes before retrieving
registers content with rte_eth_dev_get_reg.
Signed-off-by: Zyta Szpak <zr@semihalf.com>
---
lib/librte_ether/rte_ethdev.c | 12 ++++++++++++
lib/librte_ether/rte_ethdev.h | 18 ++++++++++++++++++
lib/librte_ether/rte_ether_version.map | 1 +
3 files changed, 31 insertions(+)
diff --git a/lib/librte_ether/rte_ethdev.c b/lib/librte_ether/rte_ethdev.c
index a31018e..e0765f8 100644
--- a/lib/librte_ether/rte_ethdev.c
+++ b/lib/librte_ether/rte_ethdev.c
@@ -3231,6 +3231,18 @@ rte_eth_dev_get_reg_length(uint8_t port_id)
}
int
+rte_eth_dev_get_reg_width(uint8_t port_id)
+{
+ struct rte_eth_dev *dev;
+
+ RTE_ETH_VALID_PORTID_OR_ERR_RET(port_id, -ENODEV);
+
+ dev = &rte_eth_devices[port_id];
+ RTE_FUNC_PTR_OR_ERR_RET(*dev->dev_ops->get_reg_width, -ENOTSUP);
+ return (*dev->dev_ops->get_reg_width)(dev);
+}
+
+int
rte_eth_dev_get_reg_info(uint8_t port_id, struct rte_dev_reg_info *info)
{
struct rte_eth_dev *dev;
diff --git a/lib/librte_ether/rte_ethdev.h b/lib/librte_ether/rte_ethdev.h
index 2757510..552eaed 100644
--- a/lib/librte_ether/rte_ethdev.h
+++ b/lib/librte_ether/rte_ethdev.h
@@ -1292,6 +1292,9 @@ typedef int (*eth_timesync_write_time)(struct rte_eth_dev *dev,
typedef int (*eth_get_reg_length_t)(struct rte_eth_dev *dev);
/**< @internal Retrieve device register count */
+typedef int (*eth_get_reg_width_t)(struct rte_eth_dev *dev);
+/**< @internal Retrieve device register byte number */
+
typedef int (*eth_get_reg_t)(struct rte_eth_dev *dev,
struct rte_dev_reg_info *info);
/**< @internal Retrieve registers */
@@ -1455,6 +1458,8 @@ struct eth_dev_ops {
eth_get_reg_length_t get_reg_length;
/**< Get # of registers */
+ eth_get_reg_width_t get_reg_width;
+ /**< Get # of bytes in register */
eth_get_reg_t get_reg;
/**< Get registers */
eth_get_eeprom_length_t get_eeprom_length;
@@ -3971,6 +3976,19 @@ int rte_eth_tx_queue_info_get(uint8_t port_id, uint16_t queue_id,
*/
int rte_eth_dev_get_reg_length(uint8_t port_id);
+/*
+ * Retrieve the number of bytes in register for a specific device
+ *
+ * @param port_id
+ * The port identifier of the Ethernet device.
+ * @return
+ * - (>=0) number of registers if successful.
+ * - (-ENOTSUP) if hardware doesn't support.
+ * - (-ENODEV) if *port_id* invalid.
+ * - others depends on the specific operations implementation.
+ */
+int rte_eth_dev_get_reg_width(uint8_t port_id);
+
/**
* Retrieve device registers and register attributes
*
diff --git a/lib/librte_ether/rte_ether_version.map b/lib/librte_ether/rte_ether_version.map
index 214ecc7..288bc63 100644
--- a/lib/librte_ether/rte_ether_version.map
+++ b/lib/librte_ether/rte_ether_version.map
@@ -130,5 +130,6 @@ DPDK_16.04 {
rte_eth_tx_buffer_drop_callback;
rte_eth_tx_buffer_init;
rte_eth_tx_buffer_set_err_callback;
+ rte_eth_dev_get_reg_width;
} DPDK_2.2;
--
1.9.1
^ permalink raw reply related [flat|nested] 4+ messages in thread
end of thread, other threads:[~2016-05-31 15:08 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2016-05-30 9:39 [PATCH v2 1/2] ethdev: add callback to get register size in bytes zr
2016-05-30 10:58 ` Panu Matilainen
2016-05-31 15:08 ` Zyta Szpak
2016-05-30 9:40 zr
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.