All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH V3 0/2] vhost_net polling optimization
@ 2016-06-01  5:56 Jason Wang
  0 siblings, 0 replies; 6+ messages in thread
From: Jason Wang @ 2016-06-01  5:56 UTC (permalink / raw)
  To: mst, kvm, virtualization, netdev, linux-kernel

Hi:

This series tries to optimize vhost_net polling at two points:

- Stop rx polling for reduicng the unnecessary wakeups during
  handle_rx().
- Conditonally enable tx polling for reducing the unnecessary
  traversing and spinlock touching.

Test shows about 17% improvement on rx pps.

Please review

Changes from V2:
- Don't enable rx vq if we meet an err or rx vq is empty
Changes from V1:
- use vhost_net_disable_vq()/vhost_net_enable_vq() instead of open
  coding.
- Add a new patch for conditionally enable tx polling.

Jason Wang (2):
  vhost_net: stop polling socket during rx processing
  vhost_net: conditionally enable tx polling

 drivers/vhost/net.c | 67 ++++++++++++++++++++++++++++-------------------------
 1 file changed, 36 insertions(+), 31 deletions(-)

-- 
1.8.3.1

^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: [PATCH V3 0/2] vhost_net polling optimization
  2016-06-02 19:08   ` David Miller
  (?)
  (?)
@ 2016-06-03 13:03   ` Michael S. Tsirkin
  -1 siblings, 0 replies; 6+ messages in thread
From: Michael S. Tsirkin @ 2016-06-03 13:03 UTC (permalink / raw)
  To: David Miller; +Cc: jasowang, kvm, virtualization, netdev, linux-kernel

On Thu, Jun 02, 2016 at 12:08:06PM -0700, David Miller wrote:
> From: Jason Wang <jasowang@redhat.com>
> Date: Wed,  1 Jun 2016 01:56:32 -0400
> 
> > This series tries to optimize vhost_net polling at two points:
> > 
> > - Stop rx polling for reduicng the unnecessary wakeups during
> >   handle_rx().
> > - Conditonally enable tx polling for reducing the unnecessary
> >   traversing and spinlock touching.
> > 
> > Test shows about 17% improvement on rx pps.
> > 
> > Please review
> > 
> > Changes from V2:
> > - Don't enable rx vq if we meet an err or rx vq is empty
> > Changes from V1:
> > - use vhost_net_disable_vq()/vhost_net_enable_vq() instead of open
> >   coding.
> > - Add a new patch for conditionally enable tx polling.
> 
> Michael, please review this patch series.
> 
> Thanks.

thanks for the reminder, I plan to review next week.

^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: [PATCH V3 0/2] vhost_net polling optimization
  2016-06-02 19:08   ` David Miller
  (?)
@ 2016-06-03 13:03   ` Michael S. Tsirkin
  -1 siblings, 0 replies; 6+ messages in thread
From: Michael S. Tsirkin @ 2016-06-03 13:03 UTC (permalink / raw)
  To: David Miller; +Cc: netdev, linux-kernel, kvm, virtualization

On Thu, Jun 02, 2016 at 12:08:06PM -0700, David Miller wrote:
> From: Jason Wang <jasowang@redhat.com>
> Date: Wed,  1 Jun 2016 01:56:32 -0400
> 
> > This series tries to optimize vhost_net polling at two points:
> > 
> > - Stop rx polling for reduicng the unnecessary wakeups during
> >   handle_rx().
> > - Conditonally enable tx polling for reducing the unnecessary
> >   traversing and spinlock touching.
> > 
> > Test shows about 17% improvement on rx pps.
> > 
> > Please review
> > 
> > Changes from V2:
> > - Don't enable rx vq if we meet an err or rx vq is empty
> > Changes from V1:
> > - use vhost_net_disable_vq()/vhost_net_enable_vq() instead of open
> >   coding.
> > - Add a new patch for conditionally enable tx polling.
> 
> Michael, please review this patch series.
> 
> Thanks.

thanks for the reminder, I plan to review next week.

^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: [PATCH V3 0/2] vhost_net polling optimization
  2016-06-01  5:56 Jason Wang
@ 2016-06-02 19:08   ` David Miller
  0 siblings, 0 replies; 6+ messages in thread
From: David Miller @ 2016-06-02 19:08 UTC (permalink / raw)
  To: jasowang; +Cc: mst, kvm, virtualization, netdev, linux-kernel

From: Jason Wang <jasowang@redhat.com>
Date: Wed,  1 Jun 2016 01:56:32 -0400

> This series tries to optimize vhost_net polling at two points:
> 
> - Stop rx polling for reduicng the unnecessary wakeups during
>   handle_rx().
> - Conditonally enable tx polling for reducing the unnecessary
>   traversing and spinlock touching.
> 
> Test shows about 17% improvement on rx pps.
> 
> Please review
> 
> Changes from V2:
> - Don't enable rx vq if we meet an err or rx vq is empty
> Changes from V1:
> - use vhost_net_disable_vq()/vhost_net_enable_vq() instead of open
>   coding.
> - Add a new patch for conditionally enable tx polling.

Michael, please review this patch series.

Thanks.

^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: [PATCH V3 0/2] vhost_net polling optimization
@ 2016-06-02 19:08   ` David Miller
  0 siblings, 0 replies; 6+ messages in thread
From: David Miller @ 2016-06-02 19:08 UTC (permalink / raw)
  To: jasowang; +Cc: netdev, virtualization, linux-kernel, kvm, mst

From: Jason Wang <jasowang@redhat.com>
Date: Wed,  1 Jun 2016 01:56:32 -0400

> This series tries to optimize vhost_net polling at two points:
> 
> - Stop rx polling for reduicng the unnecessary wakeups during
>   handle_rx().
> - Conditonally enable tx polling for reducing the unnecessary
>   traversing and spinlock touching.
> 
> Test shows about 17% improvement on rx pps.
> 
> Please review
> 
> Changes from V2:
> - Don't enable rx vq if we meet an err or rx vq is empty
> Changes from V1:
> - use vhost_net_disable_vq()/vhost_net_enable_vq() instead of open
>   coding.
> - Add a new patch for conditionally enable tx polling.

Michael, please review this patch series.

Thanks.

^ permalink raw reply	[flat|nested] 6+ messages in thread

* [PATCH V3 0/2] vhost_net polling optimization
@ 2016-06-01  5:56 Jason Wang
  2016-06-02 19:08   ` David Miller
  0 siblings, 1 reply; 6+ messages in thread
From: Jason Wang @ 2016-06-01  5:56 UTC (permalink / raw)
  To: mst, kvm, virtualization, netdev, linux-kernel; +Cc: Jason Wang

Hi:

This series tries to optimize vhost_net polling at two points:

- Stop rx polling for reduicng the unnecessary wakeups during
  handle_rx().
- Conditonally enable tx polling for reducing the unnecessary
  traversing and spinlock touching.

Test shows about 17% improvement on rx pps.

Please review

Changes from V2:
- Don't enable rx vq if we meet an err or rx vq is empty
Changes from V1:
- use vhost_net_disable_vq()/vhost_net_enable_vq() instead of open
  coding.
- Add a new patch for conditionally enable tx polling.

Jason Wang (2):
  vhost_net: stop polling socket during rx processing
  vhost_net: conditionally enable tx polling

 drivers/vhost/net.c | 67 ++++++++++++++++++++++++++++-------------------------
 1 file changed, 36 insertions(+), 31 deletions(-)

-- 
1.8.3.1

^ permalink raw reply	[flat|nested] 6+ messages in thread

end of thread, other threads:[~2016-06-03 13:03 UTC | newest]

Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2016-06-01  5:56 [PATCH V3 0/2] vhost_net polling optimization Jason Wang
  -- strict thread matches above, loose matches on Subject: below --
2016-06-01  5:56 Jason Wang
2016-06-02 19:08 ` David Miller
2016-06-02 19:08   ` David Miller
2016-06-03 13:03   ` Michael S. Tsirkin
2016-06-03 13:03   ` Michael S. Tsirkin

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.